radv: Disable depth & stencil tests when the depthbuffer doesn't support it.
[mesa.git] / src / amd / vulkan / radv_meta_resolve_fs.c
index 884399ba4f5ce3184c857352d6532e6051a63b6a..97007d4ce6c716574a756cb8fad5fb2fe675cfcd 100644 (file)
@@ -38,7 +38,7 @@ build_nir_vertex_shader(void)
        nir_builder b;
 
        nir_builder_init_simple_shader(&b, NULL, MESA_SHADER_VERTEX, NULL);
-       b.shader->info->name = ralloc_strdup(b.shader, "meta_resolve_vs");
+       b.shader->info.name = ralloc_strdup(b.shader, "meta_resolve_vs");
 
        nir_variable *pos_out = nir_variable_create(b.shader, nir_var_shader_out,
                                                    vec4, "gl_Position");
@@ -64,7 +64,7 @@ build_resolve_fragment_shader(struct radv_device *dev, bool is_integer, bool is_
 
        snprintf(name, 64, "meta_resolve_fs-%d-%s", samples, is_integer ? "int" : (is_srgb ? "srgb" : "float"));
        nir_builder_init_simple_shader(&b, NULL, MESA_SHADER_FRAGMENT, NULL);
-       b.shader->info->name = ralloc_strdup(b.shader, name);
+       b.shader->info.name = ralloc_strdup(b.shader, name);
 
        nir_variable *input_img = nir_variable_create(b.shader, nir_var_uniform,
                                                      sampler_type, "s_tex");
@@ -80,6 +80,8 @@ build_resolve_fragment_shader(struct radv_device *dev, bool is_integer, bool is_
 
        nir_ssa_def *pos_in = nir_load_var(&b, fs_pos_in);
        nir_intrinsic_instr *src_offset = nir_intrinsic_instr_create(b.shader, nir_intrinsic_load_push_constant);
+       nir_intrinsic_set_base(src_offset, 0);
+       nir_intrinsic_set_range(src_offset, 8);
        src_offset->src[0] = nir_src_for_ssa(nir_imm_int(&b, 0));
        src_offset->num_components = 2;
        nir_ssa_dest_init(&src_offset->instr, &src_offset->dest, 2, 32, "src_offset");
@@ -150,31 +152,14 @@ fail:
 
 static const VkPipelineVertexInputStateCreateInfo normal_vi_create_info = {
        .sType = VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO,
-       .vertexBindingDescriptionCount = 1,
-       .pVertexBindingDescriptions = (VkVertexInputBindingDescription[]) {
-               {
-                       .binding = 0,
-                       .stride = 2 * sizeof(float),
-                       .inputRate = VK_VERTEX_INPUT_RATE_VERTEX
-               },
-       },
-       .vertexAttributeDescriptionCount = 1,
-       .pVertexAttributeDescriptions = (VkVertexInputAttributeDescription[]) {
-               {
-                       /* Texture Coordinate */
-                       .location = 0,
-                       .binding = 0,
-                       .format = VK_FORMAT_R32G32_SFLOAT,
-                       .offset = 0
-               },
-       },
+       .vertexBindingDescriptionCount = 0,
+       .vertexAttributeDescriptionCount = 0,
 };
 
 static VkFormat pipeline_formats[] = {
    VK_FORMAT_R8G8B8A8_UNORM,
    VK_FORMAT_R8G8B8A8_UINT,
    VK_FORMAT_R8G8B8A8_SINT,
-   VK_FORMAT_R8G8B8A8_SRGB,
    VK_FORMAT_R16G16B16A16_UNORM,
    VK_FORMAT_R16G16B16A16_SNORM,
    VK_FORMAT_R16G16B16A16_UINT,
@@ -206,7 +191,16 @@ create_resolve_pipeline(struct radv_device *device,
                .nir = build_nir_vertex_shader(),
        };
 
-       /* compute shader */
+       VkRenderPass *rp = is_srgb ?
+               &device->meta_state.resolve_fragment.rc[samples_log2].srgb_render_pass :
+               &device->meta_state.resolve_fragment.rc[samples_log2].render_pass[fs_key];
+
+       assert(!*rp);
+
+       VkPipeline *pipeline = is_srgb ?
+               &device->meta_state.resolve_fragment.rc[samples_log2].srgb_pipeline :
+               &device->meta_state.resolve_fragment.rc[samples_log2].pipeline[fs_key];
+       assert(!*pipeline);
 
        VkPipelineShaderStageCreateInfo pipeline_shader_stages[] = {
                {
@@ -224,6 +218,7 @@ create_resolve_pipeline(struct radv_device *device,
                },
        };
 
+
        result = radv_CreateRenderPass(radv_device_to_handle(device),
                                       &(VkRenderPassCreateInfo) {
                                               .sType = VK_STRUCTURE_TYPE_RENDER_PASS_CREATE_INFO,
@@ -253,7 +248,7 @@ create_resolve_pipeline(struct radv_device *device,
                                               .pPreserveAttachments = (uint32_t[]) { 0 },
                                       },
                                       .dependencyCount = 0,
-                                               }, &device->meta_state.alloc, &device->meta_state.resolve_fragment.rc[samples_log2].render_pass[fs_key]);
+                                               }, &device->meta_state.alloc, rp);
 
 
        const VkGraphicsPipelineCreateInfo vk_pipeline_info = {
@@ -312,7 +307,7 @@ create_resolve_pipeline(struct radv_device *device,
                },
                .flags = 0,
                .layout = device->meta_state.resolve_fragment.p_layout,
-               .renderPass = device->meta_state.resolve_fragment.rc[samples_log2].render_pass[fs_key],
+               .renderPass = *rp,
                .subpass = 0,
        };
 
@@ -324,8 +319,7 @@ create_resolve_pipeline(struct radv_device *device,
                                               radv_pipeline_cache_to_handle(&device->meta_state.cache),
                                               &vk_pipeline_info, &radv_pipeline_info,
                                               &device->meta_state.alloc,
-                                              &device->meta_state.resolve_fragment.rc[samples_log2].pipeline[fs_key]);
-
+                                              pipeline);
 
        ralloc_free(vs.nir);
        ralloc_free(fs.nir);
@@ -354,6 +348,8 @@ radv_device_init_meta_resolve_fragment_state(struct radv_device *device)
                for (unsigned j = 0; j < ARRAY_SIZE(pipeline_formats); ++j) {
                        res = create_resolve_pipeline(device, i, pipeline_formats[j]);
                }
+
+               res = create_resolve_pipeline(device, i, VK_FORMAT_R8G8B8A8_SRGB);
        }
 
        return res;
@@ -372,7 +368,12 @@ radv_device_finish_meta_resolve_fragment_state(struct radv_device *device)
                                             state->resolve_fragment.rc[i].pipeline[j],
                                             &state->alloc);
                }
-
+               radv_DestroyRenderPass(radv_device_to_handle(device),
+                                      state->resolve_fragment.rc[i].srgb_render_pass,
+                                              &state->alloc);
+               radv_DestroyPipeline(radv_device_to_handle(device),
+                                    state->resolve_fragment.rc[i].srgb_pipeline,
+                                    &state->alloc);
        }
 
        radv_DestroyDescriptorSetLayout(radv_device_to_handle(device),
@@ -386,6 +387,7 @@ radv_device_finish_meta_resolve_fragment_state(struct radv_device *device)
 static void
 emit_resolve(struct radv_cmd_buffer *cmd_buffer,
             struct radv_image_view *src_iview,
+            struct radv_image_view *dest_iview,
             const VkOffset2D *src_offset,
              const VkOffset2D *dest_offset,
              const VkExtent2D *resolve_extent)
@@ -427,8 +429,10 @@ emit_resolve(struct radv_cmd_buffer *cmd_buffer,
                              VK_SHADER_STAGE_FRAGMENT_BIT, 0, 8,
                              push_constants);
 
-       unsigned fs_key = radv_format_meta_fs_key(src_iview->vk_format);
-       VkPipeline pipeline_h = device->meta_state.resolve_fragment.rc[samples_log2].pipeline[fs_key];
+       unsigned fs_key = radv_format_meta_fs_key(dest_iview->vk_format);
+       VkPipeline pipeline_h = vk_format_is_srgb(dest_iview->vk_format) ?
+               device->meta_state.resolve_fragment.rc[samples_log2].srgb_pipeline :
+               device->meta_state.resolve_fragment.rc[samples_log2].pipeline[fs_key];
 
        radv_CmdBindPipeline(cmd_buffer_h, VK_PIPELINE_BIND_POINT_GRAPHICS,
                             pipeline_h);
@@ -464,6 +468,7 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
        const uint32_t samples = src_image->info.samples;
        const uint32_t samples_log2 = ffs(samples) - 1;
        unsigned fs_key = radv_format_meta_fs_key(dest_image->vk_format);
+       VkRenderPass rp;
        for (uint32_t r = 0; r < region_count; ++r) {
                const VkImageResolve *region = &regions[r];
                const uint32_t src_base_layer =
@@ -478,6 +483,9 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
                radv_fast_clear_flush_image_inplace(cmd_buffer, src_image, &range);
        }
 
+       rp = vk_format_is_srgb(dest_image->vk_format) ?
+               device->meta_state.resolve_fragment.rc[samples_log2].srgb_render_pass :
+               device->meta_state.resolve_fragment.rc[samples_log2].render_pass[fs_key];
        radv_meta_save_graphics_reset_vport_scissor_novertex(&saved_state, cmd_buffer);
 
        for (uint32_t r = 0; r < region_count; ++r) {
@@ -519,8 +527,7 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
                                                             .baseArrayLayer = src_base_layer + layer,
                                                             .layerCount = 1,
                                                     },
-                                            },
-                                            cmd_buffer, VK_IMAGE_USAGE_SAMPLED_BIT);
+                                            });
 
                        struct radv_image_view dest_iview;
                        radv_image_view_init(&dest_iview, cmd_buffer->device,
@@ -536,8 +543,7 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
                                                             .baseArrayLayer = dest_base_layer + layer,
                                                             .layerCount = 1,
                                                     },
-                                                            },
-                                            cmd_buffer, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT);
+                                            });
 
 
                        VkFramebuffer fb;
@@ -556,7 +562,7 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
                        radv_CmdBeginRenderPass(radv_cmd_buffer_to_handle(cmd_buffer),
                                                &(VkRenderPassBeginInfo) {
                                                        .sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO,
-                                                               .renderPass = device->meta_state.resolve_fragment.rc[samples_log2].render_pass[fs_key],
+                                                               .renderPass = rp,
                                                                .framebuffer = fb,
                                                                .renderArea = {
                                                                .offset = { dstOffset.x, dstOffset.y, },
@@ -570,6 +576,7 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
 
                        emit_resolve(cmd_buffer,
                                     &src_iview,
+                                    &dest_iview,
                                     &(VkOffset2D) { srcOffset.x, srcOffset.y },
                                     &(VkOffset2D) { dstOffset.x, dstOffset.y },
                                     &(VkExtent2D) { extent.width, extent.height });
@@ -606,12 +613,13 @@ radv_cmd_buffer_resolve_subpass_fs(struct radv_cmd_buffer *cmd_buffer)
        if (!subpass->has_resolve)
                return;
 
-       radv_meta_save_graphics_reset_vport_scissor(&saved_state, cmd_buffer);
+       radv_meta_save_graphics_reset_vport_scissor_novertex(&saved_state, cmd_buffer);
 
        for (uint32_t i = 0; i < subpass->color_count; ++i) {
                VkAttachmentReference src_att = subpass->color_attachments[i];
                VkAttachmentReference dest_att = subpass->resolve_attachments[i];
-               struct radv_image *dst_img = cmd_buffer->state.framebuffer->attachments[dest_att.attachment].attachment->image;
+               struct radv_image_view *dest_iview = cmd_buffer->state.framebuffer->attachments[dest_att.attachment].attachment;
+               struct radv_image *dst_img = dest_iview->image;
                struct radv_image_view *src_iview = cmd_buffer->state.framebuffer->attachments[src_att.attachment].attachment;
                if (dest_att.attachment == VK_ATTACHMENT_UNUSED)
                        continue;
@@ -647,6 +655,7 @@ radv_cmd_buffer_resolve_subpass_fs(struct radv_cmd_buffer *cmd_buffer)
                 */
                emit_resolve(cmd_buffer,
                             src_iview,
+                            dest_iview,
                             &(VkOffset2D) { 0, 0 },
                             &(VkOffset2D) { 0, 0 },
                             &(VkExtent2D) { fb->width, fb->height });