radv: use amdgpu_addr_create
[mesa.git] / src / amd / vulkan / winsys / amdgpu / radv_amdgpu_surface.c
index 31927ecd91b4e685e3710ac4f3824b71c9233edb..508a6d1f733a0d47fa2af94787bcb03b1365e945 100644 (file)
 #include "radv_amdgpu_surface.h"
 #include "sid.h"
 
-#ifndef NO_ENTRIES
-#define NO_ENTRIES 32
-#endif
-
-#ifndef NO_MACRO_ENTRIES
-#define NO_MACRO_ENTRIES 16
-#endif
-
-#ifndef CIASICIDGFXENGINE_SOUTHERNISLAND
-#define CIASICIDGFXENGINE_SOUTHERNISLAND 0x0000000A
-#endif
+#include "ac_surface.h"
 
-static int radv_amdgpu_surface_sanity(const struct radeon_surf *surf)
+static int radv_amdgpu_surface_sanity(const struct ac_surf_info *surf_info,
+                                     const struct radeon_surf *surf)
 {
        unsigned type = RADEON_SURF_GET(surf->flags, TYPE);
 
@@ -55,14 +46,14 @@ static int radv_amdgpu_surface_sanity(const struct radeon_surf *surf)
                return -EINVAL;
 
        /* all dimension must be at least 1 ! */
-       if (!surf->npix_x || !surf->npix_y || !surf->npix_z ||
-           !surf->array_size)
+       if (!surf_info->width || !surf_info->height || !surf_info->depth ||
+           !surf_info->array_size)
                return -EINVAL;
 
-       if (!surf->blk_w || !surf->blk_h || !surf->blk_d)
+       if (!surf->blk_w || !surf->blk_h)
                return -EINVAL;
 
-       switch (surf->nsamples) {
+       switch (surf_info->samples) {
        case 1:
        case 2:
        case 4:
@@ -74,24 +65,24 @@ static int radv_amdgpu_surface_sanity(const struct radeon_surf *surf)
 
        switch (type) {
        case RADEON_SURF_TYPE_1D:
-               if (surf->npix_y > 1)
+               if (surf_info->height > 1)
                        return -EINVAL;
                /* fall through */
        case RADEON_SURF_TYPE_2D:
        case RADEON_SURF_TYPE_CUBEMAP:
-               if (surf->npix_z > 1 || surf->array_size > 1)
+               if (surf_info->depth > 1 || surf_info->array_size > 1)
                        return -EINVAL;
                break;
        case RADEON_SURF_TYPE_3D:
-               if (surf->array_size > 1)
+               if (surf_info->array_size > 1)
                        return -EINVAL;
                break;
        case RADEON_SURF_TYPE_1D_ARRAY:
-               if (surf->npix_y > 1)
+               if (surf_info->height > 1)
                        return -EINVAL;
                /* fall through */
        case RADEON_SURF_TYPE_2D_ARRAY:
-               if (surf->npix_z > 1)
+               if (surf_info->depth > 1)
                        return -EINVAL;
                break;
        default:
@@ -100,65 +91,8 @@ static int radv_amdgpu_surface_sanity(const struct radeon_surf *surf)
        return 0;
 }
 
-static void *ADDR_API radv_allocSysMem(const ADDR_ALLOCSYSMEM_INPUT * pInput)
-{
-       return malloc(pInput->sizeInBytes);
-}
-
-static ADDR_E_RETURNCODE ADDR_API radv_freeSysMem(const ADDR_FREESYSMEM_INPUT * pInput)
-{
-       free(pInput->pVirtAddr);
-       return ADDR_OK;
-}
-
-ADDR_HANDLE radv_amdgpu_addr_create(struct amdgpu_gpu_info *amdinfo, int family, int rev_id,
-                                   enum chip_class chip_class)
-{
-       ADDR_CREATE_INPUT addrCreateInput = {0};
-       ADDR_CREATE_OUTPUT addrCreateOutput = {0};
-       ADDR_REGISTER_VALUE regValue = {0};
-       ADDR_CREATE_FLAGS createFlags = {{0}};
-       ADDR_E_RETURNCODE addrRet;
-
-       addrCreateInput.size = sizeof(ADDR_CREATE_INPUT);
-       addrCreateOutput.size = sizeof(ADDR_CREATE_OUTPUT);
-
-       regValue.noOfBanks = amdinfo->mc_arb_ramcfg & 0x3;
-       regValue.gbAddrConfig = amdinfo->gb_addr_cfg;
-       regValue.noOfRanks = (amdinfo->mc_arb_ramcfg & 0x4) >> 2;
-
-       regValue.backendDisables = amdinfo->backend_disable[0];
-       regValue.pTileConfig = amdinfo->gb_tile_mode;
-       regValue.noOfEntries = ARRAY_SIZE(amdinfo->gb_tile_mode);
-       if (chip_class == SI) {
-               regValue.pMacroTileConfig = NULL;
-               regValue.noOfMacroEntries = 0;
-       } else {
-               regValue.pMacroTileConfig = amdinfo->gb_macro_tile_mode;
-               regValue.noOfMacroEntries = ARRAY_SIZE(amdinfo->gb_macro_tile_mode);
-       }
-
-       createFlags.value = 0;
-       createFlags.useTileIndex = 1;
-       createFlags.degradeBaseLevel = 1;
-
-       addrCreateInput.chipEngine = CIASICIDGFXENGINE_SOUTHERNISLAND;
-       addrCreateInput.chipFamily = family;
-       addrCreateInput.chipRevision = rev_id;
-       addrCreateInput.createFlags = createFlags;
-       addrCreateInput.callbacks.allocSysMem = radv_allocSysMem;
-       addrCreateInput.callbacks.freeSysMem = radv_freeSysMem;
-       addrCreateInput.callbacks.debugPrint = 0;
-       addrCreateInput.regValue = regValue;
-
-       addrRet = AddrCreate(&addrCreateInput, &addrCreateOutput);
-       if (addrRet != ADDR_OK)
-               return NULL;
-
-       return addrCreateOutput.hLib;
-}
-
 static int radv_compute_level(ADDR_HANDLE addrlib,
+                             const struct ac_surf_info *surf_info,
                               struct radeon_surf *surf, bool is_stencil,
                               unsigned level, unsigned type, bool compressed,
                               ADDR_COMPUTE_SURFACE_INFO_INPUT *AddrSurfInfoIn,
@@ -166,27 +100,27 @@ static int radv_compute_level(ADDR_HANDLE addrlib,
                               ADDR_COMPUTE_DCCINFO_INPUT *AddrDccIn,
                               ADDR_COMPUTE_DCCINFO_OUTPUT *AddrDccOut)
 {
-       struct radeon_surf_level *surf_level;
+       struct legacy_surf_level *surf_level;
        ADDR_E_RETURNCODE ret;
 
        AddrSurfInfoIn->mipLevel = level;
-       AddrSurfInfoIn->width = u_minify(surf->npix_x, level);
-       AddrSurfInfoIn->height = u_minify(surf->npix_y, level);
+       AddrSurfInfoIn->width = u_minify(surf_info->width, level);
+       AddrSurfInfoIn->height = u_minify(surf_info->height, level);
 
        if (type == RADEON_SURF_TYPE_3D)
-               AddrSurfInfoIn->numSlices = u_minify(surf->npix_z, level);
+               AddrSurfInfoIn->numSlices = u_minify(surf_info->depth, level);
        else if (type == RADEON_SURF_TYPE_CUBEMAP)
                AddrSurfInfoIn->numSlices = 6;
        else
-               AddrSurfInfoIn->numSlices = surf->array_size;
+               AddrSurfInfoIn->numSlices = surf_info->array_size;
 
        if (level > 0) {
                /* Set the base level pitch. This is needed for calculation
                 * of non-zero levels. */
                if (is_stencil)
-                       AddrSurfInfoIn->basePitch = surf->stencil_level[0].nblk_x;
+                       AddrSurfInfoIn->basePitch = surf->u.legacy.stencil_level[0].nblk_x;
                else
-                       AddrSurfInfoIn->basePitch = surf->level[0].nblk_x;
+                       AddrSurfInfoIn->basePitch = surf->u.legacy.level[0].nblk_x;
 
                /* Convert blocks to pixels for compressed formats. */
                if (compressed)
@@ -199,19 +133,11 @@ static int radv_compute_level(ADDR_HANDLE addrlib,
        if (ret != ADDR_OK)
                return ret;
 
-       surf_level = is_stencil ? &surf->stencil_level[level] : &surf->level[level];
-       surf_level->offset = align64(surf->bo_size, AddrSurfInfoOut->baseAlign);
+       surf_level = is_stencil ? &surf->u.legacy.stencil_level[level] : &surf->u.legacy.level[level];
+       surf_level->offset = align64(surf->surf_size, AddrSurfInfoOut->baseAlign);
        surf_level->slice_size = AddrSurfInfoOut->sliceSize;
-       surf_level->pitch_bytes = AddrSurfInfoOut->pitch * (is_stencil ? 1 : surf->bpe);
-       surf_level->npix_x = u_minify(surf->npix_x, level);
-       surf_level->npix_y = u_minify(surf->npix_y, level);
-       surf_level->npix_z = u_minify(surf->npix_z, level);
        surf_level->nblk_x = AddrSurfInfoOut->pitch;
        surf_level->nblk_y = AddrSurfInfoOut->height;
-       if (type == RADEON_SURF_TYPE_3D)
-               surf_level->nblk_z = AddrSurfInfoOut->depth;
-       else
-               surf_level->nblk_z = 1;
 
        switch (AddrSurfInfoOut->tileMode) {
        case ADDR_TM_LINEAR_ALIGNED:
@@ -228,15 +154,14 @@ static int radv_compute_level(ADDR_HANDLE addrlib,
        }
 
        if (is_stencil)
-               surf->stencil_tiling_index[level] = AddrSurfInfoOut->tileIndex;
+               surf->u.legacy.stencil_tiling_index[level] = AddrSurfInfoOut->tileIndex;
        else
-               surf->tiling_index[level] = AddrSurfInfoOut->tileIndex;
+               surf->u.legacy.tiling_index[level] = AddrSurfInfoOut->tileIndex;
 
-       surf->bo_size = surf_level->offset + AddrSurfInfoOut->surfSize;
+       surf->surf_size = surf_level->offset + AddrSurfInfoOut->surfSize;
 
        /* Clear DCC fields at the beginning. */
        surf_level->dcc_offset = 0;
-       surf_level->dcc_enabled = false;
 
        /* The previous level's flag tells us if we can use DCC for this level. */
        if (AddrSurfInfoIn->flags.dccCompatible &&
@@ -254,19 +179,43 @@ static int radv_compute_level(ADDR_HANDLE addrlib,
                if (ret == ADDR_OK) {
                        surf_level->dcc_offset = surf->dcc_size;
                        surf_level->dcc_fast_clear_size = AddrDccOut->dccFastClearSize;
-                       surf_level->dcc_enabled = true;
+                       surf->num_dcc_levels = level + 1;
                        surf->dcc_size = surf_level->dcc_offset + AddrDccOut->dccRamSize;
-                       surf->dcc_alignment = MAX(surf->dcc_alignment, AddrDccOut->dccRamBaseAlign);
+                       surf->dcc_alignment = MAX2(surf->dcc_alignment, AddrDccOut->dccRamBaseAlign);
                }
        }
 
+       if (!is_stencil && AddrSurfInfoIn->flags.depth &&
+           surf_level->mode == RADEON_SURF_MODE_2D && level == 0) {
+               ADDR_COMPUTE_HTILE_INFO_INPUT AddrHtileIn = {0};
+               ADDR_COMPUTE_HTILE_INFO_OUTPUT AddrHtileOut = {0};
+               AddrHtileIn.flags.tcCompatible = AddrSurfInfoIn->flags.tcCompatible;
+               AddrHtileIn.pitch = AddrSurfInfoOut->pitch;
+               AddrHtileIn.height = AddrSurfInfoOut->height;
+               AddrHtileIn.numSlices = AddrSurfInfoOut->depth;
+               AddrHtileIn.blockWidth = ADDR_HTILE_BLOCKSIZE_8;
+               AddrHtileIn.blockHeight = ADDR_HTILE_BLOCKSIZE_8;
+               AddrHtileIn.pTileInfo = AddrSurfInfoOut->pTileInfo;
+               AddrHtileIn.tileIndex = AddrSurfInfoOut->tileIndex;
+               AddrHtileIn.macroModeIndex = AddrSurfInfoOut->macroModeIndex;
+
+               ret = AddrComputeHtileInfo(addrlib,
+                                          &AddrHtileIn,
+                                          &AddrHtileOut);
+
+               if (ret == ADDR_OK) {
+                       surf->htile_size = AddrHtileOut.htileBytes;
+                       surf->htile_slice_size = AddrHtileOut.sliceSize;
+                       surf->htile_alignment = AddrHtileOut.baseAlign;
+               }
+       }
        return 0;
 }
 
 static void radv_set_micro_tile_mode(struct radeon_surf *surf,
                                      struct radeon_info *info)
 {
-       uint32_t tile_mode = info->si_tile_mode_array[surf->tiling_index[0]];
+       uint32_t tile_mode = info->si_tile_mode_array[surf->u.legacy.tiling_index[0]];
 
        if (info->chip_class >= CIK)
                surf->micro_tile_mode = G_009910_MICRO_TILE_MODE_NEW(tile_mode);
@@ -274,8 +223,22 @@ static void radv_set_micro_tile_mode(struct radeon_surf *surf,
                surf->micro_tile_mode = G_009910_MICRO_TILE_MODE(tile_mode);
 }
 
+static unsigned cik_get_macro_tile_index(struct radeon_surf *surf)
+{
+       unsigned index, tileb;
+
+       tileb = 8 * 8 * surf->bpe;
+       tileb = MIN2(surf->u.legacy.tile_split, tileb);
+
+       for (index = 0; tileb > 64; index++)
+               tileb >>= 1;
+
+       assert(index < 16);
+       return index;
+}
 
 static int radv_amdgpu_winsys_surface_init(struct radeon_winsys *_ws,
+                                          const struct ac_surf_info *surf_info,
                                           struct radeon_surf *surf)
 {
        struct radv_amdgpu_winsys *ws = radv_amdgpu_winsys(_ws);
@@ -288,8 +251,9 @@ static int radv_amdgpu_winsys_surface_init(struct radeon_winsys *_ws,
        ADDR_TILEINFO AddrTileInfoIn = {0};
        ADDR_TILEINFO AddrTileInfoOut = {0};
        int r;
+       uint32_t last_level = surf_info->levels - 1;
 
-       r = radv_amdgpu_surface_sanity(surf);
+       r = radv_amdgpu_surface_sanity(surf_info, surf);
        if (r)
                return r;
 
@@ -304,7 +268,7 @@ static int radv_amdgpu_winsys_surface_init(struct radeon_winsys *_ws,
        compressed = surf->blk_w == 4 && surf->blk_h == 4;
 
        /* MSAA and FMASK require 2D tiling. */
-       if (surf->nsamples > 1 ||
+       if (surf_info->samples > 1 ||
            (surf->flags & RADEON_SURF_FMASK))
                mode = RADEON_SURF_MODE_2D;
 
@@ -345,7 +309,7 @@ static int radv_amdgpu_winsys_surface_init(struct radeon_winsys *_ws,
                AddrDccIn.bpp = AddrSurfInfoIn.bpp = surf->bpe * 8;
        }
 
-       AddrDccIn.numSamples = AddrSurfInfoIn.numSamples = surf->nsamples;
+       AddrDccIn.numSamples = AddrSurfInfoIn.numSamples = surf_info->samples;
        AddrSurfInfoIn.tileIndex = -1;
 
        /* Set the micro tile type. */
@@ -360,8 +324,8 @@ static int radv_amdgpu_winsys_surface_init(struct radeon_winsys *_ws,
        AddrSurfInfoIn.flags.depth = (surf->flags & RADEON_SURF_ZBUFFER) != 0;
        AddrSurfInfoIn.flags.cube = type == RADEON_SURF_TYPE_CUBEMAP;
        AddrSurfInfoIn.flags.display = (surf->flags & RADEON_SURF_SCANOUT) != 0;
-       AddrSurfInfoIn.flags.pow2Pad = surf->last_level > 0;
-       AddrSurfInfoIn.flags.degrade4Space = 1;
+       AddrSurfInfoIn.flags.pow2Pad = last_level > 0;
+       AddrSurfInfoIn.flags.opt4Space = 1;
 
        /* DCC notes:
         * - If we add MSAA support, keep in mind that CB can't decompress 8bpp
@@ -372,8 +336,8 @@ static int radv_amdgpu_winsys_surface_init(struct radeon_winsys *_ws,
        AddrSurfInfoIn.flags.dccCompatible = !(surf->flags & RADEON_SURF_Z_OR_SBUFFER) &&
                !(surf->flags & RADEON_SURF_DISABLE_DCC) &&
                !compressed && AddrDccIn.numSamples <= 1 &&
-               ((surf->array_size == 1 && surf->npix_z == 1) ||
-                surf->last_level == 0);
+               ((surf_info->array_size == 1 && surf_info->depth == 1) ||
+                last_level == 0);
 
        AddrSurfInfoIn.flags.noStencil = (surf->flags & RADEON_SURF_SBUFFER) == 0;
        AddrSurfInfoIn.flags.compressZ = AddrSurfInfoIn.flags.depth;
@@ -385,22 +349,23 @@ static int radv_amdgpu_winsys_surface_init(struct radeon_winsys *_ws,
         * TODO: update addrlib to a newer version, remove this, and
         * use flags.matchStencilTileCfg = 1 as an alternative fix.
         */
-       if (surf->last_level > 0)
+       if (last_level > 0)
                AddrSurfInfoIn.flags.noStencil = 1;
 
        /* Set preferred macrotile parameters. This is usually required
         * for shared resources. This is for 2D tiling only. */
        if (AddrSurfInfoIn.tileMode >= ADDR_TM_2D_TILED_THIN1 &&
-           surf->bankw && surf->bankh && surf->mtilea && surf->tile_split) {
+           surf->u.legacy.bankw && surf->u.legacy.bankh && surf->u.legacy.mtilea &&
+           surf->u.legacy.tile_split) {
                /* If any of these parameters are incorrect, the calculation
                 * will fail. */
-               AddrTileInfoIn.banks = surf->num_banks;
-               AddrTileInfoIn.bankWidth = surf->bankw;
-               AddrTileInfoIn.bankHeight = surf->bankh;
-               AddrTileInfoIn.macroAspectRatio = surf->mtilea;
-               AddrTileInfoIn.tileSplitBytes = surf->tile_split;
-               AddrTileInfoIn.pipeConfig = surf->pipe_config + 1; /* +1 compared to GB_TILE_MODE */
-               AddrSurfInfoIn.flags.degrade4Space = 0;
+               AddrTileInfoIn.banks = surf->u.legacy.num_banks;
+               AddrTileInfoIn.bankWidth = surf->u.legacy.bankw;
+               AddrTileInfoIn.bankHeight = surf->u.legacy.bankh;
+               AddrTileInfoIn.macroAspectRatio = surf->u.legacy.mtilea;
+               AddrTileInfoIn.tileSplitBytes = surf->u.legacy.tile_split;
+               AddrTileInfoIn.pipeConfig = surf->u.legacy.pipe_config + 1; /* +1 compared to GB_TILE_MODE */
+               AddrSurfInfoIn.flags.opt4Space = 0;
                AddrSurfInfoIn.pTileInfo = &AddrTileInfoIn;
 
                /* If AddrSurfInfoIn.pTileInfo is set, Addrlib doesn't set
@@ -435,35 +400,39 @@ static int radv_amdgpu_winsys_surface_init(struct radeon_winsys *_ws,
                                AddrSurfInfoIn.tileIndex = 10; /* 2D displayable */
                        else
                                AddrSurfInfoIn.tileIndex = 14; /* 2D non-displayable */
+                       AddrSurfInfoOut.macroModeIndex = cik_get_macro_tile_index(surf);
                }
        }
 
-       surf->bo_size = 0;
+       surf->surf_size = 0;
+       surf->num_dcc_levels = 0;
        surf->dcc_size = 0;
        surf->dcc_alignment = 1;
+       surf->htile_size = surf->htile_slice_size = 0;
+       surf->htile_alignment = 1;
 
        /* Calculate texture layout information. */
-       for (level = 0; level <= surf->last_level; level++) {
-               r = radv_compute_level(ws->addrlib, surf, false, level, type, compressed,
+       for (level = 0; level <= last_level; level++) {
+               r = radv_compute_level(ws->addrlib, surf_info, surf, false, level, type, compressed,
                                       &AddrSurfInfoIn, &AddrSurfInfoOut, &AddrDccIn, &AddrDccOut);
                if (r)
-                       return r;
+                       break;
 
                if (level == 0) {
-                       surf->bo_alignment = AddrSurfInfoOut.baseAlign;
-                       surf->pipe_config = AddrSurfInfoOut.pTileInfo->pipeConfig - 1;
+                       surf->surf_alignment = AddrSurfInfoOut.baseAlign;
+                       surf->u.legacy.pipe_config = AddrSurfInfoOut.pTileInfo->pipeConfig - 1;
                        radv_set_micro_tile_mode(surf, &ws->info);
 
                        /* For 2D modes only. */
                        if (AddrSurfInfoOut.tileMode >= ADDR_TM_2D_TILED_THIN1) {
-                               surf->bankw = AddrSurfInfoOut.pTileInfo->bankWidth;
-                               surf->bankh = AddrSurfInfoOut.pTileInfo->bankHeight;
-                               surf->mtilea = AddrSurfInfoOut.pTileInfo->macroAspectRatio;
-                               surf->tile_split = AddrSurfInfoOut.pTileInfo->tileSplitBytes;
-                               surf->num_banks = AddrSurfInfoOut.pTileInfo->banks;
-                               surf->macro_tile_index = AddrSurfInfoOut.macroModeIndex;
+                               surf->u.legacy.bankw = AddrSurfInfoOut.pTileInfo->bankWidth;
+                               surf->u.legacy.bankh = AddrSurfInfoOut.pTileInfo->bankHeight;
+                               surf->u.legacy.mtilea = AddrSurfInfoOut.pTileInfo->macroAspectRatio;
+                               surf->u.legacy.tile_split = AddrSurfInfoOut.pTileInfo->tileSplitBytes;
+                               surf->u.legacy.num_banks = AddrSurfInfoOut.pTileInfo->banks;
+                               surf->u.legacy.macro_tile_index = AddrSurfInfoOut.macroModeIndex;
                        } else {
-                               surf->macro_tile_index = 0;
+                               surf->u.legacy.macro_tile_index = 0;
                        }
                }
        }
@@ -474,22 +443,22 @@ static int radv_amdgpu_winsys_surface_init(struct radeon_winsys *_ws,
                AddrSurfInfoIn.flags.depth = 0;
                AddrSurfInfoIn.flags.stencil = 1;
                /* This will be ignored if AddrSurfInfoIn.pTileInfo is NULL. */
-               AddrTileInfoIn.tileSplitBytes = surf->stencil_tile_split;
+               AddrTileInfoIn.tileSplitBytes = surf->u.legacy.stencil_tile_split;
 
-               for (level = 0; level <= surf->last_level; level++) {
-                       r = radv_compute_level(ws->addrlib, surf, true, level, type, compressed,
+               for (level = 0; level <= last_level; level++) {
+                       r = radv_compute_level(ws->addrlib, surf_info, surf, true, level, type, compressed,
                                               &AddrSurfInfoIn, &AddrSurfInfoOut, &AddrDccIn, &AddrDccOut);
                        if (r)
                                return r;
 
                        /* DB uses the depth pitch for both stencil and depth. */
-                       if (surf->stencil_level[level].nblk_x != surf->level[level].nblk_x)
-                               surf->stencil_adjusted = true;
+                       if (surf->u.legacy.stencil_level[level].nblk_x != surf->u.legacy.level[level].nblk_x)
+                               surf->u.legacy.stencil_adjusted = true;
 
                        if (level == 0) {
                                /* For 2D modes only. */
                                if (AddrSurfInfoOut.tileMode >= ADDR_TM_2D_TILED_THIN1) {
-                                       surf->stencil_tile_split =
+                                       surf->u.legacy.stencil_tile_split =
                                                AddrSurfInfoOut.pTileInfo->tileSplitBytes;
                                }
                        }
@@ -501,7 +470,7 @@ static int radv_amdgpu_winsys_surface_init(struct radeon_winsys *_ws,
         * complicated.
         */
 #if 0
-       if (surf->dcc_size && surf->last_level > 0) {
+       if (surf->dcc_size && last_level > 0) {
                surf->dcc_size = align64(surf->bo_size >> 8,
                                         ws->info.pipe_interleave_bytes *
                                         ws->info.num_tile_pipes);