freedreno/ir3: use pipe_debug_callback for shader-db traces
[mesa.git] / src / gallium / drivers / freedreno / a4xx / fd4_program.c
index e085d88f0c17d2d631db11ce22dd059fcad90e13..4396383eef9a3b57cc1cc5bfb087a81e34d71825 100644 (file)
@@ -31,8 +31,6 @@
 #include "util/u_memory.h"
 #include "util/u_inlines.h"
 #include "util/u_format.h"
-#include "tgsi/tgsi_dump.h"
-#include "tgsi/tgsi_parse.h"
 
 #include "freedreno_program.h"
 
@@ -52,8 +50,10 @@ static struct fd4_shader_stateobj *
 create_shader_stateobj(struct pipe_context *pctx, const struct pipe_shader_state *cso,
                enum shader_t type)
 {
+       struct fd_context *ctx = fd_context(pctx);
+       struct ir3_compiler *compiler = ctx->screen->compiler;
        struct fd4_shader_stateobj *so = CALLOC_STRUCT(fd4_shader_stateobj);
-       so->shader = ir3_shader_create(pctx, cso->tokens, type);
+       so->shader = ir3_shader_create(compiler, cso, type, &ctx->debug);
        return so;
 }
 
@@ -152,14 +152,7 @@ setup_stages(struct fd4_emit *emit, struct stage *s)
        unsigned i;
 
        s[VS].v = fd4_emit_get_vp(emit);
-
-       if (emit->key.binning_pass) {
-               /* use dummy stateobj to simplify binning vs non-binning: */
-               static const struct ir3_shader_variant binning_fp = {};
-               s[FS].v = &binning_fp;
-       } else {
-               s[FS].v = fd4_emit_get_fp(emit);
-       }
+       s[FS].v = fd4_emit_get_fp(emit);
 
        s[HS].v = s[DS].v = s[GS].v = NULL;  /* for now */
 
@@ -184,7 +177,24 @@ setup_stages(struct fd4_emit *emit, struct stage *s)
         * space and FS taking entire remaining space.  We probably don't
         * need to do that the same way, but for now mimic what the blob
         * does to make it easier to diff against register values from blob
+        *
+        * NOTE: if VS.instrlen + FS.instrlen > 64, then one or both shaders
+        * is run from external memory.
         */
+       if ((s[VS].instrlen + s[FS].instrlen) > 64) {
+               /* prioritize FS for internal memory: */
+               if (s[FS].instrlen < 64) {
+                       /* if FS can fit, kick VS out to external memory: */
+                       s[VS].instrlen = 0;
+               } else if (s[VS].instrlen < 64) {
+                       /* otherwise if VS can fit, kick out FS: */
+                       s[FS].instrlen = 0;
+               } else {
+                       /* neither can fit, run both from external memory: */
+                       s[VS].instrlen = 0;
+                       s[FS].instrlen = 0;
+               }
+       }
        s[VS].constlen = 66;
        s[FS].constlen = 128 - s[VS].constlen;
        s[VS].instroff = 0;
@@ -196,26 +206,50 @@ setup_stages(struct fd4_emit *emit, struct stage *s)
 }
 
 void
-fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit)
+fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit,
+               int nr, struct pipe_surface **bufs)
 {
        struct stage s[MAX_STAGES];
-       uint32_t pos_regid, posz_regid, psize_regid, color_regid;
+       uint32_t pos_regid, posz_regid, psize_regid, color_regid[8];
+       uint32_t face_regid, coord_regid, zwcoord_regid;
+       enum a3xx_threadsize fssz;
        int constmode;
        int i, j, k;
 
+       debug_assert(nr <= ARRAY_SIZE(color_regid));
+
+       if (emit->key.binning_pass)
+               nr = 0;
+
        setup_stages(emit, s);
 
+       fssz = (s[FS].i->max_reg >= 24) ? TWO_QUADS : FOUR_QUADS;
+
        /* blob seems to always use constmode currently: */
        constmode = 1;
 
-       pos_regid = ir3_find_output_regid(s[VS].v,
-               ir3_semantic_name(TGSI_SEMANTIC_POSITION, 0));
-       posz_regid = ir3_find_output_regid(s[FS].v,
-               ir3_semantic_name(TGSI_SEMANTIC_POSITION, 0));
-       psize_regid = ir3_find_output_regid(s[VS].v,
-               ir3_semantic_name(TGSI_SEMANTIC_PSIZE, 0));
-       color_regid = ir3_find_output_regid(s[FS].v,
-               ir3_semantic_name(TGSI_SEMANTIC_COLOR, 0));
+       pos_regid = ir3_find_output_regid(s[VS].v, VARYING_SLOT_POS);
+       posz_regid = ir3_find_output_regid(s[FS].v, FRAG_RESULT_DEPTH);
+       psize_regid = ir3_find_output_regid(s[VS].v, VARYING_SLOT_PSIZ);
+       if (s[FS].v->color0_mrt) {
+               color_regid[0] = color_regid[1] = color_regid[2] = color_regid[3] =
+               color_regid[4] = color_regid[5] = color_regid[6] = color_regid[7] =
+                       ir3_find_output_regid(s[FS].v, FRAG_RESULT_COLOR);
+       } else {
+               color_regid[0] = ir3_find_output_regid(s[FS].v, FRAG_RESULT_DATA0);
+               color_regid[1] = ir3_find_output_regid(s[FS].v, FRAG_RESULT_DATA1);
+               color_regid[2] = ir3_find_output_regid(s[FS].v, FRAG_RESULT_DATA2);
+               color_regid[3] = ir3_find_output_regid(s[FS].v, FRAG_RESULT_DATA3);
+               color_regid[4] = ir3_find_output_regid(s[FS].v, FRAG_RESULT_DATA4);
+               color_regid[5] = ir3_find_output_regid(s[FS].v, FRAG_RESULT_DATA5);
+               color_regid[6] = ir3_find_output_regid(s[FS].v, FRAG_RESULT_DATA6);
+               color_regid[7] = ir3_find_output_regid(s[FS].v, FRAG_RESULT_DATA7);
+       }
+
+       /* TODO get these dynamically: */
+       face_regid = s[FS].v->frag_face ? regid(0,0) : regid(63,0);
+       coord_regid = s[FS].v->frag_coord ? regid(0,0) : regid(63,0);
+       zwcoord_regid = s[FS].v->frag_coord ? regid(0,2) : regid(63,0);
 
        /* we could probably divide this up into things that need to be
         * emitted if frag-prog is dirty vs if vert-prog is dirty..
@@ -224,8 +258,8 @@ fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit)
        OUT_PKT0(ring, REG_A4XX_HLSQ_UPDATE_CONTROL, 1);
        OUT_RING(ring, 0x00000003);
 
-       OUT_PKT0(ring, REG_A4XX_HLSQ_CONTROL_0_REG, 4);
-       OUT_RING(ring, A4XX_HLSQ_CONTROL_0_REG_FSTHREADSIZE(FOUR_QUADS) |
+       OUT_PKT0(ring, REG_A4XX_HLSQ_CONTROL_0_REG, 5);
+       OUT_RING(ring, A4XX_HLSQ_CONTROL_0_REG_FSTHREADSIZE(fssz) |
                        A4XX_HLSQ_CONTROL_0_REG_CONSTMODE(constmode) |
                        A4XX_HLSQ_CONTROL_0_REG_FSSUPERTHREADENABLE |
                        /* NOTE:  I guess SHADERRESTART and CONSTFULLUPDATE maybe
@@ -235,11 +269,15 @@ fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit)
                        A4XX_HLSQ_CONTROL_0_REG_SPSHADERRESTART |
                        A4XX_HLSQ_CONTROL_0_REG_SPCONSTFULLUPDATE);
        OUT_RING(ring, A4XX_HLSQ_CONTROL_1_REG_VSTHREADSIZE(TWO_QUADS) |
-                       0xfcfc0000 |          /* XXX */
                        A4XX_HLSQ_CONTROL_1_REG_VSSUPERTHREADENABLE |
-                       COND(s[FS].v->frag_coord, A4XX_HLSQ_CONTROL_1_REG_ZWCOORD));
-       OUT_RING(ring, A4XX_HLSQ_CONTROL_2_REG_PRIMALLOCTHRESHOLD(31));
-       OUT_RING(ring, A4XX_HLSQ_CONTROL_3_REG_REGID(s[FS].v->pos_regid));
+                       A4XX_HLSQ_CONTROL_1_REG_COORDREGID(coord_regid) |
+                       A4XX_HLSQ_CONTROL_1_REG_ZWCOORDREGID(zwcoord_regid));
+       OUT_RING(ring, A4XX_HLSQ_CONTROL_2_REG_PRIMALLOCTHRESHOLD(63) |
+                       0x3f3f000 |           /* XXX */
+                       A4XX_HLSQ_CONTROL_2_REG_FACEREGID(face_regid));
+       OUT_RING(ring, A4XX_HLSQ_CONTROL_3_REG_REGID(s[FS].v->pos_regid) |
+                       0xfcfcfc00);
+       OUT_RING(ring, 0x00fcfcfc);   /* XXX HLSQ_CONTROL_4 */
 
        OUT_PKT0(ring, REG_A4XX_HLSQ_VS_CONTROL_REG, 5);
        OUT_RING(ring, A4XX_HLSQ_VS_CONTROL_REG_CONSTLENGTH(s[VS].constlen) |
@@ -268,7 +306,11 @@ fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit)
                        COND(emit->key.binning_pass, A4XX_SP_SP_CTRL_REG_BINNING_PASS));
 
        OUT_PKT0(ring, REG_A4XX_SP_INSTR_CACHE_CTRL, 1);
-       OUT_RING(ring, 0x1c3);   /* XXX SP_INSTR_CACHE_CTRL */
+       OUT_RING(ring, 0x7f | /* XXX */
+                       COND(s[VS].instrlen, A4XX_SP_INSTR_CACHE_CTRL_VS_BUFFER) |
+                       COND(s[FS].instrlen, A4XX_SP_INSTR_CACHE_CTRL_FS_BUFFER) |
+                       COND(s[VS].instrlen && s[FS].instrlen,
+                                       A4XX_SP_INSTR_CACHE_CTRL_INSTR_BUFFER));
 
        OUT_PKT0(ring, REG_A4XX_SP_VS_LENGTH_REG, 1);
        OUT_RING(ring, s[VS].v->instrlen);      /* SP_VS_LENGTH_REG */
@@ -285,7 +327,7 @@ fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit)
                        A4XX_SP_VS_CTRL_REG1_INITIALOUTSTANDING(s[VS].v->total_in));
        OUT_RING(ring, A4XX_SP_VS_PARAM_REG_POSREGID(pos_regid) |
                        A4XX_SP_VS_PARAM_REG_PSIZEREGID(psize_regid) |
-                       A4XX_SP_VS_PARAM_REG_TOTALVSOUTVAR(align(s[FS].v->total_in, 4) / 4));
+                       A4XX_SP_VS_PARAM_REG_TOTALVSOUTVAR(s[FS].v->varying_in));
 
        for (i = 0, j = -1; (i < 16) && (j < (int)s[FS].v->inputs_count); i++) {
                uint32_t reg = 0;
@@ -294,14 +336,14 @@ fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit)
 
                j = ir3_next_varying(s[FS].v, j);
                if (j < s[FS].v->inputs_count) {
-                       k = ir3_find_output(s[VS].v, s[FS].v->inputs[j].semantic);
+                       k = ir3_find_output(s[VS].v, s[FS].v->inputs[j].slot);
                        reg |= A4XX_SP_VS_OUT_REG_A_REGID(s[VS].v->outputs[k].regid);
                        reg |= A4XX_SP_VS_OUT_REG_A_COMPMASK(s[FS].v->inputs[j].compmask);
                }
 
                j = ir3_next_varying(s[FS].v, j);
                if (j < s[FS].v->inputs_count) {
-                       k = ir3_find_output(s[VS].v, s[FS].v->inputs[j].semantic);
+                       k = ir3_find_output(s[VS].v, s[FS].v->inputs[j].slot);
                        reg |= A4XX_SP_VS_OUT_REG_B_REGID(s[VS].v->outputs[k].regid);
                        reg |= A4XX_SP_VS_OUT_REG_B_COMPMASK(s[FS].v->inputs[j].compmask);
                }
@@ -335,29 +377,49 @@ fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit)
                        A4XX_SP_VS_OBJ_OFFSET_REG_SHADEROBJOFFSET(s[VS].instroff));
        OUT_RELOC(ring, s[VS].v->bo, 0, 0, 0);  /* SP_VS_OBJ_START_REG */
 
-       OUT_PKT0(ring, REG_A4XX_SP_FS_LENGTH_REG, 1);
-       OUT_RING(ring, s[FS].v->instrlen);  /* SP_FS_LENGTH_REG */
-
-       OUT_PKT0(ring, REG_A4XX_SP_FS_CTRL_REG0, 2);
-       OUT_RING(ring, A4XX_SP_FS_CTRL_REG0_THREADMODE(MULTI) |
-                       COND(s[FS].v->total_in > 0, A4XX_SP_FS_CTRL_REG0_VARYING) |
-                       A4XX_SP_FS_CTRL_REG0_HALFREGFOOTPRINT(s[FS].i->max_half_reg + 1) |
-                       A4XX_SP_FS_CTRL_REG0_FULLREGFOOTPRINT(s[FS].i->max_reg + 1) |
-                       A4XX_SP_FS_CTRL_REG0_INOUTREGOVERLAP(1) |
-                       A4XX_SP_FS_CTRL_REG0_THREADSIZE(FOUR_QUADS) |
-                       A4XX_SP_FS_CTRL_REG0_SUPERTHREADMODE |
-                       COND(s[FS].v->has_samp, A4XX_SP_FS_CTRL_REG0_PIXLODENABLE));
-       OUT_RING(ring, A4XX_SP_FS_CTRL_REG1_CONSTLENGTH(s[FS].constlen) |
-                       0x80000000 |      /* XXX */
-                       COND(s[FS].v->total_in > 0, A4XX_SP_FS_CTRL_REG1_VARYING));
-
-       OUT_PKT0(ring, REG_A4XX_SP_FS_OBJ_OFFSET_REG, 2);
-       OUT_RING(ring, A4XX_SP_FS_OBJ_OFFSET_REG_CONSTOBJECTOFFSET(s[FS].constoff) |
-                       A4XX_SP_FS_OBJ_OFFSET_REG_SHADEROBJOFFSET(s[FS].instroff));
-       if (emit->key.binning_pass)
+       if (emit->key.binning_pass) {
+               OUT_PKT0(ring, REG_A4XX_SP_FS_LENGTH_REG, 1);
+               OUT_RING(ring, 0x00000000);         /* SP_FS_LENGTH_REG */
+
+               OUT_PKT0(ring, REG_A4XX_SP_FS_CTRL_REG0, 2);
+               OUT_RING(ring, A4XX_SP_FS_CTRL_REG0_THREADMODE(MULTI) |
+                               COND(s[FS].v->total_in > 0, A4XX_SP_FS_CTRL_REG0_VARYING) |
+                               A4XX_SP_FS_CTRL_REG0_HALFREGFOOTPRINT(0) |
+                               A4XX_SP_FS_CTRL_REG0_FULLREGFOOTPRINT(0) |
+                               A4XX_SP_FS_CTRL_REG0_INOUTREGOVERLAP(1) |
+                               A4XX_SP_FS_CTRL_REG0_THREADSIZE(fssz) |
+                               A4XX_SP_FS_CTRL_REG0_SUPERTHREADMODE);
+               OUT_RING(ring, A4XX_SP_FS_CTRL_REG1_CONSTLENGTH(s[FS].constlen) |
+                               0x80000000);
+
+               OUT_PKT0(ring, REG_A4XX_SP_FS_OBJ_OFFSET_REG, 2);
+               OUT_RING(ring, A4XX_SP_FS_OBJ_OFFSET_REG_CONSTOBJECTOFFSET(s[FS].constoff) |
+                               A4XX_SP_FS_OBJ_OFFSET_REG_SHADEROBJOFFSET(s[FS].instroff));
                OUT_RING(ring, 0x00000000);
-       else
+       } else {
+               OUT_PKT0(ring, REG_A4XX_SP_FS_LENGTH_REG, 1);
+               OUT_RING(ring, s[FS].v->instrlen);  /* SP_FS_LENGTH_REG */
+
+               OUT_PKT0(ring, REG_A4XX_SP_FS_CTRL_REG0, 2);
+               OUT_RING(ring, A4XX_SP_FS_CTRL_REG0_THREADMODE(MULTI) |
+                               COND(s[FS].v->total_in > 0, A4XX_SP_FS_CTRL_REG0_VARYING) |
+                               A4XX_SP_FS_CTRL_REG0_HALFREGFOOTPRINT(s[FS].i->max_half_reg + 1) |
+                               A4XX_SP_FS_CTRL_REG0_FULLREGFOOTPRINT(s[FS].i->max_reg + 1) |
+                               A4XX_SP_FS_CTRL_REG0_INOUTREGOVERLAP(1) |
+                               A4XX_SP_FS_CTRL_REG0_THREADSIZE(fssz) |
+                               A4XX_SP_FS_CTRL_REG0_SUPERTHREADMODE |
+                               COND(s[FS].v->has_samp, A4XX_SP_FS_CTRL_REG0_PIXLODENABLE));
+               OUT_RING(ring, A4XX_SP_FS_CTRL_REG1_CONSTLENGTH(s[FS].constlen) |
+                               0x80000000 |      /* XXX */
+                               COND(s[FS].v->frag_face, A4XX_SP_FS_CTRL_REG1_FACENESS) |
+                               COND(s[FS].v->total_in > 0, A4XX_SP_FS_CTRL_REG1_VARYING) |
+                               COND(s[FS].v->frag_coord, A4XX_SP_FS_CTRL_REG1_FRAGCOORD));
+
+               OUT_PKT0(ring, REG_A4XX_SP_FS_OBJ_OFFSET_REG, 2);
+               OUT_RING(ring, A4XX_SP_FS_OBJ_OFFSET_REG_CONSTOBJECTOFFSET(s[FS].constoff) |
+                               A4XX_SP_FS_OBJ_OFFSET_REG_SHADEROBJOFFSET(s[FS].instroff));
                OUT_RELOC(ring, s[FS].v->bo, 0, 0, 0);  /* SP_FS_OBJ_START_REG */
+       }
 
        OUT_PKT0(ring, REG_A4XX_SP_HS_OBJ_OFFSET_REG, 1);
        OUT_RING(ring, A4XX_SP_HS_OBJ_OFFSET_REG_CONSTOBJECTOFFSET(s[HS].constoff) |
@@ -371,34 +433,39 @@ fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit)
        OUT_RING(ring, A4XX_SP_GS_OBJ_OFFSET_REG_CONSTOBJECTOFFSET(s[GS].constoff) |
                        A4XX_SP_GS_OBJ_OFFSET_REG_SHADEROBJOFFSET(s[GS].instroff));
 
-       OUT_PKT0(ring, REG_A4XX_RB_MSAA_CONTROL2, 1);
-       OUT_RING(ring, A4XX_RB_MSAA_CONTROL2_MSAA_SAMPLES(0) |
-                       COND(s[FS].v->total_in > 0, A4XX_RB_MSAA_CONTROL2_VARYING));
+       OUT_PKT0(ring, REG_A4XX_RB_RENDER_CONTROL2, 1);
+       OUT_RING(ring, A4XX_RB_RENDER_CONTROL2_MSAA_SAMPLES(0) |
+                       COND(s[FS].v->total_in > 0, A4XX_RB_RENDER_CONTROL2_VARYING) |
+                       COND(s[FS].v->frag_face, A4XX_RB_RENDER_CONTROL2_FACENESS) |
+                       COND(s[FS].v->frag_coord, A4XX_RB_RENDER_CONTROL2_XCOORD |
+                                       A4XX_RB_RENDER_CONTROL2_YCOORD |
+                                       A4XX_RB_RENDER_CONTROL2_ZCOORD |
+                                       A4XX_RB_RENDER_CONTROL2_WCOORD));
 
        OUT_PKT0(ring, REG_A4XX_RB_FS_OUTPUT_REG, 1);
-       OUT_RING(ring, A4XX_RB_FS_OUTPUT_REG_COLOR_PIPE_ENABLE |
+       OUT_RING(ring, A4XX_RB_FS_OUTPUT_REG_MRT(nr) |
                        COND(s[FS].v->writes_pos, A4XX_RB_FS_OUTPUT_REG_FRAG_WRITES_Z));
 
        OUT_PKT0(ring, REG_A4XX_SP_FS_OUTPUT_REG, 1);
-       if (s[FS].v->writes_pos) {
-               OUT_RING(ring, 0x00000001 |
-                               A4XX_SP_FS_OUTPUT_REG_DEPTH_ENABLE |
-                               A4XX_SP_FS_OUTPUT_REG_DEPTH_REGID(posz_regid));
-       } else {
-               OUT_RING(ring, 0x00000001);
-       }
+       OUT_RING(ring, A4XX_SP_FS_OUTPUT_REG_MRT(nr) |
+                       COND(s[FS].v->writes_pos, A4XX_SP_FS_OUTPUT_REG_DEPTH_ENABLE) |
+                       A4XX_SP_FS_OUTPUT_REG_DEPTH_REGID(posz_regid));
 
        OUT_PKT0(ring, REG_A4XX_SP_FS_MRT_REG(0), 8);
-       OUT_RING(ring, A4XX_SP_FS_MRT_REG_REGID(color_regid) |
-                       A4XX_SP_FS_MRT_REG_MRTFORMAT(emit->format) |
-                       COND(emit->key.half_precision, A4XX_SP_FS_MRT_REG_HALF_PRECISION));
-       OUT_RING(ring, A4XX_SP_FS_MRT_REG_REGID(0));
-       OUT_RING(ring, A4XX_SP_FS_MRT_REG_REGID(0));
-       OUT_RING(ring, A4XX_SP_FS_MRT_REG_REGID(0));
-       OUT_RING(ring, A4XX_SP_FS_MRT_REG_REGID(0));
-       OUT_RING(ring, A4XX_SP_FS_MRT_REG_REGID(0));
-       OUT_RING(ring, A4XX_SP_FS_MRT_REG_REGID(0));
-       OUT_RING(ring, A4XX_SP_FS_MRT_REG_REGID(0));
+       for (i = 0; i < 8; i++) {
+               enum a4xx_color_fmt format = 0;
+               bool srgb = false;
+               if (i < nr) {
+                       format = fd4_emit_format(bufs[i]);
+                       if (bufs[i] && !emit->no_decode_srgb)
+                               srgb = util_format_is_srgb(bufs[i]->format);
+               }
+               OUT_RING(ring, A4XX_SP_FS_MRT_REG_REGID(color_regid[i]) |
+                               A4XX_SP_FS_MRT_REG_MRTFORMAT(format) |
+                               COND(srgb, A4XX_SP_FS_MRT_REG_COLOR_SRGB) |
+                               COND(emit->key.half_precision,
+                                       A4XX_SP_FS_MRT_REG_HALF_PRECISION));
+       }
 
        if (emit->key.binning_pass) {
                OUT_PKT0(ring, REG_A4XX_VPC_ATTR, 2);
@@ -407,26 +474,86 @@ fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit)
                                COND(s[VS].v->writes_psize, A4XX_VPC_ATTR_PSIZE));
                OUT_RING(ring, 0x00000000);
        } else {
-               uint32_t vinterp[8] = {0}, flatshade[2] = {0};
-
-               /* figure out VARYING_INTERP / FLAT_SHAD register values: */
+               uint32_t vinterp[8], vpsrepl[8];
+
+               memset(vinterp, 0, sizeof(vinterp));
+               memset(vpsrepl, 0, sizeof(vpsrepl));
+
+               /* looks like we need to do int varyings in the frag
+                * shader on a4xx (no flatshad reg?  or a420.0 bug?):
+                *
+                *    (sy)(ss)nop
+                *    (sy)ldlv.u32 r0.x,l[r0.x], 1
+                *    ldlv.u32 r0.y,l[r0.x+1], 1
+                *    (ss)bary.f (ei)r63.x, 0, r0.x
+                *    (ss)(rpt1)cov.s32f16 hr0.x, (r)r0.x
+                *    (rpt5)nop
+                *    sam (f16)(xyzw)hr0.x, hr0.x, s#0, t#0
+                *
+                * Possibly on later a4xx variants we'll be able to use
+                * something like the code below instead of workaround
+                * in the shader:
+                */
+               /* figure out VARYING_INTERP / VARYING_PS_REPL register values: */
                for (j = -1; (j = ir3_next_varying(s[FS].v, j)) < (int)s[FS].v->inputs_count; ) {
-                       uint32_t interp = s[FS].v->inputs[j].interpolate;
-                       if ((interp == TGSI_INTERPOLATE_CONSTANT) ||
-                                       ((interp == TGSI_INTERPOLATE_COLOR) && emit->rasterflat)) {
-                               /* TODO might be cleaner to just +8 in SP_VS_VPC_DST_REG
-                                * instead.. rather than -8 everywhere else..
-                                */
-                               uint32_t loc = s[FS].v->inputs[j].inloc - 8;
+                       /* NOTE: varyings are packed, so if compmask is 0xb
+                        * then first, third, and fourth component occupy
+                        * three consecutive varying slots:
+                        */
+                       unsigned compmask = s[FS].v->inputs[j].compmask;
 
-                               /* currently assuming varyings aligned to 4 (not
-                                * packed):
-                                */
-                               debug_assert((loc % 4) == 0);
+                       /* TODO might be cleaner to just +8 in SP_VS_VPC_DST_REG
+                        * instead.. rather than -8 everywhere else..
+                        */
+                       uint32_t inloc = s[FS].v->inputs[j].inloc - 8;
+
+                       if ((s[FS].v->inputs[j].interpolate == INTERP_QUALIFIER_FLAT) ||
+                                       (s[FS].v->inputs[j].rasterflat && emit->rasterflat)) {
+                               uint32_t loc = inloc;
+
+                               for (i = 0; i < 4; i++) {
+                                       if (compmask & (1 << i)) {
+                                               vinterp[loc / 16] |= 1 << ((loc % 16) * 2);
+                                               //flatshade[loc / 32] |= 1 << (loc % 32);
+                                               loc++;
+                                       }
+                               }
+                       }
 
-                               for (i = 0; i < 4; i++, loc++) {
-                                       vinterp[loc / 16] |= 1 << ((loc % 16) * 2);
-                                       flatshade[loc / 32] |= 1 << (loc % 32);
+                       gl_varying_slot slot = s[FS].v->inputs[j].slot;
+
+                       /* since we don't enable PIPE_CAP_TGSI_TEXCOORD: */
+                       if (slot >= VARYING_SLOT_VAR0) {
+                               unsigned texmask = 1 << (slot - VARYING_SLOT_VAR0);
+                               /* Replace the .xy coordinates with S/T from the point sprite. Set
+                                * interpolation bits for .zw such that they become .01
+                                */
+                               if (emit->sprite_coord_enable & texmask) {
+                                       /* mask is two 2-bit fields, where:
+                                        *   '01' -> S
+                                        *   '10' -> T
+                                        *   '11' -> 1 - T  (flip mode)
+                                        */
+                                       unsigned mask = emit->sprite_coord_mode ? 0b1101 : 0b1001;
+                                       uint32_t loc = inloc;
+                                       if (compmask & 0x1) {
+                                               vpsrepl[loc / 16] |= ((mask >> 0) & 0x3) << ((loc % 16) * 2);
+                                               loc++;
+                                       }
+                                       if (compmask & 0x2) {
+                                               vpsrepl[loc / 16] |= ((mask >> 2) & 0x3) << ((loc % 16) * 2);
+                                               loc++;
+                                       }
+                                       if (compmask & 0x4) {
+                                               /* .z <- 0.0f */
+                                               vinterp[loc / 16] |= 0b10 << ((loc % 16) * 2);
+                                               loc++;
+                                       }
+                                       if (compmask & 0x8) {
+                                               /* .w <- 1.0f */
+                                               vinterp[loc / 16] |= 0b11 << ((loc % 16) * 2);
+                                               loc++;
+                                       }
                                }
                        }
                }
@@ -446,26 +573,15 @@ fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit)
 
                OUT_PKT0(ring, REG_A4XX_VPC_VARYING_PS_REPL_MODE(0), 8);
                for (i = 0; i < 8; i++)
-                       OUT_RING(ring, s[FS].v->shader->vpsrepl[i]);   /* VPC_VARYING_PS_REPL[i] */
+                       OUT_RING(ring, vpsrepl[i]);   /* VPC_VARYING_PS_REPL[i] */
        }
 
-       emit_shader(ring, s[VS].v);
+       if (s[VS].instrlen)
+               emit_shader(ring, s[VS].v);
 
        if (!emit->key.binning_pass)
-               emit_shader(ring, s[FS].v);
-}
-
-/* hack.. until we figure out how to deal w/ vpsrepl properly.. */
-static void
-fix_blit_fp(struct pipe_context *pctx)
-{
-       struct fd_context *ctx = fd_context(pctx);
-       struct fd4_shader_stateobj *so = ctx->blit_prog.fp;
-
-       so->shader->vpsrepl[0] = 0x99999999;
-       so->shader->vpsrepl[1] = 0x99999999;
-       so->shader->vpsrepl[2] = 0x99999999;
-       so->shader->vpsrepl[3] = 0x99999999;
+               if (s[FS].instrlen)
+                       emit_shader(ring, s[FS].v);
 }
 
 void
@@ -478,6 +594,4 @@ fd4_prog_init(struct pipe_context *pctx)
        pctx->delete_vs_state = fd4_vp_state_delete;
 
        fd_prog_init(pctx);
-
-       fix_blit_fp(pctx);
 }