freedreno/a6xx: fix border-color swizzles
[mesa.git] / src / gallium / drivers / freedreno / a6xx / fd6_emit.c
index eb24fb96cfba89e185ab0a4298dea4879bd453cc..95ac616a76c39b7ba51d507e1e03cd91f049579b 100644 (file)
 #include "fd6_zsa.h"
 
 static uint32_t
-shader_t_to_opcode(enum shader_t type)
+shader_t_to_opcode(gl_shader_stage type)
 {
        switch (type) {
-       case SHADER_VERTEX:
-       case SHADER_TCS:
-       case SHADER_TES:
-       case SHADER_GEOM:
+       case MESA_SHADER_VERTEX:
+       case MESA_SHADER_TESS_CTRL:
+       case MESA_SHADER_TESS_EVAL:
+       case MESA_SHADER_GEOMETRY:
                return CP_LOAD_STATE6_GEOM;
-       case SHADER_FRAGMENT:
-       case SHADER_COMPUTE:
+       case MESA_SHADER_FRAGMENT:
+       case MESA_SHADER_COMPUTE:
+       case MESA_SHADER_KERNEL:
                return CP_LOAD_STATE6_FRAG;
        default:
                unreachable("bad shader type");
@@ -67,7 +68,7 @@ shader_t_to_opcode(enum shader_t type)
  * sizedwords:     size of const value buffer
  */
 static void
-fd6_emit_const(struct fd_ringbuffer *ring, enum shader_t type,
+fd6_emit_const(struct fd_ringbuffer *ring, gl_shader_stage type,
                uint32_t regid, uint32_t offset, uint32_t sizedwords,
                const uint32_t *dwords, struct pipe_resource *prsc)
 {
@@ -105,7 +106,7 @@ fd6_emit_const(struct fd_ringbuffer *ring, enum shader_t type,
 }
 
 static void
-fd6_emit_const_bo(struct fd_ringbuffer *ring, enum shader_t type, boolean write,
+fd6_emit_const_bo(struct fd_ringbuffer *ring, gl_shader_stage type, boolean write,
                uint32_t regid, uint32_t num, struct pipe_resource **prscs, uint32_t *offsets)
 {
        uint32_t anum = align(num, 2);
@@ -195,7 +196,8 @@ setup_border_colors(struct fd_texture_stateobj *tex, struct bcolor_entry *entrie
                if ((i >= tex->num_textures) || !tex->textures[i])
                        continue;
 
-               enum pipe_format format = tex->textures[i]->format;
+               struct pipe_sampler_view *view = tex->textures[i];
+               enum pipe_format format = view->format;
                const struct util_format_description *desc =
                                util_format_description(format);
 
@@ -205,8 +207,14 @@ setup_border_colors(struct fd_texture_stateobj *tex, struct bcolor_entry *entrie
                e->rgb10a2 = 0;
                e->z24 = 0;
 
+               unsigned char swiz[4];
+
+               fd6_tex_swiz(format, swiz,
+                               view->swizzle_r, view->swizzle_g,
+                               view->swizzle_b, view->swizzle_a);
+
                for (j = 0; j < 4; j++) {
-                       int c = desc->swizzle[j];
+                       int c = swiz[j];
                        int cd = c;
 
                        /*
@@ -328,7 +336,10 @@ emit_border_color(struct fd_context *ctx, struct fd_ringbuffer *ring)
 bool
 fd6_emit_textures(struct fd_pipe *pipe, struct fd_ringbuffer *ring,
                enum a6xx_state_block sb, struct fd_texture_stateobj *tex,
-               unsigned bcolor_offset)
+               unsigned bcolor_offset,
+               /* can be NULL if no image/SSBO state to merge in: */
+               const struct ir3_shader_variant *v, struct fd_shaderbuf_stateobj *buf,
+               struct fd_shaderimg_stateobj *img)
 {
        bool needs_border = false;
        unsigned opcode, tex_samp_reg, tex_const_reg, tex_count_reg;
@@ -350,17 +361,15 @@ fd6_emit_textures(struct fd_pipe *pipe, struct fd_ringbuffer *ring,
                opcode = CP_LOAD_STATE6_FRAG;
                tex_samp_reg = REG_A6XX_SP_CS_TEX_SAMP_LO;
                tex_const_reg = REG_A6XX_SP_CS_TEX_CONST_LO;
-               tex_count_reg = 0; //REG_A6XX_SP_CS_TEX_COUNT;
+               tex_count_reg = REG_A6XX_SP_CS_TEX_COUNT;
                break;
        default:
                unreachable("bad state block");
        }
 
-
        if (tex->num_samplers > 0) {
                struct fd_ringbuffer *state =
-                       fd_ringbuffer_new_flags(pipe, tex->num_samplers * 4 * 4,
-                                       FD_RINGBUFFER_OBJECT);
+                       fd_ringbuffer_new_object(pipe, tex->num_samplers * 4 * 4);
                for (unsigned i = 0; i < tex->num_samplers; i++) {
                        static const struct fd6_sampler_stateobj dummy_sampler = {};
                        const struct fd6_sampler_stateobj *sampler = tex->samplers[i] ?
@@ -368,7 +377,7 @@ fd6_emit_textures(struct fd_pipe *pipe, struct fd_ringbuffer *ring,
                        OUT_RING(state, sampler->texsamp0);
                        OUT_RING(state, sampler->texsamp1);
                        OUT_RING(state, sampler->texsamp2 |
-                               A6XX_TEX_SAMP_2_BCOLOR_OFFSET(bcolor_offset));
+                               A6XX_TEX_SAMP_2_BCOLOR_OFFSET((i + bcolor_offset) * sizeof(struct bcolor_entry)));
                        OUT_RING(state, sampler->texsamp3);
                        needs_border |= sampler->needs_border;
                }
@@ -388,30 +397,43 @@ fd6_emit_textures(struct fd_pipe *pipe, struct fd_ringbuffer *ring,
                fd_ringbuffer_del(state);
        }
 
-       if (tex->num_textures > 0) {
+       unsigned num_merged_textures = tex->num_textures;
+       unsigned num_textures = tex->num_textures;
+       if (v) {
+               num_merged_textures += v->image_mapping.num_tex;
+
+               /* There could be more bound textures than what the shader uses.
+                * Which isn't known at shader compile time.  So in the case we
+                * are merging tex state, only emit the textures that the shader
+                * uses (since the image/SSBO related tex state comes immediately
+                * after)
+                */
+               num_textures = v->image_mapping.tex_base;
+       }
+
+       if (num_merged_textures > 0) {
                struct fd_ringbuffer *state =
-                       fd_ringbuffer_new_flags(pipe, tex->num_textures * 16 * 4,
-                                       FD_RINGBUFFER_OBJECT);
-               for (unsigned i = 0; i < tex->num_textures; i++) {
+                       fd_ringbuffer_new_object(pipe, num_merged_textures * 16 * 4);
+               for (unsigned i = 0; i < num_textures; i++) {
                        static const struct fd6_pipe_sampler_view dummy_view = {};
                        const struct fd6_pipe_sampler_view *view = tex->textures[i] ?
                                fd6_pipe_sampler_view(tex->textures[i]) : &dummy_view;
-                       enum a6xx_tile_mode tile_mode = TILE6_LINEAR;
+                       struct fd_resource *rsc = NULL;
 
                        if (view->base.texture)
-                               tile_mode = fd_resource(view->base.texture)->tile_mode;
+                               rsc = fd_resource(view->base.texture);
 
-                       OUT_RING(state, view->texconst0 |
-                               A6XX_TEX_CONST_0_TILE_MODE(tile_mode));
+                       OUT_RING(state, view->texconst0);
                        OUT_RING(state, view->texconst1);
                        OUT_RING(state, view->texconst2);
-                       OUT_RING(state, view->texconst3);
+                       OUT_RING(state, view->texconst3 |
+                               COND(rsc && view->ubwc_enabled,
+                                       A6XX_TEX_CONST_3_FLAG | A6XX_TEX_CONST_3_UNK27));
 
-                       if (view->base.texture) {
-                               struct fd_resource *rsc = fd_resource(view->base.texture);
+                       if (rsc) {
                                if (view->base.format == PIPE_FORMAT_X32_S8X24_UINT)
                                        rsc = rsc->stencil;
-                               OUT_RELOC(state, rsc->bo, view->offset,
+                               OUT_RELOC(state, rsc->bo, view->offset + rsc->offset,
                                        (uint64_t)view->texconst5 << 32, 0);
                        } else {
                                OUT_RING(state, 0x00000000);
@@ -419,8 +441,14 @@ fd6_emit_textures(struct fd_pipe *pipe, struct fd_ringbuffer *ring,
                        }
 
                        OUT_RING(state, view->texconst6);
-                       OUT_RING(state, view->texconst7);
-                       OUT_RING(state, view->texconst8);
+
+                       if (rsc && view->ubwc_enabled) {
+                               OUT_RELOC(state, rsc->bo, view->offset + rsc->ubwc_offset, 0, 0);
+                       } else {
+                               OUT_RING(state, 0);
+                               OUT_RING(state, 0);
+                       }
+
                        OUT_RING(state, view->texconst9);
                        OUT_RING(state, view->texconst10);
                        OUT_RING(state, view->texconst11);
@@ -430,13 +458,26 @@ fd6_emit_textures(struct fd_pipe *pipe, struct fd_ringbuffer *ring,
                        OUT_RING(state, 0);
                }
 
+               if (v) {
+                       const struct ir3_ibo_mapping *mapping = &v->image_mapping;
+
+                       for (unsigned i = 0; i < mapping->num_tex; i++) {
+                               unsigned idx = mapping->tex_to_image[i];
+                               if (idx & IBO_SSBO) {
+                                       fd6_emit_ssbo_tex(state, &buf->sb[idx & ~IBO_SSBO]);
+                               } else {
+                                       fd6_emit_image_tex(state, &img->si[idx]);
+                               }
+                       }
+               }
+
                /* emit texture state: */
                OUT_PKT7(ring, opcode, 3);
                OUT_RING(ring, CP_LOAD_STATE6_0_DST_OFF(0) |
                        CP_LOAD_STATE6_0_STATE_TYPE(ST6_CONSTANTS) |
                        CP_LOAD_STATE6_0_STATE_SRC(SS6_INDIRECT) |
                        CP_LOAD_STATE6_0_STATE_BLOCK(sb) |
-                       CP_LOAD_STATE6_0_NUM_UNIT(tex->num_textures));
+                       CP_LOAD_STATE6_0_NUM_UNIT(num_merged_textures));
                OUT_RB(ring, state); /* SRC_ADDR_LO/HI */
 
                OUT_PKT4(ring, tex_const_reg, 2);
@@ -445,95 +486,91 @@ fd6_emit_textures(struct fd_pipe *pipe, struct fd_ringbuffer *ring,
                fd_ringbuffer_del(state);
        }
 
-       if (tex_count_reg) {
-               OUT_PKT4(ring, tex_count_reg, 1);
-               OUT_RING(ring, tex->num_textures);
-       }
+       OUT_PKT4(ring, tex_count_reg, 1);
+       OUT_RING(ring, num_merged_textures);
 
        return needs_border;
 }
 
-static void
-emit_ssbos(struct fd_context *ctx, struct fd_ringbuffer *ring,
-               enum a6xx_state_block sb, struct fd_shaderbuf_stateobj *so)
+/* Emits combined texture state, which also includes any Image/SSBO
+ * related texture state merged in (because we must have all texture
+ * state for a given stage in a single buffer).  In the fast-path, if
+ * we don't need to merge in any image/ssbo related texture state, we
+ * just use cached texture stateobj.  Otherwise we generate a single-
+ * use stateobj.
+ *
+ * TODO Is there some sane way we can still use cached texture stateobj
+ * with image/ssbo in use?
+ *
+ * returns whether border_color is required:
+ */
+static bool
+fd6_emit_combined_textures(struct fd_ringbuffer *ring, struct fd6_emit *emit,
+               enum pipe_shader_type type, const struct ir3_shader_variant *v)
 {
-       unsigned count = util_last_bit(so->enabled_mask);
-       unsigned opcode;
-
-       if (count == 0)
-               return;
-
-       switch (sb) {
-       case SB6_SSBO:
-       case SB6_CS_SSBO:
-               opcode = CP_LOAD_STATE6_GEOM;
-               break;
-       default:
-               unreachable("bad state block");
-       }
+       struct fd_context *ctx = emit->ctx;
+       bool needs_border = false;
 
-       OUT_PKT7(ring, opcode, 3 + (4 * count));
-       OUT_RING(ring, CP_LOAD_STATE6_0_DST_OFF(0) |
-                       CP_LOAD_STATE6_0_STATE_TYPE(0) |
-                       CP_LOAD_STATE6_0_STATE_SRC(SS6_DIRECT) |
-                       CP_LOAD_STATE6_0_STATE_BLOCK(sb) |
-                       CP_LOAD_STATE6_0_NUM_UNIT(count));
-       OUT_RING(ring, CP_LOAD_STATE6_1_EXT_SRC_ADDR(0));
-       OUT_RING(ring, CP_LOAD_STATE6_2_EXT_SRC_ADDR_HI(0));
-       for (unsigned i = 0; i < count; i++) {
-               OUT_RING(ring, 0x00000000);
-               OUT_RING(ring, 0x00000000);
-               OUT_RING(ring, 0x00000000);
-               OUT_RING(ring, 0x00000000);
-       }
+       static const struct {
+               enum a6xx_state_block sb;
+               enum fd6_state_id state_id;
+       } s[PIPE_SHADER_TYPES] = {
+               [PIPE_SHADER_VERTEX]    = { SB6_VS_TEX, FD6_GROUP_VS_TEX },
+               [PIPE_SHADER_FRAGMENT]  = { SB6_FS_TEX, FD6_GROUP_FS_TEX },
+       };
 
-#if 0
-       OUT_PKT7(ring, opcode, 3 + (2 * count));
-       OUT_RING(ring, CP_LOAD_STATE6_0_DST_OFF(0) |
-                       CP_LOAD_STATE6_0_STATE_TYPE(1) |
-                       CP_LOAD_STATE6_0_STATE_SRC(SS6_DIRECT) |
-                       CP_LOAD_STATE6_0_STATE_BLOCK(sb) |
-                       CP_LOAD_STATE6_0_NUM_UNIT(count));
-       OUT_RING(ring, CP_LOAD_STATE6_1_EXT_SRC_ADDR(0));
-       OUT_RING(ring, CP_LOAD_STATE6_2_EXT_SRC_ADDR_HI(0));
-       for (unsigned i = 0; i < count; i++) {
-               struct pipe_shader_buffer *buf = &so->sb[i];
-               unsigned sz = buf->buffer_size;
+       debug_assert(s[type].state_id);
 
-               /* width is in dwords, overflows into height: */
-               sz /= 4;
+       if (!v->image_mapping.num_tex) {
+               /* in the fast-path, when we don't have to mix in any image/SSBO
+                * related texture state, we can just lookup the stateobj and
+                * re-emit that:
+                */
+               if ((ctx->dirty_shader[type] & FD_DIRTY_SHADER_TEX) &&
+                               ctx->tex[type].num_textures > 0) {
+                       struct fd6_texture_state *tex = fd6_texture_state(ctx,
+                                       s[type].sb, &ctx->tex[type]);
 
-               OUT_RING(ring, A6XX_SSBO_1_0_WIDTH(sz));
-               OUT_RING(ring, A6XX_SSBO_1_1_HEIGHT(sz >> 16));
-       }
-#endif
+                       needs_border |= tex->needs_border;
 
-       OUT_PKT7(ring, opcode, 3 + (2 * count));
-       OUT_RING(ring, CP_LOAD_STATE6_0_DST_OFF(0) |
-                       CP_LOAD_STATE6_0_STATE_TYPE(2) |
-                       CP_LOAD_STATE6_0_STATE_SRC(SS6_DIRECT) |
-                       CP_LOAD_STATE6_0_STATE_BLOCK(sb) |
-                       CP_LOAD_STATE6_0_NUM_UNIT(count));
-       OUT_RING(ring, CP_LOAD_STATE6_1_EXT_SRC_ADDR(0));
-       OUT_RING(ring, CP_LOAD_STATE6_2_EXT_SRC_ADDR_HI(0));
-       for (unsigned i = 0; i < count; i++) {
-               struct pipe_shader_buffer *buf = &so->sb[i];
-               if (buf->buffer) {
-                       struct fd_resource *rsc = fd_resource(buf->buffer);
-                       OUT_RELOCW(ring, rsc->bo, buf->buffer_offset, 0, 0);
-               } else {
-                       OUT_RING(ring, 0x00000000);
-                       OUT_RING(ring, 0x00000000);
+                       fd6_emit_add_group(emit, tex->stateobj, s[type].state_id, 0x7);
+               }
+       } else {
+               /* In the slow-path, create a one-shot texture state object
+                * if either TEX|PROG|SSBO|IMAGE state is dirty:
+                */
+               if (ctx->dirty_shader[type] &
+                               (FD_DIRTY_SHADER_TEX | FD_DIRTY_SHADER_PROG |
+                                FD_DIRTY_SHADER_IMAGE | FD_DIRTY_SHADER_SSBO)) {
+                       struct fd_texture_stateobj *tex = &ctx->tex[type];
+                       struct fd_shaderbuf_stateobj *buf = &ctx->shaderbuf[type];
+                       struct fd_shaderimg_stateobj *img = &ctx->shaderimg[type];
+                       struct fd_ringbuffer *stateobj =
+                               fd_submit_new_ringbuffer(ctx->batch->submit,
+                                       0x1000, FD_RINGBUFFER_STREAMING);
+                       unsigned bcolor_offset =
+                               fd6_border_color_offset(ctx, s[type].sb, tex);
+
+                       needs_border |= fd6_emit_textures(ctx->pipe, stateobj, s[type].sb, tex,
+                                       bcolor_offset, v, buf, img);
+
+                       fd6_emit_add_group(emit, stateobj, s[type].state_id, 0x7);
+
+                       fd_ringbuffer_del(stateobj);
                }
        }
+
+       return needs_border;
 }
 
-void
-fd6_emit_vertex_bufs(struct fd_ringbuffer *ring, struct fd6_emit *emit)
+static struct fd_ringbuffer *
+build_vbo_state(struct fd6_emit *emit, const struct ir3_shader_variant *vp)
 {
-       int32_t i, j;
        const struct fd_vertex_state *vtx = emit->vtx;
-       const struct ir3_shader_variant *vp = fd6_emit_get_vp(emit);
+       int32_t i, j;
+
+       struct fd_ringbuffer *ring = fd_submit_new_ringbuffer(emit->ctx->batch->submit,
+                       4 * (10 * vp->inputs_count + 2), FD_RINGBUFFER_STREAMING);
 
        for (i = 0, j = 0; i <= vp->inputs_count; i++) {
                if (vp->inputs[i].sysval)
@@ -581,109 +618,160 @@ fd6_emit_vertex_bufs(struct fd_ringbuffer *ring, struct fd6_emit *emit)
 
        OUT_PKT4(ring, REG_A6XX_VFD_CONTROL_0, 1);
        OUT_RING(ring, A6XX_VFD_CONTROL_0_VTXCNT(j) | (j << 8));
+
+       return ring;
+}
+
+static struct fd_ringbuffer *
+build_lrz(struct fd6_emit *emit, bool binning_pass)
+{
+       struct fd6_zsa_stateobj *zsa = fd6_zsa_stateobj(emit->ctx->zsa);
+       struct pipe_framebuffer_state *pfb = &emit->ctx->batch->framebuffer;
+       struct fd_resource *rsc = fd_resource(pfb->zsbuf->texture);
+       uint32_t gras_lrz_cntl = zsa->gras_lrz_cntl;
+       uint32_t rb_lrz_cntl = zsa->rb_lrz_cntl;
+
+       struct fd_ringbuffer *ring = fd_submit_new_ringbuffer(emit->ctx->batch->submit,
+                       16, FD_RINGBUFFER_STREAMING);
+
+       if (emit->no_lrz_write || !rsc->lrz || !rsc->lrz_valid) {
+               gras_lrz_cntl = 0;
+               rb_lrz_cntl = 0;
+       } else if (binning_pass && zsa->lrz_write) {
+               gras_lrz_cntl |= A6XX_GRAS_LRZ_CNTL_LRZ_WRITE;
+       }
+
+       OUT_PKT4(ring, REG_A6XX_GRAS_LRZ_CNTL, 1);
+       OUT_RING(ring, gras_lrz_cntl);
+
+       OUT_PKT4(ring, REG_A6XX_RB_LRZ_CNTL, 1);
+       OUT_RING(ring, rb_lrz_cntl);
+
+       return ring;
+}
+
+static void
+fd6_emit_streamout(struct fd_ringbuffer *ring, struct fd6_emit *emit, struct ir3_stream_output_info *info)
+{
+       struct fd_context *ctx = emit->ctx;
+       const struct fd6_program_state *prog = fd6_emit_get_prog(emit);
+       struct fd_streamout_stateobj *so = &ctx->streamout;
+
+       emit->streamout_mask = 0;
+
+       for (unsigned i = 0; i < so->num_targets; i++) {
+               struct pipe_stream_output_target *target = so->targets[i];
+
+               if (!target)
+                       continue;
+
+               unsigned offset = (so->offsets[i] * info->stride[i] * 4) +
+                               target->buffer_offset;
+
+               OUT_PKT4(ring, REG_A6XX_VPC_SO_BUFFER_BASE_LO(i), 3);
+               /* VPC_SO[i].BUFFER_BASE_LO: */
+               OUT_RELOCW(ring, fd_resource(target->buffer)->bo, 0, 0, 0);
+               OUT_RING(ring, target->buffer_size + offset);
+
+               OUT_PKT4(ring, REG_A6XX_VPC_SO_BUFFER_OFFSET(i), 3);
+               OUT_RING(ring, offset);
+               /* VPC_SO[i].FLUSH_BASE_LO/HI: */
+               // TODO just give hw a dummy addr for now.. we should
+               // be using this an then CP_MEM_TO_REG to set the
+               // VPC_SO[i].BUFFER_OFFSET for the next draw..
+               OUT_RELOCW(ring, fd6_context(ctx)->blit_mem, 0x100, 0, 0);
+
+               emit->streamout_mask |= (1 << i);
+       }
+
+       if (emit->streamout_mask) {
+               const struct fd6_streamout_state *tf = &prog->tf;
+
+               OUT_PKT7(ring, CP_CONTEXT_REG_BUNCH, 12 + (2 * tf->prog_count));
+               OUT_RING(ring, REG_A6XX_VPC_SO_BUF_CNTL);
+               OUT_RING(ring, tf->vpc_so_buf_cntl);
+               OUT_RING(ring, REG_A6XX_VPC_SO_NCOMP(0));
+               OUT_RING(ring, tf->ncomp[0]);
+               OUT_RING(ring, REG_A6XX_VPC_SO_NCOMP(1));
+               OUT_RING(ring, tf->ncomp[1]);
+               OUT_RING(ring, REG_A6XX_VPC_SO_NCOMP(2));
+               OUT_RING(ring, tf->ncomp[2]);
+               OUT_RING(ring, REG_A6XX_VPC_SO_NCOMP(3));
+               OUT_RING(ring, tf->ncomp[3]);
+               OUT_RING(ring, REG_A6XX_VPC_SO_CNTL);
+               OUT_RING(ring, A6XX_VPC_SO_CNTL_ENABLE);
+               for (unsigned i = 0; i < tf->prog_count; i++) {
+                       OUT_RING(ring, REG_A6XX_VPC_SO_PROG);
+                       OUT_RING(ring, tf->prog[i]);
+               }
+
+               OUT_PKT4(ring, REG_A6XX_VPC_SO_OVERRIDE, 1);
+               OUT_RING(ring, 0x0);
+       } else {
+               OUT_PKT7(ring, CP_CONTEXT_REG_BUNCH, 4);
+               OUT_RING(ring, REG_A6XX_VPC_SO_CNTL);
+               OUT_RING(ring, 0);
+               OUT_RING(ring, REG_A6XX_VPC_SO_BUF_CNTL);
+               OUT_RING(ring, 0);
+
+               OUT_PKT4(ring, REG_A6XX_VPC_SO_OVERRIDE, 1);
+               OUT_RING(ring, A6XX_VPC_SO_OVERRIDE_SO_DISABLE);
+       }
+
 }
 
 void
-fd6_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
-               struct fd6_emit *emit)
+fd6_emit_state(struct fd_ringbuffer *ring, struct fd6_emit *emit)
 {
+       struct fd_context *ctx = emit->ctx;
        struct pipe_framebuffer_state *pfb = &ctx->batch->framebuffer;
-       const struct ir3_shader_variant *vp = fd6_emit_get_vp(emit);
-       const struct ir3_shader_variant *fp = fd6_emit_get_fp(emit);
+       const struct fd6_program_state *prog = fd6_emit_get_prog(emit);
+       const struct ir3_shader_variant *vp = emit->vs;
+       const struct ir3_shader_variant *fp = emit->fs;
        const enum fd_dirty_3d_state dirty = emit->dirty;
        bool needs_border = false;
 
        emit_marker6(ring, 5);
 
-       if ((dirty & FD_DIRTY_FRAMEBUFFER) && !emit->key.binning_pass) {
-               unsigned char mrt_comp[A6XX_MAX_RENDER_TARGETS] = {0};
+       if (emit->dirty & (FD_DIRTY_VTXBUF | FD_DIRTY_VTXSTATE)) {
+               struct fd_ringbuffer *state;
 
-               for (unsigned i = 0; i < pfb->nr_cbufs; i++) {
-                       mrt_comp[i] = ((i < pfb->nr_cbufs) && pfb->cbufs[i]) ? 0xf : 0;
-               }
+               state = build_vbo_state(emit, emit->vs);
+               fd6_emit_add_group(emit, state, FD6_GROUP_VBO, 0x6);
+               fd_ringbuffer_del(state);
 
-               OUT_PKT4(ring, REG_A6XX_RB_RENDER_COMPONENTS, 1);
-               OUT_RING(ring, A6XX_RB_RENDER_COMPONENTS_RT0(mrt_comp[0]) |
-                               A6XX_RB_RENDER_COMPONENTS_RT1(mrt_comp[1]) |
-                               A6XX_RB_RENDER_COMPONENTS_RT2(mrt_comp[2]) |
-                               A6XX_RB_RENDER_COMPONENTS_RT3(mrt_comp[3]) |
-                               A6XX_RB_RENDER_COMPONENTS_RT4(mrt_comp[4]) |
-                               A6XX_RB_RENDER_COMPONENTS_RT5(mrt_comp[5]) |
-                               A6XX_RB_RENDER_COMPONENTS_RT6(mrt_comp[6]) |
-                               A6XX_RB_RENDER_COMPONENTS_RT7(mrt_comp[7]));
-
-               OUT_PKT4(ring, REG_A6XX_SP_FS_RENDER_COMPONENTS, 1);
-               OUT_RING(ring,
-                                A6XX_SP_FS_RENDER_COMPONENTS_RT0(mrt_comp[0]) |
-                                A6XX_SP_FS_RENDER_COMPONENTS_RT1(mrt_comp[1]) |
-                                A6XX_SP_FS_RENDER_COMPONENTS_RT2(mrt_comp[2]) |
-                                A6XX_SP_FS_RENDER_COMPONENTS_RT3(mrt_comp[3]) |
-                                A6XX_SP_FS_RENDER_COMPONENTS_RT4(mrt_comp[4]) |
-                                A6XX_SP_FS_RENDER_COMPONENTS_RT5(mrt_comp[5]) |
-                                A6XX_SP_FS_RENDER_COMPONENTS_RT6(mrt_comp[6]) |
-                                A6XX_SP_FS_RENDER_COMPONENTS_RT7(mrt_comp[7]));
+               state = build_vbo_state(emit, emit->bs);
+               fd6_emit_add_group(emit, state, FD6_GROUP_VBO_BINNING, 0x1);
+               fd_ringbuffer_del(state);
        }
 
        if (dirty & FD_DIRTY_ZSA) {
                struct fd6_zsa_stateobj *zsa = fd6_zsa_stateobj(ctx->zsa);
-               uint32_t rb_alpha_control = zsa->rb_alpha_control;
 
                if (util_format_is_pure_integer(pipe_surface_format(pfb->cbufs[0])))
-                       rb_alpha_control &= ~A6XX_RB_ALPHA_CONTROL_ALPHA_TEST;
-
-               OUT_PKT4(ring, REG_A6XX_RB_ALPHA_CONTROL, 1);
-               OUT_RING(ring, rb_alpha_control);
-
-               OUT_PKT4(ring, REG_A6XX_RB_STENCIL_CONTROL, 1);
-               OUT_RING(ring, zsa->rb_stencil_control);
+                       fd6_emit_add_group(emit, zsa->stateobj_no_alpha, FD6_GROUP_ZSA, 0x7);
+               else
+                       fd6_emit_add_group(emit, zsa->stateobj, FD6_GROUP_ZSA, 0x7);
        }
 
-       if (dirty & (FD_DIRTY_ZSA | FD_DIRTY_BLEND | FD_DIRTY_PROG)) {
-               struct fd6_zsa_stateobj *zsa = fd6_zsa_stateobj(ctx->zsa);
-
-               if (pfb->zsbuf) {
-                       struct fd_resource *rsc = fd_resource(pfb->zsbuf->texture);
-                       uint32_t gras_lrz_cntl = zsa->gras_lrz_cntl;
-                       uint32_t rb_lrz_cntl = zsa->rb_lrz_cntl;
+       if ((dirty & (FD_DIRTY_ZSA | FD_DIRTY_PROG)) && pfb->zsbuf) {
+               struct fd_ringbuffer *state;
 
-                       if (emit->no_lrz_write || !rsc->lrz || !rsc->lrz_valid) {
-                               gras_lrz_cntl = 0;
-                               rb_lrz_cntl = 0;
-                       } else if (emit->key.binning_pass && zsa->lrz_write) {
-                               gras_lrz_cntl |= A6XX_GRAS_LRZ_CNTL_LRZ_WRITE;
-                       }
-
-                       OUT_PKT4(ring, REG_A6XX_GRAS_LRZ_CNTL, 1);
-                       OUT_RING(ring, gras_lrz_cntl);
+               state = build_lrz(emit, false);
+               fd6_emit_add_group(emit, state, FD6_GROUP_LRZ, 0x6);
+               fd_ringbuffer_del(state);
 
-                       OUT_PKT4(ring, REG_A6XX_RB_LRZ_CNTL, 1);
-                       OUT_RING(ring, rb_lrz_cntl);
-               }
+               state = build_lrz(emit, true);
+               fd6_emit_add_group(emit, state, FD6_GROUP_LRZ_BINNING, 0x1);
+               fd_ringbuffer_del(state);
        }
 
-       if (dirty & (FD_DIRTY_ZSA | FD_DIRTY_STENCIL_REF)) {
-               struct fd6_zsa_stateobj *zsa = fd6_zsa_stateobj(ctx->zsa);
+       if (dirty & FD_DIRTY_STENCIL_REF) {
                struct pipe_stencil_ref *sr = &ctx->stencil_ref;
 
-               OUT_PKT4(ring, REG_A6XX_RB_STENCILREF, 3);
+               OUT_PKT4(ring, REG_A6XX_RB_STENCILREF, 1);
                OUT_RING(ring, A6XX_RB_STENCILREF_REF(sr->ref_value[0]) |
                                A6XX_RB_STENCILREF_BFREF(sr->ref_value[1]));
-               OUT_RING(ring, zsa->rb_stencilmask);
-               OUT_RING(ring, zsa->rb_stencilwrmask);
-       }
-
-       if (dirty & (FD_DIRTY_ZSA | FD_DIRTY_RASTERIZER | FD_DIRTY_PROG)) {
-               struct fd6_zsa_stateobj *zsa = fd6_zsa_stateobj(ctx->zsa);
-               bool fragz = fp->has_kill | fp->writes_pos;
-
-               OUT_PKT4(ring, REG_A6XX_RB_DEPTH_CNTL, 1);
-               OUT_RING(ring, zsa->rb_depth_cntl);
-
-               OUT_PKT4(ring, REG_A6XX_RB_DEPTH_PLANE_CNTL, 1);
-               OUT_RING(ring, COND(fragz, A6XX_RB_DEPTH_PLANE_CNTL_FRAG_WRITES_Z));
-
-               OUT_PKT4(ring, REG_A6XX_GRAS_SU_DEPTH_PLANE_CNTL, 1);
-               OUT_RING(ring, COND(fragz, A6XX_GRAS_SU_DEPTH_PLANE_CNTL_FRAG_WRITES_Z));
        }
 
        /* NOTE: scissor enabled bit is part of rasterizer state: */
@@ -696,12 +784,6 @@ fd6_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
                OUT_RING(ring, A6XX_GRAS_SC_SCREEN_SCISSOR_TL_0_X(scissor->maxx - 1) |
                                A6XX_GRAS_SC_SCREEN_SCISSOR_TL_0_Y(scissor->maxy - 1));
 
-               OUT_PKT4(ring, REG_A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL_0, 2);
-               OUT_RING(ring, A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL_0_X(scissor->minx) |
-                               A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL_0_Y(scissor->miny));
-               OUT_RING(ring, A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL_0_X(scissor->maxx - 1) |
-                               A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL_0_Y(scissor->maxy - 1));
-
                ctx->batch->max_scissor.minx = MIN2(ctx->batch->max_scissor.minx, scissor->minx);
                ctx->batch->max_scissor.miny = MIN2(ctx->batch->max_scissor.miny, scissor->miny);
                ctx->batch->max_scissor.maxx = MAX2(ctx->batch->max_scissor.maxx, scissor->maxx);
@@ -709,7 +791,8 @@ fd6_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
        }
 
        if (dirty & FD_DIRTY_VIEWPORT) {
-               fd_wfi(ctx->batch, ring);
+               struct pipe_scissor_state *scissor = &ctx->viewport_scissor;
+
                OUT_PKT4(ring, REG_A6XX_GRAS_CL_VPORT_XOFFSET_0, 6);
                OUT_RING(ring, A6XX_GRAS_CL_VPORT_XOFFSET_0(ctx->viewport.translate[0]));
                OUT_RING(ring, A6XX_GRAS_CL_VPORT_XSCALE_0(ctx->viewport.scale[0]));
@@ -717,49 +800,42 @@ fd6_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
                OUT_RING(ring, A6XX_GRAS_CL_VPORT_YSCALE_0(ctx->viewport.scale[1]));
                OUT_RING(ring, A6XX_GRAS_CL_VPORT_ZOFFSET_0(ctx->viewport.translate[2]));
                OUT_RING(ring, A6XX_GRAS_CL_VPORT_ZSCALE_0(ctx->viewport.scale[2]));
-       }
-
-       if (dirty & FD_DIRTY_PROG)
-               fd6_program_emit(ctx, ring, emit);
-
-       if (dirty & FD_DIRTY_RASTERIZER) {
-               struct fd6_rasterizer_stateobj *rasterizer =
-                               fd6_rasterizer_stateobj(ctx->rasterizer);
 
-               OUT_PKT4(ring, REG_A6XX_GRAS_UNKNOWN_8000, 1);
-               OUT_RING(ring, 0x80);
-               OUT_PKT4(ring, REG_A6XX_GRAS_UNKNOWN_8001, 1);
-               OUT_RING(ring, 0x0);
-               OUT_PKT4(ring, REG_A6XX_GRAS_UNKNOWN_8004, 1);
-               OUT_RING(ring, 0x0);
+               OUT_PKT4(ring, REG_A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL_0, 2);
+               OUT_RING(ring, A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL_0_X(scissor->minx) |
+                               A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL_0_Y(scissor->miny));
+               OUT_RING(ring, A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL_0_X(scissor->maxx - 1) |
+                               A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL_0_Y(scissor->maxy - 1));
 
-               OUT_PKT4(ring, REG_A6XX_GRAS_SU_CNTL, 1);
-               OUT_RING(ring, rasterizer->gras_su_cntl);
+               unsigned guardband_x = fd_calc_guardband(scissor->maxx - scissor->minx);
+               unsigned guardband_y = fd_calc_guardband(scissor->maxy - scissor->miny);
 
-               OUT_PKT4(ring, REG_A6XX_GRAS_SU_POINT_MINMAX, 2);
-               OUT_RING(ring, rasterizer->gras_su_point_minmax);
-               OUT_RING(ring, rasterizer->gras_su_point_size);
+               OUT_PKT4(ring, REG_A6XX_GRAS_CL_GUARDBAND_CLIP_ADJ, 1);
+               OUT_RING(ring, A6XX_GRAS_CL_GUARDBAND_CLIP_ADJ_HORZ(guardband_x) |
+                               A6XX_GRAS_CL_GUARDBAND_CLIP_ADJ_VERT(guardband_y));
+       }
 
-               OUT_PKT4(ring, REG_A6XX_GRAS_SU_POLY_OFFSET_SCALE, 3);
-               OUT_RING(ring, rasterizer->gras_su_poly_offset_scale);
-               OUT_RING(ring, rasterizer->gras_su_poly_offset_offset);
-               OUT_RING(ring, rasterizer->gras_su_poly_offset_clamp);
+       if (dirty & FD_DIRTY_PROG) {
+               fd6_emit_add_group(emit, prog->stateobj, FD6_GROUP_PROG, 0x6);
+               fd6_emit_add_group(emit, prog->binning_stateobj,
+                               FD6_GROUP_PROG_BINNING, 0x1);
 
-#if 0
-               OUT_PKT4(ring, REG_A6XX_PC_RASTER_CNTL, 1);
-               OUT_RING(ring, rasterizer->pc_raster_cntl);
+               /* emit remaining non-stateobj program state, ie. what depends
+                * on other emit state, so cannot be pre-baked.  This could
+                * be moved to a separate stateobj which is dynamically
+                * created.
+                */
+               fd6_program_emit(ring, emit);
+       }
 
-               OUT_PKT4(ring, REG_A6XX_GRAS_CL_CNTL, 1);
-               OUT_RING(ring, rasterizer->gras_cl_clip_cntl);
-#endif
+       if (dirty & FD_DIRTY_RASTERIZER) {
+               struct fd6_rasterizer_stateobj *rasterizer =
+                               fd6_rasterizer_stateobj(ctx->rasterizer);
+               fd6_emit_add_group(emit, rasterizer->stateobj,
+                                                  FD6_GROUP_RASTERIZER, 0x7);
        }
 
-       /* note: must come after program emit.. because there is some overlap
-        * in registers, ex. PC_PRIMITIVE_CNTL and we rely on some cached
-        * values from fd6_program_emit() to avoid having to re-emit the prog
-        * every time rast state changes.
-        *
-        * Since the primitive restart state is not part of a tracked object, we
+       /* Since the primitive restart state is not part of a tracked object, we
         * re-emit this register every time.
         */
        if (emit->info && ctx->rasterizer) {
@@ -772,7 +848,6 @@ fd6_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
                OUT_PKT4(ring, REG_A6XX_VFD_UNKNOWN_A008, 1);
                OUT_RING(ring, 0);
 
-
                OUT_PKT4(ring, REG_A6XX_PC_PRIMITIVE_CNTL_0, 1);
                OUT_RING(ring, rasterizer->pc_primitive_cntl |
                                 COND(emit->info->primitive_restart && emit->info->index_size,
@@ -780,21 +855,16 @@ fd6_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
        }
 
        if (dirty & (FD_DIRTY_FRAMEBUFFER | FD_DIRTY_RASTERIZER | FD_DIRTY_PROG)) {
-               uint32_t posz_regid = ir3_find_output_regid(fp, FRAG_RESULT_DEPTH);
                unsigned nr = pfb->nr_cbufs;
 
-               if (emit->key.binning_pass)
-                       nr = 0;
-               else if (ctx->rasterizer->rasterizer_discard)
+               if (ctx->rasterizer->rasterizer_discard)
                        nr = 0;
 
                OUT_PKT4(ring, REG_A6XX_RB_FS_OUTPUT_CNTL0, 2);
                OUT_RING(ring, COND(fp->writes_pos, A6XX_RB_FS_OUTPUT_CNTL0_FRAG_WRITES_Z));
                OUT_RING(ring, A6XX_RB_FS_OUTPUT_CNTL1_MRT(nr));
 
-               OUT_PKT4(ring, REG_A6XX_SP_FS_OUTPUT_CNTL0, 2);
-               OUT_RING(ring, A6XX_SP_FS_OUTPUT_CNTL0_DEPTH_REGID(posz_regid) |
-                                0xfcfc0000);
+               OUT_PKT4(ring, REG_A6XX_SP_FS_OUTPUT_CNTL1, 1);
                OUT_RING(ring, A6XX_SP_FS_OUTPUT_CNTL1_MRT(nr));
        }
 
@@ -802,97 +872,34 @@ fd6_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
                                         FD_DIRTY_SHADER_SSBO | FD_DIRTY_SHADER_IMAGE)
 
        if (ctx->dirty_shader[PIPE_SHADER_VERTEX] & DIRTY_CONST) {
-               struct fd_ringbuffer *vsconstobj =
-                       fd_ringbuffer_new_flags(ctx->pipe, 0x1000,
-                                       FD_RINGBUFFER_OBJECT | FD_RINGBUFFER_STREAMING);
+               struct fd_ringbuffer *vsconstobj = fd_submit_new_ringbuffer(
+                               ctx->batch->submit, 0x1000, FD_RINGBUFFER_STREAMING);
 
+               OUT_WFI5(vsconstobj);
                ir3_emit_vs_consts(vp, vsconstobj, ctx, emit->info);
                fd6_emit_add_group(emit, vsconstobj, FD6_GROUP_VS_CONST, 0x7);
                fd_ringbuffer_del(vsconstobj);
        }
 
-       if ((ctx->dirty_shader[PIPE_SHADER_FRAGMENT] & DIRTY_CONST) &&
-                       !emit->key.binning_pass) {
-               struct fd_ringbuffer *fsconstobj =
-                       fd_ringbuffer_new_flags(ctx->pipe, 0x1000,
-                                       FD_RINGBUFFER_OBJECT | FD_RINGBUFFER_STREAMING);
+       if (ctx->dirty_shader[PIPE_SHADER_FRAGMENT] & DIRTY_CONST) {
+               struct fd_ringbuffer *fsconstobj = fd_submit_new_ringbuffer(
+                               ctx->batch->submit, 0x1000, FD_RINGBUFFER_STREAMING);
 
+               OUT_WFI5(fsconstobj);
                ir3_emit_fs_consts(fp, fsconstobj, ctx);
-               fd6_emit_add_group(emit, fsconstobj, FD6_GROUP_FS_CONST, 0x7);
+               fd6_emit_add_group(emit, fsconstobj, FD6_GROUP_FS_CONST, 0x6);
                fd_ringbuffer_del(fsconstobj);
        }
 
-       struct pipe_stream_output_info *info = &vp->shader->stream_output;
-       if (info->num_outputs) {
-               struct fd_streamout_stateobj *so = &ctx->streamout;
-
-               emit->streamout_mask = 0;
-
-               for (unsigned i = 0; i < so->num_targets; i++) {
-                       struct pipe_stream_output_target *target = so->targets[i];
-
-                       if (!target)
-                               continue;
-
-                       unsigned offset = (so->offsets[i] * info->stride[i] * 4) +
-                                       target->buffer_offset;
-
-                       OUT_PKT4(ring, REG_A6XX_VPC_SO_BUFFER_BASE_LO(i), 3);
-                       /* VPC_SO[i].BUFFER_BASE_LO: */
-                       OUT_RELOCW(ring, fd_resource(target->buffer)->bo, 0, 0, 0);
-                       OUT_RING(ring, target->buffer_size + offset);
-
-                       OUT_PKT4(ring, REG_A6XX_VPC_SO_BUFFER_OFFSET(i), 3);
-                       OUT_RING(ring, offset);
-                       /* VPC_SO[i].FLUSH_BASE_LO/HI: */
-                       // TODO just give hw a dummy addr for now.. we should
-                       // be using this an then CP_MEM_TO_REG to set the
-                       // VPC_SO[i].BUFFER_OFFSET for the next draw..
-                       OUT_RELOCW(ring, fd6_context(ctx)->blit_mem, 0x100, 0, 0);
+       struct ir3_stream_output_info *info = &vp->shader->stream_output;
+       if (info->num_outputs)
+               fd6_emit_streamout(ring, emit, info);
 
-                       emit->streamout_mask |= (1 << i);
-               }
-
-               if (emit->streamout_mask) {
-                       struct fd6_streamout_state *tf = &fd6_context(ctx)->tf;
-
-                       OUT_PKT7(ring, CP_CONTEXT_REG_BUNCH, 12 + (2 * tf->prog_count));
-                       OUT_RING(ring, REG_A6XX_VPC_SO_BUF_CNTL);
-                       OUT_RING(ring, tf->vpc_so_buf_cntl);
-                       OUT_RING(ring, REG_A6XX_VPC_SO_NCOMP(0));
-                       OUT_RING(ring, tf->ncomp[0]);
-                       OUT_RING(ring, REG_A6XX_VPC_SO_NCOMP(1));
-                       OUT_RING(ring, tf->ncomp[1]);
-                       OUT_RING(ring, REG_A6XX_VPC_SO_NCOMP(2));
-                       OUT_RING(ring, tf->ncomp[2]);
-                       OUT_RING(ring, REG_A6XX_VPC_SO_NCOMP(3));
-                       OUT_RING(ring, tf->ncomp[3]);
-                       OUT_RING(ring, REG_A6XX_VPC_SO_CNTL);
-                       OUT_RING(ring, A6XX_VPC_SO_CNTL_ENABLE);
-                       for (unsigned i = 0; i < tf->prog_count; i++) {
-                               OUT_RING(ring, REG_A6XX_VPC_SO_PROG);
-                               OUT_RING(ring, tf->prog[i]);
-                       }
-
-                       OUT_PKT4(ring, REG_A6XX_VPC_SO_OVERRIDE, 1);
-                       OUT_RING(ring, 0x0);
-               } else {
-                       OUT_PKT7(ring, CP_CONTEXT_REG_BUNCH, 4);
-                       OUT_RING(ring, REG_A6XX_VPC_SO_CNTL);
-                       OUT_RING(ring, 0);
-                       OUT_RING(ring, REG_A6XX_VPC_SO_BUF_CNTL);
-                       OUT_RING(ring, 0);
-
-                       OUT_PKT4(ring, REG_A6XX_VPC_SO_OVERRIDE, 1);
-                       OUT_RING(ring, A6XX_VPC_SO_OVERRIDE_SO_DISABLE);
-               }
-       }
-
-       if ((dirty & FD_DIRTY_BLEND)) {
+       if (dirty & FD_DIRTY_BLEND) {
                struct fd6_blend_stateobj *blend = fd6_blend_stateobj(ctx->blend);
                uint32_t i;
 
-               for (i = 0; i < A6XX_MAX_RENDER_TARGETS; i++) {
+               for (i = 0; i < pfb->nr_cbufs; i++) {
                        enum pipe_format format = pipe_surface_format(pfb->cbufs[i]);
                        bool is_int = util_format_is_pure_integer(format);
                        bool has_alpha = util_format_has_alpha(format);
@@ -918,14 +925,18 @@ fd6_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
                        OUT_RING(ring, blend_control);
                }
 
-               OUT_PKT4(ring, REG_A6XX_RB_BLEND_CNTL, 1);
-               OUT_RING(ring, blend->rb_blend_cntl |
-                               A6XX_RB_BLEND_CNTL_SAMPLE_MASK(0xffff));
-
                OUT_PKT4(ring, REG_A6XX_SP_BLEND_CNTL, 1);
                OUT_RING(ring, blend->sp_blend_cntl);
        }
 
+       if (dirty & (FD_DIRTY_BLEND | FD_DIRTY_SAMPLE_MASK)) {
+               struct fd6_blend_stateobj *blend = fd6_blend_stateobj(ctx->blend);
+
+               OUT_PKT4(ring, REG_A6XX_RB_BLEND_CNTL, 1);
+               OUT_RING(ring, blend->rb_blend_cntl |
+                               A6XX_RB_BLEND_CNTL_SAMPLE_MASK(ctx->sample_mask));
+       }
+
        if (dirty & FD_DIRTY_BLEND_COLOR) {
                struct pipe_blend_color *bcolor = &ctx->blend_color;
 
@@ -936,34 +947,38 @@ fd6_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
                OUT_RING(ring, A6XX_RB_BLEND_ALPHA_F32(bcolor->color[3]));
        }
 
-       if ((ctx->dirty_shader[PIPE_SHADER_VERTEX] & FD_DIRTY_SHADER_TEX) &&
-                       ctx->tex[PIPE_SHADER_VERTEX].num_textures > 0) {
-               struct fd6_texture_state *tex = fd6_texture_state(ctx,
-                               SB6_VS_TEX, &ctx->tex[PIPE_SHADER_VERTEX]);
-
-               needs_border |= tex->needs_border;
-
-               fd6_emit_add_group(emit, tex->stateobj, FD6_GROUP_VS_TEX, 0x7);
-       }
+       needs_border |= fd6_emit_combined_textures(ring, emit, PIPE_SHADER_VERTEX, vp);
+       needs_border |= fd6_emit_combined_textures(ring, emit, PIPE_SHADER_FRAGMENT, fp);
 
-       if ((ctx->dirty_shader[PIPE_SHADER_FRAGMENT] & FD_DIRTY_SHADER_TEX) &&
-                       ctx->tex[PIPE_SHADER_FRAGMENT].num_textures > 0) {
-               struct fd6_texture_state *tex = fd6_texture_state(ctx,
-                               SB6_FS_TEX, &ctx->tex[PIPE_SHADER_FRAGMENT]);
+       if (needs_border)
+               emit_border_color(ctx, ring);
 
-               needs_border |= tex->needs_border;
+       if (ctx->dirty_shader[PIPE_SHADER_FRAGMENT] &
+                       (FD_DIRTY_SHADER_SSBO | FD_DIRTY_SHADER_IMAGE)) {
+               struct fd_ringbuffer *state =
+                       fd6_build_ibo_state(ctx, fp, PIPE_SHADER_FRAGMENT);
+               struct fd_ringbuffer *obj = fd_submit_new_ringbuffer(
+                       ctx->batch->submit, 9 * 4, FD_RINGBUFFER_STREAMING);
+               const struct ir3_ibo_mapping *mapping = &fp->image_mapping;
 
-               fd6_emit_add_group(emit, tex->stateobj, FD6_GROUP_FS_TEX, 0x7);
-       }
+               OUT_PKT7(obj, CP_LOAD_STATE6, 3);
+               OUT_RING(obj, CP_LOAD_STATE6_0_DST_OFF(0) |
+                       CP_LOAD_STATE6_0_STATE_TYPE(ST6_SHADER) |
+                       CP_LOAD_STATE6_0_STATE_SRC(SS6_INDIRECT) |
+                       CP_LOAD_STATE6_0_STATE_BLOCK(SB6_IBO) |
+                       CP_LOAD_STATE6_0_NUM_UNIT(mapping->num_ibo));
+               OUT_RB(obj, state);
 
-       if (needs_border)
-               emit_border_color(ctx, ring);
+               OUT_PKT4(obj, REG_A6XX_SP_IBO_LO, 2);
+               OUT_RB(obj, state);
 
-       if (ctx->dirty_shader[PIPE_SHADER_FRAGMENT] & FD_DIRTY_SHADER_SSBO)
-               emit_ssbos(ctx, ring, SB6_SSBO, &ctx->shaderbuf[PIPE_SHADER_FRAGMENT]);
+               OUT_PKT4(obj, REG_A6XX_SP_IBO_COUNT, 1);
+               OUT_RING(obj, mapping->num_ibo);
 
-       if (ctx->dirty_shader[PIPE_SHADER_FRAGMENT] & FD_DIRTY_SHADER_IMAGE)
-               fd6_emit_images(ctx, ring, PIPE_SHADER_FRAGMENT);
+               fd6_emit_add_group(emit, obj, FD6_GROUP_IBO, 0x7);
+               fd_ringbuffer_del(obj);
+               fd_ringbuffer_del(state);
+       }
 
        if (emit->num_groups > 0) {
                OUT_PKT7(ring, CP_SET_DRAW_STATE, 3 * emit->num_groups);
@@ -971,10 +986,19 @@ fd6_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
                        struct fd6_state_group *g = &emit->groups[i];
                        unsigned n = fd_ringbuffer_size(g->stateobj) / 4;
 
-                       OUT_RING(ring, CP_SET_DRAW_STATE__0_COUNT(n) |
-                                       CP_SET_DRAW_STATE__0_ENABLE_MASK(g->enable_mask) |
-                                       CP_SET_DRAW_STATE__0_GROUP_ID(g->group_id));
-                       OUT_RB(ring, g->stateobj);
+                       if (n == 0) {
+                               OUT_RING(ring, CP_SET_DRAW_STATE__0_COUNT(0) |
+                                               CP_SET_DRAW_STATE__0_DISABLE |
+                                               CP_SET_DRAW_STATE__0_ENABLE_MASK(g->enable_mask) |
+                                               CP_SET_DRAW_STATE__0_GROUP_ID(g->group_id));
+                               OUT_RING(ring, 0x00000000);
+                               OUT_RING(ring, 0x00000000);
+                       } else {
+                               OUT_RING(ring, CP_SET_DRAW_STATE__0_COUNT(n) |
+                                               CP_SET_DRAW_STATE__0_ENABLE_MASK(g->enable_mask) |
+                                               CP_SET_DRAW_STATE__0_GROUP_ID(g->group_id));
+                               OUT_RB(ring, g->stateobj);
+                       }
 
                        fd_ringbuffer_del(g->stateobj);
                }
@@ -988,43 +1012,56 @@ fd6_emit_cs_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
 {
        enum fd_dirty_shader_state dirty = ctx->dirty_shader[PIPE_SHADER_COMPUTE];
 
-       if (dirty & FD_DIRTY_SHADER_TEX) {
-               bool needs_border = false;
-               needs_border |= fd6_emit_textures(ctx->pipe, ring, SB6_CS_TEX,
-                               &ctx->tex[PIPE_SHADER_COMPUTE], 0);
+       if (dirty & (FD_DIRTY_SHADER_TEX | FD_DIRTY_SHADER_PROG |
+                        FD_DIRTY_SHADER_IMAGE | FD_DIRTY_SHADER_SSBO)) {
+               struct fd_texture_stateobj *tex = &ctx->tex[PIPE_SHADER_COMPUTE];
+               struct fd_shaderbuf_stateobj *buf = &ctx->shaderbuf[PIPE_SHADER_COMPUTE];
+               struct fd_shaderimg_stateobj *img = &ctx->shaderimg[PIPE_SHADER_COMPUTE];
+               unsigned bcolor_offset = fd6_border_color_offset(ctx, SB6_CS_TEX, tex);
+
+               bool needs_border = fd6_emit_textures(ctx->pipe, ring, SB6_CS_TEX, tex,
+                               bcolor_offset, cp, buf, img);
 
                if (needs_border)
                        emit_border_color(ctx, ring);
 
-#if 0
-               OUT_PKT4(ring, REG_A6XX_TPL1_VS_TEX_COUNT, 1);
+               OUT_PKT4(ring, REG_A6XX_SP_VS_TEX_COUNT, 1);
                OUT_RING(ring, 0);
 
-               OUT_PKT4(ring, REG_A6XX_TPL1_HS_TEX_COUNT, 1);
+               OUT_PKT4(ring, REG_A6XX_SP_HS_TEX_COUNT, 1);
                OUT_RING(ring, 0);
 
-               OUT_PKT4(ring, REG_A6XX_TPL1_DS_TEX_COUNT, 1);
+               OUT_PKT4(ring, REG_A6XX_SP_DS_TEX_COUNT, 1);
                OUT_RING(ring, 0);
 
-               OUT_PKT4(ring, REG_A6XX_TPL1_GS_TEX_COUNT, 1);
+               OUT_PKT4(ring, REG_A6XX_SP_GS_TEX_COUNT, 1);
                OUT_RING(ring, 0);
 
-               OUT_PKT4(ring, REG_A6XX_TPL1_FS_TEX_COUNT, 1);
+               OUT_PKT4(ring, REG_A6XX_SP_FS_TEX_COUNT, 1);
                OUT_RING(ring, 0);
-#endif
        }
 
-#if 0
-       OUT_PKT4(ring, REG_A6XX_TPL1_CS_TEX_COUNT, 1);
-       OUT_RING(ring, ctx->shaderimg[PIPE_SHADER_COMPUTE].enabled_mask ?
-                       ~0 : ctx->tex[PIPE_SHADER_COMPUTE].num_textures);
-#endif
+       if (dirty & (FD_DIRTY_SHADER_SSBO | FD_DIRTY_SHADER_IMAGE)) {
+               struct fd_ringbuffer *state =
+                       fd6_build_ibo_state(ctx, cp, PIPE_SHADER_COMPUTE);
+               const struct ir3_ibo_mapping *mapping = &cp->image_mapping;
+
+               OUT_PKT7(ring, CP_LOAD_STATE6_FRAG, 3);
+               OUT_RING(ring, CP_LOAD_STATE6_0_DST_OFF(0) |
+                       CP_LOAD_STATE6_0_STATE_TYPE(ST6_IBO) |
+                       CP_LOAD_STATE6_0_STATE_SRC(SS6_INDIRECT) |
+                       CP_LOAD_STATE6_0_STATE_BLOCK(SB6_CS_SHADER) |
+                       CP_LOAD_STATE6_0_NUM_UNIT(mapping->num_ibo));
+               OUT_RB(ring, state);
 
-       if (dirty & FD_DIRTY_SHADER_SSBO)
-               emit_ssbos(ctx, ring, SB6_CS_SSBO, &ctx->shaderbuf[PIPE_SHADER_COMPUTE]);
+               OUT_PKT4(ring, REG_A6XX_SP_CS_IBO_LO, 2);
+               OUT_RB(ring, state);
 
-       if (dirty & FD_DIRTY_SHADER_IMAGE)
-               fd6_emit_images(ctx, ring, PIPE_SHADER_COMPUTE);
+               OUT_PKT4(ring, REG_A6XX_SP_CS_IBO_COUNT, 1);
+               OUT_RING(ring, mapping->num_ibo);
+
+               fd_ringbuffer_del(state);
+       }
 }
 
 
@@ -1036,7 +1073,7 @@ fd6_emit_restore(struct fd_batch *batch, struct fd_ringbuffer *ring)
 {
        //struct fd_context *ctx = batch->ctx;
 
-       fd6_cache_flush(batch, ring);
+       fd6_cache_inv(batch, ring);
 
        OUT_PKT4(ring, REG_A6XX_HLSQ_UPDATE_CNTL, 1);
        OUT_RING(ring, 0xfffff);
@@ -1065,7 +1102,7 @@ t7              opcode: CP_WAIT_FOR_IDLE (26) (1 dwords)
        WRITE(REG_A6XX_GRAS_UNKNOWN_8600, 0x880);
        WRITE(REG_A6XX_HLSQ_UNKNOWN_BE04, 0);
        WRITE(REG_A6XX_SP_UNKNOWN_AE03, 0x00000410);
-       WRITE(REG_A6XX_SP_UNKNOWN_AB20, 0);
+       WRITE(REG_A6XX_SP_IBO_COUNT, 0);
        WRITE(REG_A6XX_SP_UNKNOWN_B182, 0);
        WRITE(REG_A6XX_HLSQ_UNKNOWN_BB11, 0);
        WRITE(REG_A6XX_UCHE_UNKNOWN_0E12, 0x3200000);
@@ -1099,7 +1136,8 @@ t7              opcode: CP_WAIT_FOR_IDLE (26) (1 dwords)
        WRITE(REG_A6XX_VPC_UNKNOWN_9101, 0xffff00);
        WRITE(REG_A6XX_VPC_UNKNOWN_9107, 0);
 
-       WRITE(REG_A6XX_VPC_UNKNOWN_9236, 1);
+       WRITE(REG_A6XX_VPC_UNKNOWN_9236,
+                 A6XX_VPC_UNKNOWN_9236_POINT_COORD_INVERT(0));
        WRITE(REG_A6XX_VPC_UNKNOWN_9300, 0);
 
        WRITE(REG_A6XX_VPC_SO_OVERRIDE, A6XX_VPC_SO_OVERRIDE_SO_DISABLE);
@@ -1155,47 +1193,9 @@ t7              opcode: CP_WAIT_FOR_IDLE (26) (1 dwords)
        OUT_RING(ring, CP_SET_DRAW_STATE__1_ADDR_LO(0));
        OUT_RING(ring, CP_SET_DRAW_STATE__2_ADDR_HI(0));
 
-       OUT_PKT4(ring, REG_A6XX_VPC_SO_BUFFER_BASE_LO(0), 3);
-       OUT_RING(ring, 0x00000000);   /* VPC_SO_BUFFER_BASE_LO_0 */
-       OUT_RING(ring, 0x00000000);   /* VPC_SO_BUFFER_BASE_HI_0 */
-       OUT_RING(ring, 0x00000000);   /* VPC_SO_BUFFER_SIZE_0 */
-
-       OUT_PKT4(ring, REG_A6XX_VPC_SO_FLUSH_BASE_LO(0), 2);
-       OUT_RING(ring, 0x00000000);   /* VPC_SO_FLUSH_BASE_LO_0 */
-       OUT_RING(ring, 0x00000000);   /* VPC_SO_FLUSH_BASE_HI_0 */
-
        OUT_PKT4(ring, REG_A6XX_VPC_SO_BUF_CNTL, 1);
        OUT_RING(ring, 0x00000000);   /* VPC_SO_BUF_CNTL */
 
-       OUT_PKT4(ring, REG_A6XX_VPC_SO_BUFFER_OFFSET(0), 1);
-       OUT_RING(ring, 0x00000000);   /* UNKNOWN_E2AB */
-
-       OUT_PKT4(ring, REG_A6XX_VPC_SO_BUFFER_BASE_LO(1), 3);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-
-       OUT_PKT4(ring, REG_A6XX_VPC_SO_BUFFER_OFFSET(1), 6);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-
-       OUT_PKT4(ring, REG_A6XX_VPC_SO_BUFFER_OFFSET(2), 6);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-
-       OUT_PKT4(ring, REG_A6XX_VPC_SO_BUFFER_OFFSET(3), 3);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-       OUT_RING(ring, 0x00000000);
-
        OUT_PKT4(ring, REG_A6XX_SP_HS_CTRL_REG0, 1);
        OUT_RING(ring, 0x00000000);
 
@@ -1209,14 +1209,6 @@ t7              opcode: CP_WAIT_FOR_IDLE (26) (1 dwords)
        OUT_RING(ring, 0x00000000);
 }
 
-static void
-fd6_emit_ib(struct fd_ringbuffer *ring, struct fd_ringbuffer *target)
-{
-       emit_marker6(ring, 6);
-       __OUT_IB5(ring, target);
-       emit_marker6(ring, 6);
-}
-
 static void
 fd6_mem_to_mem(struct fd_ringbuffer *ring, struct pipe_resource *dst,
                unsigned dst_off, struct pipe_resource *src, unsigned src_off,