freedreno/a6xx: Add ARB_depth_clamp and separate clamp support.
[mesa.git] / src / gallium / drivers / freedreno / a6xx / fd6_emit.c
index 82bf24759a429785bc825baad690bc1990e61ebc..ff441126e19aae888083419943aaf2c5129dd529 100644 (file)
@@ -34,7 +34,9 @@
 
 #include "freedreno_log.h"
 #include "freedreno_resource.h"
+#include "freedreno_state.h"
 #include "freedreno_query_hw.h"
+#include "common/freedreno_guardband.h"
 
 #include "fd6_emit.h"
 #include "fd6_blend.h"
@@ -258,8 +260,7 @@ fd6_emit_fb_tex(struct fd_ringbuffer *state, struct fd_context *ctx)
        OUT_RING(state, texconst0);
        OUT_RING(state, A6XX_TEX_CONST_1_WIDTH(pfb->width) |
                        A6XX_TEX_CONST_1_HEIGHT(pfb->height));
-       OUT_RINGP(state, A6XX_TEX_CONST_2_TYPE(A6XX_TEX_2D) |
-                       A6XX_TEX_CONST_2_FETCHSIZE(TFETCH6_2_BYTE),
+       OUT_RINGP(state, A6XX_TEX_CONST_2_TYPE(A6XX_TEX_2D),
                        &ctx->batch->fb_read_patches);
        OUT_RING(state, A6XX_TEX_CONST_3_ARRAY_PITCH(rsc->layout.layer_size));
 
@@ -346,7 +347,7 @@ fd6_emit_textures(struct fd_pipe *pipe, struct fd_ringbuffer *ring,
                        OUT_RING(state, sampler->texsamp0);
                        OUT_RING(state, sampler->texsamp1);
                        OUT_RING(state, sampler->texsamp2 |
-                               A6XX_TEX_SAMP_2_BCOLOR_OFFSET((i + bcolor_offset) * sizeof(struct bcolor_entry)));
+                               A6XX_TEX_SAMP_2_BCOLOR(i + bcolor_offset));
                        OUT_RING(state, sampler->texsamp3);
                        needs_border |= sampler->needs_border;
                }
@@ -552,16 +553,12 @@ fd6_emit_combined_textures(struct fd_ringbuffer *ring, struct fd6_emit *emit,
 }
 
 static struct fd_ringbuffer *
-build_vbo_state(struct fd6_emit *emit, const struct ir3_shader_variant *vp)
+build_vbo_state(struct fd6_emit *emit)
 {
        const struct fd_vertex_state *vtx = emit->vtx;
 
        struct fd_ringbuffer *ring = fd_submit_new_ringbuffer(emit->ctx->batch->submit,
-                       4 * (3 + vtx->vertexbuf.count * 4), FD_RINGBUFFER_STREAMING);
-
-       OUT_PKT4(ring, REG_A6XX_VFD_CONTROL_0, 1);
-       OUT_RING(ring, A6XX_VFD_CONTROL_0_FETCH_CNT(vtx->vertexbuf.count) |
-                       A6XX_VFD_CONTROL_0_DECODE_CNT(vtx->vtx->num_elements));
+                       4 * (1 + vtx->vertexbuf.count * 4), FD_RINGBUFFER_STREAMING);
 
        OUT_PKT4(ring, REG_A6XX_VFD_FETCH(0), 4 * vtx->vertexbuf.count);
        for (int32_t j = 0; j < vtx->vertexbuf.count; j++) {
@@ -588,11 +585,24 @@ build_vbo_state(struct fd6_emit *emit, const struct ir3_shader_variant *vp)
 static enum a6xx_ztest_mode
 compute_ztest_mode(struct fd6_emit *emit, bool lrz_valid)
 {
+       struct fd_context *ctx =  emit->ctx;
+       struct pipe_framebuffer_state *pfb = &ctx->batch->framebuffer;
+       struct fd6_zsa_stateobj *zsa = fd6_zsa_stateobj(ctx->zsa);
        const struct ir3_shader_variant *fs = emit->fs;
 
-       if (fs->no_earlyz || fs->writes_pos) {
+       if (fs->shader->nir->info.fs.early_fragment_tests)
+               return A6XX_EARLY_Z;
+
+       if (fs->no_earlyz || fs->writes_pos || !zsa->base.depth.enabled) {
                return A6XX_LATE_Z;
-       } else if (fs->has_kill) {
+       } else if ((fs->has_kill || zsa->alpha_test) &&
+                       (zsa->base.depth.writemask || !pfb->zsbuf)) {
+               /* Slightly odd, but seems like the hw wants us to select
+                * LATE_Z mode if there is no depth buffer + discard.  Either
+                * that, or when occlusion query is enabled.  See:
+                *
+                * dEQP-GLES31.functional.fbo.no_attachments.*
+                */
                return lrz_valid ? A6XX_EARLY_LRZ_LATE_Z : A6XX_LATE_Z;
        } else {
                return A6XX_EARLY_Z;
@@ -807,23 +817,20 @@ fd6_emit_state(struct fd_ringbuffer *ring, struct fd6_emit *emit)
                fd6_emit_add_group(emit, vtx->stateobj, FD6_GROUP_VTXSTATE, ENABLE_ALL);
        }
 
-       /* VFD_CONTROL packs both vfd fetch count and vfd decode count, so we have
-        * to emit this if either change.
-        */
-       if (emit->dirty & (FD_DIRTY_VTXBUF | FD_DIRTY_VTXSTATE)) {
+       if (emit->dirty & FD_DIRTY_VTXBUF) {
                struct fd_ringbuffer *state;
 
-               state = build_vbo_state(emit, emit->vs);
+               state = build_vbo_state(emit);
                fd6_emit_take_group(emit, state, FD6_GROUP_VBO, ENABLE_ALL);
        }
 
-       if (dirty & FD_DIRTY_ZSA) {
-               struct fd6_zsa_stateobj *zsa = fd6_zsa_stateobj(ctx->zsa);
+       if (dirty & (FD_DIRTY_ZSA | FD_DIRTY_RASTERIZER)) {
+               struct fd_ringbuffer *state =
+                       fd6_zsa_state(ctx,
+                                       util_format_is_pure_integer(pipe_surface_format(pfb->cbufs[0])),
+                                       fd_depth_clamp_enabled(ctx));
 
-               if (util_format_is_pure_integer(pipe_surface_format(pfb->cbufs[0])))
-                       fd6_emit_add_group(emit, zsa->stateobj_no_alpha, FD6_GROUP_ZSA, ENABLE_ALL);
-               else
-                       fd6_emit_add_group(emit, zsa->stateobj, FD6_GROUP_ZSA, ENABLE_ALL);
+               fd6_emit_add_group(emit, state, FD6_GROUP_ZSA, ENABLE_ALL);
        }
 
        if (dirty & (FD_DIRTY_ZSA | FD_DIRTY_BLEND | FD_DIRTY_PROG)) {
@@ -858,11 +865,11 @@ fd6_emit_state(struct fd_ringbuffer *ring, struct fd6_emit *emit)
                struct pipe_scissor_state *scissor = fd_context_get_scissor(ctx);
 
                OUT_REG(ring,
-                               A6XX_GRAS_SC_SCREEN_SCISSOR_TL_0(
+                               A6XX_GRAS_SC_SCREEN_SCISSOR_TL(0,
                                        .x = scissor->minx,
                                        .y = scissor->miny
                                ),
-                               A6XX_GRAS_SC_SCREEN_SCISSOR_BR_0(
+                               A6XX_GRAS_SC_SCREEN_SCISSOR_BR(0,
                                        .x = MAX2(scissor->maxx, 1) - 1,
                                        .y = MAX2(scissor->maxy, 1) - 1
                                )
@@ -880,27 +887,31 @@ fd6_emit_state(struct fd_ringbuffer *ring, struct fd6_emit *emit)
                struct pipe_scissor_state *scissor = &ctx->viewport_scissor;
 
                OUT_REG(ring,
-                               A6XX_GRAS_CL_VPORT_XOFFSET_0(ctx->viewport.translate[0]),
-                               A6XX_GRAS_CL_VPORT_XSCALE_0(ctx->viewport.scale[0]),
-                               A6XX_GRAS_CL_VPORT_YOFFSET_0(ctx->viewport.translate[1]),
-                               A6XX_GRAS_CL_VPORT_YSCALE_0(ctx->viewport.scale[1]),
-                               A6XX_GRAS_CL_VPORT_ZOFFSET_0(ctx->viewport.translate[2]),
-                               A6XX_GRAS_CL_VPORT_ZSCALE_0(ctx->viewport.scale[2])
+                               A6XX_GRAS_CL_VPORT_XOFFSET(0, ctx->viewport.translate[0]),
+                               A6XX_GRAS_CL_VPORT_XSCALE(0, ctx->viewport.scale[0]),
+                               A6XX_GRAS_CL_VPORT_YOFFSET(0, ctx->viewport.translate[1]),
+                               A6XX_GRAS_CL_VPORT_YSCALE(0, ctx->viewport.scale[1]),
+                               A6XX_GRAS_CL_VPORT_ZOFFSET(0, ctx->viewport.translate[2]),
+                               A6XX_GRAS_CL_VPORT_ZSCALE(0, ctx->viewport.scale[2])
                        );
 
                OUT_REG(ring,
-                               A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL_0(
+                               A6XX_GRAS_SC_VIEWPORT_SCISSOR_TL(0,
                                        .x = scissor->minx,
                                        .y = scissor->miny
                                ),
-                               A6XX_GRAS_SC_VIEWPORT_SCISSOR_BR_0(
+                               A6XX_GRAS_SC_VIEWPORT_SCISSOR_BR(0,
                                        .x = MAX2(scissor->maxx, 1) - 1,
                                        .y = MAX2(scissor->maxy, 1) - 1
                                )
                        );
 
-               unsigned guardband_x = fd_calc_guardband(scissor->maxx - scissor->minx);
-               unsigned guardband_y = fd_calc_guardband(scissor->maxy - scissor->miny);
+               unsigned guardband_x =
+                       fd_calc_guardband(ctx->viewport.translate[0], ctx->viewport.scale[0],
+                                                         false);
+               unsigned guardband_y =
+                       fd_calc_guardband(ctx->viewport.translate[1], ctx->viewport.scale[1],
+                                                         false);
 
                OUT_REG(ring, A6XX_GRAS_CL_GUARDBAND_CLIP_ADJ(
                                        .horz = guardband_x,
@@ -909,6 +920,24 @@ fd6_emit_state(struct fd_ringbuffer *ring, struct fd6_emit *emit)
                        );
        }
 
+       /* The clamp ranges are only used when the rasterizer wants depth
+        * clamping.
+        */
+       if ((dirty & (FD_DIRTY_VIEWPORT | FD_DIRTY_RASTERIZER)) &&
+                       fd_depth_clamp_enabled(ctx)) {
+               float zmin, zmax;
+               util_viewport_zmin_zmax(&ctx->viewport, ctx->rasterizer->clip_halfz,
+                               &zmin, &zmax);
+
+               OUT_REG(ring,
+                               A6XX_GRAS_CL_Z_CLAMP_MIN(0, zmin),
+                               A6XX_GRAS_CL_Z_CLAMP_MAX(0, zmax));
+
+               OUT_REG(ring,
+                               A6XX_RB_Z_CLAMP_MIN(zmin),
+                               A6XX_RB_Z_CLAMP_MAX(zmax));
+       }
+
        if (dirty & FD_DIRTY_PROG) {
                fd6_emit_add_group(emit, prog->config_stateobj, FD6_GROUP_PROG_CONFIG, ENABLE_ALL);
                fd6_emit_add_group(emit, prog->stateobj, FD6_GROUP_PROG, ENABLE_DRAW);
@@ -1128,8 +1157,20 @@ fd6_emit_restore(struct fd_batch *batch, struct fd_ringbuffer *ring)
 
        fd6_cache_inv(batch, ring);
 
-       OUT_PKT4(ring, REG_A6XX_HLSQ_UPDATE_CNTL, 1);
-       OUT_RING(ring, 0xfffff);
+       OUT_REG(ring, A6XX_HLSQ_INVALIDATE_CMD(
+                       .vs_state = true,
+                       .hs_state = true,
+                       .ds_state = true,
+                       .gs_state = true,
+                       .fs_state = true,
+                       .cs_state = true,
+                       .gfx_ibo = true,
+                       .cs_ibo = true,
+                       .gfx_shared_const = true,
+                       .cs_shared_const = true,
+                       .gfx_bindless = 0x1f,
+                       .cs_bindless = 0x1f
+               ));
 
        OUT_WFI5(ring);
 
@@ -1148,18 +1189,15 @@ fd6_emit_restore(struct fd_batch *batch, struct fd_ringbuffer *ring)
        WRITE(REG_A6XX_SP_UNKNOWN_AE03, 0x1430);
        WRITE(REG_A6XX_SP_IBO_COUNT, 0);
        WRITE(REG_A6XX_SP_UNKNOWN_B182, 0);
-       WRITE(REG_A6XX_HLSQ_UNKNOWN_BB11, 0);
+       WRITE(REG_A6XX_HLSQ_SHARED_CONSTS, 0);
        WRITE(REG_A6XX_UCHE_UNKNOWN_0E12, 0x3200000);
        WRITE(REG_A6XX_UCHE_CLIENT_PF, 4);
        WRITE(REG_A6XX_RB_UNKNOWN_8E01, 0x1);
-       WRITE(REG_A6XX_SP_UNKNOWN_AB00, 0x5);
+       WRITE(REG_A6XX_SP_MODE_CONTROL, A6XX_SP_MODE_CONTROL_CONSTANT_DEMOTION_ENABLE | 4);
        WRITE(REG_A6XX_VFD_ADD_OFFSET, A6XX_VFD_ADD_OFFSET_VERTEX);
        WRITE(REG_A6XX_RB_UNKNOWN_8811, 0x00000010);
        WRITE(REG_A6XX_PC_MODE_CNTL, 0x1f);
 
-       OUT_PKT4(ring, REG_A6XX_RB_SRGB_CNTL, 1);
-       OUT_RING(ring, 0);
-
        WRITE(REG_A6XX_GRAS_UNKNOWN_8101, 0);
        WRITE(REG_A6XX_GRAS_SAMPLE_CNTL, 0);
        WRITE(REG_A6XX_GRAS_UNKNOWN_8110, 0x2);
@@ -1173,31 +1211,28 @@ fd6_emit_restore(struct fd_batch *batch, struct fd_ringbuffer *ring)
        WRITE(REG_A6XX_RB_UNKNOWN_881E, 0);
        WRITE(REG_A6XX_RB_UNKNOWN_88F0, 0);
 
-       WRITE(REG_A6XX_VPC_UNKNOWN_9236,
-                 A6XX_VPC_UNKNOWN_9236_POINT_COORD_INVERT(0));
+       WRITE(REG_A6XX_VPC_POINT_COORD_INVERT,
+                 A6XX_VPC_POINT_COORD_INVERT(0).value);
        WRITE(REG_A6XX_VPC_UNKNOWN_9300, 0);
 
-       WRITE(REG_A6XX_VPC_SO_OVERRIDE, A6XX_VPC_SO_OVERRIDE_SO_DISABLE);
+       WRITE(REG_A6XX_VPC_SO_DISABLE, A6XX_VPC_SO_DISABLE(true).value);
 
-       WRITE(REG_A6XX_PC_UNKNOWN_9990, 0);
        WRITE(REG_A6XX_PC_UNKNOWN_9980, 0);
 
-       WRITE(REG_A6XX_PC_UNKNOWN_9B07, 0);
+       WRITE(REG_A6XX_PC_MULTIVIEW_CNTL, 0);
 
        WRITE(REG_A6XX_SP_UNKNOWN_A81B, 0);
 
        WRITE(REG_A6XX_SP_UNKNOWN_B183, 0);
 
        WRITE(REG_A6XX_GRAS_UNKNOWN_8099, 0);
-       WRITE(REG_A6XX_GRAS_UNKNOWN_809B, 0);
+       WRITE(REG_A6XX_GRAS_VS_LAYER_CNTL, 0);
        WRITE(REG_A6XX_GRAS_UNKNOWN_80A0, 2);
        WRITE(REG_A6XX_GRAS_UNKNOWN_80AF, 0);
        WRITE(REG_A6XX_VPC_UNKNOWN_9210, 0);
        WRITE(REG_A6XX_VPC_UNKNOWN_9211, 0);
        WRITE(REG_A6XX_VPC_UNKNOWN_9602, 0);
-       WRITE(REG_A6XX_PC_UNKNOWN_9981, 0x3);
        WRITE(REG_A6XX_PC_UNKNOWN_9E72, 0);
-       WRITE(REG_A6XX_VPC_UNKNOWN_9108, 0x3);
        WRITE(REG_A6XX_SP_TP_SAMPLE_CONFIG, 0);
        /* NOTE blob seems to (mostly?) use 0xb2 for SP_TP_UNKNOWN_B309
         * but this seems to kill texture gather offsets.
@@ -1205,8 +1240,8 @@ fd6_emit_restore(struct fd_batch *batch, struct fd_ringbuffer *ring)
        WRITE(REG_A6XX_SP_TP_UNKNOWN_B309, 0xa2);
        WRITE(REG_A6XX_RB_SAMPLE_CONFIG, 0);
        WRITE(REG_A6XX_GRAS_SAMPLE_CONFIG, 0);
-       WRITE(REG_A6XX_RB_UNKNOWN_8878, 0);
-       WRITE(REG_A6XX_RB_UNKNOWN_8879, 0);
+       WRITE(REG_A6XX_RB_Z_BOUNDS_MIN, 0);
+       WRITE(REG_A6XX_RB_Z_BOUNDS_MAX, 0);
        WRITE(REG_A6XX_HLSQ_CONTROL_5_REG, 0xfc);
 
        emit_marker6(ring, 7);
@@ -1214,7 +1249,7 @@ fd6_emit_restore(struct fd_batch *batch, struct fd_ringbuffer *ring)
        OUT_PKT4(ring, REG_A6XX_VFD_MODE_CNTL, 1);
        OUT_RING(ring, 0x00000000);   /* VFD_MODE_CNTL */
 
-       WRITE(REG_A6XX_VFD_UNKNOWN_A008, 0);
+       WRITE(REG_A6XX_VFD_MULTIVIEW_CNTL, 0);
 
        OUT_PKT4(ring, REG_A6XX_PC_MODE_CNTL, 1);
        OUT_RING(ring, 0x0000001f);   /* PC_MODE_CNTL */