* Rob Clark <robclark@freedesktop.org>
*/
+#include "drm-uapi/drm_fourcc.h"
+
#include "fd6_resource.h"
+#include "fd6_format.h"
#include "a6xx.xml.h"
-/* indexed by cpp, including msaa 2x and 4x: */
-static const struct {
- unsigned pitchalign;
- unsigned heightalign;
-} tile_alignment[] = {
- [1] = { 128, 32 },
- [2] = { 64, 32 },
- [3] = { 64, 32 },
- [4] = { 64, 16 },
- [6] = { 64, 16 },
- [8] = { 64, 16 },
- [12] = { 64, 16 },
- [16] = { 64, 16 },
- [24] = { 64, 16 },
- [32] = { 64, 16 },
- [48] = { 64, 16 },
- [64] = { 64, 16 },
-
- /* special cases for r16: */
- [0] = { 128, 16 },
-};
-
-/* NOTE: good way to test this is: (for example)
- * piglit/bin/texelFetch fs sampler3D 100x100x8
+/* A subset of the valid tiled formats can be compressed. We do
+ * already require tiled in order to be compressed, but just because
+ * it can be tiled doesn't mean it can be compressed.
*/
-static uint32_t
-setup_slices(struct fd_resource *rsc, uint32_t alignment, enum pipe_format format)
+static bool
+ok_ubwc_format(struct fd_resource *rsc, enum pipe_format pfmt)
{
- struct pipe_resource *prsc = &rsc->base;
- struct fd_screen *screen = fd_screen(prsc->screen);
- enum util_format_layout layout = util_format_description(format)->layout;
- uint32_t pitchalign = screen->gmem_alignw;
- uint32_t level, size = 0;
- uint32_t depth = prsc->depth0;
- /* linear dimensions: */
- uint32_t lwidth = prsc->width0;
- uint32_t lheight = prsc->height0;
- /* tile_mode dimensions: */
- uint32_t twidth = util_next_power_of_two(lwidth);
- uint32_t theight = util_next_power_of_two(lheight);
- /* in layer_first layout, the level (slice) contains just one
- * layer (since in fact the layer contains the slices)
+ /* NOTE: both x24s8 and z24s8 map to RB6_X8Z24_UNORM, but UBWC
+ * does not seem to work properly when sampling x24s8.. possibly
+ * because we sample it as TFMT6_8_8_8_8_UINT.
+ *
+ * This could possibly be a hw limitation, or maybe something
+ * else wrong somewhere (although z24s8 blits and sampling with
+ * UBWC seem fine). Recheck on a later revision of a6xx
*/
- uint32_t layers_in_level = rsc->layer_first ? 1 : prsc->array_size;
- int ta = rsc->cpp;
-
- /* The z16/r16 formats seem to not play by the normal tiling rules: */
- if ((rsc->cpp == 2) && (util_format_get_nr_components(format) == 1))
- ta = 0;
-
- debug_assert(ta < ARRAY_SIZE(tile_alignment));
- debug_assert(tile_alignment[ta].pitchalign);
-
- for (level = 0; level <= prsc->last_level; level++) {
- struct fd_resource_slice *slice = fd_resource_slice(rsc, level);
- bool linear_level = fd_resource_level_linear(prsc, level);
- uint32_t width, height;
-
- /* tiled levels of 3D textures are rounded up to PoT dimensions: */
- if ((prsc->target == PIPE_TEXTURE_3D) && rsc->tile_mode && !linear_level) {
- width = twidth;
- height = theight;
- } else {
- width = lwidth;
- height = lheight;
- }
- uint32_t aligned_height = height;
- uint32_t blocks;
-
- if (rsc->tile_mode && !linear_level) {
- pitchalign = tile_alignment[ta].pitchalign;
- aligned_height = align(aligned_height,
- tile_alignment[ta].heightalign);
- } else {
- pitchalign = 64;
- }
-
- /* The blits used for mem<->gmem work at a granularity of
- * 32x32, which can cause faults due to over-fetch on the
- * last level. The simple solution is to over-allocate a
- * bit the last level to ensure any over-fetch is harmless.
- * The pitch is already sufficiently aligned, but height
- * may not be:
- */
- if ((level == prsc->last_level) && (prsc->target != PIPE_BUFFER))
- aligned_height = align(aligned_height, 32);
-
- if (layout == UTIL_FORMAT_LAYOUT_ASTC)
- slice->pitch =
- util_align_npot(width, pitchalign * util_format_get_blockwidth(format));
- else
- slice->pitch = align(width, pitchalign);
-
- slice->offset = size;
- blocks = util_format_get_nblocks(format, slice->pitch, aligned_height);
-
- /* 1d array and 2d array textures must all have the same layer size
- * for each miplevel on a6xx. 3d textures can have different layer
- * sizes for high levels, but the hw auto-sizer is buggy (or at least
- * different than what this code does), so as soon as the layer size
- * range gets into range, we stop reducing it.
- */
- if (prsc->target == PIPE_TEXTURE_3D) {
- if (level <= 1 || (rsc->slices[level - 1].size0 > 0xf000)) {
- slice->size0 = align(blocks * rsc->cpp, alignment);
- } else {
- slice->size0 = rsc->slices[level - 1].size0;
- }
- } else {
- slice->size0 = align(blocks * rsc->cpp, alignment);
- }
-
- size += slice->size0 * depth * layers_in_level;
-
-#if 0
- debug_printf("%s: %ux%ux%u@%u:\t%2u: stride=%4u, size=%6u,%7u, aligned_height=%3u, blocks=%u\n",
- util_format_name(prsc->format),
- width, height, depth, rsc->cpp,
- level, slice->pitch * rsc->cpp,
- slice->size0, size, aligned_height, blocks);
-#endif
-
- depth = u_minify(depth, 1);
- lwidth = u_minify(lwidth, 1);
- lheight = u_minify(lheight, 1);
- twidth = u_minify(twidth, 1);
- theight = u_minify(theight, 1);
+ if (pfmt == PIPE_FORMAT_X24S8_UINT)
+ return false;
+
+ /* We don't fully understand what's going wrong with this combination, but
+ * we haven't been able to make it work. It's enough of a corner-case
+ * that we can just disable UBWC for these resources.
+ */
+ if (rsc->base.target != PIPE_TEXTURE_2D &&
+ pfmt == PIPE_FORMAT_Z24_UNORM_S8_UINT)
+ return false;
+
+ switch (fd6_pipe2color(pfmt)) {
+ case FMT6_10_10_10_2_UINT:
+ case FMT6_10_10_10_2_UNORM_DEST:
+ case FMT6_11_11_10_FLOAT:
+ case FMT6_16_FLOAT:
+ case FMT6_16_16_16_16_FLOAT:
+ case FMT6_16_16_16_16_SINT:
+ case FMT6_16_16_16_16_UINT:
+ case FMT6_16_16_FLOAT:
+ case FMT6_16_16_SINT:
+ case FMT6_16_16_UINT:
+ case FMT6_16_SINT:
+ case FMT6_16_UINT:
+ case FMT6_32_32_32_32_SINT:
+ case FMT6_32_32_32_32_UINT:
+ case FMT6_32_32_SINT:
+ case FMT6_32_32_UINT:
+ case FMT6_5_6_5_UNORM:
+ case FMT6_8_8_8_8_SINT:
+ case FMT6_8_8_8_8_UINT:
+ case FMT6_8_8_8_8_UNORM:
+ case FMT6_8_8_8_X8_UNORM:
+ case FMT6_8_8_SINT:
+ case FMT6_8_8_UINT:
+ case FMT6_8_8_UNORM:
+ case FMT6_Z24_UNORM_S8_UINT:
+ case FMT6_Z24_UNORM_S8_UINT_AS_R8G8B8A8:
+ return true;
+ default:
+ return false;
}
+}
- return size;
+/**
+ * Ensure the rsc is in an ok state to be used with the specified format.
+ * This handles the case of UBWC buffers used with non-UBWC compatible
+ * formats, by triggering an uncompress.
+ */
+void
+fd6_validate_format(struct fd_context *ctx, struct fd_resource *rsc,
+ enum pipe_format format)
+{
+ if (!rsc->layout.ubwc)
+ return;
+
+ if (ok_ubwc_format(rsc, format))
+ return;
+
+ fd_resource_uncompress(ctx, rsc);
}
-uint32_t
-fd6_fill_ubwc_buffer_sizes(struct fd_resource *rsc)
+static void
+setup_lrz(struct fd_resource *rsc)
{
-#define RGB_TILE_WIDTH 16
-#define RBG_TILE_WIDTH_ALIGNMENT 64
-#define RGB_TILE_HEIGHT 4
-#define RGB_TILE_HEIGHT_ALIGNMENT 16
-#define UBWC_PLANE_SIZE_ALIGNMENT 4096
+ struct fd_screen *screen = fd_screen(rsc->base.screen);
+ const uint32_t flags = DRM_FREEDRENO_GEM_CACHE_WCOMBINE |
+ DRM_FREEDRENO_GEM_TYPE_KMEM; /* TODO */
+ unsigned width0 = rsc->base.width0;
+ unsigned height0 = rsc->base.height0;
+
+ /* LRZ buffer is super-sampled: */
+ switch (rsc->base.nr_samples) {
+ case 4:
+ width0 *= 2;
+ /* fallthru */
+ case 2:
+ height0 *= 2;
+ }
+
+ unsigned lrz_pitch = align(DIV_ROUND_UP(width0, 8), 32);
+ unsigned lrz_height = align(DIV_ROUND_UP(height0, 8), 16);
+
+ unsigned size = lrz_pitch * lrz_height * 2;
+ rsc->lrz_height = lrz_height;
+ rsc->lrz_width = lrz_pitch;
+ rsc->lrz_pitch = lrz_pitch;
+ rsc->lrz = fd_bo_new(screen->dev, size, flags, "lrz");
+}
+
+static uint32_t
+fd6_setup_slices(struct fd_resource *rsc)
+{
struct pipe_resource *prsc = &rsc->base;
- uint32_t width = prsc->width0;
- uint32_t height = prsc->height0;
+
+ if (!(fd_mesa_debug & FD_DBG_NOLRZ) && has_depth(rsc->base.format))
+ setup_lrz(rsc);
+
+ if (rsc->layout.ubwc && !ok_ubwc_format(rsc, rsc->base.format))
+ rsc->layout.ubwc = false;
+
+ fdl6_layout(&rsc->layout, prsc->format, fd_resource_nr_samples(prsc),
+ prsc->width0, prsc->height0, prsc->depth0,
+ prsc->last_level + 1, prsc->array_size,
+ prsc->target == PIPE_TEXTURE_3D);
+
+ return rsc->layout.size;
+}
+
+static int
+fill_ubwc_buffer_sizes(struct fd_resource *rsc)
+{
+ struct pipe_resource *prsc = &rsc->base;
+ struct fdl_slice slice = *fd_resource_slice(rsc, 0);
/* limit things to simple single level 2d for now: */
if ((prsc->depth0 != 1) || (prsc->array_size != 1) || (prsc->last_level != 0))
- return 0;
+ return -1;
+ if (prsc->target != PIPE_TEXTURE_2D)
+ return -1;
+ if (!ok_ubwc_format(rsc, prsc->format))
+ return -1;
+
+ rsc->layout.ubwc = true;
+ rsc->layout.tile_mode = TILE6_3;
- uint32_t meta_stride =
- ALIGN_POT(DIV_ROUND_UP(width, RGB_TILE_WIDTH), RBG_TILE_WIDTH_ALIGNMENT);
- uint32_t meta_scanlines =
- ALIGN_POT(DIV_ROUND_UP(height, RGB_TILE_HEIGHT), RGB_TILE_HEIGHT_ALIGNMENT);
- uint32_t meta_plane =
- ALIGN_POT(meta_stride * meta_scanlines, UBWC_PLANE_SIZE_ALIGNMENT);
+ fdl6_layout(&rsc->layout, prsc->format, fd_resource_nr_samples(prsc),
+ prsc->width0, prsc->height0, prsc->depth0,
+ prsc->last_level + 1, prsc->array_size, false);
- rsc->offset = meta_plane;
- rsc->ubwc_pitch = meta_stride;
- rsc->ubwc_size = meta_plane >> 2;
- rsc->tile_mode = TILE6_3;
+ if (fd_resource_slice(rsc, 0)->pitch != slice.pitch)
+ return -1;
- return rsc->ubwc_size;
+ /* The imported buffer may specify an offset, add that in here. */
+ rsc->layout.slices[0].offset += slice.offset;
+ rsc->layout.ubwc_slices[0].offset += slice.offset;
+ rsc->layout.size += slice.offset;
+
+ if (rsc->layout.size > fd_bo_size(rsc->bo))
+ return -1;
+
+ return 0;
}
-uint32_t
-fd6_setup_slices(struct fd_resource *rsc)
+static int
+fd6_layout_resource_for_modifier(struct fd_resource *rsc, uint64_t modifier)
{
- uint32_t alignment;
-
- switch (rsc->base.target) {
- case PIPE_TEXTURE_3D:
- rsc->layer_first = false;
- alignment = 4096;
- break;
+ switch (modifier) {
+ case DRM_FORMAT_MOD_QCOM_COMPRESSED:
+ return fill_ubwc_buffer_sizes(rsc);
+ case DRM_FORMAT_MOD_LINEAR:
+ case DRM_FORMAT_MOD_INVALID:
+ return 0;
default:
- rsc->layer_first = true;
- alignment = 1;
- break;
+ return -1;
}
+}
+
+static const uint64_t supported_modifiers[] = {
+ DRM_FORMAT_MOD_LINEAR,
+ DRM_FORMAT_MOD_QCOM_COMPRESSED,
+};
+
+void
+fd6_resource_screen_init(struct pipe_screen *pscreen)
+{
+ struct fd_screen *screen = fd_screen(pscreen);
- return setup_slices(rsc, alignment, rsc->base.format);
+ screen->setup_slices = fd6_setup_slices;
+ screen->layout_resource_for_modifier = fd6_layout_resource_for_modifier;
+ screen->supported_modifiers = supported_modifiers;
+ screen->num_supported_modifiers = ARRAY_SIZE(supported_modifiers);
}
projects / mesa.git / blobdiff