freedreno/a5xx: cargo-cult end-batch sequence more faithfully
[mesa.git] / src / gallium / drivers / freedreno / freedreno_gmem.c
index 2d4de442452ef88ea61f90876907560dd954d5af..d9f707d9c9a1f9bdafec9d8ef813ec07795b6610 100644 (file)
@@ -34,7 +34,9 @@
 
 #include "freedreno_gmem.h"
 #include "freedreno_context.h"
+#include "freedreno_fence.h"
 #include "freedreno_resource.h"
+#include "freedreno_query_hw.h"
 #include "freedreno_util.h"
 
 /*
  * resolve.
  */
 
-static uint32_t bin_width(struct fd_context *ctx)
+static uint32_t bin_width(struct fd_screen *screen)
 {
-       if (ctx->screen->gpu_id >= 300)
+       if (is_a4xx(screen) || is_a5xx(screen))
+               return 1024;
+       if (is_a3xx(screen))
                return 992;
        return 512;
 }
 
+static uint32_t
+total_size(uint8_t cbuf_cpp[], uint8_t zsbuf_cpp[2],
+                  uint32_t bin_w, uint32_t bin_h, struct fd_gmem_stateobj *gmem)
+{
+       uint32_t total = 0, i;
+
+       for (i = 0; i < MAX_RENDER_TARGETS; i++) {
+               if (cbuf_cpp[i]) {
+                       gmem->cbuf_base[i] = align(total, 0x4000);
+                       total = gmem->cbuf_base[i] + cbuf_cpp[i] * bin_w * bin_h;
+               }
+       }
+
+       if (zsbuf_cpp[0]) {
+               gmem->zsbuf_base[0] = align(total, 0x4000);
+               total = gmem->zsbuf_base[0] + zsbuf_cpp[0] * bin_w * bin_h;
+       }
+
+       if (zsbuf_cpp[1]) {
+               gmem->zsbuf_base[1] = align(total, 0x4000);
+               total = gmem->zsbuf_base[1] + zsbuf_cpp[1] * bin_w * bin_h;
+       }
+
+       return total;
+}
+
 static void
-calculate_tiles(struct fd_context *ctx)
+calculate_tiles(struct fd_batch *batch)
 {
+       struct fd_context *ctx = batch->ctx;
        struct fd_gmem_stateobj *gmem = &ctx->gmem;
-       struct pipe_scissor_state *scissor = &ctx->max_scissor;
-       struct pipe_framebuffer_state *pfb = &ctx->framebuffer;
-       uint32_t gmem_size = ctx->screen->gmemsize_bytes;
+       struct pipe_scissor_state *scissor = &batch->max_scissor;
+       struct pipe_framebuffer_state *pfb = &batch->framebuffer;
+       const uint32_t gmem_alignw = ctx->screen->gmem_alignw;
+       const uint32_t gmem_alignh = ctx->screen->gmem_alignh;
+       const uint32_t gmem_size = ctx->screen->gmemsize_bytes;
        uint32_t minx, miny, width, height;
        uint32_t nbins_x = 1, nbins_y = 1;
        uint32_t bin_w, bin_h;
-       uint32_t max_width = bin_width(ctx);
-       uint32_t cpp = 4;
+       uint32_t max_width = bin_width(ctx->screen);
+       uint8_t cbuf_cpp[MAX_RENDER_TARGETS] = {0}, zsbuf_cpp[2] = {0};
        uint32_t i, j, t, xoff, yoff;
        uint32_t tpp_x, tpp_y;
-       bool has_zs = !!(ctx->resolve & (FD_BUFFER_DEPTH | FD_BUFFER_STENCIL));
+       bool has_zs = !!(batch->resolve & (FD_BUFFER_DEPTH | FD_BUFFER_STENCIL));
+       int tile_n[ARRAY_SIZE(ctx->pipe)];
 
-       if (pfb->cbufs[0])
-               cpp = util_format_get_blocksize(pfb->cbufs[0]->format);
+       if (has_zs) {
+               struct fd_resource *rsc = fd_resource(pfb->zsbuf->texture);
+               zsbuf_cpp[0] = rsc->cpp;
+               if (rsc->stencil)
+                       zsbuf_cpp[1] = rsc->stencil->cpp;
+       }
+       for (i = 0; i < pfb->nr_cbufs; i++) {
+               if (pfb->cbufs[i])
+                       cbuf_cpp[i] = util_format_get_blocksize(pfb->cbufs[i]->format);
+               else
+                       cbuf_cpp[i] = 4;
+       }
 
-       if ((gmem->cpp == cpp) && (gmem->has_zs == has_zs) &&
-                       !memcmp(&gmem->scissor, scissor, sizeof(gmem->scissor))) {
+       if (!memcmp(gmem->zsbuf_cpp, zsbuf_cpp, sizeof(zsbuf_cpp)) &&
+               !memcmp(gmem->cbuf_cpp, cbuf_cpp, sizeof(cbuf_cpp)) &&
+               !memcmp(&gmem->scissor, scissor, sizeof(gmem->scissor))) {
                /* everything is up-to-date */
                return;
        }
 
-       /* if have depth/stencil, we need to leave room: */
-       if (has_zs) {
-               gmem_size /= 2;
-               max_width /= 2;
-       }
-
-       if (fd_mesa_debug & FD_DBG_DSCIS) {
+       if (fd_mesa_debug & FD_DBG_NOSCIS) {
                minx = 0;
                miny = 0;
                width = pfb->width;
                height = pfb->height;
        } else {
-               minx = scissor->minx & ~31; /* round down to multiple of 32 */
-               miny = scissor->miny & ~31;
+               /* round down to multiple of alignment: */
+               minx = scissor->minx & ~(gmem_alignw - 1);
+               miny = scissor->miny & ~(gmem_alignh - 1);
                width = scissor->maxx - minx;
                height = scissor->maxy - miny;
        }
 
-       bin_w = align(width, 32);
-       bin_h = align(height, 32);
+       bin_w = align(width, gmem_alignw);
+       bin_h = align(height, gmem_alignh);
 
        /* first, find a bin width that satisfies the maximum width
         * restrictions:
         */
        while (bin_w > max_width) {
                nbins_x++;
-               bin_w = align(width / nbins_x, 32);
+               bin_w = align(width / nbins_x, gmem_alignw);
        }
 
-       /* then find a bin height that satisfies the memory constraints:
+       if (fd_mesa_debug & FD_DBG_MSGS) {
+               debug_printf("binning input: cbuf cpp:");
+               for (i = 0; i < pfb->nr_cbufs; i++)
+                       debug_printf(" %d", cbuf_cpp[i]);
+               debug_printf(", zsbuf cpp: %d; %dx%d\n",
+                               zsbuf_cpp[0], width, height);
+       }
+
+       /* then find a bin width/height that satisfies the memory
+        * constraints:
         */
-       while ((bin_w * bin_h * cpp) > gmem_size) {
-               nbins_y++;
-               bin_h = align(height / nbins_y, 32);
+       while (total_size(cbuf_cpp, zsbuf_cpp, bin_w, bin_h, gmem) > gmem_size) {
+               if (bin_w > bin_h) {
+                       nbins_x++;
+                       bin_w = align(width / nbins_x, gmem_alignw);
+               } else {
+                       nbins_y++;
+                       bin_h = align(height / nbins_y, gmem_alignh);
+               }
        }
 
        DBG("using %d bins of size %dx%d", nbins_x*nbins_y, bin_w, bin_h);
 
        gmem->scissor = *scissor;
-       gmem->cpp = cpp;
-       gmem->has_zs = has_zs;
+       memcpy(gmem->cbuf_cpp, cbuf_cpp, sizeof(cbuf_cpp));
+       memcpy(gmem->zsbuf_cpp, zsbuf_cpp, sizeof(zsbuf_cpp));
        gmem->bin_h = bin_h;
        gmem->bin_w = bin_w;
        gmem->nbins_x = nbins_x;
@@ -204,6 +258,7 @@ calculate_tiles(struct fd_context *ctx)
        /* configure tiles: */
        t = 0;
        yoff = miny;
+       memset(tile_n, 0, sizeof(tile_n));
        for (i = 0; i < nbins_y; i++) {
                uint32_t bw, bh;
 
@@ -214,20 +269,17 @@ calculate_tiles(struct fd_context *ctx)
 
                for (j = 0; j < nbins_x; j++) {
                        struct fd_tile *tile = &ctx->tile[t];
-                       uint32_t n, p;
+                       uint32_t p;
 
                        assert(t < ARRAY_SIZE(ctx->tile));
 
                        /* pipe number: */
                        p = ((i / tpp_y) * div_round_up(nbins_x, tpp_x)) + (j / tpp_x);
 
-                       /* slot number: */
-                       n = ((i % tpp_y) * tpp_x) + (j % tpp_x);
-
                        /* clip bin width: */
                        bw = MIN2(bin_w, minx + width - xoff);
 
-                       tile->n = n;
+                       tile->n = tile_n[p]++;
                        tile->p = p;
                        tile->bin_w = bw;
                        tile->bin_h = bh;
@@ -255,14 +307,15 @@ calculate_tiles(struct fd_context *ctx)
 }
 
 static void
-render_tiles(struct fd_context *ctx)
+render_tiles(struct fd_batch *batch)
 {
+       struct fd_context *ctx = batch->ctx;
        struct fd_gmem_stateobj *gmem = &ctx->gmem;
        int i;
 
-       ctx->emit_tile_init(ctx);
+       ctx->emit_tile_init(batch);
 
-       if (ctx->restore)
+       if (batch->restore)
                ctx->stats.batch_restore++;
 
        for (i = 0; i < (gmem->nbins_x * gmem->nbins_y); i++) {
@@ -271,115 +324,158 @@ render_tiles(struct fd_context *ctx)
                DBG("bin_h=%d, yoff=%d, bin_w=%d, xoff=%d",
                        tile->bin_h, tile->yoff, tile->bin_w, tile->xoff);
 
-               ctx->emit_tile_prep(ctx, tile);
+               ctx->emit_tile_prep(batch, tile);
+
+               if (batch->restore) {
+                       ctx->emit_tile_mem2gmem(batch, tile);
+               }
 
-               if (ctx->restore)
-                       ctx->emit_tile_mem2gmem(ctx, tile);
+               ctx->emit_tile_renderprep(batch, tile);
 
-               ctx->emit_tile_renderprep(ctx, tile);
+               fd_hw_query_prepare_tile(batch, i, batch->gmem);
 
                /* emit IB to drawcmds: */
-               OUT_IB(ctx->ring, ctx->draw_start, ctx->draw_end);
-               fd_reset_wfi(ctx);
+               ctx->emit_ib(batch->gmem, batch->draw);
+               fd_reset_wfi(batch);
 
                /* emit gmem2mem to transfer tile back to system memory: */
-               ctx->emit_tile_gmem2mem(ctx, tile);
+               ctx->emit_tile_gmem2mem(batch, tile);
        }
+
+       if (ctx->emit_tile_fini)
+               ctx->emit_tile_fini(batch);
 }
 
 static void
-render_sysmem(struct fd_context *ctx)
+render_sysmem(struct fd_batch *batch)
 {
-       ctx->emit_sysmem_prep(ctx);
+       struct fd_context *ctx = batch->ctx;
+
+       ctx->emit_sysmem_prep(batch);
+
+       fd_hw_query_prepare_tile(batch, 0, batch->gmem);
 
        /* emit IB to drawcmds: */
-       OUT_IB(ctx->ring, ctx->draw_start, ctx->draw_end);
-       fd_reset_wfi(ctx);
+       ctx->emit_ib(batch->gmem, batch->draw);
+       fd_reset_wfi(batch);
+
+       if (ctx->emit_sysmem_fini)
+               ctx->emit_sysmem_fini(batch);
+}
+
+static void
+flush_ring(struct fd_batch *batch)
+{
+       struct fd_context *ctx = batch->ctx;
+       int out_fence_fd = -1;
+
+       fd_ringbuffer_flush2(batch->gmem, batch->in_fence_fd,
+                       batch->needs_out_fence_fd ? &out_fence_fd : NULL);
+
+       fd_fence_ref(&ctx->screen->base, &ctx->last_fence, NULL);
+       ctx->last_fence = fd_fence_create(ctx,
+                       fd_ringbuffer_timestamp(batch->gmem), out_fence_fd);
 }
 
 void
-fd_gmem_render_tiles(struct pipe_context *pctx)
+fd_gmem_render_tiles(struct fd_batch *batch)
 {
-       struct fd_context *ctx = fd_context(pctx);
-       struct pipe_framebuffer_state *pfb = &ctx->framebuffer;
-       uint32_t timestamp = 0;
+       struct fd_context *ctx = batch->ctx;
+       struct pipe_framebuffer_state *pfb = &batch->framebuffer;
        bool sysmem = false;
 
        if (ctx->emit_sysmem_prep) {
-               if (ctx->cleared || ctx->gmem_reason || (ctx->num_draws > 5)) {
+               if (batch->cleared || batch->gmem_reason || (batch->num_draws > 5)) {
                        DBG("GMEM: cleared=%x, gmem_reason=%x, num_draws=%u",
-                               ctx->cleared, ctx->gmem_reason, ctx->num_draws);
-               } else if (!(fd_mesa_debug & FD_DBG_DBYPASS)) {
+                               batch->cleared, batch->gmem_reason, batch->num_draws);
+               } else if (!(fd_mesa_debug & FD_DBG_NOBYPASS)) {
                        sysmem = true;
                }
        }
 
-       /* mark the end of the clear/draw cmds before emitting per-tile cmds: */
-       fd_ringmarker_mark(ctx->draw_end);
-       fd_ringmarker_mark(ctx->binning_end);
-
-       fd_reset_wfi(ctx);
+       fd_reset_wfi(batch);
 
        ctx->stats.batch_total++;
 
        if (sysmem) {
-               DBG("rendering sysmem (%s/%s)",
+               DBG("%p: rendering sysmem %ux%u (%s/%s)",
+                       batch, pfb->width, pfb->height,
                        util_format_short_name(pipe_surface_format(pfb->cbufs[0])),
                        util_format_short_name(pipe_surface_format(pfb->zsbuf)));
-               render_sysmem(ctx);
+               fd_hw_query_prepare(batch, 1);
+               render_sysmem(batch);
                ctx->stats.batch_sysmem++;
        } else {
                struct fd_gmem_stateobj *gmem = &ctx->gmem;
-               calculate_tiles(ctx);
-               DBG("rendering %dx%d tiles (%s/%s)", gmem->nbins_x, gmem->nbins_y,
+               calculate_tiles(batch);
+               DBG("%p: rendering %dx%d tiles %ux%u (%s/%s)",
+                       batch, pfb->width, pfb->height, gmem->nbins_x, gmem->nbins_y,
                        util_format_short_name(pipe_surface_format(pfb->cbufs[0])),
                        util_format_short_name(pipe_surface_format(pfb->zsbuf)));
-               render_tiles(ctx);
+               fd_hw_query_prepare(batch, gmem->nbins_x * gmem->nbins_y);
+               render_tiles(batch);
                ctx->stats.batch_gmem++;
        }
 
-       /* GPU executes starting from tile cmds, which IB back to draw cmds: */
-       fd_ringmarker_flush(ctx->draw_end);
+       flush_ring(batch);
+}
 
-       /* mark start for next draw/binning cmds: */
-       fd_ringmarker_mark(ctx->draw_start);
-       fd_ringmarker_mark(ctx->binning_start);
+/* special case for when we need to create a fence but have no rendering
+ * to flush.. just emit a no-op string-marker packet.
+ */
+void
+fd_gmem_render_noop(struct fd_batch *batch)
+{
+       struct fd_context *ctx = batch->ctx;
+       struct pipe_context *pctx = &ctx->base;
 
-       fd_reset_wfi(ctx);
+       pctx->emit_string_marker(pctx, "noop", 4);
+       /* emit IB to drawcmds (which contain the string marker): */
+       ctx->emit_ib(batch->gmem, batch->draw);
+       flush_ring(batch);
+}
 
-       /* update timestamps on render targets: */
-       timestamp = fd_ringbuffer_timestamp(ctx->ring);
-       if (pfb->cbufs[0])
-               fd_resource(pfb->cbufs[0]->texture)->timestamp = timestamp;
-       if (pfb->zsbuf)
-               fd_resource(pfb->zsbuf->texture)->timestamp = timestamp;
+/* tile needs restore if it isn't completely contained within the
+ * cleared scissor:
+ */
+static bool
+skip_restore(struct pipe_scissor_state *scissor, struct fd_tile *tile)
+{
+       unsigned minx = tile->xoff;
+       unsigned maxx = tile->xoff + tile->bin_w;
+       unsigned miny = tile->yoff;
+       unsigned maxy = tile->yoff + tile->bin_h;
+       return (minx >= scissor->minx) && (maxx <= scissor->maxx) &&
+                       (miny >= scissor->miny) && (maxy <= scissor->maxy);
+}
 
-       /* reset maximal bounds: */
-       ctx->max_scissor.minx = ctx->max_scissor.miny = ~0;
-       ctx->max_scissor.maxx = ctx->max_scissor.maxy = 0;
+/* When deciding whether a tile needs mem2gmem, we need to take into
+ * account the scissor rect(s) that were cleared.  To simplify we only
+ * consider the last scissor rect for each buffer, since the common
+ * case would be a single clear.
+ */
+bool
+fd_gmem_needs_restore(struct fd_batch *batch, struct fd_tile *tile,
+               uint32_t buffers)
+{
+       if (!(batch->restore & buffers))
+               return false;
 
-       /* Note that because the per-tile setup and mem2gmem/gmem2mem are emitted
-        * after the draw/clear calls, but executed before, we need to preemptively
-        * flag some state as dirty before the first draw/clear call.
-        *
-        * TODO maybe we need to mark all state as dirty to not worry about state
-        * being clobbered by other contexts?
+       /* if buffers partially cleared, then slow-path to figure out
+        * if this particular tile needs restoring:
         */
-       ctx->dirty |= FD_DIRTY_ZSA |
-                       FD_DIRTY_RASTERIZER |
-                       FD_DIRTY_FRAMEBUFFER |
-                       FD_DIRTY_SAMPLE_MASK |
-                       FD_DIRTY_VIEWPORT |
-                       FD_DIRTY_CONSTBUF |
-                       FD_DIRTY_PROG |
-                       FD_DIRTY_SCISSOR |
-                       /* probably only needed if we need to mem2gmem on the next
-                        * draw..  but not sure if there is a good way to know?
-                        */
-                       FD_DIRTY_VERTTEX |
-                       FD_DIRTY_FRAGTEX |
-                       FD_DIRTY_BLEND;
-
-       if (fd_mesa_debug & FD_DBG_DGMEM)
-               ctx->dirty = 0xffffffff;
+       if ((buffers & FD_BUFFER_COLOR) &&
+                       (batch->partial_cleared & FD_BUFFER_COLOR) &&
+                       skip_restore(&batch->cleared_scissor.color, tile))
+               return false;
+       if ((buffers & FD_BUFFER_DEPTH) &&
+                       (batch->partial_cleared & FD_BUFFER_DEPTH) &&
+                       skip_restore(&batch->cleared_scissor.depth, tile))
+               return false;
+       if ((buffers & FD_BUFFER_STENCIL) &&
+                       (batch->partial_cleared & FD_BUFFER_STENCIL) &&
+                       skip_restore(&batch->cleared_scissor.stencil, tile))
+               return false;
+
+       return true;
 }