freedreno/a4xx: better workaround for astc+srgb
[mesa.git] / src / gallium / drivers / freedreno / ir3 / ir3_shader.c
index 312174c0c6dbf70afe9131768a963629102eeb55..435a565e61ec1b8e9019084cc07dfcbb8bb94cad 100644 (file)
@@ -39,7 +39,7 @@
 
 #include "ir3_shader.h"
 #include "ir3_compiler.h"
-
+#include "ir3_nir.h"
 
 static void
 delete_variant(struct ir3_shader_variant *v)
@@ -127,14 +127,14 @@ void * ir3_shader_assemble(struct ir3_shader_variant *v, uint32_t gpu_id)
 static void
 assemble_variant(struct ir3_shader_variant *v)
 {
-       struct fd_context *ctx = fd_context(v->shader->pctx);
-       uint32_t gpu_id = v->shader->compiler->gpu_id;
+       struct ir3_compiler *compiler = v->shader->compiler;
+       uint32_t gpu_id = compiler->gpu_id;
        uint32_t sz, *bin;
 
        bin = ir3_shader_assemble(v, gpu_id);
        sz = v->info.sizedwords * 4;
 
-       v->bo = fd_bo_new(ctx->dev, sz,
+       v->bo = fd_bo_new(compiler->dev, sz,
                        DRM_FREEDRENO_GEM_CACHE_WCOMBINE |
                        DRM_FREEDRENO_GEM_TYPE_KMEM);
 
@@ -187,12 +187,6 @@ create_variant(struct ir3_shader *shader, struct ir3_shader_key key)
        v->key = key;
        v->type = shader->type;
 
-       if (fd_mesa_debug & FD_DBG_DISASM) {
-               DBG("dump tgsi: type=%d, k={bp=%u,cts=%u,hp=%u}", shader->type,
-                       key.binning_pass, key.color_two_side, key.half_precision);
-               tgsi_dump(shader->tokens, 0);
-       }
-
        ret = ir3_compile_shader_nir(shader->compiler, v);
        if (ret) {
                debug_error("compile failed!");
@@ -229,6 +223,7 @@ ir3_shader_variant(struct ir3_shader *shader, struct ir3_shader_key key)
                        key.vsaturate_s = 0;
                        key.vsaturate_t = 0;
                        key.vsaturate_r = 0;
+                       key.vastc_srgb = 0;
                }
                break;
        case SHADER_VERTEX:
@@ -239,6 +234,7 @@ ir3_shader_variant(struct ir3_shader *shader, struct ir3_shader_key key)
                        key.fsaturate_s = 0;
                        key.fsaturate_t = 0;
                        key.fsaturate_r = 0;
+                       key.fastc_srgb = 0;
                }
                break;
        }
@@ -267,28 +263,37 @@ ir3_shader_destroy(struct ir3_shader *shader)
                v = v->next;
                delete_variant(t);
        }
-       free((void *)shader->tokens);
+       ralloc_free(shader->nir);
        free(shader);
 }
 
 struct ir3_shader *
-ir3_shader_create(struct pipe_context *pctx,
+ir3_shader_create(struct ir3_compiler *compiler,
                const struct pipe_shader_state *cso,
                enum shader_t type)
 {
        struct ir3_shader *shader = CALLOC_STRUCT(ir3_shader);
-       shader->compiler = fd_context(pctx)->screen->compiler;
+       shader->compiler = compiler;
        shader->id = ++shader->compiler->shader_count;
-       shader->pctx = pctx;
        shader->type = type;
-       shader->tokens = tgsi_dup_tokens(cso->tokens);
+       if (fd_mesa_debug & FD_DBG_DISASM) {
+               DBG("dump tgsi: type=%d", shader->type);
+               tgsi_dump(cso->tokens, 0);
+       }
+       nir_shader *nir = ir3_tgsi_to_nir(cso->tokens);
+       /* do first pass optimization, ignoring the key: */
+       shader->nir = ir3_optimize_nir(shader, nir, NULL);
+       if (fd_mesa_debug & FD_DBG_DISASM) {
+               DBG("dump nir%d: type=%d", shader->id, shader->type);
+               nir_print_shader(shader->nir, stdout);
+       }
        shader->stream_output = cso->stream_output;
        if (fd_mesa_debug & FD_DBG_SHADERDB) {
                /* if shader-db run, create a standard variant immediately
                 * (as otherwise nothing will trigger the shader to be
                 * actually compiled)
                 */
-               static struct ir3_shader_key key = {};
+               static struct ir3_shader_key key = {0};
                ir3_shader_variant(shader, key);
        }
        return shader;
@@ -300,11 +305,11 @@ static void dump_reg(const char *name, uint32_t r)
                debug_printf("; %s: r%d.%c\n", name, r >> 2, "xyzw"[r & 0x3]);
 }
 
-static void dump_semantic(struct ir3_shader_variant *so,
-               unsigned sem, const char *name)
+static void dump_output(struct ir3_shader_variant *so,
+               unsigned slot, const char *name)
 {
        uint32_t regid;
-       regid = ir3_find_output_regid(so, ir3_semantic_name(sem, 0));
+       regid = ir3_find_output_regid(so, slot);
        dump_reg(name, regid);
 }
 
@@ -355,27 +360,51 @@ ir3_shader_disasm(struct ir3_shader_variant *so, uint32_t *bin)
 
        disasm_a3xx(bin, so->info.sizedwords, 0, so->type);
 
-       debug_printf("; %s: outputs:", type);
-       for (i = 0; i < so->outputs_count; i++) {
-               uint8_t regid = so->outputs[i].regid;
-               ir3_semantic sem = so->outputs[i].semantic;
-               debug_printf(" r%d.%c (%u:%u)",
-                               (regid >> 2), "xyzw"[regid & 0x3],
-                               sem2name(sem), sem2idx(sem));
-       }
-       debug_printf("\n");
-       debug_printf("; %s: inputs:", type);
-       for (i = 0; i < so->inputs_count; i++) {
-               uint8_t regid = so->inputs[i].regid;
-               ir3_semantic sem = so->inputs[i].semantic;
-               debug_printf(" r%d.%c (%u:%u,cm=%x,il=%u,b=%u)",
-                               (regid >> 2), "xyzw"[regid & 0x3],
-                               sem2name(sem), sem2idx(sem),
-                               so->inputs[i].compmask,
-                               so->inputs[i].inloc,
-                               so->inputs[i].bary);
+       switch (so->type) {
+       case SHADER_VERTEX:
+               debug_printf("; %s: outputs:", type);
+               for (i = 0; i < so->outputs_count; i++) {
+                       uint8_t regid = so->outputs[i].regid;
+                       debug_printf(" r%d.%c (%s)",
+                                       (regid >> 2), "xyzw"[regid & 0x3],
+                                       gl_varying_slot_name(so->outputs[i].slot));
+               }
+               debug_printf("\n");
+               debug_printf("; %s: inputs:", type);
+               for (i = 0; i < so->inputs_count; i++) {
+                       uint8_t regid = so->inputs[i].regid;
+                       debug_printf(" r%d.%c (cm=%x,il=%u,b=%u)",
+                                       (regid >> 2), "xyzw"[regid & 0x3],
+                                       so->inputs[i].compmask,
+                                       so->inputs[i].inloc,
+                                       so->inputs[i].bary);
+               }
+               debug_printf("\n");
+               break;
+       case SHADER_FRAGMENT:
+               debug_printf("; %s: outputs:", type);
+               for (i = 0; i < so->outputs_count; i++) {
+                       uint8_t regid = so->outputs[i].regid;
+                       debug_printf(" r%d.%c (%s)",
+                                       (regid >> 2), "xyzw"[regid & 0x3],
+                                       gl_frag_result_name(so->outputs[i].slot));
+               }
+               debug_printf("\n");
+               debug_printf("; %s: inputs:", type);
+               for (i = 0; i < so->inputs_count; i++) {
+                       uint8_t regid = so->inputs[i].regid;
+                       debug_printf(" r%d.%c (%s,cm=%x,il=%u,b=%u)",
+                                       (regid >> 2), "xyzw"[regid & 0x3],
+                                       gl_varying_slot_name(so->inputs[i].slot),
+                                       so->inputs[i].compmask,
+                                       so->inputs[i].inloc,
+                                       so->inputs[i].bary);
+               }
+               debug_printf("\n");
+               break;
+       case SHADER_COMPUTE:
+               break;
        }
-       debug_printf("\n");
 
        /* print generic shader info: */
        debug_printf("; %s prog %d/%d: %u instructions, %d half, %d full\n",
@@ -391,13 +420,24 @@ ir3_shader_disasm(struct ir3_shader_variant *so, uint32_t *bin)
        /* print shader type specific info: */
        switch (so->type) {
        case SHADER_VERTEX:
-               dump_semantic(so, TGSI_SEMANTIC_POSITION, "pos");
-               dump_semantic(so, TGSI_SEMANTIC_PSIZE, "psize");
+               dump_output(so, VARYING_SLOT_POS, "pos");
+               dump_output(so, VARYING_SLOT_PSIZ, "psize");
                break;
        case SHADER_FRAGMENT:
                dump_reg("pos (bary)", so->pos_regid);
-               dump_semantic(so, TGSI_SEMANTIC_POSITION, "posz");
-               dump_semantic(so, TGSI_SEMANTIC_COLOR, "color");
+               dump_output(so, FRAG_RESULT_DEPTH, "posz");
+               if (so->color0_mrt) {
+                       dump_output(so, FRAG_RESULT_COLOR, "color");
+               } else {
+                       dump_output(so, FRAG_RESULT_DATA0, "data0");
+                       dump_output(so, FRAG_RESULT_DATA1, "data1");
+                       dump_output(so, FRAG_RESULT_DATA2, "data2");
+                       dump_output(so, FRAG_RESULT_DATA3, "data3");
+                       dump_output(so, FRAG_RESULT_DATA4, "data4");
+                       dump_output(so, FRAG_RESULT_DATA5, "data5");
+                       dump_output(so, FRAG_RESULT_DATA6, "data6");
+                       dump_output(so, FRAG_RESULT_DATA7, "data7");
+               }
                /* these two are hard-coded since we don't know how to
                 * program them to anything but all 0's...
                 */
@@ -424,10 +464,9 @@ ir3_shader_disasm(struct ir3_shader_variant *so, uint32_t *bin)
 #include "freedreno_resource.h"
 
 static void
-emit_user_consts(struct ir3_shader_variant *v, struct fd_ringbuffer *ring,
-               struct fd_constbuf_stateobj *constbuf)
+emit_user_consts(struct fd_context *ctx, const struct ir3_shader_variant *v,
+               struct fd_ringbuffer *ring, struct fd_constbuf_stateobj *constbuf)
 {
-       struct fd_context *ctx = fd_context(v->shader->pctx);
        const unsigned index = 0;     /* user consts are index 0 */
        /* TODO save/restore dirty_mask for binning pass instead: */
        uint32_t dirty_mask = constbuf->enabled_mask;
@@ -463,12 +502,11 @@ emit_user_consts(struct ir3_shader_variant *v, struct fd_ringbuffer *ring,
 }
 
 static void
-emit_ubos(struct ir3_shader_variant *v, struct fd_ringbuffer *ring,
-               struct fd_constbuf_stateobj *constbuf)
+emit_ubos(struct fd_context *ctx, const struct ir3_shader_variant *v,
+               struct fd_ringbuffer *ring, struct fd_constbuf_stateobj *constbuf)
 {
-       uint32_t offset = v->first_driver_param;  /* UBOs after user consts */
+       uint32_t offset = v->first_driver_param + IR3_UBOS_OFF;
        if (v->constlen > offset) {
-               struct fd_context *ctx = fd_context(v->shader->pctx);
                uint32_t params = MIN2(4, v->constlen - offset) * 4;
                uint32_t offsets[params];
                struct fd_bo *bos[params];
@@ -493,9 +531,9 @@ emit_ubos(struct ir3_shader_variant *v, struct fd_ringbuffer *ring,
 }
 
 static void
-emit_immediates(struct ir3_shader_variant *v, struct fd_ringbuffer *ring)
+emit_immediates(struct fd_context *ctx, const struct ir3_shader_variant *v,
+               struct fd_ringbuffer *ring)
 {
-       struct fd_context *ctx = fd_context(v->shader->pctx);
        int size = v->immediates_count;
        uint32_t base = v->first_immediate;
 
@@ -517,11 +555,12 @@ emit_immediates(struct ir3_shader_variant *v, struct fd_ringbuffer *ring)
 
 /* emit stream-out buffers: */
 static void
-emit_tfbos(struct ir3_shader_variant *v, struct fd_ringbuffer *ring)
+emit_tfbos(struct fd_context *ctx, const struct ir3_shader_variant *v,
+               struct fd_ringbuffer *ring)
 {
-       uint32_t offset = v->first_driver_param + 5;  /* streamout addresses after driver-params*/
+       /* streamout addresses after driver-params: */
+       uint32_t offset = v->first_driver_param + IR3_TFBOS_OFF;
        if (v->constlen > offset) {
-               struct fd_context *ctx = fd_context(v->shader->pctx);
                struct fd_streamout_stateobj *so = &ctx->streamout;
                struct pipe_stream_output_info *info = &v->shader->stream_output;
                uint32_t params = 4;
@@ -547,9 +586,8 @@ emit_tfbos(struct ir3_shader_variant *v, struct fd_ringbuffer *ring)
 }
 
 static uint32_t
-max_tf_vtx(struct ir3_shader_variant *v)
+max_tf_vtx(struct fd_context *ctx, const struct ir3_shader_variant *v)
 {
-       struct fd_context *ctx = fd_context(v->shader->pctx);
        struct fd_streamout_stateobj *so = &ctx->streamout;
        struct pipe_stream_output_info *info = &v->shader->stream_output;
        uint32_t maxvtxcnt = 0x7fffffff;
@@ -593,11 +631,9 @@ max_tf_vtx(struct ir3_shader_variant *v)
 }
 
 void
-ir3_emit_consts(struct ir3_shader_variant *v, struct fd_ringbuffer *ring,
-               const struct pipe_draw_info *info, uint32_t dirty)
+ir3_emit_consts(const struct ir3_shader_variant *v, struct fd_ringbuffer *ring,
+               struct fd_context *ctx, const struct pipe_draw_info *info, uint32_t dirty)
 {
-       struct fd_context *ctx = fd_context(v->shader->pctx);
-
        if (dirty & (FD_DIRTY_PROG | FD_DIRTY_CONSTBUF)) {
                struct fd_constbuf_stateobj *constbuf;
                bool shader_dirty;
@@ -613,30 +649,46 @@ ir3_emit_consts(struct ir3_shader_variant *v, struct fd_ringbuffer *ring,
                        return;
                }
 
-               emit_user_consts(v, ring, constbuf);
-               emit_ubos(v, ring, constbuf);
+               emit_user_consts(ctx, v, ring, constbuf);
+               emit_ubos(ctx, v, ring, constbuf);
                if (shader_dirty)
-                       emit_immediates(v, ring);
+                       emit_immediates(ctx, v, ring);
        }
 
        /* emit driver params every time: */
        /* TODO skip emit if shader doesn't use driver params to avoid WFI.. */
        if (info && (v->type == SHADER_VERTEX)) {
-               uint32_t offset = v->first_driver_param + 4;  /* driver params after UBOs */
+               uint32_t offset = v->first_driver_param + IR3_DRIVER_PARAM_OFF;
                if (v->constlen >= offset) {
-                       uint32_t vertex_params[4] = {
+                       uint32_t vertex_params[IR3_DP_COUNT] = {
                                [IR3_DP_VTXID_BASE] = info->indexed ?
                                                info->index_bias : info->start,
-                               [IR3_DP_VTXCNT_MAX] = max_tf_vtx(v),
+                               [IR3_DP_VTXCNT_MAX] = max_tf_vtx(ctx, v),
                        };
+                       /* if no user-clip-planes, we don't need to emit the
+                        * entire thing:
+                        */
+                       uint32_t vertex_params_size = 4;
+
+                       if (v->key.ucp_enables) {
+                               struct pipe_clip_state *ucp = &ctx->ucp;
+                               unsigned pos = IR3_DP_UCP0_X;
+                               for (unsigned i = 0; pos <= IR3_DP_UCP7_W; i++) {
+                                       for (unsigned j = 0; j < 4; j++) {
+                                               vertex_params[pos] = fui(ucp->ucp[i][j]);
+                                               pos++;
+                                       }
+                               }
+                               vertex_params_size = ARRAY_SIZE(vertex_params);
+                       }
 
                        fd_wfi(ctx, ring);
                        ctx->emit_const(ring, SHADER_VERTEX, offset * 4, 0,
-                                       ARRAY_SIZE(vertex_params), vertex_params, NULL);
+                                       vertex_params_size, vertex_params, NULL);
 
                        /* if needed, emit stream-out buffer addresses: */
                        if (vertex_params[IR3_DP_VTXCNT_MAX] > 0) {
-                               emit_tfbos(v, ring);
+                               emit_tfbos(ctx, v, ring);
                        }
                }
        }