iris: consider framebuffer parameter for aux usages
[mesa.git] / src / gallium / drivers / iris / iris_resource.c
index 3934f82350498997184f95b82e45f9340be25a0d..746de83f057fd207a2cd4fb20688dca30afba4b4 100644 (file)
@@ -4,30 +4,42 @@
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
  * to deal in the Software without restriction, including without limitation
- * on the rights to use, copy, modify, merge, publish, distribute, sub
- * license, and/or sell copies of the Software, and to permit persons to whom
- * the Software is furnished to do so, subject to the following conditions:
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
  *
- * The above copyright notice and this permission notice (including the next
- * paragraph) shall be included in all copies or substantial portions of the
- * Software.
+ * The above copyright notice and this permission notice shall be included
+ * in all copies or substantial portions of the Software.
  *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL
- * THE AUTHOR(S) AND/OR THEIR SUPPLIERS BE LIABLE FOR ANY CLAIM,
- * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
- * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
- * USE OR OTHER DEALINGS IN THE SOFTWARE.
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+ * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
  */
+
+/**
+ * @file iris_resource.c
+ *
+ * Resources are images, buffers, and other objects used by the GPU.
+ *
+ * XXX: explain resources
+ */
+
 #include <stdio.h>
 #include <errno.h>
 #include "pipe/p_defines.h"
 #include "pipe/p_state.h"
 #include "pipe/p_context.h"
 #include "pipe/p_screen.h"
+#include "util/os_memory.h"
+#include "util/u_cpu_detect.h"
 #include "util/u_inlines.h"
 #include "util/u_format.h"
+#include "util/u_transfer.h"
+#include "util/u_transfer_helper.h"
 #include "util/u_upload_mgr.h"
 #include "util/ralloc.h"
 #include "iris_batch.h"
@@ -35,6 +47,7 @@
 #include "iris_resource.h"
 #include "iris_screen.h"
 #include "intel/common/gen_debug.h"
+#include "isl/isl.h"
 #include "drm-uapi/drm_fourcc.h"
 #include "drm-uapi/i915_drm.h"
 
@@ -131,58 +144,83 @@ pipe_bind_to_isl_usage(unsigned bindings)
 {
    isl_surf_usage_flags_t usage = 0;
 
-   if (bindings & PIPE_BIND_DEPTH_STENCIL)
-      usage |= ISL_SURF_USAGE_DEPTH_BIT | ISL_SURF_USAGE_STENCIL_BIT;
-
    if (bindings & PIPE_BIND_RENDER_TARGET)
       usage |= ISL_SURF_USAGE_RENDER_TARGET_BIT;
 
-   if (bindings & PIPE_BIND_SHADER_IMAGE)
+   if (bindings & PIPE_BIND_SAMPLER_VIEW)
+      usage |= ISL_SURF_USAGE_TEXTURE_BIT;
+
+   if (bindings & (PIPE_BIND_SHADER_IMAGE | PIPE_BIND_SHADER_BUFFER))
       usage |= ISL_SURF_USAGE_STORAGE_BIT;
 
    if (bindings & PIPE_BIND_DISPLAY_TARGET)
       usage |= ISL_SURF_USAGE_DISPLAY_BIT;
 
-   /* XXX: what to do with these? */
-   if (bindings & PIPE_BIND_BLENDABLE)
-      ;
-   if (bindings & PIPE_BIND_SAMPLER_VIEW)
-      ;
-   if (bindings & PIPE_BIND_VERTEX_BUFFER)
-      ;
-   if (bindings & PIPE_BIND_INDEX_BUFFER)
-      ;
-   if (bindings & PIPE_BIND_CONSTANT_BUFFER)
-      ;
-
-   if (bindings & PIPE_BIND_STREAM_OUTPUT)
-      ;
-   if (bindings & PIPE_BIND_CURSOR)
-      ;
-   if (bindings & PIPE_BIND_CUSTOM)
-      ;
-
-   if (bindings & PIPE_BIND_GLOBAL)
-      ;
-   if (bindings & PIPE_BIND_SHADER_BUFFER)
-      ;
-   if (bindings & PIPE_BIND_COMPUTE_RESOURCE)
-      ;
-   if (bindings & PIPE_BIND_COMMAND_ARGS_BUFFER)
-      ;
-   if (bindings & PIPE_BIND_QUERY_BUFFER)
-      ;
-
    return usage;
 }
 
+struct pipe_resource *
+iris_resource_get_separate_stencil(struct pipe_resource *p_res)
+{
+   /* For packed depth-stencil, we treat depth as the primary resource
+    * and store S8 as the "second plane" resource.
+    */
+   return p_res->next;
+}
+
+static void
+iris_resource_set_separate_stencil(struct pipe_resource *p_res,
+                                   struct pipe_resource *stencil)
+{
+   assert(util_format_has_depth(util_format_description(p_res->format)));
+   pipe_resource_reference(&p_res->next, stencil);
+}
+
+void
+iris_get_depth_stencil_resources(struct pipe_resource *res,
+                                 struct iris_resource **out_z,
+                                 struct iris_resource **out_s)
+{
+   if (!res) {
+      *out_z = NULL;
+      *out_s = NULL;
+      return;
+   }
+
+   if (res->format != PIPE_FORMAT_S8_UINT) {
+      *out_z = (void *) res;
+      *out_s = (void *) iris_resource_get_separate_stencil(res);
+   } else {
+      *out_z = NULL;
+      *out_s = (void *) res;
+   }
+}
+
+void
+iris_resource_disable_aux(struct iris_resource *res)
+{
+   iris_bo_unreference(res->aux.bo);
+   free(res->aux.state);
+
+   // XXX: clear color BO
+   // XXX: HiZ
+
+   res->aux.usage = ISL_AUX_USAGE_NONE;
+   res->aux.surf.size_B = 0;
+   res->aux.bo = NULL;
+   res->aux.state = NULL;
+}
+
 static void
 iris_resource_destroy(struct pipe_screen *screen,
                       struct pipe_resource *resource)
 {
    struct iris_resource *res = (struct iris_resource *)resource;
 
+   iris_resource_disable_aux(res);
+
    iris_bo_unreference(res->bo);
+   free(res);
 }
 
 static struct iris_resource *
@@ -197,64 +235,208 @@ iris_alloc_resource(struct pipe_screen *pscreen,
    res->base.screen = pscreen;
    pipe_reference_init(&res->base.reference, 1);
 
+   res->aux.possible_usages = 1 << ISL_AUX_USAGE_NONE;
+
    return res;
 }
 
-static struct pipe_resource *
-iris_resource_create_with_modifiers(struct pipe_screen *pscreen,
-                                    const struct pipe_resource *templ,
-                                    const uint64_t *modifiers,
-                                    int modifiers_count)
+unsigned
+iris_get_num_logical_layers(const struct iris_resource *res, unsigned level)
 {
-   struct iris_screen *screen = (struct iris_screen *)pscreen;
-   struct gen_device_info *devinfo = &screen->devinfo;
-   struct iris_resource *res = iris_alloc_resource(pscreen, templ);
-   if (!res)
+   if (res->surf.dim == ISL_SURF_DIM_3D)
+      return minify(res->surf.logical_level0_px.depth, level);
+   else
+      return res->surf.logical_level0_px.array_len;
+}
+
+static enum isl_aux_state **
+create_aux_state_map(struct iris_resource *res, enum isl_aux_state initial)
+{
+   uint32_t total_slices = 0;
+   for (uint32_t level = 0; level < res->surf.levels; level++)
+      total_slices += iris_get_num_logical_layers(res, level);
+
+   const size_t per_level_array_size =
+      res->surf.levels * sizeof(enum isl_aux_state *);
+
+   /* We're going to allocate a single chunk of data for both the per-level
+    * reference array and the arrays of aux_state.  This makes cleanup
+    * significantly easier.
+    */
+   const size_t total_size =
+      per_level_array_size + total_slices * sizeof(enum isl_aux_state);
+
+   void *data = malloc(total_size);
+   if (!data)
       return NULL;
 
-   uint64_t modifier = DRM_FORMAT_MOD_INVALID;
+   enum isl_aux_state **per_level_arr = data;
+   enum isl_aux_state *s = data + per_level_array_size;
+   for (uint32_t level = 0; level < res->surf.levels; level++) {
+      per_level_arr[level] = s;
+      const unsigned level_layers = iris_get_num_logical_layers(res, level);
+      for (uint32_t a = 0; a < level_layers; a++)
+         *(s++) = initial;
+   }
+   assert((void *)s == data + total_size);
+
+   return per_level_arr;
+}
 
-   if (modifiers_count == 0) {
-      /* Display is X-tiled for historical reasons. */
-      modifier = (templ->bind & PIPE_BIND_DISPLAY_TARGET) ?
-                 I915_FORMAT_MOD_X_TILED : I915_FORMAT_MOD_Y_TILED;
-      /* XXX: make sure this doesn't do stupid things for internal textures */
+/**
+ * Allocate the initial aux surface for a resource based on aux.usage
+ */
+static bool
+iris_resource_alloc_aux(struct iris_screen *screen, struct iris_resource *res)
+{
+   struct isl_device *isl_dev = &screen->isl_dev;
+   enum isl_aux_state initial_state;
+   UNUSED bool ok = false;
+   uint8_t memset_value = 0;
+   uint32_t alloc_flags = 0;
+
+   assert(!res->aux.bo);
+
+   switch (res->aux.usage) {
+   case ISL_AUX_USAGE_NONE:
+      res->aux.surf.size_B = 0;
+      break;
+   case ISL_AUX_USAGE_HIZ:
+      initial_state = ISL_AUX_STATE_AUX_INVALID;
+      memset_value = 0;
+      ok = isl_surf_get_hiz_surf(isl_dev, &res->surf, &res->aux.surf);
+      break;
+   case ISL_AUX_USAGE_MCS:
+      /* The Ivybridge PRM, Vol 2 Part 1 p326 says:
+       *
+       *    "When MCS buffer is enabled and bound to MSRT, it is required
+       *     that it is cleared prior to any rendering."
+       *
+       * Since we only use the MCS buffer for rendering, we just clear it
+       * immediately on allocation.  The clear value for MCS buffers is all
+       * 1's, so we simply memset it to 0xff.
+       */
+      initial_state = ISL_AUX_STATE_CLEAR;
+      memset_value = 0xFF;
+      ok = isl_surf_get_mcs_surf(isl_dev, &res->surf, &res->aux.surf);
+      break;
+   case ISL_AUX_USAGE_CCS_D:
+   case ISL_AUX_USAGE_CCS_E:
+      /* When CCS_E is used, we need to ensure that the CCS starts off in
+       * a valid state.  From the Sky Lake PRM, "MCS Buffer for Render
+       * Target(s)":
+       *
+       *    "If Software wants to enable Color Compression without Fast
+       *     clear, Software needs to initialize MCS with zeros."
+       *
+       * A CCS value of 0 indicates that the corresponding block is in the
+       * pass-through state which is what we want.
+       *
+       * For CCS_D, do the same thing.  On Gen9+, this avoids having any
+       * undefined bits in the aux buffer.
+       */
+      initial_state = ISL_AUX_STATE_PASS_THROUGH;
+      alloc_flags |= BO_ALLOC_ZEROED;
+      ok = isl_surf_get_ccs_surf(isl_dev, &res->surf, &res->aux.surf, 0);
+      break;
    }
 
-   if (templ->target == PIPE_BUFFER)
-      modifier = DRM_FORMAT_MOD_LINEAR;
+   /* No work is needed for a zero-sized auxiliary buffer. */
+   if (res->aux.surf.size_B == 0)
+      return true;
 
-   if (templ->bind & (PIPE_BIND_LINEAR | PIPE_BIND_CURSOR))
-      modifier = DRM_FORMAT_MOD_LINEAR;
+   /* Assert that ISL gave us a valid aux surf */
+   assert(ok);
 
-   if (modifier == DRM_FORMAT_MOD_INVALID) {
-      /* User requested specific modifiers */
-      modifier = select_best_modifier(devinfo, modifiers, modifiers_count);
-      if (modifier == DRM_FORMAT_MOD_INVALID)
-         return NULL;
+   /* Create the aux_state for the auxiliary buffer. */
+   res->aux.state = create_aux_state_map(res, initial_state);
+   if (!res->aux.state)
+      return false;
+
+   /* Allocate the auxiliary buffer.  ISL has stricter set of alignment rules
+    * the drm allocator.  Therefore, one can pass the ISL dimensions in terms
+    * of bytes instead of trying to recalculate based on different format
+    * block sizes.
+    */
+   res->aux.bo = iris_bo_alloc_tiled(screen->bufmgr, "aux buffer",
+                                     res->aux.surf.size_B,
+                                     IRIS_MEMZONE_OTHER, I915_TILING_Y,
+                                     res->aux.surf.row_pitch_B, alloc_flags);
+   if (!res->aux.bo)
+      return false;
+
+   /* Optionally, initialize the auxiliary data to the desired value. */
+   if (memset_value != 0) {
+      void *map = iris_bo_map(NULL, res->aux.bo, MAP_WRITE | MAP_RAW);
+      if (!map)
+         return false;
+
+      memset(map, memset_value, res->aux.surf.size_B);
+      iris_bo_unmap(res->aux.bo);
    }
 
-   const struct isl_drm_modifier_info *mod_info =
-      isl_drm_modifier_get_info(modifier);
+   // XXX: HIZ enabling
 
-   isl_surf_usage_flags_t usage = pipe_bind_to_isl_usage(templ->bind);
+   return true;
+}
 
-   if (templ->target == PIPE_TEXTURE_CUBE)
-      usage |= ISL_SURF_USAGE_CUBE_BIT;
+static bool
+supports_mcs(const struct isl_surf *surf)
+{
+   /* MCS compression only applies to multisampled resources. */
+   if (surf->samples <= 1)
+      return false;
 
-   isl_surf_init(&screen->isl_dev, &res->surf,
-                 .dim = target_to_isl_surf_dim(templ->target),
-                 .format = iris_isl_format_for_pipe_format(templ->format),
-                 .width = templ->width0,
-                 .height = templ->height0,
-                 .depth = templ->depth0,
-                 .levels = templ->last_level + 1,
-                 .array_len = templ->array_size,
-                 .samples = MAX2(templ->nr_samples, 1),
-                 .min_alignment_B = 0,
-                 .row_pitch_B = 0,
-                 .usage = usage,
-                 .tiling_flags = 1 << mod_info->tiling);
+   /* See isl_surf_get_mcs_surf for details. */
+   if (surf->samples == 16 && surf->logical_level0_px.width > 8192)
+      return false;
+
+   /* Depth and stencil buffers use the IMS (interleaved) layout. */
+   if (isl_surf_usage_is_depth_or_stencil(surf->usage))
+      return false;
+
+   return true;
+}
+
+static bool
+supports_ccs(const struct gen_device_info *devinfo,
+             const struct isl_surf *surf)
+{
+   /* Gen9+ only supports CCS for Y-tiled buffers. */
+   if (surf->tiling != ISL_TILING_Y0)
+      return false;
+
+   /* CCS only supports singlesampled resources. */
+   if (surf->samples > 1)
+      return false;
+
+   /* The PRM doesn't say this explicitly, but fast-clears don't appear to
+    * work for 3D textures until Gen9 where the layout of 3D textures changes
+    * to match 2D array textures.
+    */
+   if (devinfo->gen < 9 && surf->dim != ISL_SURF_DIM_2D)
+      return false;
+
+   /* Note: still need to check the format! */
+
+   return true;
+}
+
+static struct pipe_resource *
+iris_resource_create_for_buffer(struct pipe_screen *pscreen,
+                                const struct pipe_resource *templ)
+{
+   struct iris_screen *screen = (struct iris_screen *)pscreen;
+   struct iris_resource *res = iris_alloc_resource(pscreen, templ);
+
+   assert(templ->target == PIPE_BUFFER);
+   assert(templ->height0 <= 1);
+   assert(templ->depth0 <= 1);
+   assert(templ->format == PIPE_FORMAT_NONE ||
+          util_format_get_blocksize(templ->format) == 1);
+
+   res->internal_format = templ->format;
+   res->surf.tiling = ISL_TILING_LINEAR;
 
    enum iris_memory_zone memzone = IRIS_MEMZONE_OTHER;
    const char *name = templ->target == PIPE_BUFFER ? "buffer" : "miptree";
@@ -269,25 +451,198 @@ iris_resource_create_with_modifiers(struct pipe_screen *pscreen,
       name = "dynamic state";
    }
 
+   res->bo = iris_bo_alloc(screen->bufmgr, name, templ->width0, memzone);
+   if (!res->bo) {
+      iris_resource_destroy(pscreen, &res->base);
+      return NULL;
+   }
+
+   return &res->base;
+}
+
+static struct pipe_resource *
+iris_resource_create_with_modifiers(struct pipe_screen *pscreen,
+                                    const struct pipe_resource *templ,
+                                    const uint64_t *modifiers,
+                                    int modifiers_count)
+{
+   struct iris_screen *screen = (struct iris_screen *)pscreen;
+   struct gen_device_info *devinfo = &screen->devinfo;
+   struct iris_resource *res = iris_alloc_resource(pscreen, templ);
+
+   if (!res)
+      return NULL;
+
+   const struct util_format_description *format_desc =
+      util_format_description(templ->format);
+   const bool has_depth = util_format_has_depth(format_desc);
+   uint64_t modifier =
+      select_best_modifier(devinfo, modifiers, modifiers_count);
+
+   isl_tiling_flags_t tiling_flags = ISL_TILING_ANY_MASK;
+
+   if (modifier != DRM_FORMAT_MOD_INVALID) {
+      res->mod_info = isl_drm_modifier_get_info(modifier);
+
+      tiling_flags = 1 << res->mod_info->tiling;
+   } else {
+      if (modifiers_count > 0) {
+         fprintf(stderr, "Unsupported modifier, resource creation failed.\n");
+         return NULL;
+      }
+
+      /* No modifiers - we can select our own tiling. */
+
+      if (has_depth) {
+         /* Depth must be Y-tiled */
+         tiling_flags = ISL_TILING_Y0_BIT;
+      } else if (templ->format == PIPE_FORMAT_S8_UINT) {
+         /* Stencil must be W-tiled */
+         tiling_flags = ISL_TILING_W_BIT;
+      } else if (templ->target == PIPE_BUFFER ||
+                 templ->target == PIPE_TEXTURE_1D ||
+                 templ->target == PIPE_TEXTURE_1D_ARRAY) {
+         /* Use linear for buffers and 1D textures */
+         tiling_flags = ISL_TILING_LINEAR_BIT;
+      }
+
+      /* Use linear for staging buffers */
+      if (templ->usage == PIPE_USAGE_STAGING ||
+          templ->bind & (PIPE_BIND_LINEAR | PIPE_BIND_CURSOR) )
+         tiling_flags = ISL_TILING_LINEAR_BIT;
+   }
+
+   isl_surf_usage_flags_t usage = pipe_bind_to_isl_usage(templ->bind);
+
+   if (templ->target == PIPE_TEXTURE_CUBE ||
+       templ->target == PIPE_TEXTURE_CUBE_ARRAY)
+      usage |= ISL_SURF_USAGE_CUBE_BIT;
+
+   if (templ->usage != PIPE_USAGE_STAGING) {
+      if (templ->format == PIPE_FORMAT_S8_UINT)
+         usage |= ISL_SURF_USAGE_STENCIL_BIT;
+      else if (has_depth)
+         usage |= ISL_SURF_USAGE_DEPTH_BIT;
+   }
+
+   enum pipe_format pfmt = templ->format;
+   res->internal_format = pfmt;
+
+   /* Should be handled by u_transfer_helper */
+   assert(!util_format_is_depth_and_stencil(pfmt));
+
+   struct iris_format_info fmt = iris_format_for_usage(devinfo, pfmt, usage);
+   assert(fmt.fmt != ISL_FORMAT_UNSUPPORTED);
+
+   UNUSED const bool isl_surf_created_successfully =
+      isl_surf_init(&screen->isl_dev, &res->surf,
+                    .dim = target_to_isl_surf_dim(templ->target),
+                    .format = fmt.fmt,
+                    .width = templ->width0,
+                    .height = templ->height0,
+                    .depth = templ->depth0,
+                    .levels = templ->last_level + 1,
+                    .array_len = templ->array_size,
+                    .samples = MAX2(templ->nr_samples, 1),
+                    .min_alignment_B = 0,
+                    .row_pitch_B = 0,
+                    .usage = usage,
+                    .tiling_flags = tiling_flags);
+   assert(isl_surf_created_successfully);
+
+   if (res->mod_info) {
+      res->aux.possible_usages |= 1 << res->mod_info->aux_usage;
+   } else if (has_depth) {
+      res->aux.possible_usages |= 1 << ISL_AUX_USAGE_HIZ;
+   } else if (supports_mcs(&res->surf)) {
+      res->aux.possible_usages |= 1 << ISL_AUX_USAGE_MCS;
+   } else if (supports_ccs(devinfo, &res->surf)) {
+      if (isl_format_supports_ccs_e(devinfo, res->surf.format))
+         res->aux.possible_usages |= 1 << ISL_AUX_USAGE_CCS_E;
+      else if (isl_format_supports_ccs_d(devinfo, res->surf.format))
+         res->aux.possible_usages |= 1 << ISL_AUX_USAGE_CCS_D;
+   }
+
+   // XXX: we don't actually do aux yet
+   res->aux.possible_usages = 1 << ISL_AUX_USAGE_NONE;
+
+   res->aux.usage = util_last_bit(res->aux.possible_usages) - 1;
+
+   const char *name = "miptree";
+   enum iris_memory_zone memzone = IRIS_MEMZONE_OTHER;
+
+   /* These are for u_upload_mgr buffers only */
+   assert(!(templ->flags & (IRIS_RESOURCE_FLAG_SHADER_MEMZONE |
+                            IRIS_RESOURCE_FLAG_SURFACE_MEMZONE |
+                            IRIS_RESOURCE_FLAG_DYNAMIC_MEMZONE)));
+
    res->bo = iris_bo_alloc_tiled(screen->bufmgr, name, res->surf.size_B,
                                  memzone,
                                  isl_tiling_to_i915_tiling(res->surf.tiling),
                                  res->surf.row_pitch_B, 0);
+
    if (!res->bo)
       goto fail;
 
+   if (!iris_resource_alloc_aux(screen, res))
+      goto fail;
+
    return &res->base;
 
 fail:
+   fprintf(stderr, "XXX: resource creation failed\n");
    iris_resource_destroy(pscreen, &res->base);
    return NULL;
+
 }
 
 static struct pipe_resource *
 iris_resource_create(struct pipe_screen *pscreen,
                      const struct pipe_resource *templ)
 {
-   return iris_resource_create_with_modifiers(pscreen, templ, NULL, 0);
+   if (templ->target == PIPE_BUFFER)
+      return iris_resource_create_for_buffer(pscreen, templ);
+   else
+      return iris_resource_create_with_modifiers(pscreen, templ, NULL, 0);
+}
+
+static uint64_t
+tiling_to_modifier(uint32_t tiling)
+{
+   static const uint64_t map[] = {
+      [I915_TILING_NONE]   = DRM_FORMAT_MOD_LINEAR,
+      [I915_TILING_X]      = I915_FORMAT_MOD_X_TILED,
+      [I915_TILING_Y]      = I915_FORMAT_MOD_Y_TILED,
+   };
+
+   assert(tiling < ARRAY_SIZE(map));
+
+   return map[tiling];
+}
+
+static struct pipe_resource *
+iris_resource_from_user_memory(struct pipe_screen *pscreen,
+                               const struct pipe_resource *templ,
+                               void *user_memory)
+{
+   struct iris_screen *screen = (struct iris_screen *)pscreen;
+   struct iris_bufmgr *bufmgr = screen->bufmgr;
+   struct iris_resource *res = iris_alloc_resource(pscreen, templ);
+   if (!res)
+      return NULL;
+
+   assert(templ->target == PIPE_BUFFER);
+
+   res->internal_format = templ->format;
+   res->bo = iris_bo_create_userptr(bufmgr, "user",
+                                    user_memory, templ->width0,
+                                    IRIS_MEMZONE_OTHER);
+   if (!res->bo) {
+      free(res);
+      return NULL;
+   }
+
+   return &res->base;
 }
 
 static struct pipe_resource *
@@ -297,6 +652,7 @@ iris_resource_from_handle(struct pipe_screen *pscreen,
                           unsigned usage)
 {
    struct iris_screen *screen = (struct iris_screen *)pscreen;
+   struct gen_device_info *devinfo = &screen->devinfo;
    struct iris_bufmgr *bufmgr = screen->bufmgr;
    struct iris_resource *res = iris_alloc_resource(pscreen, templ);
    if (!res)
@@ -309,38 +665,56 @@ iris_resource_from_handle(struct pipe_screen *pscreen,
    }
 
    switch (whandle->type) {
-   case WINSYS_HANDLE_TYPE_SHARED:
+   case WINSYS_HANDLE_TYPE_FD:
       res->bo = iris_bo_import_dmabuf(bufmgr, whandle->handle);
       break;
-   case WINSYS_HANDLE_TYPE_FD:
+   case WINSYS_HANDLE_TYPE_SHARED:
       res->bo = iris_bo_gem_create_from_name(bufmgr, "winsys image",
                                              whandle->handle);
       break;
    default:
       unreachable("invalid winsys handle type");
    }
+   if (!res->bo)
+      return NULL;
 
-   const struct isl_drm_modifier_info *mod_info =
-      isl_drm_modifier_get_info(whandle->modifier);
-
-   // XXX: usage...
-   isl_surf_usage_flags_t isl_usage = ISL_SURF_USAGE_DISPLAY_BIT;
-
-   isl_surf_init(&screen->isl_dev, &res->surf,
-                 .dim = target_to_isl_surf_dim(templ->target),
-                 .format = iris_isl_format_for_pipe_format(templ->format),
-                 .width = templ->width0,
-                 .height = templ->height0,
-                 .depth = templ->depth0,
-                 .levels = templ->last_level + 1,
-                 .array_len = templ->array_size,
-                 .samples = MAX2(templ->nr_samples, 1),
-                 .min_alignment_B = 0,
-                 .row_pitch_B = 0,
-                 .usage = isl_usage,
-                 .tiling_flags = 1 << mod_info->tiling);
-
-   assert(res->bo->tiling_mode == isl_tiling_to_i915_tiling(res->surf.tiling));
+   uint64_t modifier = whandle->modifier;
+   if (modifier == DRM_FORMAT_MOD_INVALID) {
+      modifier = tiling_to_modifier(res->bo->tiling_mode);
+   }
+   res->mod_info = isl_drm_modifier_get_info(modifier);
+   assert(res->mod_info);
+
+   isl_surf_usage_flags_t isl_usage = pipe_bind_to_isl_usage(templ->bind);
+
+   const struct iris_format_info fmt =
+      iris_format_for_usage(devinfo, templ->format, isl_usage);
+   res->internal_format = templ->format;
+
+   if (templ->target == PIPE_BUFFER) {
+      res->surf.tiling = ISL_TILING_LINEAR;
+   } else {
+      isl_surf_init(&screen->isl_dev, &res->surf,
+                    .dim = target_to_isl_surf_dim(templ->target),
+                    .format = fmt.fmt,
+                    .width = templ->width0,
+                    .height = templ->height0,
+                    .depth = templ->depth0,
+                    .levels = templ->last_level + 1,
+                    .array_len = templ->array_size,
+                    .samples = MAX2(templ->nr_samples, 1),
+                    .min_alignment_B = 0,
+                    .row_pitch_B = whandle->stride,
+                    .usage = isl_usage,
+                    .tiling_flags = 1 << res->mod_info->tiling);
+
+      assert(res->bo->tiling_mode ==
+             isl_tiling_to_i915_tiling(res->surf.tiling));
+
+      // XXX: create_ccs_buf_for_image?
+      if (!iris_resource_alloc_aux(screen, res))
+         goto fail;
+   }
 
    return &res->base;
 
@@ -358,13 +732,16 @@ iris_resource_get_handle(struct pipe_screen *pscreen,
 {
    struct iris_resource *res = (struct iris_resource *)resource;
 
+   /* If this is a buffer, stride should be 0 - no need to special case */
    whandle->stride = res->surf.row_pitch_B;
+   whandle->modifier = tiling_to_modifier(res->bo->tiling_mode);
 
    switch (whandle->type) {
    case WINSYS_HANDLE_TYPE_SHARED:
       return iris_bo_flink(res->bo, &whandle->handle) == 0;
    case WINSYS_HANDLE_TYPE_KMS:
-      return iris_bo_export_gem_handle(res->bo) != 0;
+      whandle->handle = iris_bo_export_gem_handle(res->bo);
+      return true;
    case WINSYS_HANDLE_TYPE_FD:
       return iris_bo_export_dmabuf(res->bo, (int *) &whandle->handle) == 0;
    }
@@ -372,6 +749,294 @@ iris_resource_get_handle(struct pipe_screen *pscreen,
    return false;
 }
 
+static void
+get_image_offset_el(struct isl_surf *surf, unsigned level, unsigned z,
+                    unsigned *out_x0_el, unsigned *out_y0_el)
+{
+   if (surf->dim == ISL_SURF_DIM_3D) {
+      isl_surf_get_image_offset_el(surf, level, 0, z, out_x0_el, out_y0_el);
+   } else {
+      isl_surf_get_image_offset_el(surf, level, z, 0, out_x0_el, out_y0_el);
+   }
+}
+
+/**
+ * Get pointer offset into stencil buffer.
+ *
+ * The stencil buffer is W tiled. Since the GTT is incapable of W fencing, we
+ * must decode the tile's layout in software.
+ *
+ * See
+ *   - PRM, 2011 Sandy Bridge, Volume 1, Part 2, Section 4.5.2.1 W-Major Tile
+ *     Format.
+ *   - PRM, 2011 Sandy Bridge, Volume 1, Part 2, Section 4.5.3 Tiling Algorithm
+ *
+ * Even though the returned offset is always positive, the return type is
+ * signed due to
+ *    commit e8b1c6d6f55f5be3bef25084fdd8b6127517e137
+ *    mesa: Fix return type of  _mesa_get_format_bytes() (#37351)
+ */
+static intptr_t
+s8_offset(uint32_t stride, uint32_t x, uint32_t y, bool swizzled)
+{
+   uint32_t tile_size = 4096;
+   uint32_t tile_width = 64;
+   uint32_t tile_height = 64;
+   uint32_t row_size = 64 * stride / 2; /* Two rows are interleaved. */
+
+   uint32_t tile_x = x / tile_width;
+   uint32_t tile_y = y / tile_height;
+
+   /* The byte's address relative to the tile's base addres. */
+   uint32_t byte_x = x % tile_width;
+   uint32_t byte_y = y % tile_height;
+
+   uintptr_t u = tile_y * row_size
+               + tile_x * tile_size
+               + 512 * (byte_x / 8)
+               +  64 * (byte_y / 8)
+               +  32 * ((byte_y / 4) % 2)
+               +  16 * ((byte_x / 4) % 2)
+               +   8 * ((byte_y / 2) % 2)
+               +   4 * ((byte_x / 2) % 2)
+               +   2 * (byte_y % 2)
+               +   1 * (byte_x % 2);
+
+   if (swizzled) {
+      /* adjust for bit6 swizzling */
+      if (((byte_x / 8) % 2) == 1) {
+         if (((byte_y / 8) % 2) == 0) {
+            u += 64;
+         } else {
+            u -= 64;
+         }
+      }
+   }
+
+   return u;
+}
+
+static void
+iris_unmap_s8(struct iris_transfer *map)
+{
+   struct pipe_transfer *xfer = &map->base;
+   struct iris_resource *res = (struct iris_resource *) xfer->resource;
+   struct isl_surf *surf = &res->surf;
+   const bool has_swizzling = false;
+
+   if (xfer->usage & PIPE_TRANSFER_WRITE) {
+      uint8_t *untiled_s8_map = map->ptr;
+      uint8_t *tiled_s8_map =
+         iris_bo_map(map->dbg, res->bo, xfer->usage | MAP_RAW);
+
+      struct pipe_box box = xfer->box;
+
+      for (int s = 0; s < box.depth; s++) {
+         unsigned x0_el, y0_el;
+         get_image_offset_el(surf, xfer->level, box.z, &x0_el, &y0_el);
+
+         for (uint32_t y = 0; y < box.height; y++) {
+            for (uint32_t x = 0; x < box.width; x++) {
+               ptrdiff_t offset = s8_offset(surf->row_pitch_B,
+                                            x0_el + box.x + x,
+                                            y0_el + box.y + y,
+                                            has_swizzling);
+               tiled_s8_map[offset] =
+                  untiled_s8_map[s * xfer->layer_stride + y * xfer->stride + x];
+            }
+         }
+
+         box.z++;
+      }
+   }
+
+   free(map->buffer);
+}
+
+static void
+iris_map_s8(struct iris_transfer *map)
+{
+   struct pipe_transfer *xfer = &map->base;
+   struct iris_resource *res = (struct iris_resource *) xfer->resource;
+   struct isl_surf *surf = &res->surf;
+
+   xfer->stride = surf->row_pitch_B;
+   xfer->layer_stride = xfer->stride * xfer->box.height;
+
+   /* The tiling and detiling functions require that the linear buffer has
+    * a 16-byte alignment (that is, its `x0` is 16-byte aligned).  Here we
+    * over-allocate the linear buffer to get the proper alignment.
+    */
+   map->buffer = map->ptr = malloc(xfer->layer_stride * xfer->box.depth);
+   assert(map->buffer);
+
+   const bool has_swizzling = false;
+
+   /* One of either READ_BIT or WRITE_BIT or both is set.  READ_BIT implies no
+    * INVALIDATE_RANGE_BIT.  WRITE_BIT needs the original values read in unless
+    * invalidate is set, since we'll be writing the whole rectangle from our
+    * temporary buffer back out.
+    */
+   if (!(xfer->usage & PIPE_TRANSFER_DISCARD_RANGE)) {
+      uint8_t *untiled_s8_map = map->ptr;
+      uint8_t *tiled_s8_map =
+         iris_bo_map(map->dbg, res->bo, xfer->usage | MAP_RAW);
+
+      struct pipe_box box = xfer->box;
+
+      for (int s = 0; s < box.depth; s++) {
+         unsigned x0_el, y0_el;
+         get_image_offset_el(surf, xfer->level, box.z, &x0_el, &y0_el);
+
+         for (uint32_t y = 0; y < box.height; y++) {
+            for (uint32_t x = 0; x < box.width; x++) {
+               ptrdiff_t offset = s8_offset(surf->row_pitch_B,
+                                            x0_el + box.x + x,
+                                            y0_el + box.y + y,
+                                            has_swizzling);
+               untiled_s8_map[s * xfer->layer_stride + y * xfer->stride + x] =
+                  tiled_s8_map[offset];
+            }
+         }
+
+         box.z++;
+      }
+   }
+
+   map->unmap = iris_unmap_s8;
+}
+
+/* Compute extent parameters for use with tiled_memcpy functions.
+ * xs are in units of bytes and ys are in units of strides.
+ */
+static inline void
+tile_extents(struct isl_surf *surf,
+             const struct pipe_box *box,
+             unsigned level,
+             unsigned *x1_B, unsigned *x2_B,
+             unsigned *y1_el, unsigned *y2_el)
+{
+   const struct isl_format_layout *fmtl = isl_format_get_layout(surf->format);
+   const unsigned cpp = fmtl->bpb / 8;
+
+   assert(box->x % fmtl->bw == 0);
+   assert(box->y % fmtl->bh == 0);
+
+   unsigned x0_el, y0_el;
+   get_image_offset_el(surf, level, box->z, &x0_el, &y0_el);
+
+   *x1_B = (box->x / fmtl->bw + x0_el) * cpp;
+   *y1_el = box->y / fmtl->bh + y0_el;
+   *x2_B = (DIV_ROUND_UP(box->x + box->width, fmtl->bw) + x0_el) * cpp;
+   *y2_el = DIV_ROUND_UP(box->y + box->height, fmtl->bh) + y0_el;
+}
+
+static void
+iris_unmap_tiled_memcpy(struct iris_transfer *map)
+{
+   struct pipe_transfer *xfer = &map->base;
+   struct pipe_box box = xfer->box;
+   struct iris_resource *res = (struct iris_resource *) xfer->resource;
+   struct isl_surf *surf = &res->surf;
+
+   const bool has_swizzling = false;
+
+   if (xfer->usage & PIPE_TRANSFER_WRITE) {
+      char *dst = iris_bo_map(map->dbg, res->bo, xfer->usage | MAP_RAW);
+
+      for (int s = 0; s < box.depth; s++) {
+         unsigned x1, x2, y1, y2;
+         tile_extents(surf, &box, xfer->level, &x1, &x2, &y1, &y2);
+
+         void *ptr = map->ptr + s * xfer->layer_stride;
+
+         isl_memcpy_linear_to_tiled(x1, x2, y1, y2, dst, ptr,
+                                    surf->row_pitch_B, xfer->stride,
+                                    has_swizzling, surf->tiling, ISL_MEMCPY);
+         box.z++;
+      }
+   }
+   os_free_aligned(map->buffer);
+   map->buffer = map->ptr = NULL;
+}
+
+static void
+iris_map_tiled_memcpy(struct iris_transfer *map)
+{
+   struct pipe_transfer *xfer = &map->base;
+   struct iris_resource *res = (struct iris_resource *) xfer->resource;
+   struct isl_surf *surf = &res->surf;
+
+   xfer->stride = ALIGN(surf->row_pitch_B, 16);
+   xfer->layer_stride = xfer->stride * xfer->box.height;
+
+   unsigned x1, x2, y1, y2;
+   tile_extents(surf, &xfer->box, xfer->level, &x1, &x2, &y1, &y2);
+
+   /* The tiling and detiling functions require that the linear buffer has
+    * a 16-byte alignment (that is, its `x0` is 16-byte aligned).  Here we
+    * over-allocate the linear buffer to get the proper alignment.
+    */
+   map->buffer =
+      os_malloc_aligned(xfer->layer_stride * xfer->box.depth, 16);
+   assert(map->buffer);
+   map->ptr = (char *)map->buffer + (x1 & 0xf);
+
+   const bool has_swizzling = false;
+
+   // XXX: PIPE_TRANSFER_READ?
+   if (!(xfer->usage & PIPE_TRANSFER_DISCARD_RANGE)) {
+      char *src = iris_bo_map(map->dbg, res->bo, xfer->usage | MAP_RAW);
+
+      struct pipe_box box = xfer->box;
+
+      for (int s = 0; s < box.depth; s++) {
+         unsigned x1, x2, y1, y2;
+         tile_extents(surf, &box, xfer->level, &x1, &x2, &y1, &y2);
+
+         /* Use 's' rather than 'box.z' to rebase the first slice to 0. */
+         void *ptr = map->ptr + s * xfer->layer_stride;
+
+         isl_memcpy_tiled_to_linear(x1, x2, y1, y2, ptr, src, xfer->stride,
+                                    surf->row_pitch_B, has_swizzling,
+                                    surf->tiling, ISL_MEMCPY);
+         box.z++;
+      }
+   }
+
+   map->unmap = iris_unmap_tiled_memcpy;
+}
+
+static void
+iris_map_direct(struct iris_transfer *map)
+{
+   struct pipe_transfer *xfer = &map->base;
+   struct pipe_box *box = &xfer->box;
+   struct iris_resource *res = (struct iris_resource *) xfer->resource;
+
+   void *ptr = iris_bo_map(map->dbg, res->bo, xfer->usage);
+
+   if (res->base.target == PIPE_BUFFER) {
+      xfer->stride = 0;
+      xfer->layer_stride = 0;
+
+      map->ptr = ptr + box->x;
+   } else {
+      struct isl_surf *surf = &res->surf;
+      const struct isl_format_layout *fmtl =
+         isl_format_get_layout(surf->format);
+      const unsigned cpp = fmtl->bpb / 8;
+      unsigned x0_el, y0_el;
+
+      get_image_offset_el(surf, xfer->level, box->z, &x0_el, &y0_el);
+
+      xfer->stride = isl_surf_get_row_pitch_B(surf);
+      xfer->layer_stride = isl_surf_get_array_pitch(surf);
+
+      map->ptr = ptr + (y0_el + box->y) * xfer->stride + (x0_el + box->x) * cpp;
+   }
+}
+
 static void *
 iris_transfer_map(struct pipe_context *ctx,
                   struct pipe_resource *resource,
@@ -382,124 +1047,197 @@ iris_transfer_map(struct pipe_context *ctx,
 {
    struct iris_context *ice = (struct iris_context *)ctx;
    struct iris_resource *res = (struct iris_resource *)resource;
-   struct pipe_transfer *transfer;
+   struct isl_surf *surf = &res->surf;
 
-   // PIPE_TRANSFER_DISCARD_WHOLE_RESOURCE
-   // PIPE_TRANSFER_DISCARD_RANGE
-   // PIPE_TRANSFER_MAP_DIRECTLY
+    /* If we can discard the whole resource, we can also discard the
+     * subrange being accessed.
+     */
+    if (usage & PIPE_TRANSFER_DISCARD_WHOLE_RESOURCE)
+       usage |= PIPE_TRANSFER_DISCARD_RANGE;
 
-   transfer = calloc(1, sizeof(struct pipe_transfer));
-   if (!transfer)
+   if (surf->tiling != ISL_TILING_LINEAR &&
+       (usage & PIPE_TRANSFER_MAP_DIRECTLY))
       return NULL;
 
-   pipe_resource_reference(&transfer->resource, resource);
-   transfer->level = level;
-   transfer->usage = usage;
-   transfer->box = *box;
-   transfer->stride = isl_surf_get_row_pitch_B(&res->surf);
-   transfer->layer_stride = isl_surf_get_array_pitch(&res->surf);
-   *ptransfer = transfer;
+   if (resource->target != PIPE_BUFFER) {
+      iris_resource_access_raw(ice, &ice->batches[IRIS_BATCH_RENDER], res,
+                               level, box->z, box->depth,
+                               usage & PIPE_TRANSFER_WRITE);
+   }
 
-   if (!(usage & PIPE_TRANSFER_UNSYNCHRONIZED) &&
-       iris_batch_references(&ice->render_batch, res->bo)) {
-      iris_batch_flush(&ice->render_batch);
+   if (!(usage & PIPE_TRANSFER_UNSYNCHRONIZED)) {
+      for (int i = 0; i < IRIS_BATCH_COUNT; i++) {
+         if (iris_batch_references(&ice->batches[i], res->bo))
+            iris_batch_flush(&ice->batches[i]);
+      }
    }
 
    if ((usage & PIPE_TRANSFER_DONTBLOCK) && iris_bo_busy(res->bo))
       return NULL;
 
-   usage &= (PIPE_TRANSFER_READ |
-             PIPE_TRANSFER_WRITE |
-             PIPE_TRANSFER_UNSYNCHRONIZED |
-             PIPE_TRANSFER_PERSISTENT |
-             PIPE_TRANSFER_COHERENT);
+   struct iris_transfer *map = slab_alloc(&ice->transfer_pool);
+   struct pipe_transfer *xfer = &map->base;
+
+   if (!map)
+      return NULL;
 
-   return iris_bo_map(&ice->dbg, res->bo, usage);
+   memset(map, 0, sizeof(*map));
+   map->dbg = &ice->dbg;
+
+   pipe_resource_reference(&xfer->resource, resource);
+   xfer->level = level;
+   xfer->usage = usage;
+   xfer->box = *box;
+   *ptransfer = xfer;
+
+   xfer->usage &= (PIPE_TRANSFER_READ |
+                   PIPE_TRANSFER_WRITE |
+                   PIPE_TRANSFER_UNSYNCHRONIZED |
+                   PIPE_TRANSFER_PERSISTENT |
+                   PIPE_TRANSFER_COHERENT |
+                   PIPE_TRANSFER_DISCARD_RANGE);
+
+   if (surf->tiling == ISL_TILING_W) {
+      // XXX: just teach iris_map_tiled_memcpy about W tiling...
+      iris_map_s8(map);
+   } else if (surf->tiling != ISL_TILING_LINEAR) {
+      iris_map_tiled_memcpy(map);
+   } else {
+      iris_map_direct(map);
+   }
+
+   return map->ptr;
 }
 
 static void
-iris_transfer_flush_region(struct pipe_context *pipe,
-                           struct pipe_transfer *transfer,
+iris_transfer_flush_region(struct pipe_context *ctx,
+                           struct pipe_transfer *xfer,
                            const struct pipe_box *box)
 {
+   struct iris_context *ice = (struct iris_context *)ctx;
+   struct iris_resource *res = (struct iris_resource *) xfer->resource;
+
+
+   // XXX: don't emit flushes in both engines...? we may also need to flush
+   // even if there isn't a draw yet - may still be stale data in caches...
+   for (int i = 0; i < IRIS_BATCH_COUNT; i++) {
+      if (ice->batches[i].contains_draw) {
+         iris_batch_maybe_flush(&ice->batches[i], 24);
+         iris_flush_and_dirty_for_history(ice, &ice->batches[i], res);
+      }
+   }
 }
 
 static void
-iris_transfer_unmap(struct pipe_context *pipe,
-                    struct pipe_transfer *transfer)
+iris_transfer_unmap(struct pipe_context *ctx, struct pipe_transfer *xfer)
 {
-   pipe_resource_reference(&transfer->resource, NULL);
-   free(transfer);
+   struct iris_context *ice = (struct iris_context *)ctx;
+   struct iris_transfer *map = (void *) xfer;
+   struct iris_resource *res = (struct iris_resource *) xfer->resource;
+
+   if (map->unmap)
+      map->unmap(map);
+
+   // XXX: don't emit flushes in both engines...?
+   for (int i = 0; i < IRIS_BATCH_COUNT; i++) {
+      if (ice->batches[i].contains_draw) {
+         iris_batch_maybe_flush(&ice->batches[i], 24);
+         iris_flush_and_dirty_for_history(ice, &ice->batches[i], res);
+      }
+   }
+
+   pipe_resource_reference(&xfer->resource, NULL);
+   slab_free(&ice->transfer_pool, map);
 }
 
 static void
-iris_buffer_subdata(struct pipe_context *pipe,
-                    struct pipe_resource *resource,
-                    unsigned usage, unsigned offset,
-                    unsigned size, const void *data)
+iris_flush_resource(struct pipe_context *ctx, struct pipe_resource *resource)
 {
 }
 
-static void
-iris_texture_subdata(struct pipe_context *pipe,
-                     struct pipe_resource *resource,
-                     unsigned level,
-                     unsigned usage,
-                     const struct pipe_box *box,
-                     const void *data,
-                     unsigned stride,
-                     unsigned layer_stride)
+void
+iris_flush_and_dirty_for_history(struct iris_context *ice,
+                                 struct iris_batch *batch,
+                                 struct iris_resource *res)
 {
-}
+   if (res->base.target != PIPE_BUFFER)
+      return;
+
+   unsigned flush = PIPE_CONTROL_CS_STALL;
+
+   /* We've likely used the rendering engine (i.e. BLORP) to write to this
+    * surface.  Flush the render cache so the data actually lands.
+    */
+   if (batch->name != IRIS_BATCH_COMPUTE)
+      flush |= PIPE_CONTROL_RENDER_TARGET_FLUSH;
+
+   uint64_t dirty = 0ull;
+
+   if (res->bind_history & PIPE_BIND_CONSTANT_BUFFER) {
+      flush |= PIPE_CONTROL_CONST_CACHE_INVALIDATE |
+               PIPE_CONTROL_TEXTURE_CACHE_INVALIDATE;
+      dirty |= IRIS_DIRTY_CONSTANTS_VS |
+               IRIS_DIRTY_CONSTANTS_TCS |
+               IRIS_DIRTY_CONSTANTS_TES |
+               IRIS_DIRTY_CONSTANTS_GS |
+               IRIS_DIRTY_CONSTANTS_FS |
+               IRIS_DIRTY_CONSTANTS_CS |
+               IRIS_ALL_DIRTY_BINDINGS;
+   }
 
+   if (res->bind_history & PIPE_BIND_SAMPLER_VIEW)
+      flush |= PIPE_CONTROL_TEXTURE_CACHE_INVALIDATE;
 
-static void
-iris_resource_copy_region(struct pipe_context *ctx,
-                          struct pipe_resource *dst,
-                          unsigned dst_level,
-                          unsigned dstx, unsigned dsty, unsigned dstz,
-                          struct pipe_resource *src,
-                          unsigned src_level,
-                          const struct pipe_box *src_box)
-{
-}
+   if (res->bind_history & (PIPE_BIND_VERTEX_BUFFER | PIPE_BIND_INDEX_BUFFER))
+      flush |= PIPE_CONTROL_VF_CACHE_INVALIDATE;
 
-static void
-iris_flush_resource(struct pipe_context *ctx, struct pipe_resource *resource)
-{
+   if (res->bind_history & (PIPE_BIND_SHADER_BUFFER | PIPE_BIND_SHADER_IMAGE))
+      flush |= PIPE_CONTROL_DATA_CACHE_FLUSH;
+
+   iris_emit_pipe_control_flush(batch, flush);
+
+   ice->state.dirty |= dirty;
 }
 
-static boolean
-iris_generate_mipmap(struct pipe_context *ctx,
-                     struct pipe_resource *resource,
-                     enum pipe_format format,
-                     unsigned base_level,
-                     unsigned last_level,
-                     unsigned first_layer,
-                     unsigned last_layer)
+static enum pipe_format
+iris_resource_get_internal_format(struct pipe_resource *p_res)
 {
-   return true;
+   struct iris_resource *res = (void *) p_res;
+   return res->internal_format;
 }
 
+static const struct u_transfer_vtbl transfer_vtbl = {
+   .resource_create       = iris_resource_create,
+   .resource_destroy      = iris_resource_destroy,
+   .transfer_map          = iris_transfer_map,
+   .transfer_unmap        = iris_transfer_unmap,
+   .transfer_flush_region = iris_transfer_flush_region,
+   .get_internal_format   = iris_resource_get_internal_format,
+   .set_stencil           = iris_resource_set_separate_stencil,
+   .get_stencil           = iris_resource_get_separate_stencil,
+};
+
 void
 iris_init_screen_resource_functions(struct pipe_screen *pscreen)
 {
    pscreen->resource_create_with_modifiers =
       iris_resource_create_with_modifiers;
-   pscreen->resource_create = iris_resource_create;
+   pscreen->resource_create = u_transfer_helper_resource_create;
+   pscreen->resource_from_user_memory = iris_resource_from_user_memory;
    pscreen->resource_from_handle = iris_resource_from_handle;
    pscreen->resource_get_handle = iris_resource_get_handle;
-   pscreen->resource_destroy = iris_resource_destroy;
+   pscreen->resource_destroy = u_transfer_helper_resource_destroy;
+   pscreen->transfer_helper =
+      u_transfer_helper_create(&transfer_vtbl, true, true, false, true);
 }
 
 void
 iris_init_resource_functions(struct pipe_context *ctx)
 {
    ctx->flush_resource = iris_flush_resource;
-   ctx->transfer_map = iris_transfer_map;
-   ctx->transfer_flush_region = iris_transfer_flush_region;
-   ctx->transfer_unmap = iris_transfer_unmap;
-   ctx->buffer_subdata = iris_buffer_subdata;
-   ctx->texture_subdata = iris_texture_subdata;
-   ctx->resource_copy_region = iris_resource_copy_region;
+   ctx->transfer_map = u_transfer_helper_transfer_map;
+   ctx->transfer_flush_region = u_transfer_helper_transfer_flush_region;
+   ctx->transfer_unmap = u_transfer_helper_transfer_unmap;
+   ctx->buffer_subdata = u_default_buffer_subdata;
+   ctx->texture_subdata = u_default_texture_subdata;
 }