#include "lima_resource.h"
#include "lima_submit.h"
#include "lima_util.h"
+#include "lima_format.h"
#include <drm-uapi/lima_drm.h>
-#define LIMA_TEXEL_FORMAT_BGR_565 0x0e
-#define LIMA_TEXEL_FORMAT_RGB_888 0x15
-#define LIMA_TEXEL_FORMAT_RGBA_8888 0x16
-#define LIMA_TEXEL_FORMAT_RGBX_8888 0x17
#define lima_tex_list_size 64
-static uint32_t pipe_format_to_lima(enum pipe_format pformat)
+static_assert(offsetof(lima_tex_desc, va) == 24, "lima_tex_desc->va offset isn't 24");
+
+
+static void
+lima_texture_desc_set_va(lima_tex_desc *desc,
+ int idx,
+ uint32_t va)
{
- unsigned swap_chans = 0, flag1 = 0, format;
+ unsigned va_bit_idx = VA_BIT_OFFSET + (VA_BIT_SIZE * idx);
+ unsigned va_idx = va_bit_idx / 32;
+ va_bit_idx %= 32;
- switch (pformat) {
- case PIPE_FORMAT_R8G8B8A8_UNORM:
- swap_chans = 1;
- case PIPE_FORMAT_B8G8R8A8_UNORM:
- format = LIMA_TEXEL_FORMAT_RGBA_8888;
- break;
- case PIPE_FORMAT_R8G8B8X8_UNORM:
- swap_chans = 1;
- case PIPE_FORMAT_B8G8R8X8_UNORM:
- format = LIMA_TEXEL_FORMAT_RGBX_8888;
- break;
- case PIPE_FORMAT_R8G8B8_UNORM:
- swap_chans = 1;
- format = LIMA_TEXEL_FORMAT_RGB_888;
- break;
- case PIPE_FORMAT_B5G6R5_UNORM:
- format = LIMA_TEXEL_FORMAT_BGR_565;
- break;
- default:
- assert(0);
- break;
- }
+ va >>= 6;
- return (swap_chans << 7) | (flag1 << 6) | format;
+ desc->va[va_idx] |= va << va_bit_idx;
+ if (va_bit_idx <= 6)
+ return;
+ desc->va[va_idx + 1] |= va >> (32 - va_bit_idx);
}
void
-lima_texture_desc_set_res(struct lima_context *ctx, uint32_t *desc,
+lima_texture_desc_set_res(struct lima_context *ctx, lima_tex_desc *desc,
struct pipe_resource *prsc,
unsigned first_level, unsigned last_level)
{
height = u_minify(height, first_level);
}
- desc[0] |= pipe_format_to_lima(prsc->format);
- desc[2] |= (width << 22);
- desc[3] |= 0x10000 | (height << 3) | (width >> 10);
+ desc->format = lima_format_get_texel(prsc->format);
+ desc->swap_r_b = lima_format_get_swap_rb(prsc->format);
+ desc->width = width;
+ desc->height = height;
+ desc->unknown_3_1 = 1;
if (lima_res->tiled)
layout = 3;
else {
/* for padded linear texture */
if (lima_res->levels[first_level].width != width) {
- desc[0] |= lima_res->levels[first_level].width << 18;
- desc[2] |= 0x100;
+ desc->stride = lima_res->levels[first_level].stride;
+ desc->has_stride = 1;
}
layout = 0;
}
- lima_submit_add_bo(ctx->pp_submit, lima_res->bo, LIMA_SUBMIT_BO_READ);
-
uint32_t base_va = lima_res->bo->va;
- /* attach level 0 */
- desc[6] |= (base_va << 24) | (layout << 13);
- desc[7] |= base_va >> 8;
+ /* attach first level */
+ uint32_t first_va = base_va + lima_res->levels[first_level].offset;
+ desc->va_s.va_0 = first_va >> 6;
+ desc->va_s.layout = layout;
/* Attach remaining levels.
* Each subsequent mipmap address is specified using the 26 msbs.
* These addresses are then packed continuously in memory */
- unsigned current_desc_index = 7;
- unsigned current_desc_bit_index = 24;
- for (i = 1; i < LIMA_MAX_MIP_LEVELS; i++) {
- if (first_level + i > last_level)
- break;
-
- uint32_t address = base_va + lima_res->levels[i].offset;
- address = (address >> 6);
- desc[current_desc_index] |= (address << current_desc_bit_index);
- if (current_desc_bit_index <= 6) {
- current_desc_bit_index += 26;
- if (current_desc_bit_index >= 32) {
- current_desc_bit_index &= 0x1F;
- current_desc_index++;
- }
- continue;
- }
- desc[current_desc_index + 1] |= (address >> (32 - current_desc_bit_index));
- current_desc_bit_index = (current_desc_bit_index + 26) & 0x1F;
- current_desc_index++;
+ for (i = 1; i <= (last_level - first_level); i++) {
+ uint32_t address = base_va + lima_res->levels[first_level + i].offset;
+ lima_texture_desc_set_va(desc, i, address);
}
}
static void
lima_update_tex_desc(struct lima_context *ctx, struct lima_sampler_state *sampler,
- struct lima_sampler_view *texture, void *pdesc)
+ struct lima_sampler_view *texture, void *pdesc,
+ unsigned desc_size)
{
- uint32_t *desc = pdesc;
+ /* unit is 1/16 since lod_bias is in fixed format */
+ int lod_bias_delta = 0;
+ lima_tex_desc *desc = pdesc;
unsigned first_level;
unsigned last_level;
- bool mipmapping;
+ float max_lod;
+
+ memset(desc, 0, desc_size);
+
+ switch (texture->base.target) {
+ case PIPE_TEXTURE_2D:
+ case PIPE_TEXTURE_RECT:
+ desc->texture_type = LIMA_TEXTURE_TYPE_2D;
+ break;
+ case PIPE_TEXTURE_CUBE:
+ desc->texture_type = LIMA_TEXTURE_TYPE_CUBE;
+ break;
+ default:
+ break;
+ }
+
+ if (!sampler->base.normalized_coords)
+ desc->unnorm_coords = 1;
- memset(desc, 0, lima_tex_desc_size);
+ first_level = texture->base.u.tex.first_level;
+ last_level = texture->base.u.tex.last_level;
+ if (last_level - first_level >= LIMA_MAX_MIP_LEVELS)
+ last_level = first_level + LIMA_MAX_MIP_LEVELS - 1;
- /* 2D texture */
- desc[1] |= 0x400;
+ desc->min_lod = lima_float_to_fixed8(sampler->base.min_lod);
+ max_lod = MIN2(sampler->base.max_lod, sampler->base.min_lod +
+ (last_level - first_level));
+ desc->max_lod = lima_float_to_fixed8(max_lod);
+ desc->lod_bias = lima_float_to_fixed8(sampler->base.lod_bias);
- desc[1] &= ~0xff000000;
switch (sampler->base.min_mip_filter) {
- case PIPE_TEX_MIPFILTER_NEAREST:
- first_level = texture->base.u.tex.first_level;
- last_level = texture->base.u.tex.last_level;
- if (last_level - first_level >= LIMA_MAX_MIP_LEVELS)
- last_level = first_level + LIMA_MAX_MIP_LEVELS - 1;
- mipmapping = true;
- desc[1] |= ((last_level - first_level) << 24);
- desc[2] &= ~0x0600;
- break;
case PIPE_TEX_MIPFILTER_LINEAR:
- first_level = texture->base.u.tex.first_level;
- last_level = texture->base.u.tex.last_level;
- if (last_level - first_level >= LIMA_MAX_MIP_LEVELS)
- last_level = first_level + LIMA_MAX_MIP_LEVELS - 1;
- mipmapping = true;
- desc[1] |= ((last_level - first_level) << 24);
- desc[2] |= 0x0600;
+ desc->min_mipfilter_2 = 3;
+ break;
+ case PIPE_TEX_MIPFILTER_NEAREST:
+ desc->min_mipfilter_2 = 0;
break;
case PIPE_TEX_MIPFILTER_NONE:
+ desc->max_lod = desc->min_lod;
+ break;
default:
- first_level = 0;
- last_level = 0;
- mipmapping = false;
- desc[2] &= ~0x0600;
break;
}
switch (sampler->base.mag_img_filter) {
case PIPE_TEX_FILTER_LINEAR:
- desc[2] &= ~0x1000;
- /* no mipmap, filter_mag = linear */
- if (!mipmapping)
- desc[1] |= 0x80000000;
+ desc->mag_img_filter_nearest = 0;
break;
case PIPE_TEX_FILTER_NEAREST:
default:
- desc[2] |= 0x1000;
+ desc->mag_img_filter_nearest = 1;
break;
}
switch (sampler->base.min_img_filter) {
break;
case PIPE_TEX_FILTER_LINEAR:
- desc[2] &= ~0x0800;
+ desc->min_img_filter_nearest = 0;
break;
case PIPE_TEX_FILTER_NEAREST:
default:
- desc[2] |= 0x0800;
+ lod_bias_delta = 8;
+ desc->min_img_filter_nearest = 1;
break;
}
/* Only clamp, clamp to edge, repeat and mirror repeat are supported */
- desc[2] &= ~0xe000;
switch (sampler->base.wrap_s) {
case PIPE_TEX_WRAP_CLAMP:
- desc[2] |= 0x4000;
+ desc->wrap_s_clamp = 1;
break;
case PIPE_TEX_WRAP_CLAMP_TO_EDGE:
case PIPE_TEX_WRAP_CLAMP_TO_BORDER:
- desc[2] |= 0x2000;
+ desc->wrap_s_clamp_to_edge = 1;
break;
case PIPE_TEX_WRAP_MIRROR_REPEAT:
- desc[2] |= 0x8000;
+ desc->wrap_s_mirror_repeat = 1;
break;
case PIPE_TEX_WRAP_REPEAT:
default:
}
/* Only clamp, clamp to edge, repeat and mirror repeat are supported */
- desc[2] &= ~0x070000;
switch (sampler->base.wrap_t) {
case PIPE_TEX_WRAP_CLAMP:
- desc[2] |= 0x020000;
+ desc->wrap_t_clamp = 1;
break;
case PIPE_TEX_WRAP_CLAMP_TO_EDGE:
case PIPE_TEX_WRAP_CLAMP_TO_BORDER:
- desc[2] |= 0x010000;
+ desc->wrap_t_clamp_to_edge = 1;
break;
case PIPE_TEX_WRAP_MIRROR_REPEAT:
- desc[2] |= 0x040000;
+ desc->wrap_t_mirror_repeat = 1;
break;
case PIPE_TEX_WRAP_REPEAT:
default:
break;
}
+ if (desc->min_img_filter_nearest && desc->mag_img_filter_nearest &&
+ desc->min_mipfilter_2 == 0 &&
+ (desc->min_lod != desc->max_lod))
+ lod_bias_delta = -1;
+
+ desc->lod_bias += lod_bias_delta;
+
lima_texture_desc_set_res(ctx, desc, texture->base.texture,
first_level, last_level);
}
+static unsigned
+lima_calc_tex_desc_size(struct lima_sampler_view *texture)
+{
+ unsigned size = offsetof(lima_tex_desc, va);
+ unsigned va_bit_size;
+ unsigned first_level = texture->base.u.tex.first_level;
+ unsigned last_level = texture->base.u.tex.last_level;
+
+ if (last_level - first_level >= LIMA_MAX_MIP_LEVELS)
+ last_level = first_level + LIMA_MAX_MIP_LEVELS - 1;
+
+ va_bit_size = VA_BIT_OFFSET + VA_BIT_SIZE * (last_level - first_level + 1);
+ size += (va_bit_size + 7) >> 3;
+ size = align(size, lima_min_tex_desc_size);
+
+ return size;
+}
+
void
lima_update_textures(struct lima_context *ctx)
{
if (!lima_tex->num_samplers || !lima_tex->num_textures)
return;
- unsigned size = lima_tex_list_size + lima_tex->num_samplers * lima_tex_desc_size;
+ /* we always need to add texture bo to submit */
+ for (int i = 0; i < lima_tex->num_samplers; i++) {
+ struct lima_sampler_view *texture = lima_sampler_view(lima_tex->textures[i]);
+ struct lima_resource *rsc = lima_resource(texture->base.texture);
+ lima_submit_add_bo(ctx->pp_submit, rsc->bo, LIMA_SUBMIT_BO_READ);
+ }
+
+ /* do not regenerate texture desc if no change */
+ if (!(ctx->dirty & LIMA_CONTEXT_DIRTY_TEXTURES))
+ return;
+
+ unsigned size = lima_tex_list_size;
+ for (int i = 0; i < lima_tex->num_samplers; i++) {
+ struct lima_sampler_view *texture = lima_sampler_view(lima_tex->textures[i]);
+ size += lima_calc_tex_desc_size(texture);
+ }
+
uint32_t *descs =
- lima_ctx_buff_alloc(ctx, lima_ctx_buff_pp_tex_desc, size, true);
+ lima_ctx_buff_alloc(ctx, lima_ctx_buff_pp_tex_desc, size);
+ off_t offset = lima_tex_list_size;
for (int i = 0; i < lima_tex->num_samplers; i++) {
- off_t offset = lima_tex_desc_size * i + lima_tex_list_size;
struct lima_sampler_state *sampler = lima_sampler_state(lima_tex->samplers[i]);
struct lima_sampler_view *texture = lima_sampler_view(lima_tex->textures[i]);
+ unsigned desc_size = lima_calc_tex_desc_size(texture);
descs[i] = lima_ctx_buff_va(ctx, lima_ctx_buff_pp_tex_desc,
LIMA_CTX_BUFF_SUBMIT_PP) + offset;
- lima_update_tex_desc(ctx, sampler, texture, (void *)descs + offset);
+ lima_update_tex_desc(ctx, sampler, texture, (void *)descs + offset, desc_size);
+ offset += desc_size;
}
lima_dump_command_stream_print(
descs, size, false, "add textures_desc at va %x\n",
lima_ctx_buff_va(ctx, lima_ctx_buff_pp_tex_desc, 0));
+
+ lima_dump_texture_descriptor(
+ descs, size,
+ lima_ctx_buff_va(ctx, lima_ctx_buff_pp_tex_desc, 0) + lima_tex_list_size,
+ lima_tex_list_size);
}