panfrost: Move pool routines to common code
[mesa.git] / src / gallium / drivers / panfrost / pan_cmdstream.c
index aa82d0ca3391d75449d5c7ae5087245b6d2cae11..e761c63c38b0ba59bbab7ad5f83ee3cc1d8f0d34 100644 (file)
@@ -28,7 +28,7 @@
 
 #include "panfrost-quirks.h"
 
-#include "pan_allocate.h"
+#include "pan_pool.h"
 #include "pan_bo.h"
 #include "pan_cmdstream.h"
 #include "pan_context.h"
@@ -64,7 +64,7 @@ panfrost_vt_emit_shared_memory(struct panfrost_context *ctx,
                 .scratchpad = panfrost_batch_get_scratchpad(batch, shift, dev->thread_tls_alloc, dev->core_count)->gpu,
                 .shared_workgroup_count = ~0,
         };
-        postfix->shared_memory = panfrost_upload_transient(batch, &shared, sizeof(shared));
+        postfix->shared_memory = panfrost_pool_upload(&batch->pool, &shared, sizeof(shared));
 }
 
 static void
@@ -81,7 +81,7 @@ panfrost_vt_attach_framebuffer(struct panfrost_context *ctx,
                         sizeof(struct mali_single_framebuffer) :
                         sizeof(struct mali_framebuffer);
 
-                batch->framebuffer = panfrost_allocate_transient(batch, size);
+                batch->framebuffer = panfrost_pool_alloc(&batch->pool, size);
 
                 /* Tag the pointer */
                 if (!(dev->quirks & MIDGARD_SFBD))
@@ -134,10 +134,15 @@ panfrost_vt_update_occlusion_query(struct panfrost_context *ctx,
                                    struct mali_vertex_tiler_postfix *postfix)
 {
         SET_BIT(postfix->gl_enables, MALI_OCCLUSION_QUERY, ctx->occlusion_query);
-        if (ctx->occlusion_query)
+        if (ctx->occlusion_query) {
                 postfix->occlusion_counter = ctx->occlusion_query->bo->gpu;
-        else
+                panfrost_batch_add_bo(ctx->batch, ctx->occlusion_query->bo,
+                                      PAN_BO_ACCESS_SHARED |
+                                      PAN_BO_ACCESS_RW |
+                                      PAN_BO_ACCESS_FRAGMENT);
+        } else {
                 postfix->occlusion_counter = 0;
+        }
 }
 
 void
@@ -226,7 +231,7 @@ panfrost_get_index_buffer_bounded(struct panfrost_context *ctx,
         } else {
                 /* Otherwise, we need to upload to transient memory */
                 const uint8_t *ibuf8 = (const uint8_t *) info->index.user;
-                out = panfrost_upload_transient(batch, ibuf8 + offset,
+                out = panfrost_pool_upload(&batch->pool, ibuf8 + offset,
                                                 info->count *
                                                 info->index_size);
         }
@@ -550,6 +555,8 @@ panfrost_frag_meta_rasterizer_update(struct panfrost_context *ctx,
                 fragmeta->depth_factor = 0.0f;
                 SET_BIT(fragmeta->unknown2_4, MALI_DEPTH_RANGE_A, false);
                 SET_BIT(fragmeta->unknown2_4, MALI_DEPTH_RANGE_B, false);
+                SET_BIT(fragmeta->unknown2_3, MALI_DEPTH_CLIP_NEAR, true);
+                SET_BIT(fragmeta->unknown2_3, MALI_DEPTH_CLIP_FAR, true);
                 return;
         }
 
@@ -567,6 +574,9 @@ panfrost_frag_meta_rasterizer_update(struct panfrost_context *ctx,
 
         SET_BIT(fragmeta->unknown2_4, MALI_DEPTH_RANGE_A, rast->offset_tri);
         SET_BIT(fragmeta->unknown2_4, MALI_DEPTH_RANGE_B, rast->offset_tri);
+
+        SET_BIT(fragmeta->unknown2_3, MALI_DEPTH_CLIP_NEAR, rast->depth_clip_near);
+        SET_BIT(fragmeta->unknown2_3, MALI_DEPTH_CLIP_FAR, rast->depth_clip_far);
 }
 
 static void
@@ -662,6 +672,9 @@ panfrost_frag_meta_blend_update(struct panfrost_context *ctx,
                 (dev->quirks & MIDGARD_SFBD) && ctx->blend &&
                 !ctx->blend->base.dither);
 
+        SET_BIT(fragmeta->unknown2_4, MALI_ALPHA_TO_COVERAGE,
+                        ctx->blend->base.alpha_to_coverage);
+
         /* Get blending setup */
         unsigned rt_count = MAX2(ctx->pipe_framebuffer.nr_cbufs, 1);
 
@@ -825,8 +838,10 @@ panfrost_frag_shader_meta_init(struct panfrost_context *ctx,
 
         fs = panfrost_get_shader_state(ctx, PIPE_SHADER_FRAGMENT);
 
-        fragmeta->alpha_coverage = ~MALI_ALPHA_COVERAGE(0.000000);
-        fragmeta->unknown2_3 = MALI_DEPTH_FUNC(MALI_FUNC_ALWAYS) | 0x3010;
+        bool msaa = ctx->rasterizer && ctx->rasterizer->base.multisample;
+        fragmeta->coverage_mask = (msaa ? ctx->sample_mask : ~0) & 0xF;
+
+        fragmeta->unknown2_3 = MALI_DEPTH_FUNC(MALI_FUNC_ALWAYS) | 0x10;
         fragmeta->unknown2_4 = 0x4e0;
 
         /* unknown2_4 has 0x10 bit set on T6XX and T720. We don't know why this
@@ -845,7 +860,8 @@ panfrost_frag_shader_meta_init(struct panfrost_context *ctx,
 
                 SET_BIT(fragmeta->midgard1.flags_lo, MALI_EARLY_Z,
                         !fs->can_discard && !fs->writes_global &&
-                        !fs->writes_depth && !fs->writes_stencil);
+                        !fs->writes_depth && !fs->writes_stencil &&
+                        !ctx->blend->base.alpha_to_coverage);
 
                 /* Add the writes Z/S flags if needed. */
                 SET_BIT(fragmeta->midgard1.flags_lo, MALI_WRITES_Z, fs->writes_depth);
@@ -918,7 +934,7 @@ panfrost_emit_shader_meta(struct panfrost_batch *batch,
 
                 panfrost_frag_shader_meta_init(ctx, &meta, rts);
 
-                xfer = panfrost_allocate_transient(batch, desc_size);
+                xfer = panfrost_pool_alloc(&batch->pool, desc_size);
 
                 memcpy(xfer.cpu, &meta, sizeof(meta));
                 memcpy(xfer.cpu + sizeof(meta), rts, rt_size * rt_count);
@@ -928,7 +944,7 @@ panfrost_emit_shader_meta(struct panfrost_batch *batch,
 
                 shader_ptr = xfer.gpu;
         } else {
-                shader_ptr = panfrost_upload_transient(batch, &meta,
+                shader_ptr = panfrost_pool_upload(&batch->pool, &meta,
                                                        sizeof(meta));
         }
 
@@ -1024,8 +1040,16 @@ panfrost_mali_viewport_init(struct panfrost_context *ctx,
         mvp->viewport0[1] = miny;
         mvp->viewport1[1] = MALI_POSITIVE(maxy);
 
-        mvp->clip_minz = minz;
-        mvp->clip_maxz = maxz;
+        bool clip_near = true;
+        bool clip_far = true;
+
+        if (ctx->rasterizer) {
+                clip_near = ctx->rasterizer->base.depth_clip_near;
+                clip_far = ctx->rasterizer->base.depth_clip_far;
+        }
+
+        mvp->clip_minz = clip_near ? minz : -INFINITY;
+        mvp->clip_maxz = clip_far ? maxz : INFINITY;
 }
 
 void
@@ -1047,7 +1071,7 @@ panfrost_emit_viewport(struct panfrost_batch *batch,
                                              mvp.viewport1[0] + 1,
                                              mvp.viewport1[1] + 1);
 
-        tiler_postfix->viewport = panfrost_upload_transient(batch, &mvp,
+        tiler_postfix->viewport = panfrost_pool_upload(&batch->pool, &mvp,
                                                             sizeof(mvp));
 }
 
@@ -1070,7 +1094,7 @@ panfrost_map_constant_buffer_gpu(struct panfrost_batch *batch,
                  * PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT */
                 return rsrc->bo->gpu + cb->buffer_offset;
         } else if (cb->user_buffer) {
-                return panfrost_upload_transient(batch,
+                return panfrost_pool_upload(&batch->pool,
                                                  cb->user_buffer +
                                                  cb->buffer_offset,
                                                  cb->buffer_size);
@@ -1275,7 +1299,7 @@ panfrost_emit_const_buf(struct panfrost_batch *batch,
         size_t sys_size = sizeof(float) * 4 * ss->sysval_count;
         size_t uniform_size = has_uniforms ? (buf->cb[0].buffer_size) : 0;
         size_t size = sys_size + uniform_size;
-        struct panfrost_transfer transfer = panfrost_allocate_transient(batch,
+        struct panfrost_transfer transfer = panfrost_pool_alloc(&batch->pool,
                                                                         size);
 
         /* Upload sysvals requested by the shader */
@@ -1321,7 +1345,7 @@ panfrost_emit_const_buf(struct panfrost_batch *batch,
                 ubos[ubo] = MALI_MAKE_UBO(aligned / bytes_per_field, gpu);
         }
 
-        mali_ptr ubufs = panfrost_upload_transient(batch, ubos, sz);
+        mali_ptr ubufs = panfrost_pool_upload(&batch->pool, ubos, sz);
         postfix->uniforms = transfer.gpu;
         postfix->uniform_buffers = ubufs;
 
@@ -1354,7 +1378,7 @@ panfrost_emit_shared_memory(struct panfrost_batch *batch,
                 .shared_shift = util_logbase2(single_size) - 1
         };
 
-        vtp->postfix.shared_memory = panfrost_upload_transient(batch, &shared,
+        vtp->postfix.shared_memory = panfrost_pool_upload(&batch->pool, &shared,
                                                                sizeof(shared));
 }
 
@@ -1387,7 +1411,8 @@ panfrost_update_sampler_view(struct panfrost_sampler_view *view,
                              struct pipe_context *pctx)
 {
         struct panfrost_resource *rsrc = pan_resource(view->base.texture);
-        if (view->layout != rsrc->layout) {
+        if (view->texture_bo != rsrc->bo->gpu ||
+            view->layout != rsrc->layout) {
                 panfrost_bo_unreference(view->bo);
                 panfrost_create_sampler_view_bo(view, pctx, &rsrc->base);
         }
@@ -1429,7 +1454,7 @@ panfrost_emit_texture_descriptors(struct panfrost_batch *batch,
                         memcpy(&descriptors[i], view->bifrost_descriptor, sizeof(*view->bifrost_descriptor));
                 }
 
-                postfix->textures = panfrost_upload_transient(batch,
+                postfix->textures = panfrost_pool_upload(&batch->pool,
                                                               descriptors,
                                                               sizeof(struct bifrost_texture_descriptor) *
                                                                       ctx->sampler_view_count[stage]);
@@ -1446,7 +1471,7 @@ panfrost_emit_texture_descriptors(struct panfrost_batch *batch,
                         trampolines[i] = panfrost_get_tex_desc(batch, stage, view);
                 }
 
-                postfix->textures = panfrost_upload_transient(batch,
+                postfix->textures = panfrost_pool_upload(&batch->pool,
                                                               trampolines,
                                                               sizeof(uint64_t) *
                                                               ctx->sampler_view_count[stage]);
@@ -1467,7 +1492,7 @@ panfrost_emit_sampler_descriptors(struct panfrost_batch *batch,
         if (device->quirks & IS_BIFROST) {
                 size_t desc_size = sizeof(struct bifrost_sampler_descriptor);
                 size_t transfer_size = desc_size * ctx->sampler_count[stage];
-                struct panfrost_transfer transfer = panfrost_allocate_transient(batch,
+                struct panfrost_transfer transfer = panfrost_pool_alloc(&batch->pool,
                                                                                 transfer_size);
                 struct bifrost_sampler_descriptor *desc = (struct bifrost_sampler_descriptor *)transfer.cpu;
 
@@ -1478,7 +1503,7 @@ panfrost_emit_sampler_descriptors(struct panfrost_batch *batch,
         } else {
                 size_t desc_size = sizeof(struct mali_sampler_descriptor);
                 size_t transfer_size = desc_size * ctx->sampler_count[stage];
-                struct panfrost_transfer transfer = panfrost_allocate_transient(batch,
+                struct panfrost_transfer transfer = panfrost_pool_alloc(&batch->pool,
                                                                                 transfer_size);
                 struct mali_sampler_descriptor *desc = (struct mali_sampler_descriptor *)transfer.cpu;
 
@@ -1501,7 +1526,7 @@ panfrost_emit_vertex_attr_meta(struct panfrost_batch *batch,
         struct panfrost_vertex_state *so = ctx->vertex;
 
         panfrost_vertex_state_upd_attr_offs(ctx, vertex_postfix);
-        vertex_postfix->attribute_meta = panfrost_upload_transient(batch, so->hw,
+        vertex_postfix->attribute_meta = panfrost_pool_upload(&batch->pool, so->hw,
                                                                sizeof(*so->hw) *
                                                                PAN_MAX_ATTRIBUTE);
 }
@@ -1610,7 +1635,7 @@ panfrost_emit_vertex_data(struct panfrost_batch *batch,
 
         /* Upload whatever we emitted and go */
 
-        vertex_postfix->attributes = panfrost_upload_transient(batch, attrs,
+        vertex_postfix->attributes = panfrost_pool_upload(&batch->pool, attrs,
                                                            k * sizeof(*attrs));
 }
 
@@ -1623,7 +1648,7 @@ panfrost_emit_varyings(struct panfrost_batch *batch, union mali_attr *slot,
         slot->size = stride * count;
         slot->shift = slot->extra_flags = 0;
 
-        struct panfrost_transfer transfer = panfrost_allocate_transient(batch,
+        struct panfrost_transfer transfer = panfrost_pool_alloc(&batch->pool,
                                                                         slot->size);
 
         slot->elements = transfer.gpu | MALI_ATTR_LINEAR;
@@ -2038,7 +2063,7 @@ panfrost_emit_varying_descriptor(struct panfrost_batch *batch,
         vs_size = sizeof(struct mali_attr_meta) * vs->varying_count;
         fs_size = sizeof(struct mali_attr_meta) * fs->varying_count;
 
-        struct panfrost_transfer trans = panfrost_allocate_transient(batch,
+        struct panfrost_transfer trans = panfrost_pool_alloc(&batch->pool,
                                                                      vs_size +
                                                                      fs_size);
 
@@ -2086,7 +2111,7 @@ panfrost_emit_varying_descriptor(struct panfrost_batch *batch,
         }
 
         unsigned xfb_base = pan_xfb_base(present);
-        struct panfrost_transfer T = panfrost_allocate_transient(batch,
+        struct panfrost_transfer T = panfrost_pool_alloc(&batch->pool,
                         sizeof(union mali_attr) * (xfb_base + ctx->streamout.num_targets));
         union mali_attr *varyings = (union mali_attr *) T.cpu;
 
@@ -2252,5 +2277,5 @@ panfrost_emit_sample_locations(struct panfrost_batch *batch)
             0, 0,
         };
 
-        return panfrost_upload_transient(batch, locations, 96 * sizeof(uint16_t));
+        return panfrost_pool_upload(&batch->pool, locations, 96 * sizeof(uint16_t));
 }