radeonsi: add/update assertions for 32-bit address space
[mesa.git] / src / gallium / drivers / radeon / r600_buffer_common.c
index 92521f4779273c8616394634c4d2856b62a5f4bd..2106b9b3a5ef964aebc0fb4e38bf63123d6bcbe6 100644 (file)
@@ -21,6 +21,7 @@
  * USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
+#include "radeonsi/si_pipe.h"
 #include "r600_cs.h"
 #include "util/u_memory.h"
 #include "util/u_upload_mgr.h"
@@ -63,7 +64,7 @@ void *si_buffer_map_sync_with_rings(struct r600_common_context *ctx,
            ctx->ws->cs_is_buffer_referenced(ctx->gfx.cs,
                                             resource->buf, rusage)) {
                if (usage & PIPE_TRANSFER_DONTBLOCK) {
-                       ctx->gfx.flush(ctx, RADEON_FLUSH_ASYNC, NULL);
+                       ctx->gfx.flush(ctx, PIPE_FLUSH_ASYNC, NULL);
                        return NULL;
                } else {
                        ctx->gfx.flush(ctx, 0, NULL);
@@ -74,7 +75,7 @@ void *si_buffer_map_sync_with_rings(struct r600_common_context *ctx,
            ctx->ws->cs_is_buffer_referenced(ctx->dma.cs,
                                             resource->buf, rusage)) {
                if (usage & PIPE_TRANSFER_DONTBLOCK) {
-                       ctx->dma.flush(ctx, RADEON_FLUSH_ASYNC, NULL);
+                       ctx->dma.flush(ctx, PIPE_FLUSH_ASYNC, NULL);
                        return NULL;
                } else {
                        ctx->dma.flush(ctx, 0, NULL);
@@ -98,7 +99,7 @@ void *si_buffer_map_sync_with_rings(struct r600_common_context *ctx,
        return ctx->ws->buffer_map(resource->buf, NULL, usage);
 }
 
-void si_init_resource_fields(struct r600_common_screen *rscreen,
+void si_init_resource_fields(struct si_screen *sscreen,
                             struct r600_resource *res,
                             uint64_t size, unsigned alignment)
 {
@@ -123,8 +124,8 @@ void si_init_resource_fields(struct r600_common_screen *rscreen,
                /* Older kernels didn't always flush the HDP cache before
                 * CS execution
                 */
-               if (rscreen->info.drm_major == 2 &&
-                   rscreen->info.drm_minor < 40) {
+               if (sscreen->info.drm_major == 2 &&
+                   sscreen->info.drm_minor < 40) {
                        res->domains = RADEON_DOMAIN_GTT;
                        res->flags |= RADEON_FLAG_GTT_WC;
                        break;
@@ -151,14 +152,14 @@ void si_init_resource_fields(struct r600_common_screen *rscreen,
                 * ensures all CPU writes finish before the GPU
                 * executes a command stream.
                 */
-               if (rscreen->info.drm_major == 2 &&
-                   rscreen->info.drm_minor < 40)
+               if (sscreen->info.drm_major == 2 &&
+                   sscreen->info.drm_minor < 40)
                        res->domains = RADEON_DOMAIN_GTT;
        }
 
        /* Tiled textures are unmappable. Always put them in VRAM. */
        if ((res->b.b.target != PIPE_BUFFER && !rtex->surface.is_linear) ||
-           res->flags & R600_RESOURCE_FLAG_UNMAPPABLE) {
+           res->b.b.flags & R600_RESOURCE_FLAG_UNMAPPABLE) {
                res->domains = RADEON_DOMAIN_VRAM;
                res->flags |= RADEON_FLAG_NO_CPU_ACCESS |
                         RADEON_FLAG_GTT_WC;
@@ -170,45 +171,40 @@ void si_init_resource_fields(struct r600_common_screen *rscreen,
        else
                res->flags |= RADEON_FLAG_NO_INTERPROCESS_SHARING;
 
-       /* If VRAM is just stolen system memory, allow both VRAM and
-        * GTT, whichever has free space. If a buffer is evicted from
-        * VRAM to GTT, it will stay there.
-        *
-        * DRM 3.6.0 has good BO move throttling, so we can allow VRAM-only
-        * placements even with a low amount of stolen VRAM.
-        */
-       if (!rscreen->info.has_dedicated_vram &&
-           (rscreen->info.drm_major < 3 || rscreen->info.drm_minor < 6) &&
-           res->domains == RADEON_DOMAIN_VRAM) {
-               res->domains = RADEON_DOMAIN_VRAM_GTT;
-               res->flags &= ~RADEON_FLAG_NO_CPU_ACCESS; /* disallowed with VRAM_GTT */
-       }
-
-       if (rscreen->debug_flags & DBG(NO_WC))
+       if (sscreen->debug_flags & DBG(NO_WC))
                res->flags &= ~RADEON_FLAG_GTT_WC;
 
+       if (res->b.b.flags & R600_RESOURCE_FLAG_READ_ONLY)
+               res->flags |= RADEON_FLAG_READ_ONLY;
+
+       if (res->b.b.flags & R600_RESOURCE_FLAG_32BIT)
+               res->flags |= RADEON_FLAG_32BIT;
+
        /* Set expected VRAM and GART usage for the buffer. */
        res->vram_usage = 0;
        res->gart_usage = 0;
+       res->max_forced_staging_uploads = 0;
+       res->b.max_forced_staging_uploads = 0;
 
        if (res->domains & RADEON_DOMAIN_VRAM) {
                res->vram_usage = size;
 
+               res->max_forced_staging_uploads =
                res->b.max_forced_staging_uploads =
-                       rscreen->info.has_dedicated_vram &&
-                       size >= rscreen->info.vram_vis_size / 4 ? 1 : 0;
+                       sscreen->info.has_dedicated_vram &&
+                       size >= sscreen->info.vram_vis_size / 4 ? 1 : 0;
        } else if (res->domains & RADEON_DOMAIN_GTT) {
                res->gart_usage = size;
        }
 }
 
-bool si_alloc_resource(struct r600_common_screen *rscreen,
+bool si_alloc_resource(struct si_screen *sscreen,
                       struct r600_resource *res)
 {
        struct pb_buffer *old_buf, *new_buf;
 
        /* Allocate a new resource. */
-       new_buf = rscreen->ws->buffer_create(rscreen->ws, res->bo_size,
+       new_buf = sscreen->ws->buffer_create(sscreen->ws, res->bo_size,
                                             res->bo_alignment,
                                             res->domains, res->flags);
        if (!new_buf) {
@@ -222,10 +218,21 @@ bool si_alloc_resource(struct r600_common_screen *rscreen,
        old_buf = res->buf;
        res->buf = new_buf; /* should be atomic */
 
-       if (rscreen->info.has_virtual_memory)
-               res->gpu_address = rscreen->ws->buffer_get_virtual_address(res->buf);
-       else
+       if (sscreen->info.has_virtual_memory) {
+               res->gpu_address = sscreen->ws->buffer_get_virtual_address(res->buf);
+
+               if (res->flags & RADEON_FLAG_32BIT) {
+                       uint64_t start = res->gpu_address;
+                       uint64_t last = start + res->bo_size - 1;
+                       (void)start;
+                       (void)last;
+
+                       assert((start >> 32) == sscreen->info.address32_hi);
+                       assert((last >> 32) == sscreen->info.address32_hi);
+               }
+       } else {
                res->gpu_address = 0;
+       }
 
        pb_reference(&old_buf, NULL);
 
@@ -233,7 +240,7 @@ bool si_alloc_resource(struct r600_common_screen *rscreen,
        res->TC_L2_dirty = false;
 
        /* Print debug information. */
-       if (rscreen->debug_flags & DBG(VM) && res->b.b.target == PIPE_BUFFER) {
+       if (sscreen->debug_flags & DBG(VM) && res->b.b.target == PIPE_BUFFER) {
                fprintf(stderr, "VM start=0x%"PRIX64"  end=0x%"PRIX64" | Buffer %"PRIu64" bytes\n",
                        res->gpu_address, res->gpu_address + res->buf->size,
                        res->buf->size);
@@ -295,6 +302,7 @@ void si_replace_buffer_storage(struct pipe_context *ctx,
        rdst->gpu_address = rsrc->gpu_address;
        rdst->b.b.bind = rsrc->b.b.bind;
        rdst->b.max_forced_staging_uploads = rsrc->b.max_forced_staging_uploads;
+       rdst->max_forced_staging_uploads = rsrc->max_forced_staging_uploads;
        rdst->flags = rsrc->flags;
 
        assert(rdst->vram_usage == rsrc->vram_usage);
@@ -306,8 +314,8 @@ void si_replace_buffer_storage(struct pipe_context *ctx,
        rctx->rebind_buffer(ctx, dst, old_gpu_address);
 }
 
-void si_invalidate_resource(struct pipe_context *ctx,
-                           struct pipe_resource *resource)
+static void si_invalidate_resource(struct pipe_context *ctx,
+                                  struct pipe_resource *resource)
 {
        struct r600_common_context *rctx = (struct r600_common_context*)ctx;
        struct r600_resource *rbuffer = r600_resource(resource);
@@ -347,17 +355,6 @@ static void *r600_buffer_get_transfer(struct pipe_context *ctx,
        return data;
 }
 
-static bool r600_can_dma_copy_buffer(struct r600_common_context *rctx,
-                                    unsigned dstx, unsigned srcx, unsigned size)
-{
-       bool dword_aligned = !(dstx % 4) && !(srcx % 4) && !(size % 4);
-
-       return rctx->screen->has_cp_dma ||
-              (dword_aligned && (rctx->dma.cs ||
-                                 rctx->screen->has_streamout));
-
-}
-
 static void *r600_buffer_transfer_map(struct pipe_context *ctx,
                                       struct pipe_resource *resource,
                                       unsigned level,
@@ -366,7 +363,6 @@ static void *r600_buffer_transfer_map(struct pipe_context *ctx,
                                       struct pipe_transfer **ptransfer)
 {
        struct r600_common_context *rctx = (struct r600_common_context*)ctx;
-       struct r600_common_screen *rscreen = (struct r600_common_screen*)ctx->screen;
        struct r600_resource *rbuffer = r600_resource(resource);
        uint8_t *data;
 
@@ -402,6 +398,23 @@ static void *r600_buffer_transfer_map(struct pipe_context *ctx,
                usage |= PIPE_TRANSFER_DISCARD_WHOLE_RESOURCE;
        }
 
+       /* If a buffer in VRAM is too large and the range is discarded, don't
+        * map it directly. This makes sure that the buffer stays in VRAM.
+        */
+       bool force_discard_range = false;
+       if (usage & (PIPE_TRANSFER_DISCARD_WHOLE_RESOURCE |
+                    PIPE_TRANSFER_DISCARD_RANGE) &&
+           !(usage & PIPE_TRANSFER_PERSISTENT) &&
+           /* Try not to decrement the counter if it's not positive. Still racy,
+            * but it makes it harder to wrap the counter from INT_MIN to INT_MAX. */
+           rbuffer->max_forced_staging_uploads > 0 &&
+           p_atomic_dec_return(&rbuffer->max_forced_staging_uploads) >= 0) {
+               usage &= ~(PIPE_TRANSFER_DISCARD_WHOLE_RESOURCE |
+                          PIPE_TRANSFER_UNSYNCHRONIZED);
+               usage |= PIPE_TRANSFER_DISCARD_RANGE;
+               force_discard_range = true;
+       }
+
        if (usage & PIPE_TRANSFER_DISCARD_WHOLE_RESOURCE &&
            !(usage & (PIPE_TRANSFER_UNSYNCHRONIZED |
                       TC_TRANSFER_MAP_NO_INVALIDATE))) {
@@ -417,16 +430,15 @@ static void *r600_buffer_transfer_map(struct pipe_context *ctx,
        }
 
        if ((usage & PIPE_TRANSFER_DISCARD_RANGE) &&
-           !(rscreen->debug_flags & DBG(NO_DISCARD_RANGE)) &&
            ((!(usage & (PIPE_TRANSFER_UNSYNCHRONIZED |
-                        PIPE_TRANSFER_PERSISTENT)) &&
-             r600_can_dma_copy_buffer(rctx, box->x, 0, box->width)) ||
+                        PIPE_TRANSFER_PERSISTENT))) ||
             (rbuffer->flags & RADEON_FLAG_SPARSE))) {
                assert(usage & PIPE_TRANSFER_WRITE);
 
                /* Check if mapping this buffer would cause waiting for the GPU.
                 */
                if (rbuffer->flags & RADEON_FLAG_SPARSE ||
+                   force_discard_range ||
                    si_rings_is_buffer_referenced(rctx, rbuffer->buf, RADEON_USAGE_READWRITE) ||
                    !rctx->ws->buffer_wait(rbuffer->buf, 0, RADEON_USAGE_READWRITE)) {
                        /* Do a wait-free write-only transfer using a temporary buffer. */
@@ -455,8 +467,7 @@ static void *r600_buffer_transfer_map(struct pipe_context *ctx,
        else if (((usage & PIPE_TRANSFER_READ) &&
                  !(usage & PIPE_TRANSFER_PERSISTENT) &&
                  (rbuffer->domains & RADEON_DOMAIN_VRAM ||
-                  rbuffer->flags & RADEON_FLAG_GTT_WC) &&
-                 r600_can_dma_copy_buffer(rctx, 0, box->x, box->width)) ||
+                  rbuffer->flags & RADEON_FLAG_GTT_WC)) ||
                 (rbuffer->flags & RADEON_FLAG_SPARSE)) {
                struct r600_resource *staging;
 
@@ -555,10 +566,10 @@ static void r600_buffer_transfer_unmap(struct pipe_context *ctx,
        slab_free(&rctx->pool_transfers, transfer);
 }
 
-void si_buffer_subdata(struct pipe_context *ctx,
-                      struct pipe_resource *buffer,
-                      unsigned usage, unsigned offset,
-                      unsigned size, const void *data)
+static void si_buffer_subdata(struct pipe_context *ctx,
+                             struct pipe_resource *buffer,
+                             unsigned usage, unsigned offset,
+                             unsigned size, const void *data)
 {
        struct pipe_transfer *transfer = NULL;
        struct pipe_box box;
@@ -609,19 +620,22 @@ r600_alloc_buffer_struct(struct pipe_screen *screen,
        return rbuffer;
 }
 
-struct pipe_resource *si_buffer_create(struct pipe_screen *screen,
-                                      const struct pipe_resource *templ,
-                                      unsigned alignment)
+static struct pipe_resource *si_buffer_create(struct pipe_screen *screen,
+                                             const struct pipe_resource *templ,
+                                             unsigned alignment)
 {
-       struct r600_common_screen *rscreen = (struct r600_common_screen*)screen;
+       struct si_screen *sscreen = (struct si_screen*)screen;
        struct r600_resource *rbuffer = r600_alloc_buffer_struct(screen, templ);
 
-       si_init_resource_fields(rscreen, rbuffer, templ->width0, alignment);
+       if (templ->flags & PIPE_RESOURCE_FLAG_SPARSE)
+               rbuffer->b.b.flags |= R600_RESOURCE_FLAG_UNMAPPABLE;
+
+       si_init_resource_fields(sscreen, rbuffer, templ->width0, alignment);
 
        if (templ->flags & PIPE_RESOURCE_FLAG_SPARSE)
                rbuffer->flags |= RADEON_FLAG_SPARSE;
 
-       if (!si_alloc_resource(rscreen, rbuffer)) {
+       if (!si_alloc_resource(sscreen, rbuffer)) {
                FREE(rbuffer);
                return NULL;
        }
@@ -649,13 +663,13 @@ struct pipe_resource *si_aligned_buffer_create(struct pipe_screen *screen,
        return si_buffer_create(screen, &buffer, alignment);
 }
 
-struct pipe_resource *
+static struct pipe_resource *
 si_buffer_from_user_memory(struct pipe_screen *screen,
                           const struct pipe_resource *templ,
                           void *user_memory)
 {
-       struct r600_common_screen *rscreen = (struct r600_common_screen*)screen;
-       struct radeon_winsys *ws = rscreen->ws;
+       struct si_screen *sscreen = (struct si_screen*)screen;
+       struct radeon_winsys *ws = sscreen->ws;
        struct r600_resource *rbuffer = r600_alloc_buffer_struct(screen, templ);
 
        rbuffer->domains = RADEON_DOMAIN_GTT;
@@ -671,7 +685,7 @@ si_buffer_from_user_memory(struct pipe_screen *screen,
                return NULL;
        }
 
-       if (rscreen->info.has_virtual_memory)
+       if (sscreen->info.has_virtual_memory)
                rbuffer->gpu_address =
                        ws->buffer_get_virtual_address(rbuffer->buf);
        else
@@ -682,3 +696,30 @@ si_buffer_from_user_memory(struct pipe_screen *screen,
 
        return &rbuffer->b.b;
 }
+
+static struct pipe_resource *si_resource_create(struct pipe_screen *screen,
+                                               const struct pipe_resource *templ)
+{
+       if (templ->target == PIPE_BUFFER) {
+               return si_buffer_create(screen, templ, 256);
+       } else {
+               return si_texture_create(screen, templ);
+       }
+}
+
+void si_init_screen_buffer_functions(struct si_screen *sscreen)
+{
+       sscreen->b.resource_create = si_resource_create;
+       sscreen->b.resource_destroy = u_resource_destroy_vtbl;
+       sscreen->b.resource_from_user_memory = si_buffer_from_user_memory;
+}
+
+void si_init_buffer_functions(struct si_context *sctx)
+{
+       sctx->b.b.invalidate_resource = si_invalidate_resource;
+       sctx->b.b.transfer_map = u_transfer_map_vtbl;
+       sctx->b.b.transfer_flush_region = u_transfer_flush_region_vtbl;
+       sctx->b.b.transfer_unmap = u_transfer_unmap_vtbl;
+       sctx->b.b.texture_subdata = u_default_texture_subdata;
+       sctx->b.b.buffer_subdata = si_buffer_subdata;
+}