radeonsi: release saved resources in si_compute_copy_image
[mesa.git] / src / gallium / drivers / radeonsi / si_compute_blit.c
index 4c5464ac118c3ac79b66b42d70782c1f0671521e..18dafac1a45d6c6549d1bbcd7058e6e9e17dc070 100644 (file)
@@ -24,7 +24,7 @@
  */
 
 #include "si_pipe.h"
-#include "util/u_format.h"
+#include "util/format/u_format.h"
 #include "util/format_srgb.h"
 
 /* Note: Compute shaders always use SI_COMPUTE_DST_CACHE_POLICY for dst
@@ -73,6 +73,76 @@ static void si_compute_internal_end(struct si_context *sctx)
        sctx->render_cond_force_off = false;
 }
 
+static void si_compute_clear_12bytes_buffer(struct si_context *sctx,
+                                       struct pipe_resource *dst,
+                                       unsigned dst_offset,
+                                       unsigned size,
+                                       const uint32_t *clear_value,
+                                       enum si_coherency coher)
+{
+       struct pipe_context *ctx = &sctx->b;
+
+       assert(dst_offset % 4 == 0);
+       assert(size % 4 == 0);
+       unsigned size_12 = DIV_ROUND_UP(size, 12);
+
+       unsigned data[4] = {0};
+       memcpy(data, clear_value, 12);
+
+       si_compute_internal_begin(sctx);
+
+       sctx->flags |= SI_CONTEXT_PS_PARTIAL_FLUSH |
+                      SI_CONTEXT_CS_PARTIAL_FLUSH |
+                      si_get_flush_flags(sctx, coher, SI_COMPUTE_DST_CACHE_POLICY);
+
+       struct pipe_shader_buffer saved_sb = {0};
+       si_get_shader_buffers(sctx, PIPE_SHADER_COMPUTE, 0, 1, &saved_sb);
+
+       unsigned saved_writable_mask = 0;
+       if (sctx->const_and_shader_buffers[PIPE_SHADER_COMPUTE].writable_mask &
+           (1u << si_get_shaderbuf_slot(0)))
+               saved_writable_mask = 1;
+
+       struct pipe_constant_buffer saved_cb = {};
+       si_get_pipe_constant_buffer(sctx, PIPE_SHADER_COMPUTE, 0, &saved_cb);
+
+       void *saved_cs = sctx->cs_shader_state.program;
+
+       struct pipe_constant_buffer cb = {};
+       cb.buffer_size = sizeof(data);
+       cb.user_buffer = data;
+       ctx->set_constant_buffer(ctx, PIPE_SHADER_COMPUTE, 0, &cb);
+
+       struct pipe_shader_buffer sb = {0};
+       sb.buffer = dst;
+       sb.buffer_offset = dst_offset;
+       sb.buffer_size = size;
+
+       ctx->set_shader_buffers(ctx, PIPE_SHADER_COMPUTE, 0, 1, &sb, 0x1);
+
+       struct pipe_grid_info info = {0};
+
+       if (!sctx->cs_clear_12bytes_buffer)
+               sctx->cs_clear_12bytes_buffer =
+                       si_clear_12bytes_buffer_shader(ctx);
+       ctx->bind_compute_state(ctx, sctx->cs_clear_12bytes_buffer);
+       info.block[0] = 64;
+       info.last_block[0] = size_12 % 64;
+       info.block[1] = 1;
+       info.block[2] = 1;
+       info.grid[0] = DIV_ROUND_UP(size_12, 64);
+       info.grid[1] = 1;
+       info.grid[2] = 1;
+
+       ctx->launch_grid(ctx, &info);
+
+       ctx->bind_compute_state(ctx, saved_cs);
+       ctx->set_shader_buffers(ctx, PIPE_SHADER_COMPUTE, 0, 1, &saved_sb, saved_writable_mask);
+       ctx->set_constant_buffer(ctx, PIPE_SHADER_COMPUTE, 0, &saved_cb);
+
+       si_compute_internal_end(sctx);
+}
+
 static void si_compute_do_clear_or_copy(struct si_context *sctx,
                                        struct pipe_resource *dst,
                                        unsigned dst_offset,
@@ -117,13 +187,14 @@ static void si_compute_do_clear_or_copy(struct si_context *sctx,
                                           SI_COMPUTE_CLEAR_DW_PER_THREAD;
        unsigned instructions_per_thread = MAX2(1, dwords_per_thread / 4);
        unsigned dwords_per_instruction = dwords_per_thread / instructions_per_thread;
-       unsigned dwords_per_wave = dwords_per_thread * 64;
+       unsigned wave_size = sctx->screen->compute_wave_size;
+       unsigned dwords_per_wave = dwords_per_thread * wave_size;
 
        unsigned num_dwords = size / 4;
        unsigned num_instructions = DIV_ROUND_UP(num_dwords, dwords_per_instruction);
 
        struct pipe_grid_info info = {};
-       info.block[0] = MIN2(64, num_instructions);
+       info.block[0] = MIN2(wave_size, num_instructions);
        info.block[1] = 1;
        info.block[2] = 1;
        info.grid[0] = DIV_ROUND_UP(num_dwords, dwords_per_wave);
@@ -192,7 +263,7 @@ void si_clear_buffer(struct si_context *sctx, struct pipe_resource *dst,
        if (!size)
                return;
 
-       unsigned clear_alignment = MIN2(clear_value_size, 4);
+       ASSERTED unsigned clear_alignment = MIN2(clear_value_size, 4);
 
        assert(clear_value_size != 3 && clear_value_size != 6); /* 12 is allowed. */
        assert(offset % clear_alignment == 0);
@@ -230,17 +301,8 @@ void si_clear_buffer(struct si_context *sctx, struct pipe_resource *dst,
                clear_value_size = 4;
        }
 
-       /* Use transform feedback for 12-byte clears. */
-       /* TODO: Use compute. */
        if (clear_value_size == 12) {
-               union pipe_color_union streamout_clear_value;
-
-               memcpy(&streamout_clear_value, clear_value, clear_value_size);
-               si_blitter_begin(sctx, SI_DISABLE_RENDER_COND);
-               util_blitter_clear_buffer(sctx->blitter, dst, offset,
-                                         size, clear_value_size / 4,
-                                         &streamout_clear_value);
-               si_blitter_end(sctx);
+               si_compute_clear_12bytes_buffer(sctx, dst, offset, size, clear_value, coher);
                return;
        }
 
@@ -424,6 +486,9 @@ void si_compute_copy_image(struct si_context *sctx,
        ctx->set_shader_images(ctx, PIPE_SHADER_COMPUTE, 0, 2, saved_image);
        ctx->set_constant_buffer(ctx, PIPE_SHADER_COMPUTE, 0, &saved_cb);
        si_compute_internal_end(sctx);
+       for (int i = 0; i < 2; i++)
+               pipe_resource_reference(&saved_image[i].resource, NULL);
+       pipe_resource_reference(&saved_cb.buffer, NULL);
 }
 
 void si_retile_dcc(struct si_context *sctx, struct si_texture *tex)
@@ -434,7 +499,7 @@ void si_retile_dcc(struct si_context *sctx, struct si_texture *tex)
                       SI_CONTEXT_CS_PARTIAL_FLUSH |
                       si_get_flush_flags(sctx, SI_COHERENCY_CB_META, L2_LRU) |
                       si_get_flush_flags(sctx, SI_COHERENCY_SHADER, L2_LRU);
-       si_emit_cache_flush(sctx);
+       sctx->emit_cache_flush(sctx);
 
        /* Save states. */
        void *saved_cs = sctx->cs_shader_state.program;
@@ -450,9 +515,9 @@ void si_retile_dcc(struct si_context *sctx, struct si_texture *tex)
        unsigned num_elements = tex->surface.u.gfx9.dcc_retile_num_elements;
        struct pipe_image_view img[3];
 
-       assert(tex->dcc_retile_map_offset && tex->dcc_retile_map_offset <= UINT_MAX);
-       assert(tex->dcc_offset && tex->dcc_offset <= UINT_MAX);
-       assert(tex->display_dcc_offset && tex->display_dcc_offset <= UINT_MAX);
+       assert(tex->surface.dcc_retile_map_offset && tex->surface.dcc_retile_map_offset <= UINT_MAX);
+       assert(tex->surface.dcc_offset && tex->surface.dcc_offset <= UINT_MAX);
+       assert(tex->surface.display_dcc_offset && tex->surface.display_dcc_offset <= UINT_MAX);
 
        for (unsigned i = 0; i < 3; i++) {
                img[i].resource = &tex->buffer.b.b;
@@ -462,15 +527,15 @@ void si_retile_dcc(struct si_context *sctx, struct si_texture *tex)
 
        img[0].format = use_uint16 ? PIPE_FORMAT_R16G16B16A16_UINT :
                                     PIPE_FORMAT_R32G32B32A32_UINT;
-       img[0].u.buf.offset = tex->dcc_retile_map_offset;
+       img[0].u.buf.offset = tex->surface.dcc_retile_map_offset;
        img[0].u.buf.size = num_elements * (use_uint16 ? 2 : 4);
 
        img[1].format = PIPE_FORMAT_R8_UINT;
-       img[1].u.buf.offset = tex->dcc_offset;
+       img[1].u.buf.offset = tex->surface.dcc_offset;
        img[1].u.buf.size = tex->surface.dcc_size;
 
        img[2].format = PIPE_FORMAT_R8_UINT;
-       img[2].u.buf.offset = tex->display_dcc_offset;
+       img[2].u.buf.offset = tex->surface.display_dcc_offset;
        img[2].u.buf.size = tex->surface.u.gfx9.display_dcc_size;
 
        ctx->set_shader_images(ctx, PIPE_SHADER_COMPUTE, 0, 3, img);
@@ -502,6 +567,96 @@ void si_retile_dcc(struct si_context *sctx, struct si_texture *tex)
        /* Restore states. */
        ctx->bind_compute_state(ctx, saved_cs);
        ctx->set_shader_images(ctx, PIPE_SHADER_COMPUTE, 0, 3, saved_img);
+
+       for (unsigned i = 0; i < 3; i++) {
+               pipe_resource_reference(&saved_img[i].resource, NULL);
+       }
+}
+
+/* Expand FMASK to make it identity, so that image stores can ignore it. */
+void si_compute_expand_fmask(struct pipe_context *ctx, struct pipe_resource *tex)
+{
+       struct si_context *sctx = (struct si_context *)ctx;
+       bool is_array = tex->target == PIPE_TEXTURE_2D_ARRAY;
+       unsigned log_fragments = util_logbase2(tex->nr_storage_samples);
+       unsigned log_samples = util_logbase2(tex->nr_samples);
+       assert(tex->nr_samples >= 2);
+
+       /* EQAA FMASK expansion is unimplemented. */
+       if (tex->nr_samples != tex->nr_storage_samples)
+               return;
+
+       si_compute_internal_begin(sctx);
+
+       /* Flush caches and sync engines. */
+       sctx->flags |= SI_CONTEXT_CS_PARTIAL_FLUSH |
+                      si_get_flush_flags(sctx, SI_COHERENCY_SHADER, L2_STREAM);
+       si_make_CB_shader_coherent(sctx, tex->nr_samples, true,
+                                  true /* DCC is not possible with image stores */);
+
+       /* Save states. */
+       void *saved_cs = sctx->cs_shader_state.program;
+       struct pipe_image_view saved_image = {0};
+       util_copy_image_view(&saved_image, &sctx->images[PIPE_SHADER_COMPUTE].views[0]);
+
+       /* Bind the image. */
+       struct pipe_image_view image = {0};
+       image.resource = tex;
+       /* Don't set WRITE so as not to trigger FMASK expansion, causing
+        * an infinite loop. */
+       image.shader_access = image.access = PIPE_IMAGE_ACCESS_READ;
+       image.format = util_format_linear(tex->format);
+       if (is_array)
+               image.u.tex.last_layer = tex->array_size - 1;
+
+       ctx->set_shader_images(ctx, PIPE_SHADER_COMPUTE, 0, 1, &image);
+
+       /* Bind the shader. */
+       void **shader = &sctx->cs_fmask_expand[log_samples - 1][is_array];
+       if (!*shader)
+               *shader = si_create_fmask_expand_cs(ctx, tex->nr_samples, is_array);
+       ctx->bind_compute_state(ctx, *shader);
+
+       /* Dispatch compute. */
+       struct pipe_grid_info info = {0};
+       info.block[0] = 8;
+       info.last_block[0] = tex->width0 % 8;
+       info.block[1] = 8;
+       info.last_block[1] = tex->height0 % 8;
+       info.block[2] = 1;
+       info.grid[0] = DIV_ROUND_UP(tex->width0, 8);
+       info.grid[1] = DIV_ROUND_UP(tex->height0, 8);
+       info.grid[2] = is_array ? tex->array_size : 1;
+
+       ctx->launch_grid(ctx, &info);
+
+       /* Flush caches and sync engines. */
+       sctx->flags |= SI_CONTEXT_CS_PARTIAL_FLUSH |
+                      (sctx->chip_class <= GFX8 ? SI_CONTEXT_WB_L2 : 0) |
+                      si_get_flush_flags(sctx, SI_COHERENCY_SHADER, L2_STREAM);
+
+       /* Restore previous states. */
+       ctx->bind_compute_state(ctx, saved_cs);
+       ctx->set_shader_images(ctx, PIPE_SHADER_COMPUTE, 0, 1, &saved_image);
+       si_compute_internal_end(sctx);
+       pipe_resource_reference(&saved_image.resource, NULL);
+
+       /* Array of fully expanded FMASK values, arranged by [log2(fragments)][log2(samples)-1]. */
+#define INVALID 0 /* never used */
+       static const uint64_t fmask_expand_values[][4] = {
+               /* samples */
+               /* 2 (8 bpp) 4 (8 bpp)   8 (8-32bpp) 16 (16-64bpp)      fragments */
+               {0x02020202, 0x0E0E0E0E, 0xFEFEFEFE, 0xFFFEFFFE},         /* 1 */
+               {0x02020202, 0xA4A4A4A4, 0xAAA4AAA4, 0xAAAAAAA4},         /* 2 */
+               {INVALID,    0xE4E4E4E4, 0x44443210, 0x4444444444443210}, /* 4 */
+               {INVALID,    INVALID,    0x76543210, 0x8888888876543210}, /* 8 */
+       };
+
+       /* Clear FMASK to identity. */
+       struct si_texture *stex = (struct si_texture*)tex;
+       si_clear_buffer(sctx, tex, stex->surface.fmask_offset, stex->surface.fmask_size,
+                       (uint32_t*)&fmask_expand_values[log_fragments][log_samples - 1],
+                       4, SI_COHERENCY_SHADER, false);
 }
 
 void si_init_compute_blit_functions(struct si_context *sctx)
@@ -603,4 +758,6 @@ void si_compute_clear_render_target(struct pipe_context *ctx,
        ctx->set_shader_images(ctx, PIPE_SHADER_COMPUTE, 0, 1, &saved_image);
        ctx->set_constant_buffer(ctx, PIPE_SHADER_COMPUTE, 0, &saved_cb);
        si_compute_internal_end(sctx);
+       pipe_resource_reference(&saved_image.resource, NULL);
+       pipe_resource_reference(&saved_cb.buffer, NULL);
 }