radeonsi/nir: set FS properties only when scanning a fragment shader
[mesa.git] / src / gallium / drivers / radeonsi / si_shader_nir.c
index b6aa79857af1a3cc3576e18756a87ea370b4353c..b4fba8b88123748bcc88a9219d6d3011172a5aae 100644 (file)
@@ -1,5 +1,6 @@
 /*
  * Copyright 2017 Advanced Micro Devices, Inc.
+ * All Rights Reserved.
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
@@ -21,8 +22,8 @@
  * USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "si_shader.h"
 #include "si_shader_internal.h"
+#include "si_pipe.h"
 
 #include "ac_nir_to_llvm.h"
 
 #include "compiler/nir_types.h"
 
 
-static int
-type_size(const struct glsl_type *type)
-{
-   return glsl_count_attribute_slots(type, false);
-}
-
 static void scan_instruction(struct tgsi_shader_info *info,
                             nir_instr *instr)
 {
@@ -62,6 +57,9 @@ static void scan_instruction(struct tgsi_shader_info *info,
                if (!tex->texture) {
                        info->samplers_declared |=
                                u_bit_consecutive(tex->sampler_index, 1);
+               } else {
+                       if (tex->texture->var->data.bindless)
+                               info->uses_bindless_samplers = true;
                }
 
                switch (tex->op) {
@@ -86,6 +84,27 @@ static void scan_instruction(struct tgsi_shader_info *info,
                case nir_intrinsic_load_invocation_id:
                        info->uses_invocationid = true;
                        break;
+               case nir_intrinsic_load_num_work_groups:
+                       info->uses_grid_size = true;
+                       break;
+               case nir_intrinsic_load_local_group_size:
+                       /* The block size is translated to IMM with a fixed block size. */
+                       if (info->properties[TGSI_PROPERTY_CS_FIXED_BLOCK_WIDTH] == 0)
+                               info->uses_block_size = true;
+                       break;
+               case nir_intrinsic_load_local_invocation_id:
+               case nir_intrinsic_load_work_group_id: {
+                       unsigned mask = nir_ssa_def_components_read(&intr->dest.ssa);
+                       while (mask) {
+                               unsigned i = u_bit_scan(&mask);
+
+                               if (intr->intrinsic == nir_intrinsic_load_work_group_id)
+                                       info->uses_block_id[i] = true;
+                               else
+                                       info->uses_thread_id[i] = true;
+                       }
+                       break;
+               }
                case nir_intrinsic_load_vertex_id:
                        info->uses_vertexid = 1;
                        break;
@@ -105,15 +124,30 @@ static void scan_instruction(struct tgsi_shader_info *info,
                case nir_intrinsic_load_tess_level_outer:
                        info->reads_tess_factors = true;
                        break;
-               case nir_intrinsic_image_store:
-               case nir_intrinsic_image_atomic_add:
-               case nir_intrinsic_image_atomic_min:
-               case nir_intrinsic_image_atomic_max:
-               case nir_intrinsic_image_atomic_and:
-               case nir_intrinsic_image_atomic_or:
-               case nir_intrinsic_image_atomic_xor:
-               case nir_intrinsic_image_atomic_exchange:
-               case nir_intrinsic_image_atomic_comp_swap:
+               case nir_intrinsic_image_var_load:
+               case nir_intrinsic_image_var_size:
+               case nir_intrinsic_image_var_samples: {
+                       nir_variable *var = intr->variables[0]->var;
+                       if (var->data.bindless)
+                               info->uses_bindless_images = true;
+
+                       break;
+               }
+               case nir_intrinsic_image_var_store:
+               case nir_intrinsic_image_var_atomic_add:
+               case nir_intrinsic_image_var_atomic_min:
+               case nir_intrinsic_image_var_atomic_max:
+               case nir_intrinsic_image_var_atomic_and:
+               case nir_intrinsic_image_var_atomic_or:
+               case nir_intrinsic_image_var_atomic_xor:
+               case nir_intrinsic_image_var_atomic_exchange:
+               case nir_intrinsic_image_var_atomic_comp_swap: {
+                       nir_variable *var = intr->variables[0]->var;
+                       if (var->data.bindless)
+                               info->uses_bindless_images = true;
+
+                       /* fall-through */
+               }
                case nir_intrinsic_store_ssbo:
                case nir_intrinsic_ssbo_atomic_add:
                case nir_intrinsic_ssbo_atomic_imin:
@@ -222,16 +256,13 @@ void si_nir_scan_shader(const struct nir_shader *nir,
        nir_function *func;
        unsigned i;
 
-       assert(nir->info.stage == MESA_SHADER_VERTEX ||
-              nir->info.stage == MESA_SHADER_GEOMETRY ||
-              nir->info.stage == MESA_SHADER_TESS_CTRL ||
-              nir->info.stage == MESA_SHADER_TESS_EVAL ||
-              nir->info.stage == MESA_SHADER_FRAGMENT);
-
        info->processor = pipe_shader_type_from_mesa(nir->info.stage);
        info->num_tokens = 2; /* indicate that the shader is non-empty */
        info->num_instructions = 2;
 
+       info->properties[TGSI_PROPERTY_NEXT_SHADER] =
+               pipe_shader_type_from_mesa(nir->info.next_stage);
+
        if (nir->info.stage == MESA_SHADER_TESS_CTRL) {
                info->properties[TGSI_PROPERTY_TCS_VERTICES_OUT] =
                        nir->info.tess.tcs_vertices_out;
@@ -261,29 +292,77 @@ void si_nir_scan_shader(const struct nir_shader *nir,
                info->properties[TGSI_PROPERTY_GS_INVOCATIONS] = nir->info.gs.invocations;
        }
 
+       if (nir->info.stage == MESA_SHADER_FRAGMENT) {
+               info->properties[TGSI_PROPERTY_FS_EARLY_DEPTH_STENCIL] =
+                       nir->info.fs.early_fragment_tests | nir->info.fs.post_depth_coverage;
+               info->properties[TGSI_PROPERTY_FS_POST_DEPTH_COVERAGE] = nir->info.fs.post_depth_coverage;
+
+               if (nir->info.fs.pixel_center_integer) {
+                       info->properties[TGSI_PROPERTY_FS_COORD_PIXEL_CENTER] =
+                               TGSI_FS_COORD_PIXEL_CENTER_INTEGER;
+               }
+
+               if (nir->info.fs.depth_layout != FRAG_DEPTH_LAYOUT_NONE) {
+                       switch (nir->info.fs.depth_layout) {
+                       case FRAG_DEPTH_LAYOUT_ANY:
+                               info->properties[TGSI_PROPERTY_FS_DEPTH_LAYOUT] = TGSI_FS_DEPTH_LAYOUT_ANY;
+                               break;
+                       case FRAG_DEPTH_LAYOUT_GREATER:
+                               info->properties[TGSI_PROPERTY_FS_DEPTH_LAYOUT] = TGSI_FS_DEPTH_LAYOUT_GREATER;
+                               break;
+                       case FRAG_DEPTH_LAYOUT_LESS:
+                               info->properties[TGSI_PROPERTY_FS_DEPTH_LAYOUT] = TGSI_FS_DEPTH_LAYOUT_LESS;
+                               break;
+                       case FRAG_DEPTH_LAYOUT_UNCHANGED:
+                               info->properties[TGSI_PROPERTY_FS_DEPTH_LAYOUT] = TGSI_FS_DEPTH_LAYOUT_UNCHANGED;
+                               break;
+                       default:
+                               unreachable("Unknow depth layout");
+                       }
+               }
+       }
+
+       if (nir->info.stage == MESA_SHADER_COMPUTE) {
+               info->properties[TGSI_PROPERTY_CS_FIXED_BLOCK_WIDTH] = nir->info.cs.local_size[0];
+               info->properties[TGSI_PROPERTY_CS_FIXED_BLOCK_HEIGHT] = nir->info.cs.local_size[1];
+               info->properties[TGSI_PROPERTY_CS_FIXED_BLOCK_DEPTH] = nir->info.cs.local_size[2];
+       }
+
        i = 0;
        uint64_t processed_inputs = 0;
        unsigned num_inputs = 0;
        nir_foreach_variable(variable, &nir->inputs) {
                unsigned semantic_name, semantic_index;
-               unsigned attrib_count = glsl_count_attribute_slots(variable->type,
+
+               const struct glsl_type *type = variable->type;
+               if (nir_is_per_vertex_io(variable, nir->info.stage)) {
+                       assert(glsl_type_is_array(type));
+                       type = glsl_get_array_element(type);
+               }
+
+               unsigned attrib_count = glsl_count_attribute_slots(type,
                                                                   nir->info.stage == MESA_SHADER_VERTEX);
 
+               i = variable->data.driver_location;
+
                /* Vertex shader inputs don't have semantics. The state
                 * tracker has already mapped them to attributes via
                 * variable->data.driver_location.
                 */
                if (nir->info.stage == MESA_SHADER_VERTEX) {
-                       if (glsl_type_is_dual_slot(variable->type))
+                       /* TODO: gather the actual input useage and remove this. */
+                       info->input_usage_mask[i] = TGSI_WRITEMASK_XYZW;
+
+                       if (glsl_type_is_dual_slot(variable->type)) {
                                num_inputs += 2;
-                       else
+
+                               /* TODO: gather the actual input useage and remove this. */
+                               info->input_usage_mask[i+1] = TGSI_WRITEMASK_XYZW;
+                       } else
                                num_inputs++;
                        continue;
                }
 
-               assert(nir->info.stage != MESA_SHADER_FRAGMENT ||
-                      (attrib_count == 1 && "not implemented"));
-
                /* Fragment shader position is a system value. */
                if (nir->info.stage == MESA_SHADER_FRAGMENT &&
                    variable->data.location == VARYING_SLOT_POS) {
@@ -295,67 +374,69 @@ void si_nir_scan_shader(const struct nir_shader *nir,
                        continue;
                }
 
-               i = variable->data.driver_location;
-               if (processed_inputs & ((uint64_t)1 << i))
-                       continue;
+               for (unsigned j = 0; j < attrib_count; j++, i++) {
 
-               processed_inputs |= ((uint64_t)1 << i);
-               num_inputs++;
+                       if (processed_inputs & ((uint64_t)1 << i))
+                               continue;
 
-               tgsi_get_gl_varying_semantic(variable->data.location, true,
-                                            &semantic_name, &semantic_index);
+                       processed_inputs |= ((uint64_t)1 << i);
+                       num_inputs++;
 
-               info->input_semantic_name[i] = semantic_name;
-               info->input_semantic_index[i] = semantic_index;
+                       tgsi_get_gl_varying_semantic(variable->data.location + j, true,
+                                                    &semantic_name, &semantic_index);
 
-               if (semantic_name == TGSI_SEMANTIC_PRIMID)
-                       info->uses_primid = true;
+                       info->input_semantic_name[i] = semantic_name;
+                       info->input_semantic_index[i] = semantic_index;
 
-               if (variable->data.sample)
-                       info->input_interpolate_loc[i] = TGSI_INTERPOLATE_LOC_SAMPLE;
-               else if (variable->data.centroid)
-                       info->input_interpolate_loc[i] = TGSI_INTERPOLATE_LOC_CENTROID;
-               else
-                       info->input_interpolate_loc[i] = TGSI_INTERPOLATE_LOC_CENTER;
+                       if (semantic_name == TGSI_SEMANTIC_PRIMID)
+                               info->uses_primid = true;
 
-               enum glsl_base_type base_type =
-                       glsl_get_base_type(glsl_without_array(variable->type));
+                       if (variable->data.sample)
+                               info->input_interpolate_loc[i] = TGSI_INTERPOLATE_LOC_SAMPLE;
+                       else if (variable->data.centroid)
+                               info->input_interpolate_loc[i] = TGSI_INTERPOLATE_LOC_CENTROID;
+                       else
+                               info->input_interpolate_loc[i] = TGSI_INTERPOLATE_LOC_CENTER;
 
-               switch (variable->data.interpolation) {
-               case INTERP_MODE_NONE:
-                       if (glsl_base_type_is_integer(base_type)) {
-                               info->input_interpolate[i] = TGSI_INTERPOLATE_CONSTANT;
-                               break;
-                       }
+                       enum glsl_base_type base_type =
+                               glsl_get_base_type(glsl_without_array(variable->type));
 
-                       if (semantic_name == TGSI_SEMANTIC_COLOR) {
-                               info->input_interpolate[i] = TGSI_INTERPOLATE_COLOR;
-                               break;
-                       }
-                       /* fall-through */
+                       switch (variable->data.interpolation) {
+                       case INTERP_MODE_NONE:
+                               if (glsl_base_type_is_integer(base_type)) {
+                                       info->input_interpolate[i] = TGSI_INTERPOLATE_CONSTANT;
+                                       break;
+                               }
 
-               case INTERP_MODE_SMOOTH:
-                       assert(!glsl_base_type_is_integer(base_type));
+                               if (semantic_name == TGSI_SEMANTIC_COLOR) {
+                                       info->input_interpolate[i] = TGSI_INTERPOLATE_COLOR;
+                                       break;
+                               }
+                               /* fall-through */
 
-                       info->input_interpolate[i] = TGSI_INTERPOLATE_PERSPECTIVE;
-                       break;
+                       case INTERP_MODE_SMOOTH:
+                               assert(!glsl_base_type_is_integer(base_type));
 
-               case INTERP_MODE_NOPERSPECTIVE:
-                       assert(!glsl_base_type_is_integer(base_type));
+                               info->input_interpolate[i] = TGSI_INTERPOLATE_PERSPECTIVE;
+                               break;
 
-                       info->input_interpolate[i] = TGSI_INTERPOLATE_LINEAR;
-                       break;
+                       case INTERP_MODE_NOPERSPECTIVE:
+                               assert(!glsl_base_type_is_integer(base_type));
 
-               case INTERP_MODE_FLAT:
-                       info->input_interpolate[i] = TGSI_INTERPOLATE_CONSTANT;
-                       break;
-               }
+                               info->input_interpolate[i] = TGSI_INTERPOLATE_LINEAR;
+                               break;
+
+                       case INTERP_MODE_FLAT:
+                               info->input_interpolate[i] = TGSI_INTERPOLATE_CONSTANT;
+                               break;
+                       }
 
-               /* TODO make this more precise */
-               if (variable->data.location == VARYING_SLOT_COL0)
-                       info->colors_read |= 0x0f;
-               else if (variable->data.location == VARYING_SLOT_COL1)
-                       info->colors_read |= 0xf0;
+                       /* TODO make this more precise */
+                       if (variable->data.location == VARYING_SLOT_COL0)
+                               info->colors_read |= 0x0f;
+                       else if (variable->data.location == VARYING_SLOT_COL1)
+                               info->colors_read |= 0xf0;
+               }
        }
 
        info->num_inputs = num_inputs;
@@ -367,137 +448,266 @@ void si_nir_scan_shader(const struct nir_shader *nir,
        nir_foreach_variable(variable, &nir->outputs) {
                unsigned semantic_name, semantic_index;
 
-               if (nir->info.stage == MESA_SHADER_FRAGMENT) {
-                       tgsi_get_gl_frag_result_semantic(variable->data.location,
-                               &semantic_name, &semantic_index);
+               i = variable->data.driver_location;
 
-                       /* Adjust for dual source blending */
-                       if (variable->data.index > 0) {
-                               semantic_index++;
-                       }
-               } else {
-                       tgsi_get_gl_varying_semantic(variable->data.location, true,
-                                                    &semantic_name, &semantic_index);
+               const struct glsl_type *type = variable->type;
+               if (nir_is_per_vertex_io(variable, nir->info.stage)) {
+                       assert(glsl_type_is_array(type));
+                       type = glsl_get_array_element(type);
                }
 
-               i = variable->data.driver_location;
-               if (processed_outputs & ((uint64_t)1 << i))
-                       continue;
+               unsigned attrib_count = glsl_count_attribute_slots(type, false);
+               for (unsigned k = 0; k < attrib_count; k++, i++) {
 
-               processed_outputs |= ((uint64_t)1 << i);
-               num_outputs++;
+                       if (nir->info.stage == MESA_SHADER_FRAGMENT) {
+                               tgsi_get_gl_frag_result_semantic(variable->data.location + k,
+                                       &semantic_name, &semantic_index);
 
-               info->output_semantic_name[i] = semantic_name;
-               info->output_semantic_index[i] = semantic_index;
-               info->output_usagemask[i] = TGSI_WRITEMASK_XYZW;
+                               /* Adjust for dual source blending */
+                               if (variable->data.index > 0) {
+                                       semantic_index++;
+                               }
+                       } else {
+                               tgsi_get_gl_varying_semantic(variable->data.location + k, true,
+                                                            &semantic_name, &semantic_index);
+                       }
 
-               unsigned num_components = 4;
-               unsigned vector_elements = glsl_get_vector_elements(glsl_without_array(variable->type));
-               if (vector_elements)
-                       num_components = vector_elements;
+                       unsigned num_components = 4;
+                       unsigned vector_elements = glsl_get_vector_elements(glsl_without_array(variable->type));
+                       if (vector_elements)
+                               num_components = vector_elements;
+
+                       unsigned component = variable->data.location_frac;
+                       if (glsl_type_is_64bit(glsl_without_array(variable->type))) {
+                               if (glsl_type_is_dual_slot(glsl_without_array(variable->type)) && k % 2) {
+                                       num_components = (num_components * 2) - 4;
+                                       component = 0;
+                               } else {
+                                       num_components = MIN2(num_components * 2, 4);
+                               }
+                       }
 
-               unsigned gs_out_streams;
-               if (variable->data.stream & (1u << 31)) {
-                       gs_out_streams = variable->data.stream & ~(1u << 31);
-               } else {
-                       assert(variable->data.stream < 4);
-                       gs_out_streams = 0;
-                       for (unsigned j = 0; j < num_components; ++j)
-                               gs_out_streams |= variable->data.stream << (2 * (variable->data.location_frac + j));
-               }
+                       ubyte usagemask = 0;
+                       for (unsigned j = component; j < num_components + component; j++) {
+                               switch (j) {
+                               case 0:
+                                       usagemask |= TGSI_WRITEMASK_X;
+                                       break;
+                               case 1:
+                                       usagemask |= TGSI_WRITEMASK_Y;
+                                       break;
+                               case 2:
+                                       usagemask |= TGSI_WRITEMASK_Z;
+                                       break;
+                               case 3:
+                                       usagemask |= TGSI_WRITEMASK_W;
+                                       break;
+                               default:
+                                       unreachable("error calculating component index");
+                               }
+                       }
 
-               unsigned streamx = gs_out_streams & 3;
-               unsigned streamy = (gs_out_streams >> 2) & 3;
-               unsigned streamz = (gs_out_streams >> 4) & 3;
-               unsigned streamw = (gs_out_streams >> 6) & 3;
+                       unsigned gs_out_streams;
+                       if (variable->data.stream & (1u << 31)) {
+                               gs_out_streams = variable->data.stream & ~(1u << 31);
+                       } else {
+                               assert(variable->data.stream < 4);
+                               gs_out_streams = 0;
+                               for (unsigned j = 0; j < num_components; ++j)
+                                       gs_out_streams |= variable->data.stream << (2 * (component + j));
+                       }
 
-               if (info->output_usagemask[i] & TGSI_WRITEMASK_X) {
-                       info->output_streams[i] |= streamx;
-                       info->num_stream_output_components[streamx]++;
-               }
-               if (info->output_usagemask[i] & TGSI_WRITEMASK_Y) {
-                       info->output_streams[i] |= streamy << 2;
-                       info->num_stream_output_components[streamy]++;
-               }
-               if (info->output_usagemask[i] & TGSI_WRITEMASK_Z) {
-                       info->output_streams[i] |= streamz << 4;
-                       info->num_stream_output_components[streamz]++;
-               }
-               if (info->output_usagemask[i] & TGSI_WRITEMASK_W) {
-                       info->output_streams[i] |= streamw << 6;
-                       info->num_stream_output_components[streamw]++;
-               }
+                       unsigned streamx = gs_out_streams & 3;
+                       unsigned streamy = (gs_out_streams >> 2) & 3;
+                       unsigned streamz = (gs_out_streams >> 4) & 3;
+                       unsigned streamw = (gs_out_streams >> 6) & 3;
 
-               switch (semantic_name) {
-               case TGSI_SEMANTIC_PRIMID:
-                       info->writes_primid = true;
-                       break;
-               case TGSI_SEMANTIC_VIEWPORT_INDEX:
-                       info->writes_viewport_index = true;
-                       break;
-               case TGSI_SEMANTIC_LAYER:
-                       info->writes_layer = true;
-                       break;
-               case TGSI_SEMANTIC_PSIZE:
-                       info->writes_psize = true;
-                       break;
-               case TGSI_SEMANTIC_CLIPVERTEX:
-                       info->writes_clipvertex = true;
-                       break;
-               case TGSI_SEMANTIC_COLOR:
-                       info->colors_written |= 1 << semantic_index;
-                       break;
-               case TGSI_SEMANTIC_STENCIL:
-                       info->writes_stencil = true;
-                       break;
-               case TGSI_SEMANTIC_SAMPLEMASK:
-                       info->writes_samplemask = true;
-                       break;
-               case TGSI_SEMANTIC_EDGEFLAG:
-                       info->writes_edgeflag = true;
-                       break;
-               case TGSI_SEMANTIC_POSITION:
-                       if (info->processor == PIPE_SHADER_FRAGMENT)
-                               info->writes_z = true;
-                       else
-                               info->writes_position = true;
-                       break;
-               }
+                       if (usagemask & TGSI_WRITEMASK_X) {
+                               info->output_usagemask[i] |= TGSI_WRITEMASK_X;
+                               info->output_streams[i] |= streamx;
+                               info->num_stream_output_components[streamx]++;
+                       }
+                       if (usagemask & TGSI_WRITEMASK_Y) {
+                               info->output_usagemask[i] |= TGSI_WRITEMASK_Y;
+                               info->output_streams[i] |= streamy << 2;
+                               info->num_stream_output_components[streamy]++;
+                       }
+                       if (usagemask & TGSI_WRITEMASK_Z) {
+                               info->output_usagemask[i] |= TGSI_WRITEMASK_Z;
+                               info->output_streams[i] |= streamz << 4;
+                               info->num_stream_output_components[streamz]++;
+                       }
+                       if (usagemask & TGSI_WRITEMASK_W) {
+                               info->output_usagemask[i] |= TGSI_WRITEMASK_W;
+                               info->output_streams[i] |= streamw << 6;
+                               info->num_stream_output_components[streamw]++;
+                       }
+
+                       /* make sure we only count this location once against
+                        * the num_outputs counter.
+                        */
+                       if (processed_outputs & ((uint64_t)1 << i))
+                               continue;
+
+                       processed_outputs |= ((uint64_t)1 << i);
+                       num_outputs++;
+
+                       info->output_semantic_name[i] = semantic_name;
+                       info->output_semantic_index[i] = semantic_index;
 
-               if (nir->info.stage == MESA_SHADER_TESS_CTRL) {
                        switch (semantic_name) {
-                       case TGSI_SEMANTIC_PATCH:
-                               info->reads_perpatch_outputs = true;
-                       break;
-                       case TGSI_SEMANTIC_TESSINNER:
-                       case TGSI_SEMANTIC_TESSOUTER:
-                               info->reads_tessfactor_outputs = true;
-                       break;
-                       default:
-                               info->reads_pervertex_outputs = true;
+                       case TGSI_SEMANTIC_PRIMID:
+                               info->writes_primid = true;
+                               break;
+                       case TGSI_SEMANTIC_VIEWPORT_INDEX:
+                               info->writes_viewport_index = true;
+                               break;
+                       case TGSI_SEMANTIC_LAYER:
+                               info->writes_layer = true;
+                               break;
+                       case TGSI_SEMANTIC_PSIZE:
+                               info->writes_psize = true;
+                               break;
+                       case TGSI_SEMANTIC_CLIPVERTEX:
+                               info->writes_clipvertex = true;
+                               break;
+                       case TGSI_SEMANTIC_COLOR:
+                               info->colors_written |= 1 << semantic_index;
+                               break;
+                       case TGSI_SEMANTIC_STENCIL:
+                               info->writes_stencil = true;
+                               break;
+                       case TGSI_SEMANTIC_SAMPLEMASK:
+                               info->writes_samplemask = true;
+                               break;
+                       case TGSI_SEMANTIC_EDGEFLAG:
+                               info->writes_edgeflag = true;
+                               break;
+                       case TGSI_SEMANTIC_POSITION:
+                               if (info->processor == PIPE_SHADER_FRAGMENT)
+                                       info->writes_z = true;
+                               else
+                                       info->writes_position = true;
+                               break;
+                       }
+
+                       if (nir->info.stage == MESA_SHADER_TESS_CTRL) {
+                               switch (semantic_name) {
+                               case TGSI_SEMANTIC_PATCH:
+                                       info->reads_perpatch_outputs = true;
+                               break;
+                               case TGSI_SEMANTIC_TESSINNER:
+                               case TGSI_SEMANTIC_TESSOUTER:
+                                       info->reads_tessfactor_outputs = true;
+                               break;
+                               default:
+                                       info->reads_pervertex_outputs = true;
+                               }
                        }
                }
+
+               unsigned loc = variable->data.location;
+               if (nir->info.stage == MESA_SHADER_FRAGMENT &&
+                   loc == FRAG_RESULT_COLOR &&
+                   nir->info.outputs_written & (1ull << loc)) {
+                       assert(attrib_count == 1);
+                       info->properties[TGSI_PROPERTY_FS_COLOR0_WRITES_ALL_CBUFS] = true;
+               }
        }
 
        info->num_outputs = num_outputs;
 
+       struct set *ubo_set = _mesa_set_create(NULL, _mesa_hash_pointer,
+                                              _mesa_key_pointer_equal);
+
+       /* Intialise const_file_max[0] */
+       info->const_file_max[0] = -1;
+
+       unsigned ubo_idx = 1;
        nir_foreach_variable(variable, &nir->uniforms) {
                const struct glsl_type *type = variable->type;
                enum glsl_base_type base_type =
                        glsl_get_base_type(glsl_without_array(type));
                unsigned aoa_size = MAX2(1, glsl_get_aoa_size(type));
 
+               /* Gather buffers declared bitmasks. Note: radeonsi doesn't
+                * really use the mask (other than ubo_idx == 1 for regular
+                * uniforms) its really only used for getting the buffer count
+                * so we don't need to worry about the ordering.
+                */
+               if (variable->interface_type != NULL) {
+                       if (variable->data.mode == nir_var_uniform) {
+
+                               unsigned block_count;
+                               if (base_type != GLSL_TYPE_INTERFACE) {
+                                       struct set_entry *entry =
+                                               _mesa_set_search(ubo_set, variable->interface_type);
+
+                                       /* Check if we have already processed
+                                        * a member from this ubo.
+                                        */
+                                       if (entry)
+                                               continue;
+
+                                       block_count = 1;
+                               } else {
+                                       block_count = aoa_size;
+                               }
+
+                               info->const_buffers_declared |= u_bit_consecutive(ubo_idx, block_count);
+                               ubo_idx += block_count;
+
+                               _mesa_set_add(ubo_set, variable->interface_type);
+                       }
+
+                       if (variable->data.mode == nir_var_shader_storage) {
+                               /* TODO: make this more accurate */
+                               info->shader_buffers_declared =
+                                       u_bit_consecutive(0, SI_NUM_SHADER_BUFFERS);
+                       }
+
+                       continue;
+               }
+
                /* We rely on the fact that nir_lower_samplers_as_deref has
                 * eliminated struct dereferences.
                 */
-               if (base_type == GLSL_TYPE_SAMPLER)
-                       info->samplers_declared |=
-                               u_bit_consecutive(variable->data.binding, aoa_size);
-               else if (base_type == GLSL_TYPE_IMAGE)
-                       info->images_declared |=
-                               u_bit_consecutive(variable->data.binding, aoa_size);
+               if (base_type == GLSL_TYPE_SAMPLER) {
+                       if (variable->data.bindless) {
+                               info->const_buffers_declared |= 1;
+                               info->const_file_max[0] +=
+                                       glsl_count_attribute_slots(type, false);
+                       } else {
+                               info->samplers_declared |=
+                                       u_bit_consecutive(variable->data.binding, aoa_size);
+                       }
+               } else if (base_type == GLSL_TYPE_IMAGE) {
+                       if (variable->data.bindless) {
+                               info->const_buffers_declared |= 1;
+                               info->const_file_max[0] +=
+                                       glsl_count_attribute_slots(type, false);
+                       } else {
+                               info->images_declared |=
+                                       u_bit_consecutive(variable->data.binding, aoa_size);
+                       }
+               } else if (base_type != GLSL_TYPE_ATOMIC_UINT) {
+                       if (strncmp(variable->name, "state.", 6) == 0 ||
+                           strncmp(variable->name, "gl_", 3) == 0) {
+                               /* FIXME: figure out why piglit tests with builtin
+                                * uniforms are failing without this.
+                                */
+                               info->const_buffers_declared =
+                                       u_bit_consecutive(0, SI_NUM_CONST_BUFFERS);
+                       } else {
+                               info->const_buffers_declared |= 1;
+                               info->const_file_max[0] +=
+                                       glsl_count_attribute_slots(type, false);
+                       }
+               }
        }
 
+       _mesa_set_destroy(ubo_set, NULL);
+
        info->num_written_clipdistance = nir->info.clip_distance_array_size;
        info->num_written_culldistance = nir->info.cull_distance_array_size;
        info->clipdist_writemask = u_bit_consecutive(0, info->num_written_clipdistance);
@@ -506,10 +716,6 @@ void si_nir_scan_shader(const struct nir_shader *nir,
        if (info->processor == PIPE_SHADER_FRAGMENT)
                info->uses_kill = nir->info.fs.uses_discard;
 
-       /* TODO make this more accurate */
-       info->const_buffers_declared = u_bit_consecutive(0, SI_NUM_CONST_BUFFERS);
-       info->shader_buffers_declared = u_bit_consecutive(0, SI_NUM_SHADER_BUFFERS);
-
        func = (struct nir_function *)exec_list_get_head_const(&nir->functions);
        nir_foreach_block(block, func->impl) {
                nir_foreach_instr(instr, block)
@@ -524,6 +730,13 @@ void si_nir_scan_shader(const struct nir_shader *nir,
 void
 si_lower_nir(struct si_shader_selector* sel)
 {
+       /* Disable const buffer fast path for old LLVM versions */
+       if (sel->screen->info.chip_class == SI && HAVE_LLVM < 0x0600 &&
+           sel->info.const_buffers_declared == 1 &&
+           sel->info.shader_buffers_declared == 0) {
+               sel->info.const_buffers_declared |= 0x2;
+       }
+
        /* Adjust the driver location of inputs and outputs. The state tracker
         * interprets them as slots, while the ac/nir backend interprets them
         * as individual components.
@@ -549,10 +762,6 @@ si_lower_nir(struct si_shader_selector* sel)
         * - ensure constant offsets for texture instructions are folded
         *   and copy-propagated
         */
-       NIR_PASS_V(sel->nir, nir_lower_io, nir_var_uniform, type_size,
-                  (nir_lower_io_options)0);
-       NIR_PASS_V(sel->nir, nir_lower_uniforms_to_ubo);
-
        NIR_PASS_V(sel->nir, nir_lower_returns);
        NIR_PASS_V(sel->nir, nir_lower_vars_to_ssa);
        NIR_PASS_V(sel->nir, nir_lower_alu_to_scalar);
@@ -565,13 +774,16 @@ si_lower_nir(struct si_shader_selector* sel)
 
        const nir_lower_subgroups_options subgroups_options = {
                .subgroup_size = 64,
-               .ballot_bit_size = 32,
+               .ballot_bit_size = 64,
                .lower_to_scalar = true,
                .lower_subgroup_masks = true,
                .lower_vote_trivial = false,
+               .lower_vote_eq_to_ballot = true,
        };
        NIR_PASS_V(sel->nir, nir_lower_subgroups, &subgroups_options);
 
+       ac_lower_indirect_derefs(sel->nir, sel->screen->info.chip_class);
+
        bool progress;
        do {
                progress = false;
@@ -628,26 +840,6 @@ static void declare_nir_input_fs(struct si_shader_context *ctx,
        si_llvm_load_input_fs(ctx, input_index, out);
 }
 
-LLVMValueRef si_nir_load_input_gs(struct ac_shader_abi *abi,
-                                 unsigned location,
-                                 unsigned driver_location,
-                                 unsigned component,
-                                 unsigned num_components,
-                                 unsigned vertex_index,
-                                 unsigned const_index,
-                                 LLVMTypeRef type)
-{
-       struct si_shader_context *ctx = si_shader_context_from_abi(abi);
-
-       LLVMValueRef value[4];
-       for (unsigned i = component; i < num_components + component; i++) {
-               value[i] = si_llvm_load_input_gs(&ctx->abi, driver_location  / 4,
-                                                vertex_index, type, i);
-       }
-
-       return ac_build_varying_gather_values(&ctx->ac, value, num_components, component);
-}
-
 LLVMValueRef
 si_nir_lookup_interp_param(struct ac_shader_abi *abi,
                           enum glsl_interp_mode interp, unsigned location)
@@ -689,19 +881,17 @@ si_nir_load_sampler_desc(struct ac_shader_abi *abi,
                         unsigned descriptor_set, unsigned base_index,
                         unsigned constant_index, LLVMValueRef dynamic_index,
                         enum ac_descriptor_type desc_type, bool image,
-                        bool write)
+                        bool write, bool bindless)
 {
        struct si_shader_context *ctx = si_shader_context_from_abi(abi);
        LLVMBuilderRef builder = ctx->ac.builder;
        LLVMValueRef list = LLVMGetParam(ctx->main_fn, ctx->param_samplers_and_images);
-       LLVMValueRef index = dynamic_index;
+       LLVMValueRef index;
 
        assert(!descriptor_set);
 
-       if (!index)
-               index = ctx->ac.i32_0;
-
-       index = LLVMBuildAdd(builder, index,
+       dynamic_index = dynamic_index ? dynamic_index : ctx->ac.i32_0;
+       index = LLVMBuildAdd(builder, dynamic_index,
                             LLVMConstInt(ctx->ac.i32, base_index + constant_index, false),
                             "");
 
@@ -753,31 +943,34 @@ bool si_nir_build_llvm(struct si_shader_context *ctx, struct nir_shader *nir)
                                                                           nir->info.stage == MESA_SHADER_VERTEX);
                        unsigned input_idx = variable->data.driver_location;
 
-                       assert(attrib_count == 1);
-
                        LLVMValueRef data[4];
                        unsigned loc = variable->data.location;
 
-                       /* Packed components share the same location so skip
-                        * them if we have already processed the location.
-                        */
-                       if (processed_inputs & ((uint64_t)1 << loc))
-                               continue;
-
-                       if (nir->info.stage == MESA_SHADER_VERTEX) {
-                               declare_nir_input_vs(ctx, variable, input_idx / 4, data);
-                               bitcast_inputs(ctx, data, input_idx);
-                               if (glsl_type_is_dual_slot(variable->type)) {
+                       for (unsigned i = 0; i < attrib_count; i++) {
+                               /* Packed components share the same location so skip
+                                * them if we have already processed the location.
+                                */
+                               if (processed_inputs & ((uint64_t)1 << (loc + i))) {
                                        input_idx += 4;
+                                       continue;
+                               }
+
+                               if (nir->info.stage == MESA_SHADER_VERTEX) {
                                        declare_nir_input_vs(ctx, variable, input_idx / 4, data);
                                        bitcast_inputs(ctx, data, input_idx);
+                                       if (glsl_type_is_dual_slot(variable->type)) {
+                                               input_idx += 4;
+                                               declare_nir_input_vs(ctx, variable, input_idx / 4, data);
+                                               bitcast_inputs(ctx, data, input_idx);
+                                       }
+                               } else if (nir->info.stage == MESA_SHADER_FRAGMENT) {
+                                       declare_nir_input_fs(ctx, variable, input_idx / 4, data);
+                                       bitcast_inputs(ctx, data, input_idx);
                                }
-                       } else if (nir->info.stage == MESA_SHADER_FRAGMENT) {
-                               declare_nir_input_fs(ctx, variable, input_idx / 4, data);
-                               bitcast_inputs(ctx, data, input_idx);
-                       }
 
-                       processed_inputs |= ((uint64_t)1 << loc);
+                               processed_inputs |= ((uint64_t)1 << (loc + i));
+                               input_idx += 4;
+                       }
                }
        }
 
@@ -788,7 +981,11 @@ bool si_nir_build_llvm(struct si_shader_context *ctx, struct nir_shader *nir)
        ctx->num_samplers = util_last_bit(info->samplers_declared);
        ctx->num_images = util_last_bit(info->images_declared);
 
-       ac_nir_translate(&ctx->ac, &ctx->abi, nir, NULL);
+       if (ctx->shader->selector->local_size) {
+               assert(nir->info.stage == MESA_SHADER_COMPUTE);
+               si_declare_compute_memory(ctx);
+       }
+       ac_nir_translate(&ctx->ac, &ctx->abi, nir);
 
        return true;
 }