radeonsi: delay adding BOs at the beginning of IBs until the first draw
[mesa.git] / src / gallium / drivers / radeonsi / si_state_draw.c
index 08aa00cb6492e909f618146168fa2546004aaa07..c220eaf24f84911a2c3fa3e9d9756422ea491f08 100644 (file)
@@ -22,9 +22,7 @@
  * USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "si_pipe.h"
-#include "radeon/r600_cs.h"
-#include "sid.h"
+#include "si_build_pm4.h"
 #include "gfx9d.h"
 
 #include "util/u_index_modify.h"
@@ -61,31 +59,6 @@ static unsigned si_conv_pipe_prim(unsigned mode)
        return prim_conv[mode];
 }
 
-static unsigned si_conv_prim_to_gs_out(unsigned mode)
-{
-       static const int prim_conv[] = {
-               [PIPE_PRIM_POINTS]                      = V_028A6C_OUTPRIM_TYPE_POINTLIST,
-               [PIPE_PRIM_LINES]                       = V_028A6C_OUTPRIM_TYPE_LINESTRIP,
-               [PIPE_PRIM_LINE_LOOP]                   = V_028A6C_OUTPRIM_TYPE_LINESTRIP,
-               [PIPE_PRIM_LINE_STRIP]                  = V_028A6C_OUTPRIM_TYPE_LINESTRIP,
-               [PIPE_PRIM_TRIANGLES]                   = V_028A6C_OUTPRIM_TYPE_TRISTRIP,
-               [PIPE_PRIM_TRIANGLE_STRIP]              = V_028A6C_OUTPRIM_TYPE_TRISTRIP,
-               [PIPE_PRIM_TRIANGLE_FAN]                = V_028A6C_OUTPRIM_TYPE_TRISTRIP,
-               [PIPE_PRIM_QUADS]                       = V_028A6C_OUTPRIM_TYPE_TRISTRIP,
-               [PIPE_PRIM_QUAD_STRIP]                  = V_028A6C_OUTPRIM_TYPE_TRISTRIP,
-               [PIPE_PRIM_POLYGON]                     = V_028A6C_OUTPRIM_TYPE_TRISTRIP,
-               [PIPE_PRIM_LINES_ADJACENCY]             = V_028A6C_OUTPRIM_TYPE_LINESTRIP,
-               [PIPE_PRIM_LINE_STRIP_ADJACENCY]        = V_028A6C_OUTPRIM_TYPE_LINESTRIP,
-               [PIPE_PRIM_TRIANGLES_ADJACENCY]         = V_028A6C_OUTPRIM_TYPE_TRISTRIP,
-               [PIPE_PRIM_TRIANGLE_STRIP_ADJACENCY]    = V_028A6C_OUTPRIM_TYPE_TRISTRIP,
-               [PIPE_PRIM_PATCHES]                     = V_028A6C_OUTPRIM_TYPE_POINTLIST,
-               [SI_PRIM_RECTANGLE_LIST]                = V_028A6C_OUTPRIM_TYPE_TRISTRIP
-       };
-       assert(mode < ARRAY_SIZE(prim_conv));
-
-       return prim_conv[mode];
-}
-
 /**
  * This calculates the LDS size for tessellation shaders (VS, TCS, TES).
  * LS.LDS_SIZE is shared by all 3 shader stages.
@@ -93,11 +66,11 @@ static unsigned si_conv_prim_to_gs_out(unsigned mode)
  * The information about LDS and other non-compile-time parameters is then
  * written to userdata SGPRs.
  */
-static void si_emit_derived_tess_state(struct si_context *sctx,
+static bool si_emit_derived_tess_state(struct si_context *sctx,
                                       const struct pipe_draw_info *info,
                                       unsigned *num_patches)
 {
-       struct radeon_winsys_cs *cs = sctx->b.gfx_cs;
+       struct radeon_cmdbuf *cs = sctx->gfx_cs;
        struct si_shader *ls_current;
        struct si_shader_selector *ls;
        /* The TES pointer will only be used for sctx->last_tcs.
@@ -105,8 +78,8 @@ static void si_emit_derived_tess_state(struct si_context *sctx,
        struct si_shader_selector *tcs =
                sctx->tcs_shader.cso ? sctx->tcs_shader.cso : sctx->tes_shader.cso;
        unsigned tess_uses_primid = sctx->ia_multi_vgt_param_key.u.tess_uses_prim_id;
-       bool has_primid_instancing_bug = sctx->b.chip_class == SI &&
-                                        sctx->b.screen->info.max_se == 1;
+       bool has_primid_instancing_bug = sctx->chip_class == SI &&
+                                        sctx->screen->info.max_se == 1;
        unsigned tes_sh_base = sctx->shader_pointers.sh_base[PIPE_SHADER_TESS_EVAL];
        unsigned num_tcs_input_cp = info->vertices_per_patch;
        unsigned num_tcs_output_cp, num_tcs_inputs, num_tcs_outputs;
@@ -118,7 +91,7 @@ static void si_emit_derived_tess_state(struct si_context *sctx,
        unsigned offchip_layout, hardware_lds_size, ls_hs_config;
 
        /* Since GFX9 has merged LS-HS in the TCS state, set LS = TCS. */
-       if (sctx->b.chip_class >= GFX9) {
+       if (sctx->chip_class >= GFX9) {
                if (sctx->tcs_shader.cso)
                        ls_current = sctx->tcs_shader.current;
                else
@@ -137,7 +110,7 @@ static void si_emit_derived_tess_state(struct si_context *sctx,
            (!has_primid_instancing_bug ||
             (sctx->last_tess_uses_primid == tess_uses_primid))) {
                *num_patches = sctx->last_num_patches;
-               return;
+               return false;
        }
 
        sctx->last_ls = ls_current;
@@ -161,7 +134,7 @@ static void si_emit_derived_tess_state(struct si_context *sctx,
                num_tcs_patch_outputs = 2; /* TESSINNER + TESSOUTER */
        }
 
-       input_vertex_size = num_tcs_inputs * 16;
+       input_vertex_size = ls->lshs_vertex_stride;
        output_vertex_size = num_tcs_outputs * 16;
 
        input_patch_size = num_tcs_input_cp * input_vertex_size;
@@ -173,7 +146,8 @@ static void si_emit_derived_tess_state(struct si_context *sctx,
         * resource usage. Also ensures that the number of tcs in and out
         * vertices per threadgroup are at most 256.
         */
-       *num_patches = 64 / MAX2(num_tcs_input_cp, num_tcs_output_cp) * 4;
+       unsigned max_verts_per_patch = MAX2(num_tcs_input_cp, num_tcs_output_cp);
+       *num_patches = 256 / max_verts_per_patch;
 
        /* Make sure that the data fits in LDS. This assumes the shaders only
         * use LDS for the inputs and outputs.
@@ -191,16 +165,31 @@ static void si_emit_derived_tess_state(struct si_context *sctx,
                            (sctx->screen->tess_offchip_block_dw_size * 4) /
                            output_patch_size);
 
-       /* Not necessary for correctness, but improves performance. The
-        * specific value is taken from the proprietary driver.
+       /* Not necessary for correctness, but improves performance.
+        * The hardware can do more, but the radeonsi shader constant is
+        * limited to 6 bits.
         */
-       *num_patches = MIN2(*num_patches, 40);
+       *num_patches = MIN2(*num_patches, 63); /* triangles: 3 full waves except 3 lanes */
 
-       if (sctx->b.chip_class == SI) {
+       /* When distributed tessellation is unsupported, switch between SEs
+        * at a higher frequency to compensate for it.
+        */
+       if (!sctx->screen->has_distributed_tess && sctx->screen->info.max_se > 1)
+               *num_patches = MIN2(*num_patches, 16); /* recommended */
+
+       /* Make sure that vector lanes are reasonably occupied. It probably
+        * doesn't matter much because this is LS-HS, and TES is likely to
+        * occupy significantly more CUs.
+        */
+       unsigned temp_verts_per_tg = *num_patches * max_verts_per_patch;
+       if (temp_verts_per_tg > 64 && temp_verts_per_tg % 64 < 48)
+               *num_patches = (temp_verts_per_tg & ~63) / max_verts_per_patch;
+
+       if (sctx->chip_class == SI) {
                /* SI bug workaround, related to power management. Limit LS-HS
                 * threadgroups to only one wave.
                 */
-               unsigned one_wave = 64 / MAX2(num_tcs_input_cp, num_tcs_output_cp);
+               unsigned one_wave = 64 / max_verts_per_patch;
                *num_patches = MIN2(*num_patches, one_wave);
        }
 
@@ -232,7 +221,7 @@ static void si_emit_derived_tess_state(struct si_context *sctx,
        assert(num_tcs_input_cp <= 32);
        assert(num_tcs_output_cp <= 32);
 
-       uint64_t ring_va = r600_resource(sctx->tess_rings)->gpu_address;
+       uint64_t ring_va = si_resource(sctx->tess_rings)->gpu_address;
        assert((ring_va & u_bit_consecutive(0, 19)) == 0);
 
        tcs_in_layout = S_VS_STATE_LS_OUT_PATCH_SIZE(input_patch_size / 4) |
@@ -249,7 +238,7 @@ static void si_emit_derived_tess_state(struct si_context *sctx,
        /* Compute the LDS size. */
        lds_size = output_patch0_offset + output_patch_size * *num_patches;
 
-       if (sctx->b.chip_class >= CIK) {
+       if (sctx->chip_class >= CIK) {
                assert(lds_size <= 65536);
                lds_size = align(lds_size, 512) / 512;
        } else {
@@ -262,7 +251,7 @@ static void si_emit_derived_tess_state(struct si_context *sctx,
                                  C_VS_STATE_LS_OUT_VERTEX_SIZE;
        sctx->current_vs_state |= tcs_in_layout;
 
-       if (sctx->b.chip_class >= GFX9) {
+       if (sctx->chip_class >= GFX9) {
                unsigned hs_rsrc2 = ls_current->config.rsrc2 |
                                    S_00B42C_LDS_SIZE(lds_size);
 
@@ -283,7 +272,7 @@ static void si_emit_derived_tess_state(struct si_context *sctx,
 
                /* Due to a hw bug, RSRC2_LS must be written twice with another
                 * LS register written in between. */
-               if (sctx->b.chip_class == CIK && sctx->b.family != CHIP_HAWAII)
+               if (sctx->chip_class == CIK && sctx->family != CHIP_HAWAII)
                        radeon_set_sh_reg(cs, R_00B52C_SPI_SHADER_PGM_RSRC2_LS, ls_rsrc2);
                radeon_set_sh_reg_seq(cs, R_00B528_SPI_SHADER_PGM_RSRC1_LS, 2);
                radeon_emit(cs, ls_current->config.rsrc1);
@@ -307,12 +296,18 @@ static void si_emit_derived_tess_state(struct si_context *sctx,
                       S_028B58_HS_NUM_INPUT_CP(num_tcs_input_cp) |
                       S_028B58_HS_NUM_OUTPUT_CP(num_tcs_output_cp);
 
-       if (sctx->b.chip_class >= CIK)
-               radeon_set_context_reg_idx(cs, R_028B58_VGT_LS_HS_CONFIG, 2,
-                                          ls_hs_config);
-       else
-               radeon_set_context_reg(cs, R_028B58_VGT_LS_HS_CONFIG,
-                                      ls_hs_config);
+       if (sctx->last_ls_hs_config != ls_hs_config) {
+               if (sctx->chip_class >= CIK) {
+                       radeon_set_context_reg_idx(cs, R_028B58_VGT_LS_HS_CONFIG, 2,
+                                                  ls_hs_config);
+               } else {
+                       radeon_set_context_reg(cs, R_028B58_VGT_LS_HS_CONFIG,
+                                              ls_hs_config);
+               }
+               sctx->last_ls_hs_config = ls_hs_config;
+               return true; /* true if the context rolls */
+       }
+       return false;
 }
 
 static unsigned si_num_prims_for_vertices(const struct pipe_draw_info *info)
@@ -320,10 +315,12 @@ static unsigned si_num_prims_for_vertices(const struct pipe_draw_info *info)
        switch (info->mode) {
        case PIPE_PRIM_PATCHES:
                return info->count / info->vertices_per_patch;
+       case PIPE_PRIM_POLYGON:
+               return info->count >= 3;
        case SI_PRIM_RECTANGLE_LIST:
                return info->count / 3;
        default:
-               return u_prims_for_vertices(info->mode, info->count);
+               return u_decomposed_prims_for_vertices(info->mode, info->count);
        }
 }
 
@@ -353,19 +350,11 @@ si_get_init_multi_vgt_param(struct si_screen *sscreen,
                    key->u.uses_gs)
                        partial_vs_wave = true;
 
-               /* Needed for 028B6C_DISTRIBUTION_MODE != 0 */
+               /* Needed for 028B6C_DISTRIBUTION_MODE != 0. (implies >= VI) */
                if (sscreen->has_distributed_tess) {
                        if (key->u.uses_gs) {
-                               if (sscreen->info.chip_class <= VI)
+                               if (sscreen->info.chip_class == VI)
                                        partial_es_wave = true;
-
-                               /* GPU hang workaround. */
-                               if (sscreen->info.family == CHIP_TONGA ||
-                                   sscreen->info.family == CHIP_FIJI ||
-                                   sscreen->info.family == CHIP_POLARIS10 ||
-                                   sscreen->info.family == CHIP_POLARIS11 ||
-                                   sscreen->info.family == CHIP_POLARIS12)
-                                       partial_vs_wave = true;
                        } else {
                                partial_vs_wave = true;
                        }
@@ -387,7 +376,7 @@ si_get_init_multi_vgt_param(struct si_screen *sscreen,
                 * Polaris supports primitive restart with WD_SWITCH_ON_EOP=0
                 * for points, line strips, and tri strips.
                 */
-               if (sscreen->info.max_se < 4 ||
+               if (sscreen->info.max_se <= 2 ||
                    key->u.prim == PIPE_PRIM_POLYGON ||
                    key->u.prim == PIPE_PRIM_LINE_LOOP ||
                    key->u.prim == PIPE_PRIM_TRIANGLE_FAN ||
@@ -418,9 +407,21 @@ si_get_init_multi_vgt_param(struct si_screen *sscreen,
                        wd_switch_on_eop = true;
 
                /* Required on CIK and later. */
-               if (sscreen->info.max_se > 2 && !wd_switch_on_eop)
+               if (sscreen->info.max_se == 4 && !wd_switch_on_eop)
                        ia_switch_on_eoi = true;
 
+               /* HW engineers suggested that PARTIAL_VS_WAVE_ON should be set
+                * to work around a GS hang.
+                */
+               if (key->u.uses_gs &&
+                   (sscreen->info.family == CHIP_TONGA ||
+                    sscreen->info.family == CHIP_FIJI ||
+                    sscreen->info.family == CHIP_POLARIS10 ||
+                    sscreen->info.family == CHIP_POLARIS11 ||
+                    sscreen->info.family == CHIP_POLARIS12 ||
+                    sscreen->info.family == CHIP_VEGAM))
+                       partial_vs_wave = true;
+
                /* Required by Hawaii and, for some special cases, by VI. */
                if (ia_switch_on_eoi &&
                    (sscreen->info.family == CHIP_HAWAII ||
@@ -433,6 +434,12 @@ si_get_init_multi_vgt_param(struct si_screen *sscreen,
                    key->u.uses_instancing)
                        partial_vs_wave = true;
 
+               /* This only applies to Polaris10 and later 4 SE chips.
+                * wd_switch_on_eop is already true on all other chips.
+                */
+               if (!wd_switch_on_eop && key->u.primitive_restart)
+                       partial_vs_wave = true;
+
                /* If the WD switch is false, the IA switch must be false too. */
                assert(wd_switch_on_eop || !ia_switch_on_eop);
        }
@@ -453,7 +460,7 @@ si_get_init_multi_vgt_param(struct si_screen *sscreen,
                S_030960_EN_INST_OPT_ADV(sscreen->info.chip_class >= GFX9);
 }
 
-void si_init_ia_multi_vgt_param_table(struct si_context *sctx)
+static void si_init_ia_multi_vgt_param_table(struct si_context *sctx)
 {
        for (int prim = 0; prim <= SI_PRIM_RECTANGLE_LIST; prim++)
        for (int uses_instancing = 0; uses_instancing < 2; uses_instancing++)
@@ -513,7 +520,7 @@ static unsigned si_get_ia_multi_vgt_param(struct si_context *sctx,
 
        if (sctx->gs_shader.cso) {
                /* GS requirement. */
-               if (sctx->b.chip_class <= VI &&
+               if (sctx->chip_class <= VI &&
                    SI_GS_PER_ES / primgroup_size >= sctx->screen->gs_table_depth - 3)
                        ia_multi_vgt_param |= S_028AA8_PARTIAL_ES_WAVE_ON(1);
 
@@ -521,36 +528,32 @@ static unsigned si_get_ia_multi_vgt_param(struct si_context *sctx,
                 * The hw doc says all multi-SE chips are affected, but Vulkan
                 * only applies it to Hawaii. Do what Vulkan does.
                 */
-               if (sctx->b.family == CHIP_HAWAII &&
+               if (sctx->family == CHIP_HAWAII &&
                    G_028AA8_SWITCH_ON_EOI(ia_multi_vgt_param) &&
                    (info->indirect ||
                     (info->instance_count > 1 &&
                      (info->count_from_stream_output ||
                       si_num_prims_for_vertices(info) <= 1))))
-                       sctx->b.flags |= SI_CONTEXT_VGT_FLUSH;
+                       sctx->flags |= SI_CONTEXT_VGT_FLUSH;
        }
 
        return ia_multi_vgt_param;
 }
 
 /* rast_prim is the primitive type after GS. */
-static void si_emit_rasterizer_prim_state(struct si_context *sctx)
+static bool si_emit_rasterizer_prim_state(struct si_context *sctx)
 {
-       struct radeon_winsys_cs *cs = sctx->b.gfx_cs;
+       struct radeon_cmdbuf *cs = sctx->gfx_cs;
        enum pipe_prim_type rast_prim = sctx->current_rast_prim;
-       struct si_state_rasterizer *rs = sctx->emitted.named.rasterizer;
+       struct si_state_rasterizer *rs = sctx->queued.named.rasterizer;
 
        /* Skip this if not rendering lines. */
-       if (rast_prim != PIPE_PRIM_LINES &&
-           rast_prim != PIPE_PRIM_LINE_LOOP &&
-           rast_prim != PIPE_PRIM_LINE_STRIP &&
-           rast_prim != PIPE_PRIM_LINES_ADJACENCY &&
-           rast_prim != PIPE_PRIM_LINE_STRIP_ADJACENCY)
-               return;
+       if (!util_prim_is_lines(rast_prim))
+               return false;
 
        if (rast_prim == sctx->last_rast_prim &&
            rs->pa_sc_line_stipple == sctx->last_sc_line_stipple)
-               return;
+               return false;
 
        /* For lines, reset the stipple pattern at each primitive. Otherwise,
         * reset the stipple pattern at each packet (line strips, line loops).
@@ -561,6 +564,7 @@ static void si_emit_rasterizer_prim_state(struct si_context *sctx)
 
        sctx->last_rast_prim = rast_prim;
        sctx->last_sc_line_stipple = rs->pa_sc_line_stipple;
+       return true; /* true if the context rolls */
 }
 
 static void si_emit_vs_state(struct si_context *sctx,
@@ -576,33 +580,53 @@ static void si_emit_vs_state(struct si_context *sctx,
        }
 
        if (sctx->current_vs_state != sctx->last_vs_state) {
-               struct radeon_winsys_cs *cs = sctx->b.gfx_cs;
+               struct radeon_cmdbuf *cs = sctx->gfx_cs;
 
+               /* For the API vertex shader (VS_STATE_INDEXED). */
                radeon_set_sh_reg(cs,
                        sctx->shader_pointers.sh_base[PIPE_SHADER_VERTEX] +
                        SI_SGPR_VS_STATE_BITS * 4,
                        sctx->current_vs_state);
 
+               /* For vertex color clamping, which is done in the last stage
+                * before the rasterizer. */
+               if (sctx->gs_shader.cso || sctx->tes_shader.cso) {
+                       /* GS copy shader or TES if GS is missing. */
+                       radeon_set_sh_reg(cs,
+                               R_00B130_SPI_SHADER_USER_DATA_VS_0 +
+                               SI_SGPR_VS_STATE_BITS * 4,
+                               sctx->current_vs_state);
+               }
+
                sctx->last_vs_state = sctx->current_vs_state;
        }
 }
 
+static inline bool si_prim_restart_index_changed(struct si_context *sctx,
+                                                const struct pipe_draw_info *info)
+{
+       return info->primitive_restart &&
+              (info->restart_index != sctx->last_restart_index ||
+               sctx->last_restart_index == SI_RESTART_INDEX_UNKNOWN);
+}
+
 static void si_emit_draw_registers(struct si_context *sctx,
                                   const struct pipe_draw_info *info,
                                   unsigned num_patches)
 {
-       struct radeon_winsys_cs *cs = sctx->b.gfx_cs;
+       struct radeon_cmdbuf *cs = sctx->gfx_cs;
        unsigned prim = si_conv_pipe_prim(info->mode);
-       unsigned gs_out_prim = si_conv_prim_to_gs_out(sctx->current_rast_prim);
        unsigned ia_multi_vgt_param;
 
        ia_multi_vgt_param = si_get_ia_multi_vgt_param(sctx, info, num_patches);
 
        /* Draw state. */
        if (ia_multi_vgt_param != sctx->last_multi_vgt_param) {
-               if (sctx->b.chip_class >= GFX9)
-                       radeon_set_uconfig_reg_idx(cs, R_030960_IA_MULTI_VGT_PARAM, 4, ia_multi_vgt_param);
-               else if (sctx->b.chip_class >= CIK)
+               if (sctx->chip_class >= GFX9)
+                       radeon_set_uconfig_reg_idx(cs, sctx->screen,
+                                                  R_030960_IA_MULTI_VGT_PARAM, 4,
+                                                  ia_multi_vgt_param);
+               else if (sctx->chip_class >= CIK)
                        radeon_set_context_reg_idx(cs, R_028AA8_IA_MULTI_VGT_PARAM, 1, ia_multi_vgt_param);
                else
                        radeon_set_context_reg(cs, R_028AA8_IA_MULTI_VGT_PARAM, ia_multi_vgt_param);
@@ -610,22 +634,18 @@ static void si_emit_draw_registers(struct si_context *sctx,
                sctx->last_multi_vgt_param = ia_multi_vgt_param;
        }
        if (prim != sctx->last_prim) {
-               if (sctx->b.chip_class >= CIK)
-                       radeon_set_uconfig_reg_idx(cs, R_030908_VGT_PRIMITIVE_TYPE, 1, prim);
+               if (sctx->chip_class >= CIK)
+                       radeon_set_uconfig_reg_idx(cs, sctx->screen,
+                                                  R_030908_VGT_PRIMITIVE_TYPE, 1, prim);
                else
                        radeon_set_config_reg(cs, R_008958_VGT_PRIMITIVE_TYPE, prim);
 
                sctx->last_prim = prim;
        }
 
-       if (gs_out_prim != sctx->last_gs_out_prim) {
-               radeon_set_context_reg(cs, R_028A6C_VGT_GS_OUT_PRIM_TYPE, gs_out_prim);
-               sctx->last_gs_out_prim = gs_out_prim;
-       }
-
        /* Primitive restart. */
        if (info->primitive_restart != sctx->last_primitive_restart_en) {
-               if (sctx->b.chip_class >= GFX9)
+               if (sctx->chip_class >= GFX9)
                        radeon_set_uconfig_reg(cs, R_03092C_VGT_MULTI_PRIM_IB_RESET_EN,
                                               info->primitive_restart);
                else
@@ -635,9 +655,7 @@ static void si_emit_draw_registers(struct si_context *sctx,
                sctx->last_primitive_restart_en = info->primitive_restart;
 
        }
-       if (info->primitive_restart &&
-           (info->restart_index != sctx->last_restart_index ||
-            sctx->last_restart_index == SI_RESTART_INDEX_UNKNOWN)) {
+       if (si_prim_restart_index_changed(sctx, info)) {
                radeon_set_context_reg(cs, R_02840C_VGT_MULTI_PRIM_IB_RESET_INDX,
                                       info->restart_index);
                sctx->last_restart_index = info->restart_index;
@@ -651,33 +669,23 @@ static void si_emit_draw_packets(struct si_context *sctx,
                                 unsigned index_offset)
 {
        struct pipe_draw_indirect_info *indirect = info->indirect;
-       struct radeon_winsys_cs *cs = sctx->b.gfx_cs;
+       struct radeon_cmdbuf *cs = sctx->gfx_cs;
        unsigned sh_base_reg = sctx->shader_pointers.sh_base[PIPE_SHADER_VERTEX];
-       bool render_cond_bit = sctx->b.render_cond && !sctx->b.render_cond_force_off;
+       bool render_cond_bit = sctx->render_cond && !sctx->render_cond_force_off;
        uint32_t index_max_size = 0;
        uint64_t index_va = 0;
 
        if (info->count_from_stream_output) {
                struct si_streamout_target *t =
                        (struct si_streamout_target*)info->count_from_stream_output;
-               uint64_t va = t->buf_filled_size->gpu_address +
-                             t->buf_filled_size_offset;
 
                radeon_set_context_reg(cs, R_028B30_VGT_STRMOUT_DRAW_OPAQUE_VERTEX_STRIDE,
                                       t->stride_in_dw);
-
-               radeon_emit(cs, PKT3(PKT3_COPY_DATA, 4, 0));
-               radeon_emit(cs, COPY_DATA_SRC_SEL(COPY_DATA_MEM) |
-                           COPY_DATA_DST_SEL(COPY_DATA_REG) |
-                           COPY_DATA_WR_CONFIRM);
-               radeon_emit(cs, va);     /* src address lo */
-               radeon_emit(cs, va >> 32); /* src address hi */
-               radeon_emit(cs, R_028B2C_VGT_STRMOUT_DRAW_OPAQUE_BUFFER_FILLED_SIZE >> 2);
-               radeon_emit(cs, 0); /* unused */
-
-               radeon_add_to_buffer_list(sctx, sctx->b.gfx_cs,
-                                     t->buf_filled_size, RADEON_USAGE_READ,
-                                     RADEON_PRIO_SO_FILLED_SIZE);
+               si_cp_copy_data(sctx,
+                               COPY_DATA_REG, NULL,
+                               R_028B2C_VGT_STRMOUT_DRAW_OPAQUE_BUFFER_FILLED_SIZE >> 2,
+                               COPY_DATA_SRC_MEM, t->buf_filled_size,
+                               t->buf_filled_size_offset);
        }
 
        /* draw packet */
@@ -692,12 +700,12 @@ static void si_emit_draw_packets(struct si_context *sctx,
                                break;
                        case 2:
                                index_type = V_028A7C_VGT_INDEX_16 |
-                                            (SI_BIG_ENDIAN && sctx->b.chip_class <= CIK ?
+                                            (SI_BIG_ENDIAN && sctx->chip_class <= CIK ?
                                                      V_028A7C_VGT_DMA_SWAP_16_BIT : 0);
                                break;
                        case 4:
                                index_type = V_028A7C_VGT_INDEX_32 |
-                                            (SI_BIG_ENDIAN && sctx->b.chip_class <= CIK ?
+                                            (SI_BIG_ENDIAN && sctx->chip_class <= CIK ?
                                                      V_028A7C_VGT_DMA_SWAP_32_BIT : 0);
                                break;
                        default:
@@ -705,9 +713,10 @@ static void si_emit_draw_packets(struct si_context *sctx,
                                return;
                        }
 
-                       if (sctx->b.chip_class >= GFX9) {
-                               radeon_set_uconfig_reg_idx(cs, R_03090C_VGT_INDEX_TYPE,
-                                                          2, index_type);
+                       if (sctx->chip_class >= GFX9) {
+                               radeon_set_uconfig_reg_idx(cs, sctx->screen,
+                                                          R_03090C_VGT_INDEX_TYPE, 2,
+                                                          index_type);
                        } else {
                                radeon_emit(cs, PKT3(PKT3_INDEX_TYPE, 0, 0));
                                radeon_emit(cs, index_type);
@@ -718,21 +727,21 @@ static void si_emit_draw_packets(struct si_context *sctx,
 
                index_max_size = (indexbuf->width0 - index_offset) /
                                  index_size;
-               index_va = r600_resource(indexbuf)->gpu_address + index_offset;
+               index_va = si_resource(indexbuf)->gpu_address + index_offset;
 
-               radeon_add_to_buffer_list(sctx, sctx->b.gfx_cs,
-                                     (struct r600_resource *)indexbuf,
+               radeon_add_to_buffer_list(sctx, sctx->gfx_cs,
+                                     si_resource(indexbuf),
                                      RADEON_USAGE_READ, RADEON_PRIO_INDEX_BUFFER);
        } else {
                /* On CI and later, non-indexed draws overwrite VGT_INDEX_TYPE,
                 * so the state must be re-emitted before the next indexed draw.
                 */
-               if (sctx->b.chip_class >= CIK)
+               if (sctx->chip_class >= CIK)
                        sctx->last_index_size = -1;
        }
 
        if (indirect) {
-               uint64_t indirect_va = r600_resource(indirect->buffer)->gpu_address;
+               uint64_t indirect_va = si_resource(indirect->buffer)->gpu_address;
 
                assert(indirect_va % 8 == 0);
 
@@ -743,8 +752,8 @@ static void si_emit_draw_packets(struct si_context *sctx,
                radeon_emit(cs, indirect_va);
                radeon_emit(cs, indirect_va >> 32);
 
-               radeon_add_to_buffer_list(sctx, sctx->b.gfx_cs,
-                                     (struct r600_resource *)indirect->buffer,
+               radeon_add_to_buffer_list(sctx, sctx->gfx_cs,
+                                     si_resource(indirect->buffer),
                                      RADEON_USAGE_READ, RADEON_PRIO_DRAW_INDIRECT);
 
                unsigned di_src_sel = index_size ? V_0287F0_DI_SRC_SEL_DMA
@@ -773,11 +782,11 @@ static void si_emit_draw_packets(struct si_context *sctx,
                        uint64_t count_va = 0;
 
                        if (indirect->indirect_draw_count) {
-                               struct r600_resource *params_buf =
-                                       (struct r600_resource *)indirect->indirect_draw_count;
+                               struct si_resource *params_buf =
+                                       si_resource(indirect->indirect_draw_count);
 
                                radeon_add_to_buffer_list(
-                                       sctx, sctx->b.gfx_cs, params_buf,
+                                       sctx, sctx->gfx_cs, params_buf,
                                        RADEON_USAGE_READ, RADEON_PRIO_DRAW_INDIRECT);
 
                                count_va = params_buf->gpu_address + indirect->indirect_draw_count_offset;
@@ -799,10 +808,15 @@ static void si_emit_draw_packets(struct si_context *sctx,
                        radeon_emit(cs, di_src_sel);
                }
        } else {
+               unsigned instance_count = info->instance_count;
                int base_vertex;
 
-               radeon_emit(cs, PKT3(PKT3_NUM_INSTANCES, 0, 0));
-               radeon_emit(cs, info->instance_count);
+               if (sctx->last_instance_count == SI_INSTANCE_COUNT_UNKNOWN ||
+                   sctx->last_instance_count != instance_count) {
+                       radeon_emit(cs, PKT3(PKT3_NUM_INSTANCES, 0, 0));
+                       radeon_emit(cs, instance_count);
+                       sctx->last_instance_count = instance_count;
+               }
 
                /* Base vertex and start instance. */
                base_vertex = index_size ? info->index_bias : info->start;
@@ -853,9 +867,9 @@ static void si_emit_draw_packets(struct si_context *sctx,
 static void si_emit_surface_sync(struct si_context *sctx,
                                 unsigned cp_coher_cntl)
 {
-       struct radeon_winsys_cs *cs = sctx->b.gfx_cs;
+       struct radeon_cmdbuf *cs = sctx->gfx_cs;
 
-       if (sctx->b.chip_class >= GFX9) {
+       if (sctx->chip_class >= GFX9 || !sctx->has_graphics) {
                /* Flush caches and wait for the caches to assert idle. */
                radeon_emit(cs, PKT3(PKT3_ACQUIRE_MEM, 5, 0));
                radeon_emit(cs, cp_coher_cntl); /* CP_COHER_CNTL */
@@ -876,16 +890,28 @@ static void si_emit_surface_sync(struct si_context *sctx,
 
 void si_emit_cache_flush(struct si_context *sctx)
 {
-       struct radeon_winsys_cs *cs = sctx->b.gfx_cs;
-       uint32_t flags = sctx->b.flags;
+       struct radeon_cmdbuf *cs = sctx->gfx_cs;
+       uint32_t flags = sctx->flags;
+
+       if (!sctx->has_graphics) {
+               /* Only process compute flags. */
+               flags &= SI_CONTEXT_INV_ICACHE |
+                        SI_CONTEXT_INV_SMEM_L1 |
+                        SI_CONTEXT_INV_VMEM_L1 |
+                        SI_CONTEXT_INV_GLOBAL_L2 |
+                        SI_CONTEXT_WRITEBACK_GLOBAL_L2 |
+                        SI_CONTEXT_INV_L2_METADATA |
+                        SI_CONTEXT_CS_PARTIAL_FLUSH;
+       }
+
        uint32_t cp_coher_cntl = 0;
        uint32_t flush_cb_db = flags & (SI_CONTEXT_FLUSH_AND_INV_CB |
                                        SI_CONTEXT_FLUSH_AND_INV_DB);
 
        if (flags & SI_CONTEXT_FLUSH_AND_INV_CB)
-               sctx->b.num_cb_cache_flushes++;
+               sctx->num_cb_cache_flushes++;
        if (flags & SI_CONTEXT_FLUSH_AND_INV_DB)
-               sctx->b.num_db_cache_flushes++;
+               sctx->num_db_cache_flushes++;
 
        /* SI has a bug that it always flushes ICACHE and KCACHE if either
         * bit is set. An alternative way is to write SQC_CACHES, but that
@@ -900,7 +926,7 @@ void si_emit_cache_flush(struct si_context *sctx)
        if (flags & SI_CONTEXT_INV_SMEM_L1)
                cp_coher_cntl |= S_0085F0_SH_KCACHE_ACTION_ENA(1);
 
-       if (sctx->b.chip_class <= VI) {
+       if (sctx->chip_class <= VI) {
                if (flags & SI_CONTEXT_FLUSH_AND_INV_CB) {
                        cp_coher_cntl |= S_0085F0_CB_ACTION_ENA(1) |
                                         S_0085F0_CB0_DEST_BASE_ENA(1) |
@@ -913,10 +939,12 @@ void si_emit_cache_flush(struct si_context *sctx)
                                         S_0085F0_CB7_DEST_BASE_ENA(1);
 
                        /* Necessary for DCC */
-                       if (sctx->b.chip_class == VI)
-                               si_gfx_write_event_eop(sctx, V_028A90_FLUSH_AND_INV_CB_DATA_TS,
-                                                      0, EOP_DATA_SEL_DISCARD, NULL,
-                                                      0, 0, SI_NOT_QUERY);
+                       if (sctx->chip_class == VI)
+                               si_cp_release_mem(sctx,
+                                                 V_028A90_FLUSH_AND_INV_CB_DATA_TS,
+                                                 0, EOP_DST_SEL_MEM, EOP_INT_SEL_NONE,
+                                                 EOP_DATA_SEL_DISCARD, NULL,
+                                                 0, 0, SI_NOT_QUERY);
                }
                if (flags & SI_CONTEXT_FLUSH_AND_INV_DB)
                        cp_coher_cntl |= S_0085F0_DB_ACTION_ENA(1) |
@@ -946,20 +974,20 @@ void si_emit_cache_flush(struct si_context *sctx)
                        /* Only count explicit shader flushes, not implicit ones
                         * done by SURFACE_SYNC.
                         */
-                       sctx->b.num_vs_flushes++;
-                       sctx->b.num_ps_flushes++;
+                       sctx->num_vs_flushes++;
+                       sctx->num_ps_flushes++;
                } else if (flags & SI_CONTEXT_VS_PARTIAL_FLUSH) {
                        radeon_emit(cs, PKT3(PKT3_EVENT_WRITE, 0, 0));
                        radeon_emit(cs, EVENT_TYPE(V_028A90_VS_PARTIAL_FLUSH) | EVENT_INDEX(4));
-                       sctx->b.num_vs_flushes++;
+                       sctx->num_vs_flushes++;
                }
        }
 
        if (flags & SI_CONTEXT_CS_PARTIAL_FLUSH &&
            sctx->compute_is_busy) {
                radeon_emit(cs, PKT3(PKT3_EVENT_WRITE, 0, 0));
-               radeon_emit(cs, EVENT_TYPE(V_028A90_CS_PARTIAL_FLUSH | EVENT_INDEX(4)));
-               sctx->b.num_cs_flushes++;
+               radeon_emit(cs, EVENT_TYPE(V_028A90_CS_PARTIAL_FLUSH) | EVENT_INDEX(4));
+               sctx->num_cs_flushes++;
                sctx->compute_is_busy = false;
        }
 
@@ -976,7 +1004,7 @@ void si_emit_cache_flush(struct si_context *sctx)
        /* GFX9: Wait for idle if we're flushing CB or DB. ACQUIRE_MEM doesn't
         * wait for idle on GFX9. We have to use a TS event.
         */
-       if (sctx->b.chip_class >= GFX9 && flush_cb_db) {
+       if (sctx->chip_class >= GFX9 && flush_cb_db) {
                uint64_t va;
                unsigned tc_flags, cb_db_event;
 
@@ -1022,28 +1050,32 @@ void si_emit_cache_flush(struct si_context *sctx)
                        flags &= ~(SI_CONTEXT_INV_GLOBAL_L2 |
                                   SI_CONTEXT_WRITEBACK_GLOBAL_L2 |
                                   SI_CONTEXT_INV_VMEM_L1);
-                       sctx->b.num_L2_invalidates++;
+                       sctx->num_L2_invalidates++;
                }
 
                /* Do the flush (enqueue the event and wait for it). */
                va = sctx->wait_mem_scratch->gpu_address;
                sctx->wait_mem_number++;
 
-               si_gfx_write_event_eop(sctx, cb_db_event, tc_flags,
-                                      EOP_DATA_SEL_VALUE_32BIT,
-                                      sctx->wait_mem_scratch, va,
-                                      sctx->wait_mem_number, SI_NOT_QUERY);
-               si_gfx_wait_fence(sctx, va, sctx->wait_mem_number, 0xffffffff);
+               si_cp_release_mem(sctx, cb_db_event, tc_flags,
+                                 EOP_DST_SEL_MEM,
+                                 EOP_INT_SEL_SEND_DATA_AFTER_WR_CONFIRM,
+                                 EOP_DATA_SEL_VALUE_32BIT,
+                                 sctx->wait_mem_scratch, va,
+                                 sctx->wait_mem_number, SI_NOT_QUERY);
+               si_cp_wait_mem(sctx, cs, va, sctx->wait_mem_number, 0xffffffff,
+                              WAIT_REG_MEM_EQUAL);
        }
 
        /* Make sure ME is idle (it executes most packets) before continuing.
         * This prevents read-after-write hazards between PFP and ME.
         */
-       if (cp_coher_cntl ||
-           (flags & (SI_CONTEXT_CS_PARTIAL_FLUSH |
-                           SI_CONTEXT_INV_VMEM_L1 |
-                           SI_CONTEXT_INV_GLOBAL_L2 |
-                           SI_CONTEXT_WRITEBACK_GLOBAL_L2))) {
+       if (sctx->has_graphics &&
+           (cp_coher_cntl ||
+            (flags & (SI_CONTEXT_CS_PARTIAL_FLUSH |
+                      SI_CONTEXT_INV_VMEM_L1 |
+                      SI_CONTEXT_INV_GLOBAL_L2 |
+                      SI_CONTEXT_WRITEBACK_GLOBAL_L2)))) {
                radeon_emit(cs, PKT3(PKT3_PFP_SYNC_ME, 0, 0));
                radeon_emit(cs, 0);
        }
@@ -1058,7 +1090,7 @@ void si_emit_cache_flush(struct si_context *sctx)
         * SI-CIK don't support L2 write-back.
         */
        if (flags & SI_CONTEXT_INV_GLOBAL_L2 ||
-           (sctx->b.chip_class <= CIK &&
+           (sctx->chip_class <= CIK &&
             (flags & SI_CONTEXT_WRITEBACK_GLOBAL_L2))) {
                /* Invalidate L1 & L2. (L1 is always invalidated on SI)
                 * WB must be set on VI+ when TC_ACTION is set.
@@ -1066,9 +1098,9 @@ void si_emit_cache_flush(struct si_context *sctx)
                si_emit_surface_sync(sctx, cp_coher_cntl |
                                     S_0085F0_TC_ACTION_ENA(1) |
                                     S_0085F0_TCL1_ACTION_ENA(1) |
-                                    S_0301F0_TC_WB_ACTION_ENA(sctx->b.chip_class >= VI));
+                                    S_0301F0_TC_WB_ACTION_ENA(sctx->chip_class >= VI));
                cp_coher_cntl = 0;
-               sctx->b.num_L2_invalidates++;
+               sctx->num_L2_invalidates++;
        } else {
                /* L1 invalidation and L2 writeback must be done separately,
                 * because both operations can't be done together.
@@ -1084,7 +1116,7 @@ void si_emit_cache_flush(struct si_context *sctx)
                                             S_0301F0_TC_WB_ACTION_ENA(1) |
                                             S_0301F0_TC_NC_ACTION_ENA(1));
                        cp_coher_cntl = 0;
-                       sctx->b.num_L2_writebacks++;
+                       sctx->num_L2_writebacks++;
                }
                if (flags & SI_CONTEXT_INV_VMEM_L1) {
                        /* Invalidate per-CU VMEM L1. */
@@ -1108,7 +1140,7 @@ void si_emit_cache_flush(struct si_context *sctx)
                                EVENT_INDEX(0));
        }
 
-       sctx->b.flags = 0;
+       sctx->flags = 0;
 }
 
 static void si_get_draw_start_count(struct si_context *sctx,
@@ -1125,7 +1157,7 @@ static void si_get_draw_start_count(struct si_context *sctx,
                unsigned *data;
 
                if (indirect->indirect_draw_count) {
-                       data = pipe_buffer_map_range(&sctx->b.b,
+                       data = pipe_buffer_map_range(&sctx->b,
                                        indirect->indirect_draw_count,
                                        indirect->indirect_draw_count_offset,
                                        sizeof(unsigned),
@@ -1133,7 +1165,7 @@ static void si_get_draw_start_count(struct si_context *sctx,
 
                        indirect_count = *data;
 
-                       pipe_buffer_unmap(&sctx->b.b, transfer);
+                       pipe_buffer_unmap(&sctx->b, transfer);
                } else {
                        indirect_count = indirect->draw_count;
                }
@@ -1144,7 +1176,7 @@ static void si_get_draw_start_count(struct si_context *sctx,
                }
 
                map_size = (indirect_count - 1) * indirect->stride + 3 * sizeof(unsigned);
-               data = pipe_buffer_map_range(&sctx->b.b, indirect->buffer,
+               data = pipe_buffer_map_range(&sctx->b, indirect->buffer,
                                             indirect->offset, map_size,
                                             PIPE_TRANSFER_READ, &transfer);
 
@@ -1163,7 +1195,7 @@ static void si_get_draw_start_count(struct si_context *sctx,
                        data += indirect->stride / sizeof(unsigned);
                }
 
-               pipe_buffer_unmap(&sctx->b.b, transfer);
+               pipe_buffer_unmap(&sctx->b, transfer);
 
                if (begin < end) {
                        *start = begin;
@@ -1180,13 +1212,33 @@ static void si_get_draw_start_count(struct si_context *sctx,
 static void si_emit_all_states(struct si_context *sctx, const struct pipe_draw_info *info,
                               unsigned skip_atom_mask)
 {
+       unsigned num_patches = 0;
+       /* Vega10/Raven scissor bug workaround. When any context register is
+        * written (i.e. the GPU rolls the context), PA_SC_VPORT_SCISSOR
+        * registers must be written too.
+        */
+       bool handle_scissor_bug = (sctx->family == CHIP_VEGA10 || sctx->family == CHIP_RAVEN) &&
+                                 !si_is_atom_dirty(sctx, &sctx->atoms.s.scissors);
+       bool context_roll = false; /* set correctly for GFX9 only */
+
+       context_roll |= si_emit_rasterizer_prim_state(sctx);
+       if (sctx->tes_shader.cso)
+               context_roll |= si_emit_derived_tess_state(sctx, info, &num_patches);
+
+       if (handle_scissor_bug &&
+           (info->count_from_stream_output ||
+            sctx->dirty_atoms & si_atoms_that_always_roll_context() ||
+            sctx->dirty_states & si_states_that_always_roll_context() ||
+            si_prim_restart_index_changed(sctx, info)))
+               context_roll = true;
+
+       sctx->context_roll_counter = 0;
+
        /* Emit state atoms. */
        unsigned mask = sctx->dirty_atoms & ~skip_atom_mask;
-       while (mask) {
-               struct r600_atom *atom = sctx->atoms.array[u_bit_scan(&mask)];
+       while (mask)
+               sctx->atoms.array[u_bit_scan(&mask)].emit(sctx);
 
-               atom->emit(sctx, atom);
-       }
        sctx->dirty_atoms &= skip_atom_mask;
 
        /* Emit states. */
@@ -1203,17 +1255,18 @@ static void si_emit_all_states(struct si_context *sctx, const struct pipe_draw_i
        }
        sctx->dirty_states = 0;
 
-       /* Emit draw states. */
-       unsigned num_patches = 0;
+       if (handle_scissor_bug &&
+           (context_roll || sctx->context_roll_counter)) {
+               sctx->scissors.dirty_mask = (1 << SI_MAX_VIEWPORTS) - 1;
+               sctx->atoms.s.scissors.emit(sctx);
+       }
 
-       si_emit_rasterizer_prim_state(sctx);
-       if (sctx->tes_shader.cso)
-               si_emit_derived_tess_state(sctx, info, &num_patches);
+       /* Emit draw states. */
        si_emit_vs_state(sctx, info);
        si_emit_draw_registers(sctx, info, num_patches);
 }
 
-void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
+static void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
 {
        struct si_context *sctx = (struct si_context *)ctx;
        struct si_state_rasterizer *rs = sctx->queued.named.rasterizer;
@@ -1237,32 +1290,30 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
                        return;
        }
 
-       if (unlikely(!sctx->vs_shader.cso)) {
-               assert(0);
-               return;
-       }
-       if (unlikely(!sctx->ps_shader.cso && (!rs || !rs->rasterizer_discard))) {
-               assert(0);
-               return;
-       }
-       if (unlikely(!!sctx->tes_shader.cso != (info->mode == PIPE_PRIM_PATCHES))) {
+       if (unlikely(!sctx->vs_shader.cso ||
+                    !rs ||
+                    (!sctx->ps_shader.cso && !rs->rasterizer_discard) ||
+                    (!!sctx->tes_shader.cso != (info->mode == PIPE_PRIM_PATCHES)))) {
                assert(0);
                return;
        }
 
        /* Recompute and re-emit the texture resource states if needed. */
-       dirty_tex_counter = p_atomic_read(&sctx->b.screen->dirty_tex_counter);
-       if (unlikely(dirty_tex_counter != sctx->b.last_dirty_tex_counter)) {
-               sctx->b.last_dirty_tex_counter = dirty_tex_counter;
+       dirty_tex_counter = p_atomic_read(&sctx->screen->dirty_tex_counter);
+       if (unlikely(dirty_tex_counter != sctx->last_dirty_tex_counter)) {
+               sctx->last_dirty_tex_counter = dirty_tex_counter;
                sctx->framebuffer.dirty_cbufs |=
                        ((1 << sctx->framebuffer.state.nr_cbufs) - 1);
                sctx->framebuffer.dirty_zsbuf = true;
-               si_mark_atom_dirty(sctx, &sctx->framebuffer.atom);
+               si_mark_atom_dirty(sctx, &sctx->atoms.s.framebuffer);
                si_update_all_texture_descriptors(sctx);
        }
 
        si_decompress_textures(sctx, u_bit_consecutive(0, SI_NUM_GRAPHICS_SHADERS));
 
+       if (sctx->bo_list_add_all_gfx_resources)
+               si_gfx_resources_add_all_to_bo_list(sctx);
+
        /* Set the rasterization primitive type.
         *
         * This must be done after si_decompress_textures, which can call
@@ -1279,12 +1330,9 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
                rast_prim = info->mode;
 
        if (rast_prim != sctx->current_rast_prim) {
-               bool old_is_poly = sctx->current_rast_prim >= PIPE_PRIM_TRIANGLES;
-               bool new_is_poly = rast_prim >= PIPE_PRIM_TRIANGLES;
-               if (old_is_poly != new_is_poly) {
-                       sctx->scissors.dirty_mask = (1 << SI_MAX_VIEWPORTS) - 1;
-                       si_mark_atom_dirty(sctx, &sctx->scissors.atom);
-               }
+               if (util_prim_is_points_or_lines(sctx->current_rast_prim) !=
+                   util_prim_is_points_or_lines(rast_prim))
+                       si_mark_atom_dirty(sctx, &sctx->atoms.s.guardband);
 
                sctx->current_rast_prim = rast_prim;
                sctx->do_update_shaders = true;
@@ -1330,12 +1378,12 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
        }
 
        if (sctx->do_update_shaders && !si_update_shaders(sctx))
-               return;
+               goto return_cleanup;
 
        if (index_size) {
                /* Translate or upload, if needed. */
                /* 8-bit indices are supported on VI. */
-               if (sctx->b.chip_class <= CIK && index_size == 1) {
+               if (sctx->chip_class <= CIK && index_size == 1) {
                        unsigned start, count, start_offset, size, offset;
                        void *ptr;
 
@@ -1351,7 +1399,7 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
                        if (!indexbuf)
                                return;
 
-                       util_shorten_ubyte_elts_to_userptr(&sctx->b.b, info, 0, 0,
+                       util_shorten_ubyte_elts_to_userptr(&sctx->b, info, 0, 0,
                                                           index_offset + start,
                                                           count, ptr);
 
@@ -1375,12 +1423,12 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
 
                        /* info->start will be added by the drawing code */
                        index_offset -= start_offset;
-               } else if (sctx->b.chip_class <= CIK &&
-                          r600_resource(indexbuf)->TC_L2_dirty) {
+               } else if (sctx->chip_class <= CIK &&
+                          si_resource(indexbuf)->TC_L2_dirty) {
                        /* VI reads index buffers through TC L2, so it doesn't
                         * need this. */
-                       sctx->b.flags |= SI_CONTEXT_WRITEBACK_GLOBAL_L2;
-                       r600_resource(indexbuf)->TC_L2_dirty = false;
+                       sctx->flags |= SI_CONTEXT_WRITEBACK_GLOBAL_L2;
+                       si_resource(indexbuf)->TC_L2_dirty = false;
                }
        }
 
@@ -1388,73 +1436,57 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
                struct pipe_draw_indirect_info *indirect = info->indirect;
 
                /* Add the buffer size for memory checking in need_cs_space. */
-               si_context_add_resource_size(ctx, indirect->buffer);
+               si_context_add_resource_size(sctx, indirect->buffer);
 
                /* Indirect buffers use TC L2 on GFX9, but not older hw. */
-               if (sctx->b.chip_class <= VI) {
-                       if (r600_resource(indirect->buffer)->TC_L2_dirty) {
-                               sctx->b.flags |= SI_CONTEXT_WRITEBACK_GLOBAL_L2;
-                               r600_resource(indirect->buffer)->TC_L2_dirty = false;
+               if (sctx->chip_class <= VI) {
+                       if (si_resource(indirect->buffer)->TC_L2_dirty) {
+                               sctx->flags |= SI_CONTEXT_WRITEBACK_GLOBAL_L2;
+                               si_resource(indirect->buffer)->TC_L2_dirty = false;
                        }
 
                        if (indirect->indirect_draw_count &&
-                           r600_resource(indirect->indirect_draw_count)->TC_L2_dirty) {
-                               sctx->b.flags |= SI_CONTEXT_WRITEBACK_GLOBAL_L2;
-                               r600_resource(indirect->indirect_draw_count)->TC_L2_dirty = false;
+                           si_resource(indirect->indirect_draw_count)->TC_L2_dirty) {
+                               sctx->flags |= SI_CONTEXT_WRITEBACK_GLOBAL_L2;
+                               si_resource(indirect->indirect_draw_count)->TC_L2_dirty = false;
                        }
                }
        }
 
        si_need_gfx_cs_space(sctx);
 
-       /* Since we've called r600_context_add_resource_size for vertex buffers,
+       /* Since we've called si_context_add_resource_size for vertex buffers,
         * this must be called after si_need_cs_space, because we must let
         * need_cs_space flush before we add buffers to the buffer list.
         */
        if (!si_upload_vertex_buffer_descriptors(sctx))
-               return;
-
-       /* Vega10/Raven scissor bug workaround. This must be done before VPORT
-        * scissor registers are changed. There is also a more efficient but
-        * more involved alternative workaround.
-        */
-       if ((sctx->b.family == CHIP_VEGA10 || sctx->b.family == CHIP_RAVEN) &&
-           si_is_atom_dirty(sctx, &sctx->scissors.atom)) {
-               sctx->b.flags |= SI_CONTEXT_PS_PARTIAL_FLUSH;
-               si_emit_cache_flush(sctx);
-       }
+               goto return_cleanup;
 
        /* Use optimal packet order based on whether we need to sync the pipeline. */
-       if (unlikely(sctx->b.flags & (SI_CONTEXT_FLUSH_AND_INV_CB |
+       if (unlikely(sctx->flags & (SI_CONTEXT_FLUSH_AND_INV_CB |
                                      SI_CONTEXT_FLUSH_AND_INV_DB |
                                      SI_CONTEXT_PS_PARTIAL_FLUSH |
                                      SI_CONTEXT_CS_PARTIAL_FLUSH))) {
                /* If we have to wait for idle, set all states first, so that all
                 * SET packets are processed in parallel with previous draw calls.
-                * Then upload descriptors, set shader pointers, and draw, and
-                * prefetch at the end. This ensures that the time the CUs
-                * are idle is very short. (there are only SET_SH packets between
-                * the wait and the draw)
+                * Then draw and prefetch at the end. This ensures that the time
+                * the CUs are idle is very short.
                 */
-               struct r600_atom *shader_pointers = &sctx->shader_pointers.atom;
-               unsigned masked_atoms = 1u << shader_pointers->id;
+               unsigned masked_atoms = 0;
+
+               if (unlikely(sctx->flags & SI_CONTEXT_FLUSH_FOR_RENDER_COND))
+                       masked_atoms |= si_get_atom_bit(sctx, &sctx->atoms.s.render_cond);
 
-               if (unlikely(sctx->b.flags & SI_CONTEXT_FLUSH_FOR_RENDER_COND))
-                       masked_atoms |= 1u << sctx->b.render_cond_atom.id;
+               if (!si_upload_graphics_shader_descriptors(sctx))
+                       goto return_cleanup;
 
-               /* Emit all states except shader pointers and render condition. */
+               /* Emit all states except possibly render condition. */
                si_emit_all_states(sctx, info, masked_atoms);
                si_emit_cache_flush(sctx);
-
                /* <-- CUs are idle here. */
-               if (!si_upload_graphics_shader_descriptors(sctx))
-                       return;
 
-               /* Set shader pointers after descriptors are uploaded. */
-               if (si_is_atom_dirty(sctx, shader_pointers))
-                       shader_pointers->emit(sctx, NULL);
-               if (si_is_atom_dirty(sctx, &sctx->b.render_cond_atom))
-                       sctx->b.render_cond_atom.emit(sctx, NULL);
+               if (si_is_atom_dirty(sctx, &sctx->atoms.s.render_cond))
+                       sctx->atoms.s.render_cond.emit(sctx);
                sctx->dirty_atoms = 0;
 
                si_emit_draw_packets(sctx, info, indexbuf, index_size, index_offset);
@@ -1463,61 +1495,70 @@ void si_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info)
                /* Start prefetches after the draw has been started. Both will run
                 * in parallel, but starting the draw first is more important.
                 */
-               if (sctx->b.chip_class >= CIK && sctx->prefetch_L2_mask)
-                       cik_emit_prefetch_L2(sctx);
+               if (sctx->chip_class >= CIK && sctx->prefetch_L2_mask)
+                       cik_emit_prefetch_L2(sctx, false);
        } else {
                /* If we don't wait for idle, start prefetches first, then set
                 * states, and draw at the end.
                 */
-               if (sctx->b.flags)
+               if (sctx->flags)
                        si_emit_cache_flush(sctx);
 
-               if (sctx->b.chip_class >= CIK && sctx->prefetch_L2_mask)
-                       cik_emit_prefetch_L2(sctx);
+               /* Only prefetch the API VS and VBO descriptors. */
+               if (sctx->chip_class >= CIK && sctx->prefetch_L2_mask)
+                       cik_emit_prefetch_L2(sctx, true);
 
                if (!si_upload_graphics_shader_descriptors(sctx))
                        return;
 
                si_emit_all_states(sctx, info, 0);
                si_emit_draw_packets(sctx, info, indexbuf, index_size, index_offset);
+
+               /* Prefetch the remaining shaders after the draw has been
+                * started. */
+               if (sctx->chip_class >= CIK && sctx->prefetch_L2_mask)
+                       cik_emit_prefetch_L2(sctx, false);
        }
 
        if (unlikely(sctx->current_saved_cs)) {
                si_trace_emit(sctx);
-               si_log_draw_state(sctx, sctx->b.log);
+               si_log_draw_state(sctx, sctx->log);
        }
 
        /* Workaround for a VGT hang when streamout is enabled.
         * It must be done after drawing. */
-       if ((sctx->b.family == CHIP_HAWAII ||
-            sctx->b.family == CHIP_TONGA ||
-            sctx->b.family == CHIP_FIJI) &&
+       if ((sctx->family == CHIP_HAWAII ||
+            sctx->family == CHIP_TONGA ||
+            sctx->family == CHIP_FIJI) &&
            si_get_strmout_en(sctx)) {
-               sctx->b.flags |= SI_CONTEXT_VGT_STREAMOUT_SYNC;
+               sctx->flags |= SI_CONTEXT_VGT_STREAMOUT_SYNC;
        }
 
        if (unlikely(sctx->decompression_enabled)) {
-               sctx->b.num_decompress_calls++;
+               sctx->num_decompress_calls++;
        } else {
-               sctx->b.num_draw_calls++;
+               sctx->num_draw_calls++;
                if (sctx->framebuffer.state.nr_cbufs > 1)
-                       sctx->b.num_mrt_draw_calls++;
+                       sctx->num_mrt_draw_calls++;
                if (info->primitive_restart)
-                       sctx->b.num_prim_restart_calls++;
+                       sctx->num_prim_restart_calls++;
                if (G_0286E8_WAVESIZE(sctx->spi_tmpring_size))
-                       sctx->b.num_spill_draw_calls++;
+                       sctx->num_spill_draw_calls++;
        }
+
+return_cleanup:
        if (index_size && indexbuf != info->index.resource)
                pipe_resource_reference(&indexbuf, NULL);
 }
 
-void si_draw_rectangle(struct blitter_context *blitter,
-                      void *vertex_elements_cso,
-                      blitter_get_vs_func get_vs,
-                      int x1, int y1, int x2, int y2,
-                      float depth, unsigned num_instances,
-                      enum blitter_attrib_type type,
-                      const union blitter_attrib *attrib)
+static void
+si_draw_rectangle(struct blitter_context *blitter,
+                 void *vertex_elements_cso,
+                 blitter_get_vs_func get_vs,
+                 int x1, int y1, int x2, int y2,
+                 float depth, unsigned num_instances,
+                 enum blitter_attrib_type type,
+                 const union blitter_attrib *attrib)
 {
        struct pipe_context *pipe = util_blitter_get_pipe(blitter);
        struct si_context *sctx = (struct si_context*)pipe;
@@ -1542,7 +1583,7 @@ void si_draw_rectangle(struct blitter_context *blitter,
        case UTIL_BLITTER_ATTRIB_NONE:;
        }
 
-       pipe->bind_vs_state(pipe, si_get_blit_vs(sctx, type, num_instances));
+       pipe->bind_vs_state(pipe, si_get_blitter_vs(sctx, type, num_instances));
 
        struct pipe_draw_info info = {};
        info.mode = SI_PRIM_RECTANGLE_LIST;
@@ -1558,20 +1599,24 @@ void si_draw_rectangle(struct blitter_context *blitter,
 
 void si_trace_emit(struct si_context *sctx)
 {
-       struct radeon_winsys_cs *cs = sctx->b.gfx_cs;
-       uint64_t va = sctx->current_saved_cs->trace_buf->gpu_address;
+       struct radeon_cmdbuf *cs = sctx->gfx_cs;
        uint32_t trace_id = ++sctx->current_saved_cs->trace_id;
 
-       radeon_emit(cs, PKT3(PKT3_WRITE_DATA, 3, 0));
-       radeon_emit(cs, S_370_DST_SEL(V_370_MEMORY_SYNC) |
-                   S_370_WR_CONFIRM(1) |
-                   S_370_ENGINE_SEL(V_370_ME));
-       radeon_emit(cs, va);
-       radeon_emit(cs, va >> 32);
-       radeon_emit(cs, trace_id);
+       si_cp_write_data(sctx, sctx->current_saved_cs->trace_buf,
+                        0, 4, V_370_MEM, V_370_ME, &trace_id);
+
        radeon_emit(cs, PKT3(PKT3_NOP, 0, 0));
        radeon_emit(cs, AC_ENCODE_TRACE_POINT(trace_id));
 
-       if (sctx->b.log)
-               u_log_flush(sctx->b.log);
+       if (sctx->log)
+               u_log_flush(sctx->log);
+}
+
+void si_init_draw_functions(struct si_context *sctx)
+{
+       sctx->b.draw_vbo = si_draw_vbo;
+
+       sctx->blitter->draw_rectangle = si_draw_rectangle;
+
+       si_init_ia_multi_vgt_param_table(sctx);
 }