glsl: initialise killed_all field.

[mesa.git] / src / glsl / ast_to_hir.cpp

diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 1c54991cf7423f4164b6dd69de4846a4c2c907ed..d450aa1e40d307a5a1d821e64c166630d42e8f30 100644 (file)
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -2086,9 +2086,24 @@ apply_type_qualifier_to_variable(const struct ast_type_qualifier *qual,
         } else {
            var->location = qual->location;
         }
+
         if (qual->flags.q.explicit_index) {
-           var->explicit_index = true;
-           var->index = qual->index;
+            /* From the GLSL 4.30 specification, section 4.4.2 (Output
+             * Layout Qualifiers):
+             *
+             * "It is also a compile-time error if a fragment shader
+             *  sets a layout index to less than 0 or greater than 1."
+             *
+             * Older specifications don't mandate a behavior; we take
+             * this as a clarification and always generate the error.
+             */
+            if (qual->index < 0 || qual->index > 1) {
+               _mesa_glsl_error(loc, state,
+                                "explicit index may only be 0 or 1\n");
+            } else {
+               var->explicit_index = true;
+               var->index = qual->index;
+            }
         }
       }
    } else if (qual->flags.q.explicit_index) {
@@ -4043,7 +4058,7 @@ ast_uniform_block::hir(exec_list *instructions,
       decl_list->hir(&declared_variables, state);
 
       foreach_list_const(node, &declared_variables) {
-        struct ir_variable *var = (ir_variable *)node;
+        ir_variable *var = (ir_variable *)node;
 
         struct gl_uniform_buffer_variable *ubo_var =
            &ubo->Uniforms[ubo->NumUniforms++];
@@ -4054,11 +4069,15 @@ ast_uniform_block::hir(exec_list *instructions,
         ubo_var->Type = var->type;
         ubo_var->Buffer = ubo - state->uniform_blocks;
         ubo_var->Offset = 0; /* Assigned at link time. */
-        ubo_var->RowMajor = block_row_major;
-        if (decl_list->type->qualifier.flags.q.row_major)
-           ubo_var->RowMajor = true;
-        else if (decl_list->type->qualifier.flags.q.column_major)
-           ubo_var->RowMajor = false;
+
+        if (var->type->is_matrix() ||
+            (var->type->is_array() && var->type->fields.array->is_matrix())) {
+           ubo_var->RowMajor = block_row_major;
+           if (decl_list->type->qualifier.flags.q.row_major)
+              ubo_var->RowMajor = true;
+           else if (decl_list->type->qualifier.flags.q.column_major)
+              ubo_var->RowMajor = false;
+        }
 
         /* From the GL_ARB_uniform_buffer_object spec:
          *