* state atom.
*/
static void
-prepare_vs_constants(struct brw_context *brw)
+brw_upload_vs_pull_constants(struct brw_context *brw)
{
- struct gl_context *ctx = &brw->intel.ctx;
- struct intel_context *intel = &brw->intel;
/* BRW_NEW_VERTEX_PROGRAM */
struct brw_vertex_program *vp =
(struct brw_vertex_program *) brw->vertex_program;
- const struct gl_program_parameter_list *params = vp->program.Base.Parameters;
int i;
- if (vp->program.IsNVProgram)
- _mesa_load_tracked_matrices(ctx);
-
/* Updates the ParamaterValues[i] pointers for all parameters of the
* basic type of PROGRAM_STATE_VAR.
*/
- _mesa_load_state_parameters(&brw->intel.ctx, vp->program.Base.Parameters);
+ _mesa_load_state_parameters(&brw->ctx, vp->program.Base.Parameters);
/* CACHE_NEW_VS_PROG */
- if (!brw->vs.prog_data->nr_pull_params) {
+ if (!brw->vs.prog_data->base.nr_pull_params) {
if (brw->vs.const_bo) {
drm_intel_bo_unreference(brw->vs.const_bo);
brw->vs.const_bo = NULL;
+ brw->vs.surf_offset[SURF_INDEX_VERT_CONST_BUFFER] = 0;
brw->state.dirty.brw |= BRW_NEW_VS_CONSTBUF;
}
return;
/* _NEW_PROGRAM_CONSTANTS */
drm_intel_bo_unreference(brw->vs.const_bo);
- brw->vs.const_bo = drm_intel_bo_alloc(intel->bufmgr, "vp_const_buffer",
- brw->vs.prog_data->nr_pull_params * 4,
- 64);
+ uint32_t size = brw->vs.prog_data->base.nr_pull_params * 4;
+ brw->vs.const_bo = drm_intel_bo_alloc(brw->bufmgr, "vp_const_buffer",
+ size, 64);
drm_intel_gem_bo_map_gtt(brw->vs.const_bo);
- for (i = 0; i < brw->vs.prog_data->nr_pull_params; i++) {
+ for (i = 0; i < brw->vs.prog_data->base.nr_pull_params; i++) {
memcpy(brw->vs.const_bo->virtual + i * 4,
- brw->vs.prog_data->pull_param[i],
+ brw->vs.prog_data->base.pull_param[i],
4);
}
if (0) {
- for (i = 0; i < params->NumParameters; i++) {
+ for (i = 0; i < ALIGN(brw->vs.prog_data->base.nr_pull_params, 4) / 4;
+ i++) {
float *row = (float *)brw->vs.const_bo->virtual + i * 4;
printf("vs const surface %3d: %4.3f %4.3f %4.3f %4.3f\n",
i, row[0], row[1], row[2], row[3]);
}
drm_intel_gem_bo_unmap_gtt(brw->vs.const_bo);
+
+ const int surf = SURF_INDEX_VERT_CONST_BUFFER;
+ brw->vtbl.create_constant_surface(brw, brw->vs.const_bo, 0, size,
+ &brw->vs.surf_offset[surf], false);
+
brw->state.dirty.brw |= BRW_NEW_VS_CONSTBUF;
}
-const struct brw_tracked_state brw_vs_constants = {
+const struct brw_tracked_state brw_vs_pull_constants = {
.dirty = {
.mesa = (_NEW_PROGRAM_CONSTANTS),
- .brw = (BRW_NEW_VERTEX_PROGRAM),
+ .brw = (BRW_NEW_BATCH | BRW_NEW_VERTEX_PROGRAM),
.cache = CACHE_NEW_VS_PROG,
},
- .prepare = prepare_vs_constants,
+ .emit = brw_upload_vs_pull_constants,
};
-/**
- * Update the surface state for a VS constant buffer.
- *
- * Sets brw->vs.surf_bo[surf] and brw->vp->const_buffer.
- */
static void
-brw_update_vs_constant_surface( struct gl_context *ctx,
- GLuint surf)
+brw_upload_vs_ubo_surfaces(struct brw_context *brw)
{
- struct brw_context *brw = brw_context(ctx);
- struct intel_context *intel = &brw->intel;
- struct brw_vertex_program *vp =
- (struct brw_vertex_program *) brw->vertex_program;
- const struct gl_program_parameter_list *params = vp->program.Base.Parameters;
+ struct gl_context *ctx = &brw->ctx;
+ /* _NEW_PROGRAM */
+ struct gl_shader_program *prog = ctx->Shader.CurrentVertexProgram;
- assert(surf == 0);
-
- /* If there's no constant buffer, then no surface BO is needed to point at
- * it.
- */
- if (brw->vs.const_bo == NULL) {
- brw->vs.surf_offset[surf] = 0;
+ if (!prog)
return;
- }
- if (intel->gen >= 7) {
- gen7_create_constant_surface(brw, brw->vs.const_bo, params->NumParameters,
- &brw->vs.surf_offset[surf]);
- } else {
- brw_create_constant_surface(brw, brw->vs.const_bo, params->NumParameters,
- &brw->vs.surf_offset[surf]);
- }
+ brw_upload_ubo_surfaces(brw, prog->_LinkedShaders[MESA_SHADER_VERTEX],
+ &brw->vs.surf_offset[SURF_INDEX_VS_UBO(0)]);
}
-
-static void
-prepare_vs_surfaces(struct brw_context *brw)
-{
- int nr_surfaces = 0;
-
- if (brw->vs.const_bo) {
- nr_surfaces = 1;
- }
-
- if (brw->vs.nr_surfaces != nr_surfaces) {
- brw->state.dirty.brw |= BRW_NEW_NR_VS_SURFACES;
- brw->vs.nr_surfaces = nr_surfaces;
- }
-}
+const struct brw_tracked_state brw_vs_ubo_surfaces = {
+ .dirty = {
+ .mesa = _NEW_PROGRAM,
+ .brw = BRW_NEW_BATCH | BRW_NEW_UNIFORM_BUFFER,
+ .cache = 0,
+ },
+ .emit = brw_upload_vs_ubo_surfaces,
+};
/**
- * Vertex shader surfaces (constant buffer).
- *
- * This consumes the state updates for the constant buffer needing
- * to be updated, and produces BRW_NEW_NR_VS_SURFACES for the VS unit and
- * CACHE_NEW_SURF_BIND for the binding table upload.
+ * Constructs the binding table for the WM surface state, which maps unit
+ * numbers to surface state objects.
*/
-static void upload_vs_surfaces(struct brw_context *brw)
+static void
+brw_vs_upload_binding_table(struct brw_context *brw)
{
- struct gl_context *ctx = &brw->intel.ctx;
uint32_t *bind;
int i;
- /* BRW_NEW_NR_VS_SURFACES */
- if (brw->vs.nr_surfaces == 0) {
- if (brw->vs.bind_bo_offset) {
+ if (INTEL_DEBUG & DEBUG_SHADER_TIME) {
+ gen7_create_shader_time_surface(brw, &brw->vs.surf_offset[SURF_INDEX_VS_SHADER_TIME]);
+ }
+
+ /* CACHE_NEW_VS_PROG: Skip making a binding table if we don't use textures or
+ * pull constants.
+ */
+ const unsigned entries = brw->vs.prog_data->base.binding_table_size;
+ if (entries == 0) {
+ if (brw->vs.bind_bo_offset != 0) {
brw->state.dirty.brw |= BRW_NEW_VS_BINDING_TABLE;
+ brw->vs.bind_bo_offset = 0;
}
- brw->vs.bind_bo_offset = 0;
return;
}
- brw_update_vs_constant_surface(ctx, SURF_INDEX_VERT_CONST_BUFFER);
-
/* Might want to calculate nr_surfaces first, to avoid taking up so much
- * space for the binding table. (once we have vs samplers)
+ * space for the binding table.
*/
- bind = brw_state_batch(brw, AUB_TRACE_SURFACE_STATE,
- sizeof(uint32_t) * BRW_VS_MAX_SURF,
+ bind = brw_state_batch(brw, AUB_TRACE_BINDING_TABLE,
+ sizeof(uint32_t) * entries,
32, &brw->vs.bind_bo_offset);
- for (i = 0; i < BRW_VS_MAX_SURF; i++) {
- /* BRW_NEW_VS_CONSTBUF */
+ /* BRW_NEW_SURFACES and BRW_NEW_VS_CONSTBUF */
+ for (i = 0; i < entries; i++) {
bind[i] = brw->vs.surf_offset[i];
}
brw->state.dirty.brw |= BRW_NEW_VS_BINDING_TABLE;
}
-const struct brw_tracked_state brw_vs_surfaces = {
+const struct brw_tracked_state brw_vs_binding_table = {
.dirty = {
.mesa = 0,
- .brw = (BRW_NEW_VS_CONSTBUF |
- BRW_NEW_NR_VS_SURFACES |
- BRW_NEW_BATCH),
- .cache = 0
+ .brw = (BRW_NEW_BATCH |
+ BRW_NEW_VS_CONSTBUF |
+ BRW_NEW_SURFACES),
+ .cache = CACHE_NEW_VS_PROG
},
- .prepare = prepare_vs_surfaces,
- .emit = upload_vs_surfaces,
+ .emit = brw_vs_upload_binding_table,
};