fixed pointer arithmetic error in glCopyPixels
[mesa.git] / src / mesa / main / texstate.c
index a99325672c4ed48e80f88a88b6ddc7e9b6e71075..19e8984ad96ef8b79690a3ee6dc13262caf7b503 100644 (file)
@@ -1,21 +1,21 @@
-/* $Id: texstate.c,v 1.23 2000/11/19 23:10:25 brianp Exp $ */
+/* $Id: texstate.c,v 1.64 2002/02/15 16:32:06 brianp Exp $ */
 
 /*
  * Mesa 3-D graphics library
- * Version:  3.5
- * 
- * Copyright (C) 1999-2000  Brian Paul   All Rights Reserved.
- * 
+ * Version:  4.1
+ *
+ * Copyright (C) 1999-2002  Brian Paul   All Rights Reserved.
+ *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
  * to deal in the Software without restriction, including without limitation
  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
  * and/or sell copies of the Software, and to permit persons to whom the
  * Software is furnished to do so, subject to the following conditions:
- * 
+ *
  * The above copyright notice and this permission notice shall be included
  * in all copies or substantial portions of the Software.
- * 
+ *
  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
  * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 #include "texobj.h"
 #include "teximage.h"
 #include "texstate.h"
-#include "texture.h"
-#include "types.h"
+#include "mtypes.h"
 #include "math/m_xform.h"
 #include "math/m_matrix.h"
-#include "swrast/swrast.h"
 #endif
 
+/* TEMPORARY! */
+#ifndef GL_TEXTURE_COMPARE_MODE_ARB
+#define GL_TEXTURE_COMPARE_MODE_ARB    0x9990
+#define GL_TEXTURE_COMPARE_FUNC_ARB    0x9991
+#define GL_COMPARE_R_TO_TEXTURE_ARB    0x9993
+#endif
 
 
 #ifdef SPECIALCAST
@@ -58,7 +62,6 @@
 
 
 
-
 /**********************************************************************/
 /*                       Texture Environment                          */
 /**********************************************************************/
@@ -69,292 +72,377 @@ _mesa_TexEnvfv( GLenum target, GLenum pname, const GLfloat *param )
 {
    GET_CURRENT_CONTEXT(ctx);
    struct gl_texture_unit *texUnit = &ctx->Texture.Unit[ctx->Texture.CurrentUnit];
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
-   ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH(ctx, "glTexEnv");
+#define TE_ERROR(errCode, msg, value)                          \
+   {                                                           \
+      char s[100];                                             \
+      sprintf(s, msg, _mesa_lookup_enum_by_nr(value));         \
+      _mesa_error(ctx, errCode, s);                            \
+   }
 
    if (target==GL_TEXTURE_ENV) {
       switch (pname) {
-         case GL_TEXTURE_ENV_MODE:
-            {
-               GLenum mode = (GLenum) (GLint) *param;
-               switch (mode) {
-                  case GL_MODULATE:
-                  case GL_BLEND:
-                  case GL_DECAL:
-                  case GL_REPLACE:
-                  case GL_ADD:
-                  case GL_COMBINE_EXT:
-                     if (mode == GL_ADD &&
-                         !ctx->Extensions.EXT_texture_env_add) {
-                        gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(param)");
-                        return;
-                     }
-                     if (mode == GL_COMBINE_EXT &&
-                         !ctx->Extensions.EXT_texture_env_combine) {
-                        gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(param)");
-                        return;
-                     }
-                     if (texUnit->EnvMode == mode)
-                        return;  /* no change */
-                     texUnit->EnvMode = mode;
-                     break;
-                  default:
-                     gl_error( ctx, GL_INVALID_VALUE, "glTexEnv(param)" );
-                     return;
-               }
-            }
-            break;
-         case GL_TEXTURE_ENV_COLOR:
-            texUnit->EnvColor[0] = CLAMP( param[0], 0.0F, 1.0F );
-            texUnit->EnvColor[1] = CLAMP( param[1], 0.0F, 1.0F );
-            texUnit->EnvColor[2] = CLAMP( param[2], 0.0F, 1.0F );
-            texUnit->EnvColor[3] = CLAMP( param[3], 0.0F, 1.0F );
-            break;
-         case GL_COMBINE_RGB_EXT:
-            if (ctx->Extensions.EXT_texture_env_combine) {
-               GLenum mode = (GLenum) (GLint) *param;
-               switch (mode) {
-                  case GL_REPLACE:
-                  case GL_MODULATE:
-                  case GL_ADD:
-                  case GL_ADD_SIGNED_EXT:
-                  case GL_INTERPOLATE_EXT:
-                     if (texUnit->CombineModeRGB == mode)
-                        return;  /* no change */
-                     texUnit->CombineModeRGB = mode;
-                     break;
-                  default:
-                     gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(param)" );
-                     return;
-               }
-            }
-            else {
-               gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(pname)");
-               return;
-            }
-            break;
-         case GL_COMBINE_ALPHA_EXT:
-            if (ctx->Extensions.EXT_texture_env_combine) {
-               GLenum mode = (GLenum) (GLint) *param;
-               switch (mode) {
-                  case GL_REPLACE:
-                  case GL_MODULATE:
-                  case GL_ADD:
-                  case GL_ADD_SIGNED_EXT:
-                  case GL_INTERPOLATE_EXT:
-                     if (texUnit->CombineModeA == mode)
-                        return;  /* no change */
-                     texUnit->CombineModeA = mode;
-                     break;
-                  default:
-                     gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(param)" );
-                     return;
-               }
-            }
-            else {
-               gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(pname)");
-               return;
-            }
-            break;
-         case GL_SOURCE0_RGB_EXT:
-         case GL_SOURCE1_RGB_EXT:
-         case GL_SOURCE2_RGB_EXT:
-            if (ctx->Extensions.EXT_texture_env_combine) {
-               GLenum source = (GLenum) (GLint) *param;
-               GLuint s = pname - GL_SOURCE0_RGB_EXT;
-               switch (source) {
-                  case GL_TEXTURE:
-                  case GL_CONSTANT_EXT:
-                  case GL_PRIMARY_COLOR_EXT:
-                  case GL_PREVIOUS_EXT:
-                     if (texUnit->CombineSourceRGB[s] == source)
-                        return;  /* no change */
-                     texUnit->CombineSourceRGB[s] = source;
-                     break;
-                  default:
-                     gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(param)" );
-                     return;
-               }
-            }
-            else {
-               gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(pname)");
-               return;
-            }
-            break;
-         case GL_SOURCE0_ALPHA_EXT:
-         case GL_SOURCE1_ALPHA_EXT:
-         case GL_SOURCE2_ALPHA_EXT:
-            if (ctx->Extensions.EXT_texture_env_combine) {
-               GLenum source = (GLenum) (GLint) *param;
-               GLuint s = pname - GL_SOURCE0_ALPHA_EXT;
-               switch (source) {
-                  case GL_TEXTURE:
-                  case GL_CONSTANT_EXT:
-                  case GL_PRIMARY_COLOR_EXT:
-                  case GL_PREVIOUS_EXT:
-                     if (texUnit->CombineSourceA[s] == source) return;
-                     texUnit->CombineSourceA[s] = source;
-                     break;
-                  default:
-                     gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(param)" );
-                     return;
-               }
-            }
-            else {
-               gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(pname)");
-               return;
-            }
-            break;
-         case GL_OPERAND0_RGB_EXT:
-         case GL_OPERAND1_RGB_EXT:
-            if (ctx->Extensions.EXT_texture_env_combine) {
-               GLenum operand = (GLenum) (GLint) *param;
-               GLuint s = pname - GL_OPERAND0_RGB_EXT;
-               switch (operand) {
-                  case GL_SRC_COLOR:
-                  case GL_ONE_MINUS_SRC_COLOR:
-                  case GL_SRC_ALPHA:
-                  case GL_ONE_MINUS_SRC_ALPHA:
-                     texUnit->CombineOperandRGB[s] = operand;
-                     break;
-                  default:
-                     gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(param)" );
-                     return;
-               }
-            }
-            else {
-               gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(pname)");
-               return;
-            }
-            break;
-         case GL_OPERAND0_ALPHA_EXT:
-         case GL_OPERAND1_ALPHA_EXT:
-            if (ctx->Extensions.EXT_texture_env_combine) {
-               GLenum operand = (GLenum) (GLint) *param;
-               switch (operand) {
-                  case GL_SRC_ALPHA:
-                  case GL_ONE_MINUS_SRC_ALPHA:
-                     texUnit->CombineOperandA[pname-GL_OPERAND0_ALPHA_EXT]
-                        = operand;
-                     break;
-                  default:
-                     gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(param)" );
-                     return;
-               }
-            }
-            else {
-               gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(pname)");
-               return;
-            }
-            break;
-         case GL_OPERAND2_RGB_EXT:
-            if (ctx->Extensions.EXT_texture_env_combine) {
-               if ((GLenum) (GLint) *param == GL_SRC_ALPHA) {
-                  texUnit->CombineOperandRGB[2] = (GLenum) (GLint) *param;
-               }
-               else {
-                  gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(param)" );
-                  return;
-               }
-            }
-            else {
-               gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(pname)");
-               return;
-            }
-            break;
-         case GL_OPERAND2_ALPHA_EXT:
-            if (ctx->Extensions.EXT_texture_env_combine) {
-               if ((GLenum) (GLint) *param == GL_SRC_ALPHA) {
-                  texUnit->CombineOperandA[2] = (GLenum) (GLint) *param;
-               }
-               else {
-                  gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(param)" );
-                  return;
-               }
-            }
-            else {
-               gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(pname)");
-               return;
-            }
-            break;
-         case GL_RGB_SCALE_EXT:
-            if (ctx->Extensions.EXT_texture_env_combine) {
-               if (*param == 1.0) {
-                  texUnit->CombineScaleShiftRGB = 0;
-               }
-               else if (*param == 2.0) {
-                  texUnit->CombineScaleShiftRGB = 1;
-               }
-               else if (*param == 4.0) {
-                  texUnit->CombineScaleShiftRGB = 2;
-               }
-               else {
-                  gl_error( ctx, GL_INVALID_VALUE, "glTexEnv(param)" );
+      case GL_TEXTURE_ENV_MODE: {
+        GLenum mode = (GLenum) (GLint) *param;
+
+        switch (mode) {
+        case GL_ADD:
+           if (!ctx->Extensions.EXT_texture_env_add) {
+              TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", mode);
+              return;
+           }
+           break;
+        case GL_COMBINE_EXT:
+           if (!ctx->Extensions.EXT_texture_env_combine &&
+                !ctx->Extensions.ARB_texture_env_combine) {
+              TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", mode);
+              return;
+           }
+           break;
+        case GL_MODULATE:
+        case GL_BLEND:
+        case GL_DECAL:
+        case GL_REPLACE:
+           break;
+        default:
+            TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", mode);
+           return;
+        }
+
+        if (texUnit->EnvMode == mode)
+           return;
+        FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+        texUnit->EnvMode = mode;
+        break;
+      }
+      case GL_TEXTURE_ENV_COLOR: {
+        GLfloat tmp[4];
+        tmp[0] = CLAMP( param[0], 0.0F, 1.0F );
+        tmp[1] = CLAMP( param[1], 0.0F, 1.0F );
+        tmp[2] = CLAMP( param[2], 0.0F, 1.0F );
+        tmp[3] = CLAMP( param[3], 0.0F, 1.0F );
+        if (TEST_EQ_4V(tmp, texUnit->EnvColor))
+           return;
+        FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+        COPY_4FV(texUnit->EnvColor, tmp);
+        break;
+      }
+      case GL_COMBINE_RGB_EXT:
+        if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+           const GLenum mode = (GLenum) (GLint) *param;
+           switch (mode) {
+           case GL_REPLACE:
+           case GL_MODULATE:
+           case GL_ADD:
+           case GL_ADD_SIGNED_EXT:
+           case GL_INTERPOLATE_EXT:
+               /* OK */
+              break;
+            case GL_SUBTRACT_ARB:
+               if (!ctx->Extensions.ARB_texture_env_combine) {
+                  TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", mode);
                   return;
                }
-            }
-            else {
-               gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(pname)");
-               return;
-            }
-            break;
-         case GL_ALPHA_SCALE:
-            if (ctx->Extensions.EXT_texture_env_combine) {
-               if (*param == 1.0) {
-                  texUnit->CombineScaleShiftA = 0;
-               }
-               else if (*param == 2.0) {
-                  texUnit->CombineScaleShiftA = 1;
-               }
-               else if (*param == 4.0) {
-                  texUnit->CombineScaleShiftA = 2;
-               }
-               else {
-                  gl_error( ctx, GL_INVALID_VALUE, "glTexEnv(param)" );
+               break;
+           case GL_DOT3_RGB_ARB:
+           case GL_DOT3_RGBA_ARB:
+              if (!ctx->Extensions.EXT_texture_env_dot3 &&
+                   !ctx->Extensions.ARB_texture_env_dot3) {
+                  TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", mode);
+                 return;
+              }
+              break;
+           default:
+               TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", mode);
+              return;
+           }
+           if (texUnit->CombineModeRGB == mode)
+              return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+           texUnit->CombineModeRGB = mode;
+        }
+        else {
+            TE_ERROR(GL_INVALID_ENUM, "glTexEnv(pname=%s)", pname);
+           return;
+        }
+         break;
+      case GL_COMBINE_ALPHA_EXT:
+        if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+           const GLenum mode = (GLenum) (GLint) *param;
+           switch (mode) {
+           case GL_REPLACE:
+           case GL_MODULATE:
+           case GL_ADD:
+           case GL_ADD_SIGNED_EXT:
+           case GL_INTERPOLATE_EXT:
+               /* OK */
+              break;
+            case GL_SUBTRACT_ARB:
+               if (!ctx->Extensions.ARB_texture_env_combine) {
+                  TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", mode);
                   return;
                }
-            }
-            else {
-               gl_error(ctx, GL_INVALID_ENUM, "glTexEnv(pname)");
+               break;
+           default:
+               TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", mode);
+              return;
+           }
+            if (texUnit->CombineModeA == mode)
                return;
-            }
-            break;
-         default:
-            gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(pname)" );
-            return;
+            FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+            texUnit->CombineModeA = mode;
+        }
+        else {
+            TE_ERROR(GL_INVALID_ENUM, "glTexEnv(pname=%s)", pname);
+           return;
+        }
+        break;
+      case GL_SOURCE0_RGB_EXT:
+      case GL_SOURCE1_RGB_EXT:
+      case GL_SOURCE2_RGB_EXT:
+        if (ctx->Extensions.EXT_texture_env_combine ||
+            ctx->Extensions.ARB_texture_env_combine) {
+           GLenum source = (GLenum) (GLint) *param;
+           GLuint s = pname - GL_SOURCE0_RGB_EXT;
+           switch (source) {
+           case GL_TEXTURE:
+           case GL_CONSTANT_EXT:
+           case GL_PRIMARY_COLOR_EXT:
+           case GL_PREVIOUS_EXT:
+              if (texUnit->CombineSourceRGB[s] == source)
+                 return;
+              FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+              texUnit->CombineSourceRGB[s] = source;
+              break;
+           default:
+               TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", source);
+              return;
+           }
+        }
+        else {
+            TE_ERROR(GL_INVALID_ENUM, "glTexEnv(pname=%s)", pname);
+           return;
+        }
+        break;
+      case GL_SOURCE0_ALPHA_EXT:
+      case GL_SOURCE1_ALPHA_EXT:
+      case GL_SOURCE2_ALPHA_EXT:
+        if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+           GLenum source = (GLenum) (GLint) *param;
+           GLuint s = pname - GL_SOURCE0_ALPHA_EXT;
+           switch (source) {
+           case GL_TEXTURE:
+           case GL_CONSTANT_EXT:
+           case GL_PRIMARY_COLOR_EXT:
+           case GL_PREVIOUS_EXT:
+              if (texUnit->CombineSourceA[s] == source) return;
+              FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+              texUnit->CombineSourceA[s] = source;
+              break;
+           default:
+               TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", source);
+              return;
+           }
+        }
+        else {
+            TE_ERROR(GL_INVALID_ENUM, "glTexEnv(pname=%s)", pname);
+           return;
+        }
+        break;
+      case GL_OPERAND0_RGB_EXT:
+      case GL_OPERAND1_RGB_EXT:
+        if (ctx->Extensions.EXT_texture_env_combine ||
+            ctx->Extensions.ARB_texture_env_combine) {
+           GLenum operand = (GLenum) (GLint) *param;
+           GLuint s = pname - GL_OPERAND0_RGB_EXT;
+           switch (operand) {
+           case GL_SRC_COLOR:
+           case GL_ONE_MINUS_SRC_COLOR:
+           case GL_SRC_ALPHA:
+           case GL_ONE_MINUS_SRC_ALPHA:
+              if (texUnit->CombineOperandRGB[s] == operand)
+                 return;
+              FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+              texUnit->CombineOperandRGB[s] = operand;
+              break;
+           default:
+               TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", operand);
+              return;
+           }
+        }
+        else {
+            TE_ERROR(GL_INVALID_ENUM, "glTexEnv(pname=%s)", pname);
+           return;
+        }
+        break;
+      case GL_OPERAND0_ALPHA_EXT:
+      case GL_OPERAND1_ALPHA_EXT:
+        if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+           GLenum operand = (GLenum) (GLint) *param;
+           switch (operand) {
+           case GL_SRC_ALPHA:
+           case GL_ONE_MINUS_SRC_ALPHA:
+              if (texUnit->CombineOperandA[pname-GL_OPERAND0_ALPHA_EXT] ==
+                  operand)
+                 return;
+              FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+              texUnit->CombineOperandA[pname-GL_OPERAND0_ALPHA_EXT] = operand;
+              break;
+           default:
+               TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", operand);
+              return;
+           }
+        }
+        else {
+            TE_ERROR(GL_INVALID_ENUM, "glTexEnv(pname=%s)", pname);
+           return;
+        }
+        break;
+      case GL_OPERAND2_RGB_EXT:
+        if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+           GLenum operand = (GLenum) (GLint) *param;
+           switch (operand) {
+           case GL_SRC_COLOR:           /* ARB combine only */
+           case GL_ONE_MINUS_SRC_COLOR: /* ARB combine only */
+           case GL_SRC_ALPHA:
+           case GL_ONE_MINUS_SRC_ALPHA: /* ARB combine only */
+              if (texUnit->CombineOperandRGB[2] == operand)
+                 return;
+              FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+              texUnit->CombineOperandRGB[2] = operand;
+           default:
+               TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", operand);
+              return;
+           }
+        }
+        else {
+            TE_ERROR(GL_INVALID_ENUM, "glTexEnv(pname=%s)", pname);
+           return;
+        }
+        break;
+      case GL_OPERAND2_ALPHA_EXT:
+        if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+           GLenum operand = (GLenum) (GLint) *param;
+           switch (operand) {
+           case GL_SRC_ALPHA:
+           case GL_ONE_MINUS_SRC_ALPHA: /* ARB combine only */
+              if (texUnit->CombineOperandA[2] == operand)
+                 return;
+              FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+              texUnit->CombineOperandA[2] = operand;
+              break;
+           default:
+               TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", operand);
+              return;
+           }
+        }
+        else {
+            TE_ERROR(GL_INVALID_ENUM, "glTexEnv(pname=%s)", pname);
+           return;
+        }
+        break;
+      case GL_RGB_SCALE_EXT:
+        if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+           GLuint newshift;
+           if (*param == 1.0) {
+              newshift = 0;
+           }
+           else if (*param == 2.0) {
+              newshift = 1;
+           }
+           else if (*param == 4.0) {
+              newshift = 2;
+           }
+           else {
+              _mesa_error( ctx, GL_INVALID_VALUE,
+                            "glTexEnv(GL_RGB_SCALE not 1, 2 or 4)" );
+              return;
+           }
+           if (texUnit->CombineScaleShiftRGB == newshift)
+              return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+           texUnit->CombineScaleShiftRGB = newshift;
+        }
+        else {
+            TE_ERROR(GL_INVALID_ENUM, "glTexEnv(pname=%s)", pname);
+           return;
+        }
+        break;
+      case GL_ALPHA_SCALE:
+        if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+           GLuint newshift;
+           if (*param == 1.0) {
+              newshift = 0;
+           }
+           else if (*param == 2.0) {
+              newshift = 1;
+           }
+           else if (*param == 4.0) {
+              newshift = 2;
+           }
+           else {
+              _mesa_error( ctx, GL_INVALID_VALUE,
+                            "glTexEnv(GL_ALPHA_SCALE not 1, 2 or 4)" );
+              return;
+           }
+           if (texUnit->CombineScaleShiftA == newshift)
+              return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+           texUnit->CombineScaleShiftA = newshift;
+        }
+        else {
+            TE_ERROR(GL_INVALID_ENUM, "glTexEnv(pname=%s)", pname);
+           return;
+        }
+        break;
+      default:
+        _mesa_error( ctx, GL_INVALID_ENUM, "glTexEnv(pname)" );
+        return;
       }
    }
    else if (target==GL_TEXTURE_FILTER_CONTROL_EXT) {
       if (!ctx->Extensions.EXT_texture_lod_bias) {
-        gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(param)" );
+        _mesa_error( ctx, GL_INVALID_ENUM, "glTexEnv(param)" );
         return;
       }
-      if (pname == GL_TEXTURE_LOD_BIAS_EXT) {
-        texUnit->LodBias = param[0];
-      }
-      else {
-        gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(pname)" );
+      switch (pname) {
+      case GL_TEXTURE_LOD_BIAS_EXT:
+        if (texUnit->LodBias == param[0])
+           return;
+        FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+         texUnit->LodBias = CLAMP(param[0], -ctx->Const.MaxTextureLodBias,
+                                  ctx->Const.MaxTextureLodBias);
+        break;
+      default:
+         TE_ERROR(GL_INVALID_ENUM, "glTexEnv(pname=%s)", pname);
         return;
       }
    }
    else {
-      gl_error( ctx, GL_INVALID_ENUM, "glTexEnv(target)" );
+      _mesa_error( ctx, GL_INVALID_ENUM, "glTexEnv(target)" );
       return;
    }
 
    if (MESA_VERBOSE&(VERBOSE_API|VERBOSE_TEXTURE))
-      fprintf(stderr, "glTexEnv %s %s %.1f(%s) ...\n",  
-             gl_lookup_enum_by_nr(target),
-             gl_lookup_enum_by_nr(pname),
+      fprintf(stderr, "glTexEnv %s %s %.1f(%s) ...\n",
+             _mesa_lookup_enum_by_nr(target),
+             _mesa_lookup_enum_by_nr(pname),
              *param,
-             gl_lookup_enum_by_nr((GLenum) (GLint) *param));
+             _mesa_lookup_enum_by_nr((GLenum) (GLint) *param));
 
    /* Tell device driver about the new texture environment */
    if (ctx->Driver.TexEnv) {
       (*ctx->Driver.TexEnv)( ctx, target, pname, param );
    }
-
-   ctx->NewState |= _NEW_TEXTURE;
 }
 
 
@@ -380,10 +468,16 @@ void
 _mesa_TexEnviv( GLenum target, GLenum pname, const GLint *param )
 {
    GLfloat p[4];
-   p[0] = INT_TO_FLOAT( param[0] );
-   p[1] = INT_TO_FLOAT( param[1] );
-   p[2] = INT_TO_FLOAT( param[2] );
-   p[3] = INT_TO_FLOAT( param[3] );
+   if (pname == GL_TEXTURE_ENV_COLOR) {
+      p[0] = INT_TO_FLOAT( param[0] );
+      p[1] = INT_TO_FLOAT( param[1] );
+      p[2] = INT_TO_FLOAT( param[2] );
+      p[3] = INT_TO_FLOAT( param[3] );
+   }
+   else {
+      p[0] = (GLint) param[0];
+      p[1] = p[2] = p[3] = 0;  /* init to zero, just to be safe */
+   }
    _mesa_TexEnvfv( target, pname, p );
 }
 
@@ -393,11 +487,10 @@ _mesa_GetTexEnvfv( GLenum target, GLenum pname, GLfloat *params )
 {
    GET_CURRENT_CONTEXT(ctx);
    const struct gl_texture_unit *texUnit = &ctx->Texture.Unit[ctx->Texture.CurrentUnit];
-
-   ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH(ctx, "glGetTexEnvfv");
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
    if (target!=GL_TEXTURE_ENV) {
-      gl_error( ctx, GL_INVALID_ENUM, "glGetTexEnvfv(target)" );
+      _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexEnvfv(target)" );
       return;
    }
 
@@ -408,8 +501,135 @@ _mesa_GetTexEnvfv( GLenum target, GLenum pname, GLfloat *params )
       case GL_TEXTURE_ENV_COLOR:
         COPY_4FV( params, texUnit->EnvColor );
         break;
+      case GL_COMBINE_RGB_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineModeRGB;
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_COMBINE_ALPHA_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineModeA;
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_SOURCE0_RGB_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineSourceRGB[0];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_SOURCE1_RGB_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineSourceRGB[1];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_SOURCE2_RGB_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineSourceRGB[2];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_SOURCE0_ALPHA_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineSourceA[0];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_SOURCE1_ALPHA_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineSourceA[1];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_SOURCE2_ALPHA_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineSourceA[2];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_OPERAND0_RGB_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineOperandRGB[0];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_OPERAND1_RGB_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineOperandRGB[1];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_OPERAND2_RGB_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineOperandRGB[2];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_OPERAND0_ALPHA_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineOperandA[0];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_OPERAND1_ALPHA_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineOperandA[1];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+         break;
+      case GL_OPERAND2_ALPHA_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            *params = (GLfloat) texUnit->CombineOperandA[2];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+         }
+        break;
       case GL_RGB_SCALE_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             if (texUnit->CombineScaleShiftRGB == 0)
                *params = 1.0;
             else if (texUnit->CombineScaleShiftRGB == 1)
@@ -418,12 +638,13 @@ _mesa_GetTexEnvfv( GLenum target, GLenum pname, GLfloat *params )
                *params = 4.0;
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
             return;
          }
          break;
       case GL_ALPHA_SCALE:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             if (texUnit->CombineScaleShiftA == 0)
                *params = 1.0;
             else if (texUnit->CombineScaleShiftA == 1)
@@ -432,12 +653,12 @@ _mesa_GetTexEnvfv( GLenum target, GLenum pname, GLfloat *params )
                *params = 4.0;
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)");
             return;
          }
          break;
       default:
-         gl_error( ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)" );
+         _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexEnvfv(pname)" );
    }
 }
 
@@ -447,11 +668,10 @@ _mesa_GetTexEnviv( GLenum target, GLenum pname, GLint *params )
 {
    GET_CURRENT_CONTEXT(ctx);
    const struct gl_texture_unit *texUnit = &ctx->Texture.Unit[ctx->Texture.CurrentUnit];
-
-   ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH(ctx, "glGetTexEnviv");
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
    if (target != GL_TEXTURE_ENV) {
-      gl_error( ctx, GL_INVALID_ENUM, "glGetTexEnviv(target)" );
+      _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexEnviv(target)" );
       return;
    }
 
@@ -466,119 +686,163 @@ _mesa_GetTexEnviv( GLenum target, GLenum pname, GLint *params )
         params[3] = FLOAT_TO_INT( texUnit->EnvColor[3] );
          break;
       case GL_COMBINE_RGB_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineModeRGB;
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_COMBINE_ALPHA_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineModeA;
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_SOURCE0_RGB_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineSourceRGB[0];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_SOURCE1_RGB_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineSourceRGB[1];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_SOURCE2_RGB_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineSourceRGB[2];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_SOURCE0_ALPHA_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineSourceA[0];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_SOURCE1_ALPHA_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineSourceA[1];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_SOURCE2_ALPHA_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineSourceA[2];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_OPERAND0_RGB_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineOperandRGB[0];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_OPERAND1_RGB_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineOperandRGB[1];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_OPERAND2_RGB_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineOperandRGB[2];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_OPERAND0_ALPHA_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineOperandA[0];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_OPERAND1_ALPHA_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineOperandA[1];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
          break;
       case GL_OPERAND2_ALPHA_EXT:
-         if (ctx->Extensions.EXT_texture_env_combine) {
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
             *params = (GLint) texUnit->CombineOperandA[2];
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
          }
         break;
+      case GL_RGB_SCALE_EXT:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            if (texUnit->CombineScaleShiftRGB == 0)
+               *params = 1;
+            else if (texUnit->CombineScaleShiftRGB == 1)
+               *params = 2;
+            else
+               *params = 4;
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            return;
+         }
+         break;
+      case GL_ALPHA_SCALE:
+         if (ctx->Extensions.EXT_texture_env_combine ||
+             ctx->Extensions.ARB_texture_env_combine) {
+            if (texUnit->CombineScaleShiftA == 0)
+               *params = 1;
+            else if (texUnit->CombineScaleShiftA == 1)
+               *params = 2;
+            else
+               *params = 4;
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)");
+            return;
+         }
+         break;
       default:
-         gl_error( ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)" );
+         _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexEnviv(pname)" );
    }
 }
 
@@ -604,13 +868,12 @@ _mesa_TexParameterfv( GLenum target, GLenum pname, const GLfloat *params )
    struct gl_texture_unit *texUnit = &ctx->Texture.Unit[ctx->Texture.CurrentUnit];
    GLenum eparam = (GLenum) (GLint) params[0];
    struct gl_texture_object *texObj;
-
-   ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH(ctx, "glTexParameterfv");
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
    if (MESA_VERBOSE&(VERBOSE_API|VERBOSE_TEXTURE))
-      fprintf(stderr, "texPARAM %s %s %d...\n", 
-             gl_lookup_enum_by_nr(target),
-             gl_lookup_enum_by_nr(pname),
+      fprintf(stderr, "texPARAM %s %s %d...\n",
+             _mesa_lookup_enum_by_nr(target),
+             _mesa_lookup_enum_by_nr(pname),
              eparam);
 
 
@@ -631,7 +894,7 @@ _mesa_TexParameterfv( GLenum target, GLenum pname, const GLfloat *params )
          }
          /* fallthrough */
       default:
-         gl_error( ctx, GL_INVALID_ENUM, "glTexParameter(target)" );
+         _mesa_error( ctx, GL_INVALID_ENUM, "glTexParameter(target)" );
          return;
    }
 
@@ -646,97 +909,270 @@ _mesa_TexParameterfv( GLenum target, GLenum pname, const GLfloat *params )
              || eparam==GL_LINEAR_MIPMAP_NEAREST
              || eparam==GL_NEAREST_MIPMAP_LINEAR
              || eparam==GL_LINEAR_MIPMAP_LINEAR) {
+            FLUSH_VERTICES(ctx, _NEW_TEXTURE);
             texObj->MinFilter = eparam;
          }
          else {
-            gl_error( ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+            _mesa_error( ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+            return;
+         }
+         break;
+      case GL_TEXTURE_MAG_FILTER:
+         /* A small optimization */
+         if (texObj->MagFilter == eparam)
+            return;
+
+         if (eparam==GL_NEAREST || eparam==GL_LINEAR) {
+            FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+            texObj->MagFilter = eparam;
+         }
+         else {
+            _mesa_error( ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+            return;
+         }
+         break;
+      case GL_TEXTURE_WRAP_S:
+         if (texObj->WrapS == eparam)
+            return;
+         if (eparam==GL_CLAMP ||
+             eparam==GL_REPEAT ||
+             eparam==GL_CLAMP_TO_EDGE ||
+             (eparam == GL_CLAMP_TO_BORDER_ARB &&
+              ctx->Extensions.ARB_texture_border_clamp) ||
+             (eparam == GL_MIRRORED_REPEAT_ARB &&
+              ctx->Extensions.ARB_texture_mirrored_repeat)) {
+            FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+            texObj->WrapS = eparam;
+         }
+         else {
+            _mesa_error( ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+            return;
+         }
+         break;
+      case GL_TEXTURE_WRAP_T:
+         if (texObj->WrapT == eparam)
+            return;
+         if (eparam==GL_CLAMP ||
+             eparam==GL_REPEAT ||
+             eparam==GL_CLAMP_TO_EDGE ||
+             (eparam == GL_CLAMP_TO_BORDER_ARB &&
+              ctx->Extensions.ARB_texture_border_clamp) ||
+             (eparam == GL_MIRRORED_REPEAT_ARB &&
+              ctx->Extensions.ARB_texture_mirrored_repeat)) {
+            FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+            texObj->WrapT = eparam;
+         }
+         else {
+            _mesa_error( ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+            return;
+         }
+         break;
+      case GL_TEXTURE_WRAP_R_EXT:
+         if (texObj->WrapR == eparam)
+            return;
+         if (eparam==GL_CLAMP ||
+             eparam==GL_REPEAT ||
+             eparam==GL_CLAMP_TO_EDGE ||
+             (eparam == GL_CLAMP_TO_BORDER_ARB &&
+              ctx->Extensions.ARB_texture_border_clamp) ||
+             (eparam == GL_MIRRORED_REPEAT_ARB &&
+              ctx->Extensions.ARB_texture_mirrored_repeat)) {
+            FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+            texObj->WrapR = eparam;
+         }
+         else {
+            _mesa_error( ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+         }
+         break;
+#if 0 /* someday */
+      case GL_TEXTUER_BORDER_VALUES_NV:
+         /* don't clamp */
+         FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+         COPY_4V(texObj->BorderValues, params);
+         UNCLAMPED_FLOAT_TO_CHAN(texObj->BorderColor[0], params[0]);
+         UNCLAMPED_FLOAT_TO_CHAN(texObj->BorderColor[1], params[1]);
+         UNCLAMPED_FLOAT_TO_CHAN(texObj->BorderColor[2], params[2]);
+         UNCLAMPED_FLOAT_TO_CHAN(texObj->BorderColor[3], params[3]);
+         break;
+#endif
+      case GL_TEXTURE_BORDER_COLOR:
+         /* clamp */
+         FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+         texObj->BorderValues[0] = CLAMP(params[0], 0.0F, 1.0F);
+         texObj->BorderValues[1] = CLAMP(params[1], 0.0F, 1.0F);
+         texObj->BorderValues[2] = CLAMP(params[2], 0.0F, 1.0F);
+         texObj->BorderValues[3] = CLAMP(params[3], 0.0F, 1.0F);
+         UNCLAMPED_FLOAT_TO_CHAN(texObj->BorderColor[0], texObj->BorderValues[0]);
+         UNCLAMPED_FLOAT_TO_CHAN(texObj->BorderColor[1], texObj->BorderValues[1]);
+         UNCLAMPED_FLOAT_TO_CHAN(texObj->BorderColor[2], texObj->BorderValues[2]);
+         UNCLAMPED_FLOAT_TO_CHAN(texObj->BorderColor[3], texObj->BorderValues[3]);
+         break;
+      case GL_TEXTURE_MIN_LOD:
+         if (texObj->MinLod == params[0])
+            return;
+         FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+         texObj->MinLod = params[0];
+         break;
+      case GL_TEXTURE_MAX_LOD:
+         if (texObj->MaxLod == params[0])
+            return;
+         FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+         texObj->MaxLod = params[0];
+         break;
+      case GL_TEXTURE_BASE_LEVEL:
+         if (params[0] < 0.0) {
+            _mesa_error(ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+            return;
+         }
+         FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+         texObj->BaseLevel = (GLint) params[0];
+         break;
+      case GL_TEXTURE_MAX_LEVEL:
+         if (params[0] < 0.0) {
+            _mesa_error(ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+            return;
+         }
+         FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+         texObj->MaxLevel = (GLint) params[0];
+         break;
+      case GL_TEXTURE_PRIORITY:
+         /* (keithh@netcomuk.co.uk) */
+         FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+         texObj->Priority = CLAMP( params[0], 0.0F, 1.0F );
+         break;
+      case GL_TEXTURE_MAX_ANISOTROPY_EXT:
+         if (ctx->Extensions.EXT_texture_filter_anisotropic) {
+           if (params[0] < 1.0) {
+              _mesa_error(ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+              return;
+           }
+            FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+            texObj->MaxAnisotropy = params[0];
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM,
+                        "glTexParameter(pname=GL_MAX_TEXTURE_ANISOTROPY_EXT)");
+            return;
+         }
+         break;
+      case GL_TEXTURE_COMPARE_SGIX:
+         if (ctx->Extensions.SGIX_shadow) {
+            FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+            texObj->CompareFlag = params[0] ? GL_TRUE : GL_FALSE;
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM,
+                        "glTexParameter(pname=GL_TEXTURE_COMPARE_SGIX)");
+            return;
+         }
+         break;
+      case GL_TEXTURE_COMPARE_OPERATOR_SGIX:
+         if (ctx->Extensions.SGIX_shadow) {
+            GLenum op = (GLenum) params[0];
+            if (op == GL_TEXTURE_LEQUAL_R_SGIX ||
+                op == GL_TEXTURE_GEQUAL_R_SGIX) {
+               FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+               texObj->CompareOperator = op;
+            }
+            else {
+               _mesa_error(ctx, GL_INVALID_ENUM, "glTexParameter(param)");
+            }
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM,
+                    "glTexParameter(pname=GL_TEXTURE_COMPARE_OPERATOR_SGIX)");
             return;
          }
          break;
-      case GL_TEXTURE_MAG_FILTER:
-         /* A small optimization */
-         if (texObj->MagFilter == eparam)
-            return;
-
-         if (eparam==GL_NEAREST || eparam==GL_LINEAR) {
-            texObj->MagFilter = eparam;
+      case GL_SHADOW_AMBIENT_SGIX: /* aka GL_TEXTURE_COMPARE_FAIL_VALUE_ARB */
+         if (ctx->Extensions.SGIX_shadow_ambient) {
+            FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+            UNCLAMPED_FLOAT_TO_CHAN(texObj->ShadowAmbient, params[0]);
          }
          else {
-            gl_error( ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+            _mesa_error(ctx, GL_INVALID_ENUM,
+                        "glTexParameter(pname=GL_SHADOW_AMBIENT_SGIX)");
             return;
          }
          break;
-      case GL_TEXTURE_WRAP_S:
-         if (texObj->WrapS == eparam)
-            return;
-
-         if (eparam==GL_CLAMP || eparam==GL_REPEAT || eparam==GL_CLAMP_TO_EDGE) {
-            texObj->WrapS = eparam;
+      case GL_GENERATE_MIPMAP_SGIS:
+         if (ctx->Extensions.SGIS_generate_mipmap) {
+            texObj->GenerateMipmap = params[0] ? GL_TRUE : GL_FALSE;
          }
          else {
-            gl_error( ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+            _mesa_error(ctx, GL_INVALID_ENUM,
+                        "glTexParameter(pname=GL_GENERATE_MIPMAP_SGIS)");
             return;
          }
          break;
-      case GL_TEXTURE_WRAP_T:
-         if (texObj->WrapT == eparam)
-            return;
-
-         if (eparam==GL_CLAMP || eparam==GL_REPEAT || eparam==GL_CLAMP_TO_EDGE) {
-            texObj->WrapT = eparam;
+      case GL_TEXTURE_COMPARE_MODE_ARB:
+         if (ctx->Extensions.ARB_shadow) {
+            const GLenum mode = (GLenum) params[0];
+            if (mode == GL_NONE || mode == GL_COMPARE_R_TO_TEXTURE_ARB) {
+               FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+               texObj->CompareMode = params[0];
+            }
+            else {
+               _mesa_error(ctx, GL_INVALID_ENUM,
+                           "glTexParameter(bad GL_TEXTURE_COMPARE_MODE_ARB)");
+               return;
+            }
          }
          else {
-            gl_error( ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+            _mesa_error(ctx, GL_INVALID_ENUM,
+                        "glTexParameter(pname=GL_TEXTURE_COMPARE_MODE_ARB)");
             return;
          }
          break;
-      case GL_TEXTURE_WRAP_R_EXT:
-         if (texObj->WrapR == eparam)
-            return;
-
-         if (eparam==GL_CLAMP || eparam==GL_REPEAT || eparam==GL_CLAMP_TO_EDGE) {
-            texObj->WrapR = eparam;
+      case GL_TEXTURE_COMPARE_FUNC_ARB:
+         if (ctx->Extensions.ARB_shadow) {
+            const GLenum func = (GLenum) params[0];
+            if (func == GL_LEQUAL || func == GL_GEQUAL) {
+               FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+               texObj->CompareFunc = params[0];
+            }
+            else {
+               _mesa_error(ctx, GL_INVALID_ENUM,
+                           "glTexParameter(bad GL_TEXTURE_COMPARE_FUNC_ARB)");
+               return;
+            }
          }
          else {
-            gl_error( ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
-         }
-         break;
-      case GL_TEXTURE_BORDER_COLOR:
-         texObj->BorderColor[0] = (GLchan) CLAMP((GLint)(params[0]*CHAN_MAXF), 0, CHAN_MAX);
-         texObj->BorderColor[1] = (GLchan) CLAMP((GLint)(params[1]*CHAN_MAXF), 0, CHAN_MAX);
-         texObj->BorderColor[2] = (GLchan) CLAMP((GLint)(params[2]*CHAN_MAXF), 0, CHAN_MAX);
-         texObj->BorderColor[3] = (GLchan) CLAMP((GLint)(params[3]*CHAN_MAXF), 0, CHAN_MAX);
-         break;
-      case GL_TEXTURE_MIN_LOD:
-         texObj->MinLod = params[0];
-         break;
-      case GL_TEXTURE_MAX_LOD:
-         texObj->MaxLod = params[0];
-         break;
-      case GL_TEXTURE_BASE_LEVEL:
-         if (params[0] < 0.0) {
-            gl_error(ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+            _mesa_error(ctx, GL_INVALID_ENUM,
+                        "glTexParameter(pname=GL_TEXTURE_COMPARE_FUNC_ARB)");
             return;
          }
-         texObj->BaseLevel = (GLint) params[0];
          break;
-      case GL_TEXTURE_MAX_LEVEL:
-         if (params[0] < 0.0) {
-            gl_error(ctx, GL_INVALID_VALUE, "glTexParameter(param)" );
+      case GL_DEPTH_TEXTURE_MODE_ARB:
+         if (ctx->Extensions.ARB_depth_texture) {
+            const GLenum result = (GLenum) params[0];
+            if (result == GL_LUMINANCE || result == GL_INTENSITY
+                || result == GL_ALPHA) {
+               FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+               texObj->DepthMode = params[0];
+            }
+            else {
+               _mesa_error(ctx, GL_INVALID_ENUM,
+                          "glTexParameter(bad GL_DEPTH_TEXTURE_MODE_ARB)");
+               return;
+            }
+         }
+         else {
+            _mesa_error(ctx, GL_INVALID_ENUM,
+                        "glTexParameter(pname=GL_DEPTH_TEXTURE_MODE_ARB)");
             return;
          }
-         texObj->MaxLevel = (GLint) params[0];
-         break;
-      case GL_TEXTURE_PRIORITY:
-         /* (keithh@netcomuk.co.uk) */
-         texObj->Priority = CLAMP( params[0], 0.0F, 1.0F );
          break;
+
       default:
-         gl_error( ctx, GL_INVALID_ENUM, "glTexParameter(pname)" );
+         {
+            char s[100];
+            sprintf(s, "glTexParameter(pname=0x%x)", pname);
+            _mesa_error( ctx, GL_INVALID_ENUM, s);
+         }
          return;
    }
 
-   ctx->NewState |= _NEW_TEXTURE;
    texObj->Complete = GL_FALSE;
 
    if (ctx->Driver.TexParameter) {
@@ -746,7 +1182,7 @@ _mesa_TexParameterfv( GLenum target, GLenum pname, const GLfloat *params )
 
 
 void
-_mesa_TexParameteri( GLenum target, GLenum pname, const GLint param )
+_mesa_TexParameteri( GLenum target, GLenum pname, GLint param )
 {
    GLfloat fparam[4];
    fparam[0] = (GLfloat) param;
@@ -789,9 +1225,15 @@ tex_image_dimensions(GLcontext *ctx, GLenum target)
          return 3;
       case GL_TEXTURE_CUBE_MAP_ARB:
       case GL_PROXY_TEXTURE_CUBE_MAP_ARB:
+      case GL_TEXTURE_CUBE_MAP_POSITIVE_X_ARB:
+      case GL_TEXTURE_CUBE_MAP_NEGATIVE_X_ARB:
+      case GL_TEXTURE_CUBE_MAP_POSITIVE_Y_ARB:
+      case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y_ARB:
+      case GL_TEXTURE_CUBE_MAP_POSITIVE_Z_ARB:
+      case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z_ARB:
          return ctx->Extensions.ARB_texture_cube_map ? 2 : 0;
       default:
-         gl_problem(ctx, "bad target in _mesa_tex_target_dimensions()");
+         _mesa_problem(ctx, "bad target in _mesa_tex_target_dimensions()");
          return 0;
    }
 }
@@ -806,22 +1248,39 @@ _mesa_GetTexLevelParameteriv( GLenum target, GLint level,
    const struct gl_texture_image *img = NULL;
    GLuint dimensions;
    GLboolean isProxy;
+   GLint maxLevels;
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
-   ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH(ctx, "glGetTexLevelParameter");
-
-   if (level < 0 || level >= ctx->Const.MaxTextureLevels) {
-      gl_error( ctx, GL_INVALID_VALUE, "glGetTexLevelParameter[if]v" );
+   dimensions = tex_image_dimensions(ctx, target);  /* 1, 2 or 3 */
+   if (dimensions == 0) {
+      _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexLevelParameter[if]v(target)");
       return;
    }
 
-   dimensions = tex_image_dimensions(ctx, target);  /* 1, 2 or 3 */
-   if (dimensions == 0) {
-      gl_error(ctx, GL_INVALID_ENUM, "glGetTexLevelParameter[if]v(target)");
+   switch (target) {
+   case GL_TEXTURE_1D:
+   case GL_PROXY_TEXTURE_1D:
+   case GL_TEXTURE_2D:
+   case GL_PROXY_TEXTURE_2D:
+      maxLevels = ctx->Const.MaxTextureLevels;
+      break;
+   case GL_TEXTURE_3D:
+   case GL_PROXY_TEXTURE_3D:
+      maxLevels = ctx->Const.Max3DTextureLevels;
+      break;
+   default:
+      maxLevels = ctx->Const.MaxCubeTextureLevels;
+      break;
+   }
+
+   if (level < 0 || level >= maxLevels) {
+      _mesa_error( ctx, GL_INVALID_VALUE, "glGetTexLevelParameter[if]v" );
       return;
    }
 
    img = _mesa_select_tex_image(ctx, texUnit, target, level);
-   if (!img) {
+   if (!img || !img->TexFormat) {
+      /* undefined texture image */
       if (pname == GL_TEXTURE_COMPONENTS)
          *params = 1;
       else
@@ -839,49 +1298,73 @@ _mesa_GetTexLevelParameteriv( GLenum target, GLint level,
          *params = img->Width;
          return;
       case GL_TEXTURE_HEIGHT:
-         if (dimensions > 1) {
-            *params = img->Height;
-         }
-         else {
-            gl_error( ctx, GL_INVALID_ENUM,
-                      "glGetTexLevelParameter[if]v(pname=GL_TEXTURE_HEIGHT)" );
-         }
+         *params = img->Height;
          return;
       case GL_TEXTURE_DEPTH:
-         if (dimensions > 2) {
-            *params = img->Depth;
-         }
-         else {
-            gl_error( ctx, GL_INVALID_ENUM,
-                      "glGetTexLevelParameter[if]v(pname=GL_TEXTURE_DEPTH)" );
-         }
+         *params = img->Depth;
          return;
-      case GL_TEXTURE_COMPONENTS:
+      case GL_TEXTURE_INTERNAL_FORMAT:
          *params = img->IntFormat;
          return;
       case GL_TEXTURE_BORDER:
          *params = img->Border;
          return;
       case GL_TEXTURE_RED_SIZE:
-         *params = img->RedBits;
+         if (img->Format == GL_RGB || img->Format == GL_RGBA)
+            *params = img->TexFormat->RedBits;
+         else
+            *params = 0;
          return;
       case GL_TEXTURE_GREEN_SIZE:
-         *params = img->GreenBits;
+         if (img->Format == GL_RGB || img->Format == GL_RGBA)
+            *params = img->TexFormat->GreenBits;
+         else
+            *params = 0;
          return;
       case GL_TEXTURE_BLUE_SIZE:
-         *params = img->BlueBits;
+         if (img->Format == GL_RGB || img->Format == GL_RGBA)
+            *params = img->TexFormat->BlueBits;
+         else
+            *params = 0;
          return;
       case GL_TEXTURE_ALPHA_SIZE:
-         *params = img->AlphaBits;
+         if (img->Format == GL_ALPHA || img->Format == GL_LUMINANCE_ALPHA ||
+             img->Format == GL_RGBA)
+            *params = img->TexFormat->AlphaBits;
+         else
+            *params = 0;
          return;
       case GL_TEXTURE_INTENSITY_SIZE:
-         *params = img->IntensityBits;
+         if (img->Format != GL_INTENSITY)
+            *params = 0;
+         else if (img->TexFormat->IntensityBits > 0)
+            *params = img->TexFormat->IntensityBits;
+         else /* intensity probably stored as rgb texture */
+            *params = MIN2(img->TexFormat->RedBits, img->TexFormat->GreenBits);
          return;
       case GL_TEXTURE_LUMINANCE_SIZE:
-         *params = img->LuminanceBits;
+         if (img->Format != GL_LUMINANCE &&
+             img->Format != GL_LUMINANCE_ALPHA)
+            *params = 0;
+         else if (img->TexFormat->LuminanceBits > 0)
+            *params = img->TexFormat->LuminanceBits;
+         else /* luminance probably stored as rgb texture */
+            *params = MIN2(img->TexFormat->RedBits, img->TexFormat->GreenBits);
          return;
       case GL_TEXTURE_INDEX_SIZE_EXT:
-         *params = img->IndexBits;
+         if (img->Format == GL_COLOR_INDEX)
+            *params = img->TexFormat->IndexBits;
+         else
+            *params = 0;
+         return;
+      case GL_DEPTH_BITS:
+         /* XXX this isn't in the GL_SGIX_depth_texture spec
+          * but seems appropriate.
+          */
+         if (ctx->Extensions.SGIX_depth_texture)
+            *params = img->TexFormat->DepthBits;
+         else
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexLevelParameter[if]v(pname)");
          return;
 
       /* GL_ARB_texture_compression */
@@ -890,11 +1373,11 @@ _mesa_GetTexLevelParameteriv( GLenum target, GLint level,
             if (img->IsCompressed && !isProxy)
                *params = img->CompressedSize;
             else
-               gl_error(ctx, GL_INVALID_OPERATION,
+               _mesa_error(ctx, GL_INVALID_OPERATION,
                         "glGetTexLevelParameter[if]v(pname)");
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexLevelParameter[if]v(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexLevelParameter[if]v(pname)");
          }
          return;
       case GL_TEXTURE_COMPRESSED_ARB:
@@ -902,12 +1385,12 @@ _mesa_GetTexLevelParameteriv( GLenum target, GLint level,
             *params = (GLint) img->IsCompressed;
          }
          else {
-            gl_error(ctx, GL_INVALID_ENUM, "glGetTexLevelParameter[if]v(pname)");
+            _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexLevelParameter[if]v(pname)");
          }
          return;
 
       default:
-         gl_error(ctx, GL_INVALID_ENUM, "glGetTexLevelParameter[if]v(pname)");
+         _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexLevelParameter[if]v(pname)");
    }
 }
 
@@ -919,37 +1402,46 @@ _mesa_GetTexParameterfv( GLenum target, GLenum pname, GLfloat *params )
    GET_CURRENT_CONTEXT(ctx);
    struct gl_texture_unit *texUnit = &ctx->Texture.Unit[ctx->Texture.CurrentUnit];
    struct gl_texture_object *obj;
-
-   ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH(ctx, "glGetTexParameterfv");
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
    obj = _mesa_select_tex_object(ctx, texUnit, target);
    if (!obj) {
-      gl_error(ctx, GL_INVALID_ENUM, "glGetTexParameterfv(target)");
+      _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexParameterfv(target)");
       return;
    }
 
    switch (pname) {
       case GL_TEXTURE_MAG_FILTER:
         *params = ENUM_TO_FLOAT(obj->MagFilter);
-        break;
+        return;
       case GL_TEXTURE_MIN_FILTER:
          *params = ENUM_TO_FLOAT(obj->MinFilter);
-         break;
+         return;
       case GL_TEXTURE_WRAP_S:
          *params = ENUM_TO_FLOAT(obj->WrapS);
-         break;
+         return;
       case GL_TEXTURE_WRAP_T:
          *params = ENUM_TO_FLOAT(obj->WrapT);
-         break;
+         return;
       case GL_TEXTURE_WRAP_R_EXT:
          *params = ENUM_TO_FLOAT(obj->WrapR);
-         break;
+         return;
+#if 0 /* someday */
+      case GL_TEXTURE_BORDER_VALUES_NV:
+         /* unclamped */
+         params[0] = obj->BorderValues[0];
+         params[1] = obj->BorderValues[1];
+         params[2] = obj->BorderValues[2];
+         params[3] = obj->BorderValues[3];
+         return;
+#endif
       case GL_TEXTURE_BORDER_COLOR:
+         /* clamped */
          params[0] = obj->BorderColor[0] / CHAN_MAXF;
          params[1] = obj->BorderColor[1] / CHAN_MAXF;
          params[2] = obj->BorderColor[2] / CHAN_MAXF;
          params[3] = obj->BorderColor[3] / CHAN_MAXF;
-         break;
+         return;
       case GL_TEXTURE_RESIDENT:
          {
             GLboolean resident;
@@ -959,25 +1451,69 @@ _mesa_GetTexParameterfv( GLenum target, GLenum pname, GLfloat *params )
                resident = GL_TRUE;
             *params = ENUM_TO_FLOAT(resident);
          }
-         break;
+         return;
       case GL_TEXTURE_PRIORITY:
          *params = obj->Priority;
-         break;
+         return;
       case GL_TEXTURE_MIN_LOD:
          *params = obj->MinLod;
-         break;
+         return;
       case GL_TEXTURE_MAX_LOD:
          *params = obj->MaxLod;
-         break;
+         return;
       case GL_TEXTURE_BASE_LEVEL:
          *params = (GLfloat) obj->BaseLevel;
-         break;
+         return;
       case GL_TEXTURE_MAX_LEVEL:
          *params = (GLfloat) obj->MaxLevel;
+         return;
+      case GL_TEXTURE_COMPARE_SGIX:
+         if (ctx->Extensions.SGIX_shadow) {
+            *params = (GLfloat) obj->CompareFlag;
+            return;
+         }
+         break;
+      case GL_TEXTURE_COMPARE_OPERATOR_SGIX:
+         if (ctx->Extensions.SGIX_shadow) {
+            *params = (GLfloat) obj->CompareOperator;
+            return;
+         }
+         break;
+      case GL_SHADOW_AMBIENT_SGIX: /* aka GL_TEXTURE_COMPARE_FAIL_VALUE_ARB */
+         if (ctx->Extensions.SGIX_shadow_ambient) {
+            *params = CHAN_TO_FLOAT(obj->ShadowAmbient);
+            return;
+         }
+         break;
+      case GL_GENERATE_MIPMAP_SGIS:
+         if (ctx->Extensions.SGIS_generate_mipmap) {
+            *params = (GLfloat) obj->GenerateMipmap;
+            return;
+         }
+         break;
+      case GL_TEXTURE_COMPARE_MODE_ARB:
+         if (ctx->Extensions.ARB_shadow) {
+            *params = (GLfloat) obj->CompareMode;
+            return;
+         }
+         break;
+      case GL_TEXTURE_COMPARE_FUNC_ARB:
+         if (ctx->Extensions.ARB_shadow) {
+            *params = (GLfloat) obj->CompareFunc;
+            return;
+         }
+         break;
+      case GL_DEPTH_TEXTURE_MODE_ARB:
+         if (ctx->Extensions.ARB_depth_texture) {
+            *params = (GLfloat) obj->DepthMode;
+            return;
+         }
          break;
       default:
-         gl_error( ctx, GL_INVALID_ENUM, "glGetTexParameterfv(pname)" );
+         ; /* silence warnings */
    }
+   /* If we get here, pname was an unrecognized enum */
+   _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexParameterfv(pname)" );
 }
 
 
@@ -987,44 +1523,53 @@ _mesa_GetTexParameteriv( GLenum target, GLenum pname, GLint *params )
    GET_CURRENT_CONTEXT(ctx);
    struct gl_texture_unit *texUnit = &ctx->Texture.Unit[ctx->Texture.CurrentUnit];
    struct gl_texture_object *obj;
-
-   ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH(ctx, "glGetTexParameteriv");
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
    obj = _mesa_select_tex_object(ctx, texUnit, target);
    if (!obj) {
-      gl_error(ctx, GL_INVALID_ENUM, "glGetTexParameteriv(target)");
+      _mesa_error(ctx, GL_INVALID_ENUM, "glGetTexParameteriv(target)");
       return;
    }
 
    switch (pname) {
       case GL_TEXTURE_MAG_FILTER:
          *params = (GLint) obj->MagFilter;
-         break;
+         return;
       case GL_TEXTURE_MIN_FILTER:
          *params = (GLint) obj->MinFilter;
-         break;
+         return;
       case GL_TEXTURE_WRAP_S:
          *params = (GLint) obj->WrapS;
-         break;
+         return;
       case GL_TEXTURE_WRAP_T:
          *params = (GLint) obj->WrapT;
-         break;
+         return;
       case GL_TEXTURE_WRAP_R_EXT:
          *params = (GLint) obj->WrapR;
-         break;
+         return;
+#if 0 /* someday */
+      case GL_TEXTURE_BORDER_VALUES_NV:
+         /* unclamped */
+         params[0] = FLOAT_TO_INT(obj->BorderValues[0]);
+         params[1] = FLOAT_TO_INT(obj->BorderValues[1]);
+         params[2] = FLOAT_TO_INT(obj->BorderValues[2]);
+         params[3] = FLOAT_TO_INT(obj->BorderValues[3]);
+         return;
+#endif
       case GL_TEXTURE_BORDER_COLOR:
+         /* clamped */
          {
-            GLfloat color[4];
-            color[0] = obj->BorderColor[0] / CHAN_MAXF;
-            color[1] = obj->BorderColor[1] / CHAN_MAXF;
-            color[2] = obj->BorderColor[2] / CHAN_MAXF;
-            color[3] = obj->BorderColor[3] / CHAN_MAXF;
-            params[0] = FLOAT_TO_INT( color[0] );
-            params[1] = FLOAT_TO_INT( color[1] );
-            params[2] = FLOAT_TO_INT( color[2] );
-            params[3] = FLOAT_TO_INT( color[3] );
+            GLfloat b[4];
+            b[0] = CLAMP(obj->BorderValues[0], 0.0F, 1.0F);
+            b[1] = CLAMP(obj->BorderValues[1], 0.0F, 1.0F);
+            b[2] = CLAMP(obj->BorderValues[2], 0.0F, 1.0F);
+            b[3] = CLAMP(obj->BorderValues[3], 0.0F, 1.0F);
+            params[0] = FLOAT_TO_INT(b[0]);
+            params[1] = FLOAT_TO_INT(b[1]);
+            params[2] = FLOAT_TO_INT(b[2]);
+            params[3] = FLOAT_TO_INT(b[3]);
          }
-         break;
+         return;
       case GL_TEXTURE_RESIDENT:
          {
             GLboolean resident;
@@ -1034,25 +1579,70 @@ _mesa_GetTexParameteriv( GLenum target, GLenum pname, GLint *params )
                resident = GL_TRUE;
             *params = (GLint) resident;
          }
-         break;
+         return;
       case GL_TEXTURE_PRIORITY:
          *params = (GLint) obj->Priority;
-         break;
+         return;
       case GL_TEXTURE_MIN_LOD:
          *params = (GLint) obj->MinLod;
-         break;
+         return;
       case GL_TEXTURE_MAX_LOD:
          *params = (GLint) obj->MaxLod;
-         break;
+         return;
       case GL_TEXTURE_BASE_LEVEL:
          *params = obj->BaseLevel;
-         break;
+         return;
       case GL_TEXTURE_MAX_LEVEL:
          *params = obj->MaxLevel;
+         return;
+      case GL_TEXTURE_COMPARE_SGIX:
+         if (ctx->Extensions.SGIX_shadow) {
+            *params = (GLint) obj->CompareFlag;
+            return;
+         }
+         break;
+      case GL_TEXTURE_COMPARE_OPERATOR_SGIX:
+         if (ctx->Extensions.SGIX_shadow) {
+            *params = (GLint) obj->CompareOperator;
+            return;
+         }
+         break;
+      case GL_SHADOW_AMBIENT_SGIX: /* aka GL_TEXTURE_COMPARE_FAIL_VALUE_ARB */
+         if (ctx->Extensions.SGIX_shadow_ambient) {
+            GLfloat a = CHAN_TO_FLOAT(obj->ShadowAmbient);
+            *params = (GLint) FLOAT_TO_INT(a);
+            return;
+         }
+         break;
+      case GL_GENERATE_MIPMAP_SGIS:
+         if (ctx->Extensions.SGIS_generate_mipmap) {
+            *params = (GLint) obj->GenerateMipmap;
+            return;
+         }
+         break;
+      case GL_TEXTURE_COMPARE_MODE_ARB:
+         if (ctx->Extensions.ARB_shadow) {
+            *params = (GLint) obj->CompareMode;
+            return;
+         }
+         break;
+      case GL_TEXTURE_COMPARE_FUNC_ARB:
+         if (ctx->Extensions.ARB_shadow) {
+            *params = (GLint) obj->CompareFunc;
+            return;
+         }
+         break;
+      case GL_DEPTH_TEXTURE_MODE_ARB:
+         if (ctx->Extensions.ARB_depth_texture) {
+            *params = (GLint) obj->DepthMode;
+            return;
+         }
          break;
       default:
-         gl_error( ctx, GL_INVALID_ENUM, "glGetTexParameteriv(pname)" );
+         ; /* silence warnings */
    }
+   /* If we get here, pname was an unrecognized enum */
+   _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexParameteriv(pname)" );
 }
 
 
@@ -1067,199 +1657,237 @@ void
 _mesa_TexGenfv( GLenum coord, GLenum pname, const GLfloat *params )
 {
    GET_CURRENT_CONTEXT(ctx);
-   GLuint tUnit = ctx->Texture.CurrentTransformUnit;
+   GLuint tUnit = ctx->Texture.CurrentUnit;
    struct gl_texture_unit *texUnit = &ctx->Texture.Unit[tUnit];
-   ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH(ctx, "glTexGenfv");
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
    if (MESA_VERBOSE&(VERBOSE_API|VERBOSE_TEXTURE))
-      fprintf(stderr, "texGEN %s %s %x...\n", 
-             gl_lookup_enum_by_nr(coord),
-             gl_lookup_enum_by_nr(pname),
+      fprintf(stderr, "texGEN %s %s %x...\n",
+             _mesa_lookup_enum_by_nr(coord),
+             _mesa_lookup_enum_by_nr(pname),
              *(int *)params);
 
    switch (coord) {
       case GL_S:
          if (pname==GL_TEXTURE_GEN_MODE) {
            GLenum mode = (GLenum) (GLint) *params;
+           GLuint bits;
            switch (mode) {
            case GL_OBJECT_LINEAR:
-              texUnit->GenModeS = mode;
-              texUnit->_GenBitS = TEXGEN_OBJ_LINEAR;
+              bits = TEXGEN_OBJ_LINEAR;
               break;
            case GL_EYE_LINEAR:
-              texUnit->GenModeS = mode;
-              texUnit->_GenBitS = TEXGEN_EYE_LINEAR;
+              bits = TEXGEN_EYE_LINEAR;
               break;
            case GL_REFLECTION_MAP_NV:
-              texUnit->GenModeS = mode;
-              texUnit->_GenBitS = TEXGEN_REFLECTION_MAP_NV;
+              bits = TEXGEN_REFLECTION_MAP_NV;
               break;
            case GL_NORMAL_MAP_NV:
-              texUnit->GenModeS = mode;
-              texUnit->_GenBitS = TEXGEN_NORMAL_MAP_NV;
+              bits = TEXGEN_NORMAL_MAP_NV;
               break;
            case GL_SPHERE_MAP:
-              texUnit->GenModeS = mode;
-              texUnit->_GenBitS = TEXGEN_SPHERE_MAP;
+              bits = TEXGEN_SPHERE_MAP;
               break;
            default:
-              gl_error( ctx, GL_INVALID_ENUM, "glTexGenfv(param)" );
+              _mesa_error( ctx, GL_INVALID_ENUM, "glTexGenfv(param)" );
               return;
            }
+           if (texUnit->GenModeS == mode)
+              return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+           texUnit->GenModeS = mode;
+           texUnit->_GenBitS = bits;
         }
         else if (pname==GL_OBJECT_PLANE) {
+           if (TEST_EQ_4V(texUnit->ObjectPlaneS, params))
+               return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
            texUnit->ObjectPlaneS[0] = params[0];
            texUnit->ObjectPlaneS[1] = params[1];
            texUnit->ObjectPlaneS[2] = params[2];
            texUnit->ObjectPlaneS[3] = params[3];
         }
         else if (pname==GL_EYE_PLANE) {
+           GLfloat tmp[4];
+
             /* Transform plane equation by the inverse modelview matrix */
-            if (ctx->ModelView.flags & MAT_DIRTY_INVERSE) {
-               _math_matrix_analyze( &ctx->ModelView );
+            if (ctx->ModelviewMatrixStack.Top->flags & MAT_DIRTY_INVERSE) {
+               _math_matrix_analyse( ctx->ModelviewMatrixStack.Top );
             }
-            gl_transform_vector( texUnit->EyePlaneS, params,
-                                 ctx->ModelView.inv );
+            _mesa_transform_vector( tmp, params, ctx->ModelviewMatrixStack.Top->inv );
+           if (TEST_EQ_4V(texUnit->EyePlaneS, tmp))
+              return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+           COPY_4FV(texUnit->EyePlaneS, tmp);
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glTexGenfv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glTexGenfv(pname)" );
            return;
         }
         break;
       case GL_T:
          if (pname==GL_TEXTURE_GEN_MODE) {
            GLenum mode = (GLenum) (GLint) *params;
+           GLuint bitt;
            switch (mode) {
                case GL_OBJECT_LINEAR:
-                  texUnit->GenModeT = GL_OBJECT_LINEAR;
-                  texUnit->_GenBitT = TEXGEN_OBJ_LINEAR;
+                  bitt = TEXGEN_OBJ_LINEAR;
                   break;
                case GL_EYE_LINEAR:
-                  texUnit->GenModeT = GL_EYE_LINEAR;
-                  texUnit->_GenBitT = TEXGEN_EYE_LINEAR;
+                  bitt = TEXGEN_EYE_LINEAR;
                   break;
                case GL_REFLECTION_MAP_NV:
-                  texUnit->GenModeT = GL_REFLECTION_MAP_NV;
-                  texUnit->_GenBitT = TEXGEN_REFLECTION_MAP_NV;
+                  bitt = TEXGEN_REFLECTION_MAP_NV;
                   break;
                case GL_NORMAL_MAP_NV:
-                  texUnit->GenModeT = GL_NORMAL_MAP_NV;
-                  texUnit->_GenBitT = TEXGEN_NORMAL_MAP_NV;
+                  bitt = TEXGEN_NORMAL_MAP_NV;
                   break;
                case GL_SPHERE_MAP:
-                  texUnit->GenModeT = GL_SPHERE_MAP;
-                  texUnit->_GenBitT = TEXGEN_SPHERE_MAP;
+                  bitt = TEXGEN_SPHERE_MAP;
                   break;
                default:
-                  gl_error( ctx, GL_INVALID_ENUM, "glTexGenfv(param)" );
+                  _mesa_error( ctx, GL_INVALID_ENUM, "glTexGenfv(param)" );
                   return;
            }
+           if (texUnit->GenModeT == mode)
+              return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+           texUnit->GenModeT = mode;
+           texUnit->_GenBitT = bitt;
         }
         else if (pname==GL_OBJECT_PLANE) {
+           if (TEST_EQ_4V(texUnit->ObjectPlaneT, params))
+               return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
            texUnit->ObjectPlaneT[0] = params[0];
            texUnit->ObjectPlaneT[1] = params[1];
            texUnit->ObjectPlaneT[2] = params[2];
            texUnit->ObjectPlaneT[3] = params[3];
         }
         else if (pname==GL_EYE_PLANE) {
+           GLfloat tmp[4];
             /* Transform plane equation by the inverse modelview matrix */
-            if (ctx->ModelView.flags & MAT_DIRTY_INVERSE) {
-               _math_matrix_analyze( &ctx->ModelView );
+           if (ctx->ModelviewMatrixStack.Top->flags & MAT_DIRTY_INVERSE) {
+               _math_matrix_analyse( ctx->ModelviewMatrixStack.Top );
             }
-            gl_transform_vector( texUnit->EyePlaneT, params,
-                                 ctx->ModelView.inv );
+            _mesa_transform_vector( tmp, params, ctx->ModelviewMatrixStack.Top->inv );
+           if (TEST_EQ_4V(texUnit->EyePlaneT, tmp))
+               return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+           COPY_4FV(texUnit->EyePlaneT, tmp);
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glTexGenfv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glTexGenfv(pname)" );
            return;
         }
         break;
       case GL_R:
          if (pname==GL_TEXTURE_GEN_MODE) {
            GLenum mode = (GLenum) (GLint) *params;
+           GLuint bitr;
            switch (mode) {
            case GL_OBJECT_LINEAR:
-              texUnit->GenModeR = GL_OBJECT_LINEAR;
-              texUnit->_GenBitR = TEXGEN_OBJ_LINEAR;
+              bitr = TEXGEN_OBJ_LINEAR;
               break;
            case GL_REFLECTION_MAP_NV:
-              texUnit->GenModeR = GL_REFLECTION_MAP_NV;
-              texUnit->_GenBitR = TEXGEN_REFLECTION_MAP_NV;
+              bitr = TEXGEN_REFLECTION_MAP_NV;
               break;
            case GL_NORMAL_MAP_NV:
-              texUnit->GenModeR = GL_NORMAL_MAP_NV;
-              texUnit->_GenBitR = TEXGEN_NORMAL_MAP_NV;
+              bitr = TEXGEN_NORMAL_MAP_NV;
               break;
            case GL_EYE_LINEAR:
-              texUnit->GenModeR = GL_EYE_LINEAR;
-              texUnit->_GenBitR = TEXGEN_EYE_LINEAR;
+              bitr = TEXGEN_EYE_LINEAR;
               break;
            default:
-              gl_error( ctx, GL_INVALID_ENUM, "glTexGenfv(param)" );
+              _mesa_error( ctx, GL_INVALID_ENUM, "glTexGenfv(param)" );
               return;
            }
+           if (texUnit->GenModeR == mode)
+              return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+           texUnit->GenModeR = mode;
+           texUnit->_GenBitR = bitr;
         }
         else if (pname==GL_OBJECT_PLANE) {
+           if (TEST_EQ_4V(texUnit->ObjectPlaneR, params))
+               return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
            texUnit->ObjectPlaneR[0] = params[0];
            texUnit->ObjectPlaneR[1] = params[1];
            texUnit->ObjectPlaneR[2] = params[2];
            texUnit->ObjectPlaneR[3] = params[3];
         }
         else if (pname==GL_EYE_PLANE) {
+           GLfloat tmp[4];
             /* Transform plane equation by the inverse modelview matrix */
-            if (ctx->ModelView.flags & MAT_DIRTY_INVERSE) {
-               _math_matrix_analyze( &ctx->ModelView );
+            if (ctx->ModelviewMatrixStack.Top->flags & MAT_DIRTY_INVERSE) {
+               _math_matrix_analyse( ctx->ModelviewMatrixStack.Top );
             }
-            gl_transform_vector( texUnit->EyePlaneR, params,
-                                 ctx->ModelView.inv );
+            _mesa_transform_vector( tmp, params, ctx->ModelviewMatrixStack.Top->inv );
+           if (TEST_EQ_4V(texUnit->EyePlaneR, tmp))
+              return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+           COPY_4FV(texUnit->EyePlaneR, tmp);
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glTexGenfv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glTexGenfv(pname)" );
            return;
         }
         break;
       case GL_Q:
          if (pname==GL_TEXTURE_GEN_MODE) {
            GLenum mode = (GLenum) (GLint) *params;
+           GLuint bitq;
            switch (mode) {
-           case GL_OBJECT_LINEAR: 
-              texUnit->GenModeQ = GL_OBJECT_LINEAR;
-              texUnit->_GenBitQ = TEXGEN_OBJ_LINEAR;
+           case GL_OBJECT_LINEAR:
+              bitq = TEXGEN_OBJ_LINEAR;
               break;
            case GL_EYE_LINEAR:
-              texUnit->GenModeQ = GL_EYE_LINEAR;
-              texUnit->_GenBitQ = TEXGEN_EYE_LINEAR;
+              bitq = TEXGEN_EYE_LINEAR;
               break;
            default:
-              gl_error( ctx, GL_INVALID_ENUM, "glTexGenfv(param)" );
+              _mesa_error( ctx, GL_INVALID_ENUM, "glTexGenfv(param)" );
               return;
            }
+           if (texUnit->GenModeQ == mode)
+              return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+           texUnit->GenModeQ = mode;
+           texUnit->_GenBitQ = bitq;
         }
         else if (pname==GL_OBJECT_PLANE) {
+           if (TEST_EQ_4V(texUnit->ObjectPlaneQ, params))
+               return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
            texUnit->ObjectPlaneQ[0] = params[0];
            texUnit->ObjectPlaneQ[1] = params[1];
            texUnit->ObjectPlaneQ[2] = params[2];
            texUnit->ObjectPlaneQ[3] = params[3];
         }
         else if (pname==GL_EYE_PLANE) {
+           GLfloat tmp[4];
             /* Transform plane equation by the inverse modelview matrix */
-            if (ctx->ModelView.flags & MAT_DIRTY_INVERSE) {
-               _math_matrix_analyze( &ctx->ModelView );
+            if (ctx->ModelviewMatrixStack.Top->flags & MAT_DIRTY_INVERSE) {
+               _math_matrix_analyse( ctx->ModelviewMatrixStack.Top );
             }
-            gl_transform_vector( texUnit->EyePlaneQ, params,
-                                 ctx->ModelView.inv );
+            _mesa_transform_vector( tmp, params, ctx->ModelviewMatrixStack.Top->inv );
+           if (TEST_EQ_4V(texUnit->EyePlaneQ, tmp))
+              return;
+           FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+           COPY_4FV(texUnit->EyePlaneQ, tmp);
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glTexGenfv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glTexGenfv(pname)" );
            return;
         }
         break;
       default:
-         gl_error( ctx, GL_INVALID_ENUM, "glTexGenfv(coord)" );
+         _mesa_error( ctx, GL_INVALID_ENUM, "glTexGenfv(coord)" );
         return;
    }
 
-   ctx->NewState |= _NEW_TEXTURE;
+   if (ctx->Driver.TexGen)
+      ctx->Driver.TexGen( ctx, coord, pname, params );
 }
 
 
@@ -1267,10 +1895,10 @@ void
 _mesa_TexGeniv(GLenum coord, GLenum pname, const GLint *params )
 {
    GLfloat p[4];
-   p[0] = params[0];
-   p[1] = params[1];
-   p[2] = params[2];
-   p[3] = params[3];
+   p[0] = (GLfloat) params[0];
+   p[1] = (GLfloat) params[1];
+   p[2] = (GLfloat) params[2];
+   p[3] = (GLfloat) params[3];
    _mesa_TexGenfv(coord, pname, p);
 }
 
@@ -1287,10 +1915,10 @@ void
 _mesa_TexGendv(GLenum coord, GLenum pname, const GLdouble *params )
 {
    GLfloat p[4];
-   p[0] = params[0];
-   p[1] = params[1];
-   p[2] = params[2];
-   p[3] = params[3];
+   p[0] = (GLfloat) params[0];
+   p[1] = (GLfloat) params[1];
+   p[2] = (GLfloat) params[2];
+   p[3] = (GLfloat) params[3];
    _mesa_TexGenfv( coord, pname, p );
 }
 
@@ -1314,10 +1942,9 @@ void
 _mesa_GetTexGendv( GLenum coord, GLenum pname, GLdouble *params )
 {
    GET_CURRENT_CONTEXT(ctx);
-   GLuint tUnit = ctx->Texture.CurrentTransformUnit;
+   GLuint tUnit = ctx->Texture.CurrentUnit;
    struct gl_texture_unit *texUnit = &ctx->Texture.Unit[tUnit];
-
-   ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH(ctx, "glGetTexGendv");
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
    switch (coord) {
       case GL_S:
@@ -1331,7 +1958,7 @@ _mesa_GetTexGendv( GLenum coord, GLenum pname, GLdouble *params )
             COPY_4V( params, texUnit->EyePlaneS );
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGendv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGendv(pname)" );
            return;
         }
         break;
@@ -1346,7 +1973,7 @@ _mesa_GetTexGendv( GLenum coord, GLenum pname, GLdouble *params )
             COPY_4V( params, texUnit->EyePlaneT );
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGendv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGendv(pname)" );
            return;
         }
         break;
@@ -1361,7 +1988,7 @@ _mesa_GetTexGendv( GLenum coord, GLenum pname, GLdouble *params )
             COPY_4V( params, texUnit->EyePlaneR );
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGendv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGendv(pname)" );
            return;
         }
         break;
@@ -1376,12 +2003,12 @@ _mesa_GetTexGendv( GLenum coord, GLenum pname, GLdouble *params )
             COPY_4V( params, texUnit->EyePlaneQ );
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGendv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGendv(pname)" );
            return;
         }
         break;
       default:
-         gl_error( ctx, GL_INVALID_ENUM, "glGetTexGendv(coord)" );
+         _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGendv(coord)" );
         return;
    }
 }
@@ -1392,10 +2019,9 @@ void
 _mesa_GetTexGenfv( GLenum coord, GLenum pname, GLfloat *params )
 {
    GET_CURRENT_CONTEXT(ctx);
-   GLuint tUnit = ctx->Texture.CurrentTransformUnit;
+   GLuint tUnit = ctx->Texture.CurrentUnit;
    struct gl_texture_unit *texUnit = &ctx->Texture.Unit[tUnit];
-
-   ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH(ctx, "glGetTexGenfv");
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
    switch (coord) {
       case GL_S:
@@ -1409,7 +2035,7 @@ _mesa_GetTexGenfv( GLenum coord, GLenum pname, GLfloat *params )
             COPY_4V( params, texUnit->EyePlaneS );
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGenfv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGenfv(pname)" );
            return;
         }
         break;
@@ -1424,7 +2050,7 @@ _mesa_GetTexGenfv( GLenum coord, GLenum pname, GLfloat *params )
             COPY_4V( params, texUnit->EyePlaneT );
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGenfv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGenfv(pname)" );
            return;
         }
         break;
@@ -1439,7 +2065,7 @@ _mesa_GetTexGenfv( GLenum coord, GLenum pname, GLfloat *params )
             COPY_4V( params, texUnit->EyePlaneR );
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGenfv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGenfv(pname)" );
            return;
         }
         break;
@@ -1454,12 +2080,12 @@ _mesa_GetTexGenfv( GLenum coord, GLenum pname, GLfloat *params )
             COPY_4V( params, texUnit->EyePlaneQ );
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGenfv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGenfv(pname)" );
            return;
         }
         break;
       default:
-         gl_error( ctx, GL_INVALID_ENUM, "glGetTexGenfv(coord)" );
+         _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGenfv(coord)" );
         return;
    }
 }
@@ -1470,10 +2096,9 @@ void
 _mesa_GetTexGeniv( GLenum coord, GLenum pname, GLint *params )
 {
    GET_CURRENT_CONTEXT(ctx);
-   GLuint tUnit = ctx->Texture.CurrentTransformUnit;
+   GLuint tUnit = ctx->Texture.CurrentUnit;
    struct gl_texture_unit *texUnit = &ctx->Texture.Unit[tUnit];
-
-   ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH(ctx, "glGetTexGeniv");
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
    switch (coord) {
       case GL_S:
@@ -1493,7 +2118,7 @@ _mesa_GetTexGeniv( GLenum coord, GLenum pname, GLint *params )
             params[3] = (GLint) texUnit->EyePlaneS[3];
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGeniv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGeniv(pname)" );
            return;
         }
         break;
@@ -1514,7 +2139,7 @@ _mesa_GetTexGeniv( GLenum coord, GLenum pname, GLint *params )
             params[3] = (GLint) texUnit->EyePlaneT[3];
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGeniv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGeniv(pname)" );
            return;
         }
         break;
@@ -1535,7 +2160,7 @@ _mesa_GetTexGeniv( GLenum coord, GLenum pname, GLint *params )
             params[3] = (GLint) texUnit->EyePlaneR[3];
         }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGeniv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGeniv(pname)" );
            return;
         }
         break;
@@ -1556,12 +2181,12 @@ _mesa_GetTexGeniv( GLenum coord, GLenum pname, GLint *params )
             params[3] = (GLint) texUnit->EyePlaneQ[3];
          }
         else {
-           gl_error( ctx, GL_INVALID_ENUM, "glGetTexGeniv(pname)" );
+           _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGeniv(pname)" );
            return;
         }
         break;
       default:
-         gl_error( ctx, GL_INVALID_ENUM, "glGetTexGeniv(coord)" );
+         _mesa_error( ctx, GL_INVALID_ENUM, "glGetTexGeniv(coord)" );
         return;
    }
 }
@@ -1572,25 +2197,22 @@ void
 _mesa_ActiveTextureARB( GLenum target )
 {
    GET_CURRENT_CONTEXT(ctx);
-   GLint maxUnits = ctx->Const.MaxTextureUnits;
-
-   ASSERT_OUTSIDE_BEGIN_END( ctx, "glActiveTextureARB" );
+   GLuint texUnit = target - GL_TEXTURE0_ARB;
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
    if (MESA_VERBOSE & (VERBOSE_API|VERBOSE_TEXTURE))
-      fprintf(stderr, "glActiveTexture %s\n", 
-             gl_lookup_enum_by_nr(target));
-
-   if (target >= GL_TEXTURE0_ARB && target < GL_TEXTURE0_ARB + maxUnits) {
-      GLint texUnit = target - GL_TEXTURE0_ARB;
-      ctx->Texture.CurrentUnit = texUnit;
-      ctx->Texture.CurrentTransformUnit = texUnit;
-      if (ctx->Driver.ActiveTexture) {
-         (*ctx->Driver.ActiveTexture)( ctx, (GLuint) texUnit );
-      }
-      ctx->NewState |= _NEW_TEXTURE;
+      fprintf(stderr, "glActiveTexture %s\n",
+             _mesa_lookup_enum_by_nr(target));
+
+   if (texUnit > ctx->Const.MaxTextureUnits) {
+      _mesa_error(ctx, GL_INVALID_ENUM, "glActiveTextureARB(target)");
+      return;
    }
-   else {
-      gl_error(ctx, GL_INVALID_OPERATION, "glActiveTextureARB(target)");
+
+   FLUSH_VERTICES(ctx, _NEW_TEXTURE);
+   ctx->Texture.CurrentUnit = texUnit;
+   if (ctx->Driver.ActiveTexture) {
+      (*ctx->Driver.ActiveTexture)( ctx, (GLuint) texUnit );
    }
 }
 
@@ -1600,16 +2222,146 @@ void
 _mesa_ClientActiveTextureARB( GLenum target )
 {
    GET_CURRENT_CONTEXT(ctx);
-   GLint maxUnits = ctx->Const.MaxTextureUnits;
+   GLuint texUnit = target - GL_TEXTURE0_ARB;
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
+
+   if (texUnit > ctx->Const.MaxTextureUnits) {
+      _mesa_error(ctx, GL_INVALID_ENUM, "glClientActiveTextureARB(target)");
+      return;
+   }
+
+   FLUSH_VERTICES(ctx, _NEW_ARRAY);
+   ctx->Array.ActiveTexture = texUnit;
+}
+
+
+
+/**********************************************************************/
+/*                     Pixel Texgen Extensions                        */
+/**********************************************************************/
+
+void
+_mesa_PixelTexGenSGIX(GLenum mode)
+{
+   GLenum newRgbSource, newAlphaSource;
+   GET_CURRENT_CONTEXT(ctx);
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
+
+   switch (mode) {
+      case GL_NONE:
+         newRgbSource = GL_PIXEL_GROUP_COLOR_SGIS;
+         newAlphaSource = GL_PIXEL_GROUP_COLOR_SGIS;
+         break;
+      case GL_ALPHA:
+         newRgbSource = GL_PIXEL_GROUP_COLOR_SGIS;
+         newAlphaSource = GL_CURRENT_RASTER_COLOR;
+         break;
+      case GL_RGB:
+         newRgbSource = GL_CURRENT_RASTER_COLOR;
+         newAlphaSource = GL_PIXEL_GROUP_COLOR_SGIS;
+         break;
+      case GL_RGBA:
+         newRgbSource = GL_CURRENT_RASTER_COLOR;
+         newAlphaSource = GL_CURRENT_RASTER_COLOR;
+         break;
+      default:
+         _mesa_error(ctx, GL_INVALID_ENUM, "glPixelTexGenSGIX(mode)");
+         return;
+   }
+
+   if (newRgbSource == ctx->Pixel.FragmentRgbSource &&
+       newAlphaSource == ctx->Pixel.FragmentAlphaSource)
+      return;
+
+   FLUSH_VERTICES(ctx, _NEW_PIXEL);
+   ctx->Pixel.FragmentRgbSource = newRgbSource;
+   ctx->Pixel.FragmentAlphaSource = newAlphaSource;
+}
+
+
+void
+_mesa_PixelTexGenParameterfSGIS(GLenum target, GLfloat value)
+{
+   _mesa_PixelTexGenParameteriSGIS(target, (GLint) value);
+}
+
+
+void
+_mesa_PixelTexGenParameterfvSGIS(GLenum target, const GLfloat *value)
+{
+   _mesa_PixelTexGenParameteriSGIS(target, (GLint) *value);
+}
+
+
+void
+_mesa_PixelTexGenParameteriSGIS(GLenum target, GLint value)
+{
+   GET_CURRENT_CONTEXT(ctx);
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
+
+   if (value != GL_CURRENT_RASTER_COLOR && value != GL_PIXEL_GROUP_COLOR_SGIS) {
+      _mesa_error(ctx, GL_INVALID_ENUM, "glPixelTexGenParameterSGIS(value)");
+      return;
+   }
+
+   switch (target) {
+   case GL_PIXEL_FRAGMENT_RGB_SOURCE_SGIS:
+      if (ctx->Pixel.FragmentRgbSource == (GLenum) value)
+        return;
+      FLUSH_VERTICES(ctx, _NEW_PIXEL);
+      ctx->Pixel.FragmentRgbSource = (GLenum) value;
+      break;
+   case GL_PIXEL_FRAGMENT_ALPHA_SOURCE_SGIS:
+      if (ctx->Pixel.FragmentAlphaSource == (GLenum) value)
+        return;
+      FLUSH_VERTICES(ctx, _NEW_PIXEL);
+      ctx->Pixel.FragmentAlphaSource = (GLenum) value;
+      break;
+   default:
+      _mesa_error(ctx, GL_INVALID_ENUM, "glPixelTexGenParameterSGIS(target)");
+      return;
+   }
+}
+
+
+void
+_mesa_PixelTexGenParameterivSGIS(GLenum target, const GLint *value)
+{
+  _mesa_PixelTexGenParameteriSGIS(target, *value);
+}
+
+
+void
+_mesa_GetPixelTexGenParameterfvSGIS(GLenum target, GLfloat *value)
+{
+   GET_CURRENT_CONTEXT(ctx);
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
+
+   if (target == GL_PIXEL_FRAGMENT_RGB_SOURCE_SGIS) {
+      *value = (GLfloat) ctx->Pixel.FragmentRgbSource;
+   }
+   else if (target == GL_PIXEL_FRAGMENT_ALPHA_SOURCE_SGIS) {
+      *value = (GLfloat) ctx->Pixel.FragmentAlphaSource;
+   }
+   else {
+      _mesa_error(ctx, GL_INVALID_ENUM, "glGetPixelTexGenParameterfvSGIS(target)");
+   }
+}
+
 
-   ASSERT_OUTSIDE_BEGIN_END( ctx, "glClientActiveTextureARB" );
+void
+_mesa_GetPixelTexGenParameterivSGIS(GLenum target, GLint *value)
+{
+   GET_CURRENT_CONTEXT(ctx);
+   ASSERT_OUTSIDE_BEGIN_END(ctx);
 
-   if (target >= GL_TEXTURE0_ARB && target < GL_TEXTURE0_ARB + maxUnits) {
-      GLint texUnit = target - GL_TEXTURE0_ARB;
-      ctx->Array.ActiveTexture = texUnit;
-      ctx->NewState |= _NEW_ARRAY;
+   if (target == GL_PIXEL_FRAGMENT_RGB_SOURCE_SGIS) {
+      *value = (GLint) ctx->Pixel.FragmentRgbSource;
+   }
+   else if (target == GL_PIXEL_FRAGMENT_ALPHA_SOURCE_SGIS) {
+      *value = (GLint) ctx->Pixel.FragmentAlphaSource;
    }
    else {
-      gl_error(ctx, GL_INVALID_OPERATION, "glActiveTextureARB(target)");
+      _mesa_error(ctx, GL_INVALID_ENUM, "glGetPixelTexGenParameterivSGIS(target)");
    }
 }