Merge branch '7.8' into master

[mesa.git] / src / mesa / state_tracker / st_atom_scissor.c

diff --git a/src/mesa/state_tracker/st_atom_scissor.c b/src/mesa/state_tracker/st_atom_scissor.c
index 75bead388f38435af6bf7310bfcd74f684f7ee6b..5e0c51cff0af3f273a2c922899cf005cd64813eb 100644 (file)
--- a/src/mesa/state_tracker/st_atom_scissor.c
+++ b/src/mesa/state_tracker/st_atom_scissor.c
@@ -31,6 +31,7 @@
   */
  
 
+#include "main/macros.h"
 #include "st_context.h"
 #include "pipe/p_context.h"
 #include "st_atom.h"
@@ -42,8 +43,9 @@
 static void
 update_scissor( struct st_context *st )
 {
-   struct pipe_scissor_rect scissor;
+   struct pipe_scissor_state scissor;
    const struct gl_framebuffer *fb = st->ctx->DrawBuffer;
+   GLint miny, maxy;
 
    scissor.minx = 0;
    scissor.miny = 0;
@@ -51,38 +53,45 @@ update_scissor( struct st_context *st )
    scissor.maxy = fb->Height;
 
    if (st->ctx->Scissor.Enabled) {
-      if (st->ctx->Scissor.X > scissor.minx)
+      /* need to be careful here with xmax or ymax < 0 */
+      GLint xmax = MAX2(0, st->ctx->Scissor.X + st->ctx->Scissor.Width);
+      GLint ymax = MAX2(0, st->ctx->Scissor.Y + st->ctx->Scissor.Height);
+
+      if (st->ctx->Scissor.X > (GLint)scissor.minx)
          scissor.minx = st->ctx->Scissor.X;
-      if (st->ctx->Scissor.Y > scissor.miny)
+      if (st->ctx->Scissor.Y > (GLint)scissor.miny)
          scissor.miny = st->ctx->Scissor.Y;
 
-      if (st->ctx->Scissor.X + st->ctx->Scissor.Width < scissor.maxx)
-         scissor.maxx = st->ctx->Scissor.X + st->ctx->Scissor.Width;
-      if (st->ctx->Scissor.Y + st->ctx->Scissor.Height < scissor.maxy)
-         scissor.maxy = st->ctx->Scissor.Y + st->ctx->Scissor.Height;
+      if (xmax < (GLint) scissor.maxx)
+         scissor.maxx = xmax;
+      if (ymax < (GLint) scissor.maxy)
+         scissor.maxy = ymax;
 
       /* check for null space */
       if (scissor.minx >= scissor.maxx || scissor.miny >= scissor.maxy)
          scissor.minx = scissor.miny = scissor.maxx = scissor.maxy = 0;
    }
 
+   /* Now invert Y.  Pipe drivers use the convention Y=0=top for surfaces
+    */
+   miny = fb->Height - scissor.maxy;
+   maxy = fb->Height - scissor.miny;
+   scissor.miny = miny;
+   scissor.maxy = maxy;
+
    if (memcmp(&scissor, &st->state.scissor, sizeof(scissor)) != 0) {
       /* state has changed */
       st->state.scissor = scissor;  /* struct copy */
-      st->pipe->set_scissor_rect(st->pipe, &scissor); /* activate */
+      st->pipe->set_scissor_state(st->pipe, &scissor); /* activate */
    }
 }
 
 
 const struct st_tracked_state st_update_scissor = {
-   .dirty = {
-      .mesa = (_NEW_SCISSOR | _NEW_BUFFERS),
-      .st  = 0,
+   "st_update_scissor",                                        /* name */
+   {                                                   /* dirty */
+      (_NEW_SCISSOR | _NEW_BUFFERS),                   /* mesa */
+      0,                                               /* st */
    },
-   .update = update_scissor
+   update_scissor                                      /* update */
 };
-
-
-
-
-