X-Git-Url: https://git.libre-soc.org/?a=blobdiff_plain;f=docs%2Fsubmittingpatches.html;h=0581391b2958253b8f4d74d1112650becd6c185f;hb=b0c8d61281d5e09cd216e1ff3f2c441f7c550a47;hp=564ad731b24ca590311ed0b223e1a9c797f6f71c;hpb=9e4248b20695672bd0fe8668cea290d2aecd36bd;p=mesa.git diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 564ad731b24..0581391b295 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -78,6 +78,11 @@ patch comment. For example:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89689+
+ Fixes: d7b3707c612 "util/disk_cache: use stat() to check if entry is a directory" +
@@ -115,7 +120,7 @@ them in the CC list. Please use common sense and do not blindly add everyone.
- $ scripts/get_reviewer.pl --help # to get the the help screen + $ scripts/get_reviewer.pl --help # to get the help screen $ scripts/get_reviewer.pl -f src/egl/drivers/dri2/platform_android.c Rob Herring(reviewer:ANDROID EGL SUPPORT,added_lines:188/700=27%,removed_lines:58/283=20%) Tomasz Figa (reviewer:ANDROID EGL SUPPORT,authored:12/41=29%,added_lines:308/700=44%,removed_lines:115/283=41%) @@ -146,6 +151,18 @@ Whenever possible and applicable, test the patch with to check for regressions. + +As mentioned at the begining, patches should be bisectable. +A good way to test this is to make use of the `git rebase` command, +to run your tests on each commit. Assuming your branch is based off +
origin/master
, you can run: ++$ git rebase --interactive --exec "make check" origin/master ++replacing"make check"
with whatever other test you want to +run. + +Mailing Patches
@@ -174,6 +191,16 @@ When submitting follow-up patches you should also login to state of your old patches to Superseded. ++Some companies' mail server automatically append a legal disclaimer, +usually containing something along the lines of "The information in this +email is confidential" and "distribution is strictly prohibited".
+
+These legal notices prevent us from being able to accept your patch, +rendering the whole process pointless. Please make sure these are +disabled before sending your patches. (Note that you may need to contact +your email administrator for this.) +Reviewing Patches
@@ -251,6 +278,10 @@ Note: by removing the tag [as the commit is pushed] the patch is Thus, drop the line only if you want to cancel the nomination.
+Alternatively, if one uses the "Fixes" tag as described in the "Patch formatting" +section, it nominates a commit for all active stable branches that include the +commit that is referred to. +Criteria for accepting patches to the stable branch
Mesa has a designated release manager for each stable branch, and the release