X-Git-Url: https://git.libre-soc.org/?a=blobdiff_plain;f=gdb%2Fobjc-lang.c;h=d5897c036b6f2d2d6ebd33cec2d0b3e20a15b298;hb=91158a569dc571a9916dfad98c6c95ce789ad18d;hp=aa55baf50bad14c45695237f52b68bfaf7135dc4;hpb=57a9e6afe1689fca791c5be5b57b6bc361b466de;p=binutils-gdb.git diff --git a/gdb/objc-lang.c b/gdb/objc-lang.c index aa55baf50ba..d5897c036b6 100644 --- a/gdb/objc-lang.c +++ b/gdb/objc-lang.c @@ -1,6 +1,6 @@ /* Objective-C language support routines for GDB, the GNU debugger. - Copyright (C) 2002, 2003, 2004, 2005, 2007, 2008, 2009 + Copyright (C) 2002, 2003, 2004, 2005, 2007, 2008, 2009, 2010 Free Software Foundation, Inc. Contributed by Apple Computer, Inc. @@ -108,8 +108,9 @@ lookup_struct_typedef (char *name, struct block *block, int noerr) } CORE_ADDR -lookup_objc_class (char *classname) +lookup_objc_class (struct gdbarch *gdbarch, char *classname) { + struct type *char_type = builtin_type (gdbarch)->builtin_char; struct value * function, *classval; if (! target_has_execution) @@ -128,15 +129,16 @@ lookup_objc_class (char *classname) return 0; } - classval = value_string (classname, strlen (classname) + 1); + classval = value_string (classname, strlen (classname) + 1, char_type); classval = value_coerce_array (classval); return (CORE_ADDR) value_as_long (call_function_by_hand (function, 1, &classval)); } CORE_ADDR -lookup_child_selector (char *selname) +lookup_child_selector (struct gdbarch *gdbarch, char *selname) { + struct type *char_type = builtin_type (gdbarch)->builtin_char; struct value * function, *selstring; if (! target_has_execution) @@ -156,53 +158,50 @@ lookup_child_selector (char *selname) } selstring = value_coerce_array (value_string (selname, - strlen (selname) + 1)); + strlen (selname) + 1, char_type)); return value_as_long (call_function_by_hand (function, 1, &selstring)); } struct value * -value_nsstring (char *ptr, int len) +value_nsstring (struct gdbarch *gdbarch, char *ptr, int len) { + struct type *char_type = builtin_type (gdbarch)->builtin_char; struct value *stringValue[3]; struct value *function, *nsstringValue; struct symbol *sym; struct type *type; - struct objfile *objf; - struct gdbarch *gdbarch; if (!target_has_execution) return 0; /* Can't call into inferior to create NSString. */ - stringValue[2] = value_string(ptr, len); + stringValue[2] = value_string(ptr, len, char_type); stringValue[2] = value_coerce_array(stringValue[2]); /* _NSNewStringFromCString replaces "istr" after Lantern2A. */ if (lookup_minimal_symbol("_NSNewStringFromCString", 0, 0)) { - function = find_function_in_inferior("_NSNewStringFromCString", &objf); + function = find_function_in_inferior("_NSNewStringFromCString", NULL); nsstringValue = call_function_by_hand(function, 1, &stringValue[2]); } else if (lookup_minimal_symbol("istr", 0, 0)) { - function = find_function_in_inferior("istr", &objf); + function = find_function_in_inferior("istr", NULL); nsstringValue = call_function_by_hand(function, 1, &stringValue[2]); } else if (lookup_minimal_symbol("+[NSString stringWithCString:]", 0, 0)) { function - = find_function_in_inferior("+[NSString stringWithCString:]", &objf); - type = builtin_type (get_objfile_arch (objf))->builtin_long; + = find_function_in_inferior("+[NSString stringWithCString:]", NULL); + type = builtin_type (gdbarch)->builtin_long; stringValue[0] = value_from_longest - (type, lookup_objc_class ("NSString")); + (type, lookup_objc_class (gdbarch, "NSString")); stringValue[1] = value_from_longest - (type, lookup_child_selector ("stringWithCString:")); + (type, lookup_child_selector (gdbarch, "stringWithCString:")); nsstringValue = call_function_by_hand(function, 3, &stringValue[0]); } else error (_("NSString: internal error -- no way to create new NSString")); - gdbarch = get_objfile_arch (objf); - sym = lookup_struct_typedef("NSString", 0, 1); if (sym == NULL) sym = lookup_struct_typedef("NXString", 0, 1); @@ -245,22 +244,24 @@ objc_demangle (const char *mangled, int options) xfree(demangled); /* not mangled name */ return NULL; } - if (cp[1] == '_') { /* easy case: no category name */ - *cp++ = ' '; /* replace two '_' with one ' ' */ - strcpy(cp, mangled + (cp - demangled) + 2); - } - else { - *cp++ = '('; /* less easy case: category name */ - cp = strchr(cp, '_'); - if (!cp) - { - xfree(demangled); /* not mangled name */ - return NULL; - } - *cp++ = ')'; - *cp++ = ' '; /* overwriting 1st char of method name... */ - strcpy(cp, mangled + (cp - demangled)); /* get it back */ - } + if (cp[1] == '_') /* easy case: no category name */ + { + *cp++ = ' '; /* replace two '_' with one ' ' */ + strcpy(cp, mangled + (cp - demangled) + 2); + } + else + { + *cp++ = '('; /* less easy case: category name */ + cp = strchr(cp, '_'); + if (!cp) + { + xfree(demangled); /* not mangled name */ + return NULL; + } + *cp++ = ')'; + *cp++ = ' '; /* overwriting 1st char of method name... */ + strcpy(cp, mangled + (cp - demangled)); /* get it back */ + } while (*cp && *cp == '_') cp++; /* skip any initial underbars in method name */ @@ -284,7 +285,6 @@ objc_demangle (const char *mangled, int options) static void objc_emit_char (int c, struct type *type, struct ui_file *stream, int quoter) { - c &= 0xFF; /* Avoid sign bit follies. */ if (PRINT_LITERAL_FORM (c)) @@ -344,14 +344,13 @@ objc_printchar (int c, struct type *type, struct ui_file *stream) static void objc_printstr (struct ui_file *stream, struct type *type, const gdb_byte *string, unsigned int length, - int force_ellipses, + const char *encoding, int force_ellipses, const struct value_print_options *options) { unsigned int i; unsigned int things_printed = 0; int in_quotes = 0; int need_comma = 0; - int width = TYPE_LENGTH (type); /* If the string was not truncated due to `set print elements', and the last byte of it is a null, we don't print that, in @@ -442,11 +441,11 @@ objc_printstr (struct ui_file *stream, struct type *type, static CORE_ADDR objc_skip_trampoline (struct frame_info *frame, CORE_ADDR stop_pc) { + struct gdbarch *gdbarch = get_frame_arch (frame); CORE_ADDR real_stop_pc; CORE_ADDR method_stop_pc; - real_stop_pc = gdbarch_skip_trampoline_code - (current_gdbarch, frame, stop_pc); + real_stop_pc = gdbarch_skip_trampoline_code (gdbarch, frame, stop_pc); if (real_stop_pc != 0) find_objc_msgcall (real_stop_pc, &method_stop_pc); @@ -456,7 +455,7 @@ objc_skip_trampoline (struct frame_info *frame, CORE_ADDR stop_pc) if (method_stop_pc) { real_stop_pc = gdbarch_skip_trampoline_code - (current_gdbarch, frame, method_stop_pc); + (gdbarch, frame, method_stop_pc); if (real_stop_pc == 0) real_stop_pc = method_stop_pc; } @@ -576,28 +575,34 @@ add_msglist(struct stoken *str, int addcolon) char *s, *p; int len, plen; - if (str == 0) { /* Unnamed arg, or... */ - if (addcolon == 0) { /* variable number of args. */ - msglist_len++; - return; + if (str == 0) /* Unnamed arg, or... */ + { + if (addcolon == 0) /* variable number of args. */ + { + msglist_len++; + return; + } + p = ""; + plen = 0; + } + else + { + p = str->ptr; + plen = str->length; } - p = ""; - plen = 0; - } else { - p = str->ptr; - plen = str->length; - } len = plen + strlen(msglist_sel) + 2; s = (char *)xmalloc(len); strcpy(s, msglist_sel); strncat(s, p, plen); xfree(msglist_sel); msglist_sel = s; - if (addcolon) { - s[len-2] = ':'; - s[len-1] = 0; - msglist_len++; - } else + if (addcolon) + { + s[len-2] = ':'; + s[len-1] = 0; + msglist_len++; + } + else s[len-2] = '\0'; } @@ -612,7 +617,7 @@ end_msglist(void) selname_chain = sel->next; msglist_len = sel->msglist_len; msglist_sel = sel->msglist_sel; - selid = lookup_child_selector(p); + selid = lookup_child_selector (parse_gdbarch, p); if (!selid) error (_("Can't find selector \"%s\""), p); write_exp_elt_longcst (selid); @@ -995,17 +1000,18 @@ parse_selector (char *method, char **selector) nselector = s1; s2 = s1; - for (;;) { - if (isalnum (*s2) || (*s2 == '_') || (*s2 == ':')) - *s1++ = *s2; - else if (isspace (*s2)) - ; - else if ((*s2 == '\0') || (*s2 == '\'')) - break; - else - return NULL; - s2++; - } + for (;;) + { + if (isalnum (*s2) || (*s2 == '_') || (*s2 == ':')) + *s1++ = *s2; + else if (isspace (*s2)) + ; + else if ((*s2 == '\0') || (*s2 == '\'')) + break; + else + return NULL; + s2++; + } *s1++ = '\0'; while (isspace (*s2)) @@ -1089,17 +1095,18 @@ parse_method (char *method, char *type, char **class, nselector = s2; s1 = s2; - for (;;) { - if (isalnum (*s2) || (*s2 == '_') || (*s2 == ':')) - *s1++ = *s2; - else if (isspace (*s2)) - ; - else if (*s2 == ']') - break; - else - return NULL; - s2++; - } + for (;;) + { + if (isalnum (*s2) || (*s2 == '_') || (*s2 == ':')) + *s1++ = *s2; + else if (isspace (*s2)) + ; + else if (*s2 == ']') + break; + else + return NULL; + s2++; + } *s1++ = '\0'; s2++; @@ -1174,19 +1181,13 @@ find_methods (struct symtab *symtab, char type, ALL_OBJFILE_MSYMBOLS (objfile, msymbol) { - QUIT; + struct gdbarch *gdbarch = get_objfile_arch (objfile); + CORE_ADDR pc = SYMBOL_VALUE_ADDRESS (msymbol); - if ((MSYMBOL_TYPE (msymbol) != mst_text) - && (MSYMBOL_TYPE (msymbol) != mst_file_text)) - /* Not a function or method. */ - continue; - - if (symtab) - if ((SYMBOL_VALUE_ADDRESS (msymbol) < BLOCK_START (block)) || - (SYMBOL_VALUE_ADDRESS (msymbol) >= BLOCK_END (block))) - /* Not in the specified symtab. */ - continue; + QUIT; + /* Check the symbol name first as this can be done entirely without + sending any query to the target. */ symname = SYMBOL_NATURAL_NAME (msymbol); if (symname == NULL) continue; @@ -1194,7 +1195,18 @@ find_methods (struct symtab *symtab, char type, if ((symname[0] != '-' && symname[0] != '+') || (symname[1] != '[')) /* Not a method name. */ continue; - + + /* The minimal symbol might point to a function descriptor; + resolve it to the actual code address instead. */ + pc = gdbarch_convert_from_func_ptr_addr (gdbarch, pc, + ¤t_target); + + if (symtab) + if (pc < BLOCK_START (block) || pc >= BLOCK_END (block)) + /* Not in the specified symtab. */ + continue; + + /* Now that thinks are a bit sane, clean up the symname. */ while ((strlen (symname) + 1) >= tmplen) { tmplen = (tmplen == 0) ? 1024 : tmplen * 2; @@ -1222,7 +1234,7 @@ find_methods (struct symtab *symtab, char type, ((nselector == NULL) || (strcmp (selector, nselector) != 0))) continue; - sym = find_pc_function (SYMBOL_VALUE_ADDRESS (msymbol)); + sym = find_pc_function (pc); if (sym != NULL) { const char *newsymname = SYMBOL_NATURAL_NAME (sym); @@ -1259,7 +1271,8 @@ find_methods (struct symtab *symtab, char type, } if (objc_csym == NULL) { - objc_csym = xmalloc (sizeof (*objc_csym)); + objc_csym = obstack_alloc (&objfile->objfile_obstack, + sizeof (*objc_csym)); *objc_csym = objfile_csym; set_objfile_data (objfile, objc_objfile_data, objc_csym); } @@ -1304,36 +1317,36 @@ char *find_imps (struct symtab *symtab, struct block *block, strcpy (buf, method); tmp = parse_method (buf, &type, &class, &category, &selector); - if (tmp == NULL) { - - struct symbol *sym = NULL; - struct minimal_symbol *msym = NULL; - - strcpy (buf, method); - tmp = parse_selector (buf, &selector); - - if (tmp == NULL) - return NULL; - - sym = lookup_symbol (selector, block, VAR_DOMAIN, 0); - if (sym != NULL) - { - if (syms) - syms[csym] = sym; - csym++; - cdebug++; - } + if (tmp == NULL) + { + struct symbol *sym = NULL; + struct minimal_symbol *msym = NULL; - if (sym == NULL) - msym = lookup_minimal_symbol (selector, 0, 0); + strcpy (buf, method); + tmp = parse_selector (buf, &selector); - if (msym != NULL) - { - if (syms) - syms[csym] = (struct symbol *)msym; - csym++; - } - } + if (tmp == NULL) + return NULL; + + sym = lookup_symbol (selector, block, VAR_DOMAIN, 0); + if (sym != NULL) + { + if (syms) + syms[csym] = sym; + csym++; + cdebug++; + } + + if (sym == NULL) + msym = lookup_minimal_symbol (selector, 0, 0); + + if (msym != NULL) + { + if (syms) + syms[csym] = (struct symbol *)msym; + csym++; + } + } if (syms != NULL) find_methods (symtab, type, class, category, selector, @@ -1421,8 +1434,8 @@ print_object_command (char *args, int from_tty) make_cleanup (free_current_contents, &expr); int pc = 0; - object = expr->language_defn->la_exp_desc->evaluate_exp - (builtin_type (expr->gdbarch)->builtin_data_ptr, expr, &pc, EVAL_NORMAL); + object = evaluate_subexp (builtin_type (expr->gdbarch)->builtin_data_ptr, + expr, &pc, EVAL_NORMAL); do_cleanups (old_chain); } @@ -1495,26 +1508,29 @@ static void find_objc_msgsend (void) { unsigned int i; - for (i = 0; i < nmethcalls; i++) { - struct minimal_symbol *func; + for (i = 0; i < nmethcalls; i++) + { + struct minimal_symbol *func; + + /* Try both with and without underscore. */ + func = lookup_minimal_symbol (methcalls[i].name, NULL, NULL); + if ((func == NULL) && (methcalls[i].name[0] == '_')) + { + func = lookup_minimal_symbol (methcalls[i].name + 1, NULL, NULL); + } + if (func == NULL) + { + methcalls[i].begin = 0; + methcalls[i].end = 0; + continue; + } - /* Try both with and without underscore. */ - func = lookup_minimal_symbol (methcalls[i].name, NULL, NULL); - if ((func == NULL) && (methcalls[i].name[0] == '_')) { - func = lookup_minimal_symbol (methcalls[i].name + 1, NULL, NULL); - } - if (func == NULL) { - methcalls[i].begin = 0; - methcalls[i].end = 0; - continue; + methcalls[i].begin = SYMBOL_VALUE_ADDRESS (func); + do { + methcalls[i].end = SYMBOL_VALUE_ADDRESS (++func); + } while (methcalls[i].begin == methcalls[i].end); } - - methcalls[i].begin = SYMBOL_VALUE_ADDRESS (func); - do { - methcalls[i].end = SYMBOL_VALUE_ADDRESS (++func); - } while (methcalls[i].begin == methcalls[i].end); - } } /* find_objc_msgcall (replaces pc_off_limits) @@ -1610,58 +1626,74 @@ _initialize_objc_language (void) } static void -read_objc_method (CORE_ADDR addr, struct objc_method *method) +read_objc_method (struct gdbarch *gdbarch, CORE_ADDR addr, + struct objc_method *method) { - method->name = read_memory_unsigned_integer (addr + 0, 4); - method->types = read_memory_unsigned_integer (addr + 4, 4); - method->imp = read_memory_unsigned_integer (addr + 8, 4); + enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); + + method->name = read_memory_unsigned_integer (addr + 0, 4, byte_order); + method->types = read_memory_unsigned_integer (addr + 4, 4, byte_order); + method->imp = read_memory_unsigned_integer (addr + 8, 4, byte_order); } -static -unsigned long read_objc_methlist_nmethods (CORE_ADDR addr) +static unsigned long +read_objc_methlist_nmethods (struct gdbarch *gdbarch, CORE_ADDR addr) { - return read_memory_unsigned_integer (addr + 4, 4); + enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); + + return read_memory_unsigned_integer (addr + 4, 4, byte_order); } static void -read_objc_methlist_method (CORE_ADDR addr, unsigned long num, - struct objc_method *method) +read_objc_methlist_method (struct gdbarch *gdbarch, CORE_ADDR addr, + unsigned long num, struct objc_method *method) { - gdb_assert (num < read_objc_methlist_nmethods (addr)); - read_objc_method (addr + 8 + (12 * num), method); + gdb_assert (num < read_objc_methlist_nmethods (gdbarch, addr)); + read_objc_method (gdbarch, addr + 8 + (12 * num), method); } static void -read_objc_object (CORE_ADDR addr, struct objc_object *object) +read_objc_object (struct gdbarch *gdbarch, CORE_ADDR addr, + struct objc_object *object) { - object->isa = read_memory_unsigned_integer (addr, 4); + enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); + + object->isa = read_memory_unsigned_integer (addr, 4, byte_order); } static void -read_objc_super (CORE_ADDR addr, struct objc_super *super) +read_objc_super (struct gdbarch *gdbarch, CORE_ADDR addr, + struct objc_super *super) { - super->receiver = read_memory_unsigned_integer (addr, 4); - super->class = read_memory_unsigned_integer (addr + 4, 4); + enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); + + super->receiver = read_memory_unsigned_integer (addr, 4, byte_order); + super->class = read_memory_unsigned_integer (addr + 4, 4, byte_order); }; static void -read_objc_class (CORE_ADDR addr, struct objc_class *class) +read_objc_class (struct gdbarch *gdbarch, CORE_ADDR addr, + struct objc_class *class) { - class->isa = read_memory_unsigned_integer (addr, 4); - class->super_class = read_memory_unsigned_integer (addr + 4, 4); - class->name = read_memory_unsigned_integer (addr + 8, 4); - class->version = read_memory_unsigned_integer (addr + 12, 4); - class->info = read_memory_unsigned_integer (addr + 16, 4); - class->instance_size = read_memory_unsigned_integer (addr + 18, 4); - class->ivars = read_memory_unsigned_integer (addr + 24, 4); - class->methods = read_memory_unsigned_integer (addr + 28, 4); - class->cache = read_memory_unsigned_integer (addr + 32, 4); - class->protocols = read_memory_unsigned_integer (addr + 36, 4); + enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); + + class->isa = read_memory_unsigned_integer (addr, 4, byte_order); + class->super_class = read_memory_unsigned_integer (addr + 4, 4, byte_order); + class->name = read_memory_unsigned_integer (addr + 8, 4, byte_order); + class->version = read_memory_unsigned_integer (addr + 12, 4, byte_order); + class->info = read_memory_unsigned_integer (addr + 16, 4, byte_order); + class->instance_size = read_memory_unsigned_integer (addr + 18, 4, byte_order); + class->ivars = read_memory_unsigned_integer (addr + 24, 4, byte_order); + class->methods = read_memory_unsigned_integer (addr + 28, 4, byte_order); + class->cache = read_memory_unsigned_integer (addr + 32, 4, byte_order); + class->protocols = read_memory_unsigned_integer (addr + 36, 4, byte_order); } static CORE_ADDR -find_implementation_from_class (CORE_ADDR class, CORE_ADDR sel) +find_implementation_from_class (struct gdbarch *gdbarch, + CORE_ADDR class, CORE_ADDR sel) { + enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); CORE_ADDR subclass = class; while (subclass != 0) @@ -1670,7 +1702,7 @@ find_implementation_from_class (CORE_ADDR class, CORE_ADDR sel) struct objc_class class_str; unsigned mlistnum = 0; - read_objc_class (subclass, &class_str); + read_objc_class (gdbarch, subclass, &class_str); for (;;) { @@ -1679,17 +1711,18 @@ find_implementation_from_class (CORE_ADDR class, CORE_ADDR sel) unsigned long i; mlist = read_memory_unsigned_integer (class_str.methods + - (4 * mlistnum), 4); + (4 * mlistnum), + 4, byte_order); if (mlist == 0) break; - nmethods = read_objc_methlist_nmethods (mlist); + nmethods = read_objc_methlist_nmethods (gdbarch, mlist); for (i = 0; i < nmethods; i++) { struct objc_method meth_str; - read_objc_methlist_method (mlist, i, &meth_str); + read_objc_methlist_method (gdbarch, mlist, i, &meth_str); #if 0 fprintf (stderr, "checking method 0x%lx against selector 0x%lx\n", @@ -1710,17 +1743,18 @@ find_implementation_from_class (CORE_ADDR class, CORE_ADDR sel) } static CORE_ADDR -find_implementation (CORE_ADDR object, CORE_ADDR sel) +find_implementation (struct gdbarch *gdbarch, + CORE_ADDR object, CORE_ADDR sel) { struct objc_object ostr; if (object == 0) return 0; - read_objc_object (object, &ostr); + read_objc_object (gdbarch, object, &ostr); if (ostr.isa == 0) return 0; - return find_implementation_from_class (ostr.isa, sel); + return find_implementation_from_class (gdbarch, ostr.isa, sel); } static int @@ -1737,7 +1771,7 @@ resolve_msgsend (CORE_ADDR pc, CORE_ADDR *new_pc) object = gdbarch_fetch_pointer_argument (gdbarch, frame, 0, ptr_type); sel = gdbarch_fetch_pointer_argument (gdbarch, frame, 1, ptr_type); - res = find_implementation (object, sel); + res = find_implementation (gdbarch, object, sel); if (new_pc != 0) *new_pc = res; if (res == 0) @@ -1759,7 +1793,7 @@ resolve_msgsend_stret (CORE_ADDR pc, CORE_ADDR *new_pc) object = gdbarch_fetch_pointer_argument (gdbarch, frame, 1, ptr_type); sel = gdbarch_fetch_pointer_argument (gdbarch, frame, 2, ptr_type); - res = find_implementation (object, sel); + res = find_implementation (gdbarch, object, sel); if (new_pc != 0) *new_pc = res; if (res == 0) @@ -1783,11 +1817,11 @@ resolve_msgsend_super (CORE_ADDR pc, CORE_ADDR *new_pc) super = gdbarch_fetch_pointer_argument (gdbarch, frame, 0, ptr_type); sel = gdbarch_fetch_pointer_argument (gdbarch, frame, 1, ptr_type); - read_objc_super (super, &sstr); + read_objc_super (gdbarch, super, &sstr); if (sstr.class == 0) return 0; - res = find_implementation_from_class (sstr.class, sel); + res = find_implementation_from_class (gdbarch, sstr.class, sel); if (new_pc != 0) *new_pc = res; if (res == 0) @@ -1811,11 +1845,11 @@ resolve_msgsend_super_stret (CORE_ADDR pc, CORE_ADDR *new_pc) super = gdbarch_fetch_pointer_argument (gdbarch, frame, 1, ptr_type); sel = gdbarch_fetch_pointer_argument (gdbarch, frame, 2, ptr_type); - read_objc_super (super, &sstr); + read_objc_super (gdbarch, super, &sstr); if (sstr.class == 0) return 0; - res = find_implementation_from_class (sstr.class, sel); + res = find_implementation_from_class (gdbarch, sstr.class, sel); if (new_pc != 0) *new_pc = res; if (res == 0)