X-Git-Url: https://git.libre-soc.org/?a=blobdiff_plain;f=src%2Fgallium%2Fauxiliary%2Fdraw%2Fdraw_pt.c;h=e89ccd254011f24c0d508edd2f7b87da678a83d6;hb=1c2e5c223da28cdffe156b6b430fcdf638909021;hp=0a4132864250906a4b44d3854d828b43a15fad01;hpb=f94e7e25d101a8691a5276a5aa0eb97d2f4eebbc;p=mesa.git diff --git a/src/gallium/auxiliary/draw/draw_pt.c b/src/gallium/auxiliary/draw/draw_pt.c index 0a413286425..e89ccd25401 100644 --- a/src/gallium/auxiliary/draw/draw_pt.c +++ b/src/gallium/auxiliary/draw/draw_pt.c @@ -34,36 +34,26 @@ #include "draw/draw_gs.h" #include "draw/draw_private.h" #include "draw/draw_pt.h" +#include "draw/draw_vbuf.h" #include "draw/draw_vs.h" #include "tgsi/tgsi_dump.h" #include "util/u_math.h" #include "util/u_prim.h" #include "util/u_format.h" +#include "util/u_draw.h" DEBUG_GET_ONCE_BOOL_OPTION(draw_fse, "DRAW_FSE", FALSE) DEBUG_GET_ONCE_BOOL_OPTION(draw_no_fse, "DRAW_NO_FSE", FALSE) -#ifdef HAVE_LLVM -DEBUG_GET_ONCE_BOOL_OPTION(draw_use_llvm, "DRAW_USE_LLVM", TRUE) -#endif - -static unsigned trim( unsigned count, unsigned first, unsigned incr ) -{ - if (count < first) - return 0; - return count - (count - first) % incr; -} - - /* Overall we split things into: - * - frontend -- prepare fetch_elts, draw_elts - eg vcache + * - frontend -- prepare fetch_elts, draw_elts - eg vsplit * - middle -- fetch, shade, cliptest, viewport * - pipeline -- the prim pipeline: clipping, wide lines, etc * - backend -- the vbuf_render provided by the driver. */ static boolean -draw_pt_arrays(struct draw_context *draw, +draw_pt_arrays(struct draw_context *draw, unsigned prim, unsigned start, unsigned count) @@ -77,7 +67,7 @@ draw_pt_arrays(struct draw_context *draw, { unsigned first, incr; draw_pt_split_prim(prim, &first, &incr); - count = trim(count, first, incr); + count = draw_pt_trim_count(count, first, incr); if (count < first) return TRUE; } @@ -97,7 +87,9 @@ draw_pt_arrays(struct draw_context *draw, opt |= PT_PIPELINE; } - if (!draw->bypass_clipping && !draw->pt.test_fse) { + if ((draw->clip_xy || + draw->clip_z || + draw->clip_user) && !draw->pt.test_fse) { opt |= PT_CLIPTEST; } @@ -115,40 +107,76 @@ draw_pt_arrays(struct draw_context *draw, middle = draw->pt.middle.general; } - - /* Pick the right frontend - */ - if (draw->pt.user.elts || (opt & PT_PIPELINE)) { - frontend = draw->pt.front.vcache; - } else { - frontend = draw->pt.front.varray; + frontend = draw->pt.frontend; + + if (frontend ) { + if (draw->pt.prim != prim || draw->pt.opt != opt) { + /* In certain conditions switching primitives requires us to flush + * and validate the different stages. One example is when smooth + * lines are active but first drawn with triangles and then with + * lines. + */ + draw_do_flush( draw, DRAW_FLUSH_STATE_CHANGE ); + frontend = NULL; + } else if (draw->pt.eltSize != draw->pt.user.eltSize) { + /* Flush draw state if eltSize changed. + * This could be improved so only the frontend is flushed since it + * converts all indices to ushorts and the fetch part of the middle + * always prepares both linear and indexed. + */ + frontend->flush( frontend, DRAW_FLUSH_STATE_CHANGE ); + frontend = NULL; + } } - frontend->prepare( frontend, prim, middle, opt ); + if (!frontend) { + frontend = draw->pt.front.vsplit; - frontend->run(frontend, - draw_pt_elt_func(draw), - draw_pt_elt_ptr(draw, start), - draw->pt.user.eltBias, - count); + frontend->prepare( frontend, prim, middle, opt ); - frontend->finish( frontend ); + draw->pt.frontend = frontend; + draw->pt.eltSize = draw->pt.user.eltSize; + draw->pt.prim = prim; + draw->pt.opt = opt; + } + + if (draw->pt.rebind_parameters) { + /* update constants, viewport dims, clip planes, etc */ + middle->bind_parameters(middle); + draw->pt.rebind_parameters = FALSE; + } + + frontend->run( frontend, start, count ); return TRUE; } +void draw_pt_flush( struct draw_context *draw, unsigned flags ) +{ + assert(flags); + + if (draw->pt.frontend) { + draw->pt.frontend->flush( draw->pt.frontend, flags ); + + /* don't prepare if we only are flushing the backend */ + if (flags & DRAW_FLUSH_STATE_CHANGE) + draw->pt.frontend = NULL; + } + + if (flags & DRAW_FLUSH_PARAMETER_CHANGE) { + draw->pt.rebind_parameters = TRUE; + } +} + + boolean draw_pt_init( struct draw_context *draw ) { draw->pt.test_fse = debug_get_option_draw_fse(); draw->pt.no_fse = debug_get_option_draw_no_fse(); - draw->pt.front.vcache = draw_pt_vcache( draw ); - if (!draw->pt.front.vcache) - return FALSE; - - draw->pt.front.varray = draw_pt_varray(draw); - if (!draw->pt.front.varray) + draw->pt.front.vsplit = draw_pt_vsplit(draw); + if (!draw->pt.front.vsplit) return FALSE; draw->pt.middle.fetch_emit = draw_pt_fetch_emit( draw ); @@ -164,7 +192,7 @@ boolean draw_pt_init( struct draw_context *draw ) return FALSE; #if HAVE_LLVM - if (debug_get_option_draw_use_llvm()) + if (draw->llvm) draw->pt.middle.llvm = draw_pt_fetch_pipeline_or_emit_llvm( draw ); #endif @@ -194,14 +222,9 @@ void draw_pt_destroy( struct draw_context *draw ) draw->pt.middle.fetch_shade_emit = NULL; } - if (draw->pt.front.vcache) { - draw->pt.front.vcache->destroy( draw->pt.front.vcache ); - draw->pt.front.vcache = NULL; - } - - if (draw->pt.front.varray) { - draw->pt.front.varray->destroy( draw->pt.front.varray ); - draw->pt.front.varray = NULL; + if (draw->pt.front.vsplit) { + draw->pt.front.vsplit->destroy( draw->pt.front.vsplit ); + draw->pt.front.vsplit = NULL; } } @@ -221,8 +244,9 @@ draw_print_arrays(struct draw_context *draw, uint prim, int start, uint count) uint ii = 0; uint j; - if (draw->pt.user.elts) { + if (draw->pt.user.eltSize) { /* indexed arrays */ + switch (draw->pt.user.eltSize) { case 1: { @@ -258,7 +282,12 @@ draw_print_arrays(struct draw_context *draw, uint prim, int start, uint count) for (j = 0; j < draw->pt.nr_vertex_elements; j++) { uint buf = draw->pt.vertex_element[j].vertex_buffer_index; - ubyte *ptr = (ubyte *) draw->pt.user.vbuffer[buf]; + ubyte *ptr = (ubyte *) draw->pt.user.vbuffer[buf].map; + + if (draw->pt.vertex_element[j].instance_divisor) { + ii = draw->instance_id / draw->pt.vertex_element[j].instance_divisor; + } + ptr += draw->pt.vertex_buffer[buf].buffer_offset; ptr += draw->pt.vertex_buffer[buf].stride * ii; ptr += draw->pt.vertex_element[j].src_offset; @@ -297,6 +326,13 @@ draw_print_arrays(struct draw_context *draw, uint prim, int start, uint count) (void *) u); } break; + case PIPE_FORMAT_A8R8G8B8_UNORM: + { + ubyte *u = (ubyte *) ptr; + debug_printf("ARGB %d %d %d %d @ %p\n", u[0], u[1], u[2], u[3], + (void *) u); + } + break; default: debug_printf("other format %s (fix me)\n", util_format_name(draw->pt.vertex_element[j].src_format)); @@ -306,52 +342,139 @@ draw_print_arrays(struct draw_context *draw, uint prim, int start, uint count) } +/** Helper code for below */ +#define PRIM_RESTART_LOOP(elements) \ + do { \ + for (i = start; i < end; i++) { \ + if (i < elt_max && elements[i] == info->restart_index) { \ + if (cur_count > 0) { \ + /* draw elts up to prev pos */ \ + draw_pt_arrays(draw, prim, cur_start, cur_count); \ + } \ + /* begin new prim at next elt */ \ + cur_start = i + 1; \ + cur_count = 0; \ + } \ + else { \ + cur_count++; \ + } \ + } \ + if (cur_count > 0) { \ + draw_pt_arrays(draw, prim, cur_start, cur_count); \ + } \ + } while (0) + + /** - * Non-instanced drawing. - * \sa draw_arrays_instanced + * For drawing prims with primitive restart enabled. + * Scan for restart indexes and draw the runs of elements/vertices between + * the restarts. */ -void -draw_arrays(struct draw_context *draw, unsigned prim, - unsigned start, unsigned count) +static void +draw_pt_arrays_restart(struct draw_context *draw, + const struct pipe_draw_info *info) { - draw_arrays_instanced(draw, prim, start, count, 0, 1); + const unsigned prim = info->mode; + const unsigned start = info->start; + const unsigned count = info->count; + const unsigned end = start + count; + const unsigned elt_max = draw->pt.user.eltMax; + unsigned i, cur_start, cur_count; + + assert(info->primitive_restart); + + if (draw->pt.user.eltSize) { + /* indexed prims (draw_elements) */ + cur_start = start; + cur_count = 0; + + switch (draw->pt.user.eltSize) { + case 1: + { + const ubyte *elt_ub = (const ubyte *) draw->pt.user.elts; + PRIM_RESTART_LOOP(elt_ub); + } + break; + case 2: + { + const ushort *elt_us = (const ushort *) draw->pt.user.elts; + PRIM_RESTART_LOOP(elt_us); + } + break; + case 4: + { + const uint *elt_ui = (const uint *) draw->pt.user.elts; + PRIM_RESTART_LOOP(elt_ui); + } + break; + default: + assert(0 && "bad eltSize in draw_arrays()"); + } + } + else { + /* Non-indexed prims (draw_arrays). + * Primitive restart should have been handled in the state tracker. + */ + draw_pt_arrays(draw, prim, start, count); + } } +/** + * Resolve true values within pipe_draw_info. + * If we're rendering from transform feedback/stream output + * buffers both the count and max_index need to be computed + * from the attached stream output target. + */ +static void +resolve_draw_info(const struct pipe_draw_info *raw_info, + struct pipe_draw_info *info) +{ + memcpy(info, raw_info, sizeof(struct pipe_draw_info)); + + if (raw_info->count_from_stream_output) { + struct draw_so_target *target = + (struct draw_so_target *)info->count_from_stream_output; + info->count = target->emitted_vertices; + + /* Stream output draw can not be indexed */ + debug_assert(!info->indexed); + info->max_index = info->count - 1; + } +} + /** * Draw vertex arrays. - * This is the main entrypoint into the drawing module. - * If drawing an indexed primitive, the draw_set_mapped_element_buffer_range() - * function should have already been called to specify the element/index buffer - * information. - * - * \param prim one of PIPE_PRIM_x - * \param start index of first vertex to draw - * \param count number of vertices to draw - * \param startInstance number for the first primitive instance (usually 0). - * \param instanceCount number of instances to draw (1=non-instanced) + * This is the main entrypoint into the drawing module. If drawing an indexed + * primitive, the draw_set_indexes() function should have already been called + * to specify the element/index buffer information. */ void -draw_arrays_instanced(struct draw_context *draw, - unsigned mode, - unsigned start, - unsigned count, - unsigned startInstance, - unsigned instanceCount) +draw_vbo(struct draw_context *draw, + const struct pipe_draw_info *info) { - unsigned reduced_prim = u_reduced_prim(mode); unsigned instance; + unsigned index_limit; + unsigned count; + struct pipe_draw_info resolved_info; - assert(instanceCount > 0); + resolve_draw_info(info, &resolved_info); + info = &resolved_info; - if (reduced_prim != draw->reduced_prim) { - draw_do_flush(draw, DRAW_FLUSH_STATE_CHANGE); - draw->reduced_prim = reduced_prim; - } + assert(info->instance_count > 0); + if (info->indexed) + assert(draw->pt.user.elts); + + count = info->count; + + draw->pt.user.eltBias = info->index_bias; + draw->pt.user.min_index = info->min_index; + draw->pt.user.max_index = info->max_index; + draw->pt.user.eltSize = info->indexed ? draw->pt.user.eltSizeIB : 0; if (0) - debug_printf("draw_arrays(mode=%u start=%u count=%u):\n", - mode, start, count); + debug_printf("draw_vbo(mode=%u start=%u count=%u):\n", + info->mode, info->start, count); if (0) tgsi_dump(draw->vs.vertex_shader->state.tokens, 0); @@ -369,20 +492,67 @@ draw_arrays_instanced(struct draw_context *draw, } debug_printf("Buffers:\n"); for (i = 0; i < draw->pt.nr_vertex_buffers; i++) { - debug_printf(" %u: stride=%u maxindex=%u offset=%u ptr=%p\n", + debug_printf(" %u: stride=%u offset=%u size=%d ptr=%p\n", i, draw->pt.vertex_buffer[i].stride, - draw->pt.vertex_buffer[i].max_index, draw->pt.vertex_buffer[i].buffer_offset, - draw->pt.user.vbuffer[i]); + (int) draw->pt.user.vbuffer[i].size, + draw->pt.user.vbuffer[i].map); } } if (0) - draw_print_arrays(draw, mode, start, MIN2(count, 20)); + draw_print_arrays(draw, info->mode, info->start, MIN2(count, 20)); + + index_limit = util_draw_max_index(draw->pt.vertex_buffer, + draw->pt.vertex_element, + draw->pt.nr_vertex_elements, + info); +#if HAVE_LLVM + if (!draw->llvm) +#endif + { + if (index_limit == 0) { + /* one of the buffers is too small to do any valid drawing */ + debug_warning("draw: VBO too small to draw anything\n"); + return; + } + } + + /* If we're collecting stats then make sure we start from scratch */ + if (draw->collect_statistics) { + memset(&draw->statistics, 0, sizeof(draw->statistics)); + } + + draw->pt.max_index = index_limit - 1; + + /* + * TODO: We could use draw->pt.max_index to further narrow + * the min_index/max_index hints given by the state tracker. + */ + + for (instance = 0; instance < info->instance_count; instance++) { + draw->instance_id = instance + info->start_instance; + draw->start_instance = info->start_instance; + /* check for overflow */ + if (draw->instance_id < instance || + draw->instance_id < info->start_instance) { + /* if we overflown just set the instance id to the max */ + draw->instance_id = 0xffffffff; + } + + draw_new_instance(draw); + + if (info->primitive_restart) { + draw_pt_arrays_restart(draw, info); + } + else { + draw_pt_arrays(draw, info->mode, info->start, count); + } + } - for (instance = 0; instance < instanceCount; instance++) { - draw->instance_id = instance + startInstance; - draw_pt_arrays(draw, mode, start, count); + /* If requested emit the pipeline statistics for this run */ + if (draw->collect_statistics) { + draw->render->pipeline_statistics(draw->render, &draw->statistics); } }