X-Git-Url: https://git.libre-soc.org/?a=blobdiff_plain;f=src%2Fgallium%2Fdrivers%2Fradeonsi%2Fsi_blit.c;h=370ce04a9b2c9eabb5162914a0716830103699cb;hb=19f3141e6ab34dc7389b5e1fa9f3dca5e23b2191;hp=4256c51efbc97386c9cea0301acad8194a6fe487;hpb=9cc91ba6d5fafa5435ff4b6081f731acc99af47f;p=mesa.git diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index 4256c51efbc..370ce04a9b2 100644 --- a/src/gallium/drivers/radeonsi/si_blit.c +++ b/src/gallium/drivers/radeonsi/si_blit.c @@ -22,20 +22,12 @@ */ #include "si_pipe.h" +#include "si_compute.h" #include "util/u_format.h" +#include "util/u_log.h" #include "util/u_surface.h" -enum si_blitter_op /* bitmask */ -{ - SI_SAVE_TEXTURES = 1, - SI_SAVE_FRAMEBUFFER = 2, - SI_SAVE_FRAGMENT_STATE = 4, - SI_DISABLE_RENDER_COND = 8, - - SI_CLEAR = SI_SAVE_FRAGMENT_STATE, - - SI_CLEAR_SURFACE = SI_SAVE_FRAMEBUFFER | SI_SAVE_FRAGMENT_STATE, - +enum { SI_COPY = SI_SAVE_FRAMEBUFFER | SI_SAVE_TEXTURES | SI_SAVE_FRAGMENT_STATE | SI_DISABLE_RENDER_COND, @@ -48,18 +40,16 @@ enum si_blitter_op /* bitmask */ SI_COLOR_RESOLVE = SI_SAVE_FRAMEBUFFER | SI_SAVE_FRAGMENT_STATE }; -static void si_blitter_begin(struct pipe_context *ctx, enum si_blitter_op op) +void si_blitter_begin(struct pipe_context *ctx, enum si_blitter_op op) { struct si_context *sctx = (struct si_context *)ctx; - util_blitter_save_vertex_buffer_slot(sctx->blitter, sctx->vertex_buffer); - util_blitter_save_vertex_elements(sctx->blitter, sctx->vertex_elements); util_blitter_save_vertex_shader(sctx->blitter, sctx->vs_shader.cso); util_blitter_save_tessctrl_shader(sctx->blitter, sctx->tcs_shader.cso); util_blitter_save_tesseval_shader(sctx->blitter, sctx->tes_shader.cso); util_blitter_save_geometry_shader(sctx->blitter, sctx->gs_shader.cso); - util_blitter_save_so_targets(sctx->blitter, sctx->b.streamout.num_targets, - (struct pipe_stream_output_target**)sctx->b.streamout.targets); + util_blitter_save_so_targets(sctx->blitter, sctx->streamout.num_targets, + (struct pipe_stream_output_target**)sctx->streamout.targets); util_blitter_save_rasterizer(sctx->blitter, sctx->queued.named.rasterizer); if (op & SI_SAVE_FRAGMENT_STATE) { @@ -68,8 +58,7 @@ static void si_blitter_begin(struct pipe_context *ctx, enum si_blitter_op op) util_blitter_save_stencil_ref(sctx->blitter, &sctx->stencil_ref.state); util_blitter_save_fragment_shader(sctx->blitter, sctx->ps_shader.cso); util_blitter_save_sample_mask(sctx->blitter, sctx->sample_mask.sample_mask); - util_blitter_save_viewport(sctx->blitter, &sctx->b.viewports.states[0]); - util_blitter_save_scissor(sctx->blitter, &sctx->b.scissors.states[0]); + util_blitter_save_scissor(sctx->blitter, &sctx->scissors.states[0]); } if (op & SI_SAVE_FRAMEBUFFER) @@ -78,21 +67,27 @@ static void si_blitter_begin(struct pipe_context *ctx, enum si_blitter_op op) if (op & SI_SAVE_TEXTURES) { util_blitter_save_fragment_sampler_states( sctx->blitter, 2, - (void**)sctx->samplers[PIPE_SHADER_FRAGMENT].views.sampler_states); + (void**)sctx->samplers[PIPE_SHADER_FRAGMENT].sampler_states); util_blitter_save_fragment_sampler_views(sctx->blitter, 2, - sctx->samplers[PIPE_SHADER_FRAGMENT].views.views); + sctx->samplers[PIPE_SHADER_FRAGMENT].views); } if (op & SI_DISABLE_RENDER_COND) sctx->b.render_cond_force_off = true; } -static void si_blitter_end(struct pipe_context *ctx) +void si_blitter_end(struct pipe_context *ctx) { struct si_context *sctx = (struct si_context *)ctx; sctx->b.render_cond_force_off = false; + + /* Restore shader pointers because the VS blit shader changed all + * non-global VS user SGPRs. */ + sctx->shader_pointers_dirty |= SI_DESCS_SHADER_MASK(VERTEX); + sctx->vertex_buffer_pointer_dirty = true; + si_mark_atom_dirty(sctx, &sctx->shader_pointers.atom); } static unsigned u_max_sample(struct pipe_resource *r) @@ -120,6 +115,8 @@ si_blit_dbcb_copy(struct si_context *sctx, assert(sctx->dbcb_depth_copy_enabled || sctx->dbcb_stencil_copy_enabled); + sctx->decompression_enabled = true; + while (level_mask) { unsigned level = u_bit_scan(&level_mask); @@ -163,6 +160,7 @@ si_blit_dbcb_copy(struct si_context *sctx, fully_copied_levels |= 1u << level; } + sctx->decompression_enabled = false; sctx->dbcb_depth_copy_enabled = false; sctx->dbcb_stencil_copy_enabled = false; si_mark_atom_dirty(sctx, &sctx->db_render_state); @@ -218,6 +216,8 @@ si_blit_decompress_zs_planes_in_place(struct si_context *sctx, surf_tmpl.format = texture->resource.b.b.format; + sctx->decompression_enabled = true; + while (level_mask) { unsigned level = u_bit_scan(&level_mask); @@ -255,6 +255,7 @@ si_blit_decompress_zs_planes_in_place(struct si_context *sctx, if (planes & PIPE_MASK_S) texture->stencil_dirty_level_mask &= ~fully_decompressed_mask; + sctx->decompression_enabled = false; sctx->db_flush_depth_inplace = false; sctx->db_flush_stencil_inplace = false; si_mark_atom_dirty(sctx, &sctx->db_render_state); @@ -298,11 +299,11 @@ si_blit_decompress_zs_in_place(struct si_context *sctx, } static void -si_flush_depth_texture(struct si_context *sctx, - struct r600_texture *tex, - unsigned required_planes, - unsigned first_level, unsigned last_level, - unsigned first_layer, unsigned last_layer) +si_decompress_depth(struct si_context *sctx, + struct r600_texture *tex, + unsigned required_planes, + unsigned first_level, unsigned last_level, + unsigned first_layer, unsigned last_layer) { unsigned inplace_planes = 0; unsigned copy_planes = 0; @@ -314,7 +315,7 @@ si_flush_depth_texture(struct si_context *sctx, levels_z = level_mask & tex->dirty_level_mask; if (levels_z) { - if (r600_can_sample_zs(tex, false)) + if (si_can_sample_zs(tex, false)) inplace_planes |= PIPE_MASK_Z; else copy_planes |= PIPE_MASK_Z; @@ -324,21 +325,25 @@ si_flush_depth_texture(struct si_context *sctx, levels_s = level_mask & tex->stencil_dirty_level_mask; if (levels_s) { - if (r600_can_sample_zs(tex, true)) + if (si_can_sample_zs(tex, true)) inplace_planes |= PIPE_MASK_S; else copy_planes |= PIPE_MASK_S; } } - assert(!tex->tc_compatible_htile || levels_z == 0); + if (unlikely(sctx->b.log)) + u_log_printf(sctx->b.log, + "\n------------------------------------------------\n" + "Decompress Depth (levels %u - %u, levels Z: 0x%x S: 0x%x)\n\n", + first_level, last_level, levels_z, levels_s); /* We may have to allocate the flushed texture here when called from * si_decompress_subresource. */ if (copy_planes && (tex->flushed_depth_texture || - r600_init_flushed_depth_texture(&sctx->b.b, &tex->resource.b.b, NULL))) { + si_init_flushed_depth_texture(&sctx->b.b, &tex->resource.b.b, NULL))) { struct r600_texture *dst = tex->flushed_depth_texture; unsigned fully_copied_levels; unsigned levels = 0; @@ -369,19 +374,50 @@ si_flush_depth_texture(struct si_context *sctx, } if (inplace_planes) { - si_blit_decompress_zs_in_place( - sctx, tex, - levels_z, levels_s, - first_layer, last_layer); + bool has_htile = si_htile_enabled(tex, first_level); + bool tc_compat_htile = vi_tc_compat_htile_enabled(tex, first_level); + + /* Don't decompress if there is no HTILE or when HTILE is + * TC-compatible. */ + if (has_htile && !tc_compat_htile) { + si_blit_decompress_zs_in_place( + sctx, tex, + levels_z, levels_s, + first_layer, last_layer); + } else { + /* This is only a cache flush. + * + * Only clear the mask that we are flushing, because + * si_make_DB_shader_coherent() treats different levels + * and depth and stencil differently. + */ + if (inplace_planes & PIPE_MASK_Z) + tex->dirty_level_mask &= ~levels_z; + if (inplace_planes & PIPE_MASK_S) + tex->stencil_dirty_level_mask &= ~levels_s; + } + + /* Only in-place decompression needs to flush DB caches, or + * when we don't decompress but TC-compatible planes are dirty. + */ + si_make_DB_shader_coherent(sctx, tex->resource.b.b.nr_samples, + inplace_planes & PIPE_MASK_S, + tc_compat_htile); } + /* set_framebuffer_state takes care of coherency for single-sample. + * The DB->CB copy uses CB for the final writes. + */ + if (copy_planes && tex->resource.b.b.nr_samples > 1) + si_make_CB_shader_coherent(sctx, tex->resource.b.b.nr_samples, + false); } static void -si_flush_depth_textures(struct si_context *sctx, - struct si_textures_info *textures) +si_decompress_sampler_depth_textures(struct si_context *sctx, + struct si_samplers *textures) { unsigned i; - unsigned mask = textures->depth_texture_mask; + unsigned mask = textures->needs_depth_decompress_mask; while (mask) { struct pipe_sampler_view *view; @@ -390,18 +426,17 @@ si_flush_depth_textures(struct si_context *sctx, i = u_bit_scan(&mask); - view = textures->views.views[i]; + view = textures->views[i]; assert(view); sview = (struct si_sampler_view*)view; tex = (struct r600_texture *)view->texture; assert(tex->db_compatible); - si_flush_depth_texture( - sctx, tex, - sview->is_stencil_sampler ? PIPE_MASK_S : PIPE_MASK_Z, - view->u.tex.first_level, view->u.tex.last_level, - 0, util_max_layer(&tex->resource.b.b, view->u.tex.first_level)); + si_decompress_depth(sctx, tex, + sview->is_stencil_sampler ? PIPE_MASK_S : PIPE_MASK_Z, + view->u.tex.first_level, view->u.tex.last_level, + 0, util_max_layer(&tex->resource.b.b, view->u.tex.first_level)); } } @@ -422,20 +457,30 @@ static void si_blit_decompress_color(struct pipe_context *ctx, if (!level_mask) return; - if (rtex->dcc_offset && need_dcc_decompress) { + if (unlikely(sctx->b.log)) + u_log_printf(sctx->b.log, + "\n------------------------------------------------\n" + "Decompress Color (levels %u - %u, mask 0x%x)\n\n", + first_level, last_level, level_mask); + + if (need_dcc_decompress) { custom_blend = sctx->custom_blend_dcc_decompress; + assert(rtex->dcc_offset); + /* disable levels without DCC */ for (int i = first_level; i <= last_level; i++) { if (!vi_dcc_enabled(rtex, i)) level_mask &= ~(1 << i); } } else if (rtex->fmask.size) { - custom_blend = sctx->custom_blend_decompress; + custom_blend = sctx->custom_blend_fmask_decompress; } else { - custom_blend = sctx->custom_blend_fastclear; + custom_blend = sctx->custom_blend_eliminate_fastclear; } + sctx->decompression_enabled = true; + while (level_mask) { unsigned level = u_bit_scan(&level_mask); @@ -453,10 +498,19 @@ static void si_blit_decompress_color(struct pipe_context *ctx, surf_tmpl.u.tex.last_layer = layer; cbsurf = ctx->create_surface(ctx, &rtex->resource.b.b, &surf_tmpl); + /* Required before and after FMASK and DCC_DECOMPRESS. */ + if (custom_blend == sctx->custom_blend_fmask_decompress || + custom_blend == sctx->custom_blend_dcc_decompress) + sctx->b.flags |= SI_CONTEXT_FLUSH_AND_INV_CB; + si_blitter_begin(ctx, SI_DECOMPRESS); util_blitter_custom_color(sctx->blitter, cbsurf, custom_blend); si_blitter_end(ctx); + if (custom_blend == sctx->custom_blend_fmask_decompress || + custom_blend == sctx->custom_blend_dcc_decompress) + sctx->b.flags |= SI_CONTEXT_FLUSH_AND_INV_CB; + pipe_surface_reference(&cbsurf, NULL); } @@ -466,14 +520,31 @@ static void si_blit_decompress_color(struct pipe_context *ctx, rtex->dirty_level_mask &= ~(1 << level); } } + + sctx->decompression_enabled = false; + si_make_CB_shader_coherent(sctx, rtex->resource.b.b.nr_samples, + vi_dcc_enabled(rtex, first_level)); +} + +static void +si_decompress_color_texture(struct si_context *sctx, struct r600_texture *tex, + unsigned first_level, unsigned last_level) +{ + /* CMASK or DCC can be discarded and we can still end up here. */ + if (!tex->cmask.size && !tex->fmask.size && !tex->dcc_offset) + return; + + si_blit_decompress_color(&sctx->b.b, tex, first_level, last_level, 0, + util_max_layer(&tex->resource.b.b, first_level), + false); } static void si_decompress_sampler_color_textures(struct si_context *sctx, - struct si_textures_info *textures) + struct si_samplers *textures) { unsigned i; - unsigned mask = textures->compressed_colortex_mask; + unsigned mask = textures->needs_color_decompress_mask; while (mask) { struct pipe_sampler_view *view; @@ -481,27 +552,22 @@ si_decompress_sampler_color_textures(struct si_context *sctx, i = u_bit_scan(&mask); - view = textures->views.views[i]; + view = textures->views[i]; assert(view); tex = (struct r600_texture *)view->texture; - /* CMASK or DCC can be discarded and we can still end up here. */ - if (!tex->cmask.size && !tex->fmask.size && !tex->dcc_offset) - continue; - si_blit_decompress_color(&sctx->b.b, tex, - view->u.tex.first_level, view->u.tex.last_level, - 0, util_max_layer(&tex->resource.b.b, view->u.tex.first_level), - false); + si_decompress_color_texture(sctx, tex, view->u.tex.first_level, + view->u.tex.last_level); } } static void si_decompress_image_color_textures(struct si_context *sctx, - struct si_images_info *images) + struct si_images *images) { unsigned i; - unsigned mask = images->compressed_colortex_mask; + unsigned mask = images->needs_color_decompress_mask; while (mask) { const struct pipe_image_view *view; @@ -513,68 +579,79 @@ si_decompress_image_color_textures(struct si_context *sctx, assert(view->resource->target != PIPE_BUFFER); tex = (struct r600_texture *)view->resource; - if (!tex->cmask.size && !tex->fmask.size && !tex->dcc_offset) + + si_decompress_color_texture(sctx, tex, view->u.tex.level, + view->u.tex.level); + } +} + +static void si_check_render_feedback_texture(struct si_context *sctx, + struct r600_texture *tex, + unsigned first_level, + unsigned last_level, + unsigned first_layer, + unsigned last_layer) +{ + bool render_feedback = false; + + if (!tex->dcc_offset) + return; + + for (unsigned j = 0; j < sctx->framebuffer.state.nr_cbufs; ++j) { + struct r600_surface * surf; + + if (!sctx->framebuffer.state.cbufs[j]) continue; - si_blit_decompress_color(&sctx->b.b, tex, - view->u.tex.level, view->u.tex.level, - 0, util_max_layer(&tex->resource.b.b, view->u.tex.level), - false); + surf = (struct r600_surface*)sctx->framebuffer.state.cbufs[j]; + + if (tex == (struct r600_texture *)surf->base.texture && + surf->base.u.tex.level >= first_level && + surf->base.u.tex.level <= last_level && + surf->base.u.tex.first_layer <= last_layer && + surf->base.u.tex.last_layer >= first_layer) { + render_feedback = true; + break; + } } + + if (render_feedback) + si_texture_disable_dcc(&sctx->b, tex); } static void si_check_render_feedback_textures(struct si_context *sctx, - struct si_textures_info *textures) + struct si_samplers *textures) { - uint32_t mask = textures->views.enabled_mask; + uint32_t mask = textures->enabled_mask; while (mask) { const struct pipe_sampler_view *view; struct r600_texture *tex; - bool render_feedback = false; unsigned i = u_bit_scan(&mask); - view = textures->views.views[i]; + view = textures->views[i]; if(view->texture->target == PIPE_BUFFER) continue; tex = (struct r600_texture *)view->texture; - if (!tex->dcc_offset) - continue; - - for (unsigned j = 0; j < sctx->framebuffer.state.nr_cbufs; ++j) { - struct r600_surface * surf; - - if (!sctx->framebuffer.state.cbufs[j]) - continue; - - surf = (struct r600_surface*)sctx->framebuffer.state.cbufs[j]; - - if (tex == (struct r600_texture*)surf->base.texture && - surf->base.u.tex.level >= view->u.tex.first_level && - surf->base.u.tex.level <= view->u.tex.last_level && - surf->base.u.tex.first_layer <= view->u.tex.last_layer && - surf->base.u.tex.last_layer >= view->u.tex.first_layer) { - render_feedback = true; - break; - } - } - if (render_feedback) - r600_texture_disable_dcc(&sctx->b, tex); + si_check_render_feedback_texture(sctx, tex, + view->u.tex.first_level, + view->u.tex.last_level, + view->u.tex.first_layer, + view->u.tex.last_layer); } } static void si_check_render_feedback_images(struct si_context *sctx, - struct si_images_info *images) + struct si_images *images) { uint32_t mask = images->enabled_mask; while (mask) { const struct pipe_image_view *view; struct r600_texture *tex; - bool render_feedback = false; unsigned i = u_bit_scan(&mask); @@ -583,28 +660,54 @@ static void si_check_render_feedback_images(struct si_context *sctx, continue; tex = (struct r600_texture *)view->resource; - if (!tex->dcc_offset) + + si_check_render_feedback_texture(sctx, tex, + view->u.tex.level, + view->u.tex.level, + view->u.tex.first_layer, + view->u.tex.last_layer); + } +} + +static void si_check_render_feedback_resident_textures(struct si_context *sctx) +{ + util_dynarray_foreach(&sctx->resident_tex_handles, + struct si_texture_handle *, tex_handle) { + struct pipe_sampler_view *view; + struct r600_texture *tex; + + view = (*tex_handle)->view; + if (view->texture->target == PIPE_BUFFER) continue; - for (unsigned j = 0; j < sctx->framebuffer.state.nr_cbufs; ++j) { - struct r600_surface * surf; + tex = (struct r600_texture *)view->texture; - if (!sctx->framebuffer.state.cbufs[j]) - continue; + si_check_render_feedback_texture(sctx, tex, + view->u.tex.first_level, + view->u.tex.last_level, + view->u.tex.first_layer, + view->u.tex.last_layer); + } +} - surf = (struct r600_surface*)sctx->framebuffer.state.cbufs[j]; +static void si_check_render_feedback_resident_images(struct si_context *sctx) +{ + util_dynarray_foreach(&sctx->resident_img_handles, + struct si_image_handle *, img_handle) { + struct pipe_image_view *view; + struct r600_texture *tex; - if (tex == (struct r600_texture*)surf->base.texture && - surf->base.u.tex.level == view->u.tex.level && - surf->base.u.tex.first_layer <= view->u.tex.last_layer && - surf->base.u.tex.last_layer >= view->u.tex.first_layer) { - render_feedback = true; - break; - } - } + view = &(*img_handle)->view; + if (view->resource->target == PIPE_BUFFER) + continue; - if (render_feedback) - r600_texture_disable_dcc(&sctx->b, tex); + tex = (struct r600_texture *)view->resource; + + si_check_render_feedback_texture(sctx, tex, + view->u.tex.level, + view->u.tex.level, + view->u.tex.first_layer, + view->u.tex.last_layer); } } @@ -618,184 +721,92 @@ static void si_check_render_feedback(struct si_context *sctx) si_check_render_feedback_images(sctx, &sctx->images[i]); si_check_render_feedback_textures(sctx, &sctx->samplers[i]); } + + si_check_render_feedback_resident_images(sctx); + si_check_render_feedback_resident_textures(sctx); + sctx->need_check_render_feedback = false; } -static void si_decompress_textures(struct si_context *sctx, unsigned shader_mask) +static void si_decompress_resident_textures(struct si_context *sctx) { - unsigned compressed_colortex_counter, mask; + util_dynarray_foreach(&sctx->resident_tex_needs_color_decompress, + struct si_texture_handle *, tex_handle) { + struct pipe_sampler_view *view = (*tex_handle)->view; + struct r600_texture *tex = (struct r600_texture *)view->texture; - if (sctx->blitter->running) - return; - - /* Update the compressed_colortex_mask if necessary. */ - compressed_colortex_counter = p_atomic_read(&sctx->screen->b.compressed_colortex_counter); - if (compressed_colortex_counter != sctx->b.last_compressed_colortex_counter) { - sctx->b.last_compressed_colortex_counter = compressed_colortex_counter; - si_update_compressed_colortex_masks(sctx); + si_decompress_color_texture(sctx, tex, view->u.tex.first_level, + view->u.tex.last_level); } - /* Decompress color & depth textures if needed. */ - mask = sctx->compressed_tex_shader_mask & shader_mask; - while (mask) { - unsigned i = u_bit_scan(&mask); + util_dynarray_foreach(&sctx->resident_tex_needs_depth_decompress, + struct si_texture_handle *, tex_handle) { + struct pipe_sampler_view *view = (*tex_handle)->view; + struct si_sampler_view *sview = (struct si_sampler_view *)view; + struct r600_texture *tex = (struct r600_texture *)view->texture; - if (sctx->samplers[i].depth_texture_mask) { - si_flush_depth_textures(sctx, &sctx->samplers[i]); - } - if (sctx->samplers[i].compressed_colortex_mask) { - si_decompress_sampler_color_textures(sctx, &sctx->samplers[i]); - } - if (sctx->images[i].compressed_colortex_mask) { - si_decompress_image_color_textures(sctx, &sctx->images[i]); - } + si_decompress_depth(sctx, tex, + sview->is_stencil_sampler ? PIPE_MASK_S : PIPE_MASK_Z, + view->u.tex.first_level, view->u.tex.last_level, + 0, util_max_layer(&tex->resource.b.b, view->u.tex.first_level)); } - - si_check_render_feedback(sctx); } -void si_decompress_graphics_textures(struct si_context *sctx) +static void si_decompress_resident_images(struct si_context *sctx) { - si_decompress_textures(sctx, u_bit_consecutive(0, SI_NUM_GRAPHICS_SHADERS)); -} + util_dynarray_foreach(&sctx->resident_img_needs_color_decompress, + struct si_image_handle *, img_handle) { + struct pipe_image_view *view = &(*img_handle)->view; + struct r600_texture *tex = (struct r600_texture *)view->resource; -void si_decompress_compute_textures(struct si_context *sctx) -{ - si_decompress_textures(sctx, 1 << PIPE_SHADER_COMPUTE); + si_decompress_color_texture(sctx, tex, view->u.tex.level, + view->u.tex.level); + } } -static void si_clear(struct pipe_context *ctx, unsigned buffers, - const union pipe_color_union *color, - double depth, unsigned stencil) +void si_decompress_textures(struct si_context *sctx, unsigned shader_mask) { - struct si_context *sctx = (struct si_context *)ctx; - struct pipe_framebuffer_state *fb = &sctx->framebuffer.state; - struct pipe_surface *zsbuf = fb->zsbuf; - struct r600_texture *zstex = - zsbuf ? (struct r600_texture*)zsbuf->texture : NULL; - - if (buffers & PIPE_CLEAR_COLOR) { - evergreen_do_fast_color_clear(&sctx->b, fb, - &sctx->framebuffer.atom, &buffers, - &sctx->framebuffer.dirty_cbufs, - color); - if (!buffers) - return; /* all buffers have been fast cleared */ - } - - if (buffers & PIPE_CLEAR_COLOR) { - int i; - - /* These buffers cannot use fast clear, make sure to disable expansion. */ - for (i = 0; i < fb->nr_cbufs; i++) { - struct r600_texture *tex; - - /* If not clearing this buffer, skip. */ - if (!(buffers & (PIPE_CLEAR_COLOR0 << i))) - continue; + unsigned compressed_colortex_counter, mask; - if (!fb->cbufs[i]) - continue; + if (sctx->blitter->running) + return; - tex = (struct r600_texture *)fb->cbufs[i]->texture; - if (tex->fmask.size == 0) - tex->dirty_level_mask &= ~(1 << fb->cbufs[i]->u.tex.level); - } + /* Update the compressed_colortex_mask if necessary. */ + compressed_colortex_counter = p_atomic_read(&sctx->screen->compressed_colortex_counter); + if (compressed_colortex_counter != sctx->b.last_compressed_colortex_counter) { + sctx->b.last_compressed_colortex_counter = compressed_colortex_counter; + si_update_needs_color_decompress_masks(sctx); } - if (zstex && zstex->htile_buffer && - zsbuf->u.tex.level == 0 && - zsbuf->u.tex.first_layer == 0 && - zsbuf->u.tex.last_layer == util_max_layer(&zstex->resource.b.b, 0)) { - /* TC-compatible HTILE only supports depth clears to 0 or 1. */ - if (buffers & PIPE_CLEAR_DEPTH && - (!zstex->tc_compatible_htile || - depth == 0 || depth == 1)) { - /* Need to disable EXPCLEAR temporarily if clearing - * to a new value. */ - if (!zstex->depth_cleared || zstex->depth_clear_value != depth) { - sctx->db_depth_disable_expclear = true; - } + /* Decompress color & depth textures if needed. */ + mask = sctx->shader_needs_decompress_mask & shader_mask; + while (mask) { + unsigned i = u_bit_scan(&mask); - zstex->depth_clear_value = depth; - sctx->framebuffer.dirty_zsbuf = true; - si_mark_atom_dirty(sctx, &sctx->framebuffer.atom); /* updates DB_DEPTH_CLEAR */ - sctx->db_depth_clear = true; - si_mark_atom_dirty(sctx, &sctx->db_render_state); + if (sctx->samplers[i].needs_depth_decompress_mask) { + si_decompress_sampler_depth_textures(sctx, &sctx->samplers[i]); } - - /* TC-compatible HTILE only supports stencil clears to 0. */ - if (buffers & PIPE_CLEAR_STENCIL && - (!zstex->tc_compatible_htile || stencil == 0)) { - stencil &= 0xff; - - /* Need to disable EXPCLEAR temporarily if clearing - * to a new value. */ - if (!zstex->stencil_cleared || zstex->stencil_clear_value != stencil) { - sctx->db_stencil_disable_expclear = true; - } - - zstex->stencil_clear_value = stencil; - sctx->framebuffer.dirty_zsbuf = true; - si_mark_atom_dirty(sctx, &sctx->framebuffer.atom); /* updates DB_STENCIL_CLEAR */ - sctx->db_stencil_clear = true; - si_mark_atom_dirty(sctx, &sctx->db_render_state); + if (sctx->samplers[i].needs_color_decompress_mask) { + si_decompress_sampler_color_textures(sctx, &sctx->samplers[i]); + } + if (sctx->images[i].needs_color_decompress_mask) { + si_decompress_image_color_textures(sctx, &sctx->images[i]); } } - si_blitter_begin(ctx, SI_CLEAR); - util_blitter_clear(sctx->blitter, fb->width, fb->height, - util_framebuffer_get_num_layers(fb), - buffers, color, depth, stencil); - si_blitter_end(ctx); - - if (sctx->db_depth_clear) { - sctx->db_depth_clear = false; - sctx->db_depth_disable_expclear = false; - zstex->depth_cleared = true; - si_mark_atom_dirty(sctx, &sctx->db_render_state); - } - - if (sctx->db_stencil_clear) { - sctx->db_stencil_clear = false; - sctx->db_stencil_disable_expclear = false; - zstex->stencil_cleared = true; - si_mark_atom_dirty(sctx, &sctx->db_render_state); + if (shader_mask & u_bit_consecutive(0, SI_NUM_GRAPHICS_SHADERS)) { + if (sctx->uses_bindless_samplers) + si_decompress_resident_textures(sctx); + if (sctx->uses_bindless_images) + si_decompress_resident_images(sctx); + } else if (shader_mask & (1 << PIPE_SHADER_COMPUTE)) { + if (sctx->cs_shader_state.program->uses_bindless_samplers) + si_decompress_resident_textures(sctx); + if (sctx->cs_shader_state.program->uses_bindless_images) + si_decompress_resident_images(sctx); } -} - -static void si_clear_render_target(struct pipe_context *ctx, - struct pipe_surface *dst, - const union pipe_color_union *color, - unsigned dstx, unsigned dsty, - unsigned width, unsigned height, - bool render_condition_enabled) -{ - struct si_context *sctx = (struct si_context *)ctx; - si_blitter_begin(ctx, SI_CLEAR_SURFACE | - (render_condition_enabled ? 0 : SI_DISABLE_RENDER_COND)); - util_blitter_clear_render_target(sctx->blitter, dst, color, - dstx, dsty, width, height); - si_blitter_end(ctx); -} - -static void si_clear_depth_stencil(struct pipe_context *ctx, - struct pipe_surface *dst, - unsigned clear_flags, - double depth, - unsigned stencil, - unsigned dstx, unsigned dsty, - unsigned width, unsigned height, - bool render_condition_enabled) -{ - struct si_context *sctx = (struct si_context *)ctx; - - si_blitter_begin(ctx, SI_CLEAR_SURFACE | - (render_condition_enabled ? 0 : SI_DISABLE_RENDER_COND)); - util_blitter_clear_depth_stencil(sctx->blitter, dst, clear_flags, depth, stencil, - dstx, dsty, width, height); - si_blitter_end(ctx); + si_check_render_feedback(sctx); } /* Helper for decompressing a portion of a color or depth resource before @@ -813,13 +824,35 @@ static void si_decompress_subresource(struct pipe_context *ctx, if (rtex->db_compatible) { planes &= PIPE_MASK_Z | PIPE_MASK_S; - if (!(rtex->surface.flags & RADEON_SURF_SBUFFER)) + if (!rtex->surface.has_stencil) planes &= ~PIPE_MASK_S; - si_flush_depth_texture(sctx, rtex, planes, - level, level, - first_layer, last_layer); + /* If we've rendered into the framebuffer and it's a blitting + * source, make sure the decompression pass is invoked + * by dirtying the framebuffer. + */ + if (sctx->framebuffer.state.zsbuf && + sctx->framebuffer.state.zsbuf->u.tex.level == level && + sctx->framebuffer.state.zsbuf->texture == tex) + si_update_fb_dirtiness_after_rendering(sctx); + + si_decompress_depth(sctx, rtex, planes, + level, level, + first_layer, last_layer); } else if (rtex->fmask.size || rtex->cmask.size || rtex->dcc_offset) { + /* If we've rendered into the framebuffer and it's a blitting + * source, make sure the decompression pass is invoked + * by dirtying the framebuffer. + */ + for (unsigned i = 0; i < sctx->framebuffer.state.nr_cbufs; i++) { + if (sctx->framebuffer.state.cbufs[i] && + sctx->framebuffer.state.cbufs[i]->u.tex.level == level && + sctx->framebuffer.state.cbufs[i]->texture == tex) { + si_update_fb_dirtiness_after_rendering(sctx); + break; + } + } + si_blit_decompress_color(ctx, rtex, level, level, first_layer, last_layer, false); } @@ -872,7 +905,7 @@ void si_resource_copy_region(struct pipe_context *ctx, src_height0 = src->height0; util_blitter_default_dst_texture(&dst_templ, dst, dst_level, dstz); - util_blitter_default_src_texture(&src_templ, src, src_level); + util_blitter_default_src_texture(sctx->blitter, &src_templ, src, src_level); if (util_format_is_compressed(src->format) || util_format_is_compressed(dst->format)) { @@ -950,13 +983,50 @@ void si_resource_copy_region(struct pipe_context *ctx, } } + /* SNORM8 blitting has precision issues on some chips. Use the SINT + * equivalent instead, which doesn't force DCC decompression. + * Note that some chips avoid this issue by using SDMA. + */ + if (util_format_is_snorm8(dst_templ.format)) { + switch (dst_templ.format) { + case PIPE_FORMAT_R8_SNORM: + dst_templ.format = src_templ.format = PIPE_FORMAT_R8_SINT; + break; + case PIPE_FORMAT_R8G8_SNORM: + dst_templ.format = src_templ.format = PIPE_FORMAT_R8G8_SINT; + break; + case PIPE_FORMAT_R8G8B8X8_SNORM: + dst_templ.format = src_templ.format = PIPE_FORMAT_R8G8B8X8_SINT; + break; + case PIPE_FORMAT_R8G8B8A8_SNORM: + /* There are no SINT variants for ABGR and XBGR, so we have to use RGBA. */ + case PIPE_FORMAT_A8B8G8R8_SNORM: + case PIPE_FORMAT_X8B8G8R8_SNORM: + dst_templ.format = src_templ.format = PIPE_FORMAT_R8G8B8A8_SINT; + break; + case PIPE_FORMAT_A8_SNORM: + dst_templ.format = src_templ.format = PIPE_FORMAT_A8_SINT; + break; + case PIPE_FORMAT_L8_SNORM: + dst_templ.format = src_templ.format = PIPE_FORMAT_L8_SINT; + break; + case PIPE_FORMAT_L8A8_SNORM: + dst_templ.format = src_templ.format = PIPE_FORMAT_L8A8_SINT; + break; + case PIPE_FORMAT_I8_SNORM: + dst_templ.format = src_templ.format = PIPE_FORMAT_I8_SINT; + break; + default:; /* fall through */ + } + } + vi_disable_dcc_if_incompatible_format(&sctx->b, dst, dst_level, dst_templ.format); vi_disable_dcc_if_incompatible_format(&sctx->b, src, src_level, src_templ.format); /* Initialize the surface. */ - dst_view = r600_create_surface_custom(ctx, dst, &dst_templ, + dst_view = si_create_surface_custom(ctx, dst, &dst_templ, dst_width0, dst_height0, dst_width, dst_height); @@ -980,6 +1050,27 @@ void si_resource_copy_region(struct pipe_context *ctx, pipe_sampler_view_reference(&src_view, NULL); } +static void si_do_CB_resolve(struct si_context *sctx, + const struct pipe_blit_info *info, + struct pipe_resource *dst, + unsigned dst_level, unsigned dst_z, + enum pipe_format format) +{ + /* Required before and after CB_RESOLVE. */ + sctx->b.flags |= SI_CONTEXT_FLUSH_AND_INV_CB; + + si_blitter_begin(&sctx->b.b, SI_COLOR_RESOLVE | + (info->render_condition_enable ? 0 : SI_DISABLE_RENDER_COND)); + util_blitter_custom_resolve_color(sctx->blitter, dst, dst_level, dst_z, + info->src.resource, info->src.box.z, + ~0, sctx->custom_blend_resolve, + format); + si_blitter_end(&sctx->b.b); + + /* Flush caches for possible texturing. */ + si_make_CB_shader_coherent(sctx, 1, false); +} + static bool do_hardware_msaa_resolve(struct pipe_context *ctx, const struct pipe_blit_info *info) { @@ -990,7 +1081,6 @@ static bool do_hardware_msaa_resolve(struct pipe_context *ctx, unsigned dst_width = u_minify(info->dst.resource->width0, info->dst.level); unsigned dst_height = u_minify(info->dst.resource->height0, info->dst.level); enum pipe_format format = info->src.format; - unsigned sample_mask = ~0; struct pipe_resource *tmp, templ; struct pipe_blit_info blit; @@ -1051,21 +1141,14 @@ static bool do_hardware_msaa_resolve(struct pipe_context *ctx, info->dst.resource->last_level != 0) goto resolve_to_temp; - vi_dcc_clear_level(&sctx->b, dst, info->dst.level, + vi_dcc_clear_level(sctx, dst, info->dst.level, 0xFFFFFFFF); dst->dirty_level_mask &= ~(1 << info->dst.level); } /* Resolve directly from src to dst. */ - si_blitter_begin(ctx, SI_COLOR_RESOLVE | - (info->render_condition_enable ? 0 : SI_DISABLE_RENDER_COND)); - util_blitter_custom_resolve_color(sctx->blitter, - info->dst.resource, info->dst.level, - info->dst.box.z, - info->src.resource, info->src.box.z, - sample_mask, sctx->custom_blend_resolve, - format); - si_blitter_end(ctx); + si_do_CB_resolve(sctx, info, info->dst.resource, + info->dst.level, info->dst.box.z, format); return true; } @@ -1099,13 +1182,7 @@ resolve_to_temp: assert(src->surface.micro_tile_mode == rtmp->surface.micro_tile_mode); /* resolve */ - si_blitter_begin(ctx, SI_COLOR_RESOLVE | - (info->render_condition_enable ? 0 : SI_DISABLE_RENDER_COND)); - util_blitter_custom_resolve_color(sctx->blitter, tmp, 0, 0, - info->src.resource, info->src.box.z, - sample_mask, sctx->custom_blend_resolve, - format); - si_blitter_end(ctx); + si_do_CB_resolve(sctx, info, tmp, 0, 0, format); /* blit */ blit = *info; @@ -1163,7 +1240,7 @@ static void si_blit(struct pipe_context *ctx, info->src.box.z, info->src.box.z + info->src.box.depth - 1); - if (sctx->screen->b.debug_flags & DBG_FORCE_DMA && + if (sctx->screen->debug_flags & DBG(FORCE_DMA) && util_try_blit_via_copy_region(ctx, info)) return; @@ -1197,11 +1274,15 @@ static boolean si_generate_mipmap(struct pipe_context *ctx, rtex->dirty_level_mask &= ~u_bit_consecutive(base_level + 1, last_level - base_level); + sctx->generate_mipmap_for_depth = rtex->is_depth; + si_blitter_begin(ctx, SI_BLIT | SI_DISABLE_RENDER_COND); util_blitter_generate_mipmap(sctx->blitter, tex, format, base_level, last_level, first_layer, last_layer); si_blitter_end(ctx); + + sctx->generate_mipmap_for_depth = false; return true; } @@ -1242,72 +1323,8 @@ static void si_decompress_dcc(struct pipe_context *ctx, true); } -static void si_pipe_clear_buffer(struct pipe_context *ctx, - struct pipe_resource *dst, - unsigned offset, unsigned size, - const void *clear_value_ptr, - int clear_value_size) -{ - struct si_context *sctx = (struct si_context*)ctx; - uint32_t dword_value; - unsigned i; - - assert(offset % clear_value_size == 0); - assert(size % clear_value_size == 0); - - if (clear_value_size > 4) { - const uint32_t *u32 = clear_value_ptr; - bool clear_dword_duplicated = true; - - /* See if we can lower large fills to dword fills. */ - for (i = 1; i < clear_value_size / 4; i++) - if (u32[0] != u32[i]) { - clear_dword_duplicated = false; - break; - } - - if (!clear_dword_duplicated) { - /* Use transform feedback for 64-bit, 96-bit, and - * 128-bit fills. - */ - union pipe_color_union clear_value; - - memcpy(&clear_value, clear_value_ptr, clear_value_size); - si_blitter_begin(ctx, SI_DISABLE_RENDER_COND); - util_blitter_clear_buffer(sctx->blitter, dst, offset, - size, clear_value_size / 4, - &clear_value); - si_blitter_end(ctx); - return; - } - } - - /* Expand the clear value to a dword. */ - switch (clear_value_size) { - case 1: - dword_value = *(uint8_t*)clear_value_ptr; - dword_value |= (dword_value << 8) | - (dword_value << 16) | - (dword_value << 24); - break; - case 2: - dword_value = *(uint16_t*)clear_value_ptr; - dword_value |= dword_value << 16; - break; - default: - dword_value = *(uint32_t*)clear_value_ptr; - } - - sctx->b.clear_buffer(ctx, dst, offset, size, dword_value, - R600_COHERENCY_SHADER); -} - void si_init_blit_functions(struct si_context *sctx) { - sctx->b.b.clear = si_clear; - sctx->b.b.clear_buffer = si_pipe_clear_buffer; - sctx->b.b.clear_render_target = si_clear_render_target; - sctx->b.b.clear_depth_stencil = si_clear_depth_stencil; sctx->b.b.resource_copy_region = si_resource_copy_region; sctx->b.b.blit = si_blit; sctx->b.b.flush_resource = si_flush_resource;