X-Git-Url: https://git.libre-soc.org/?a=blobdiff_plain;f=src%2Fglx%2Fdrisw_glx.c;h=641917361b870888fb9f7cf712ff6c41f63ad9de;hb=bcd80be49a8260c2233dd07b2048d459a91a9c91;hp=21d0a0a9c8f1373b78bba8c35c4a321a3e44acb1;hpb=55e763c86da1aa2042d50d190d797574d6fb6fa8;p=mesa.git diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c index 21d0a0a9c8f..641917361b8 100644 --- a/src/glx/drisw_glx.c +++ b/src/glx/drisw_glx.c @@ -27,49 +27,13 @@ #include "glxclient.h" #include #include "dri_common.h" - -struct drisw_display -{ - __GLXDRIdisplay base; -}; - -struct drisw_context -{ - struct glx_context base; - __DRIcontext *driContext; - -}; - -struct drisw_screen -{ - struct glx_screen base; - - __DRIscreen *driScreen; - __GLXDRIscreen vtable; - const __DRIcoreExtension *core; - const __DRIswrastExtension *swrast; - const __DRItexBufferExtension *texBuffer; - - const __DRIconfig **driver_configs; - - void *driver; -}; - -struct drisw_drawable -{ - __GLXDRIdrawable base; - - GC gc; - GC swapgc; - - __DRIdrawable *driDrawable; - XVisualInfo *visinfo; - XImage *ximage; -}; +#include "drisw_priv.h" +#include +#include static Bool -XCreateDrawable(struct drisw_drawable * pdp, - Display * dpy, XID drawable, int visualid) +XCreateGCs(struct drisw_drawable * pdp, + Display * dpy, XID drawable, int visualid) { XGCValues gcvalues; long visMask; @@ -87,20 +51,85 @@ XCreateDrawable(struct drisw_drawable * pdp, XChangeGC(dpy, pdp->swapgc, GCGraphicsExposures, &gcvalues); /* visual */ - visTemp.screen = DefaultScreen(dpy); visTemp.visualid = visualid; - visMask = (VisualScreenMask | VisualIDMask); + visMask = VisualIDMask; pdp->visinfo = XGetVisualInfo(dpy, visMask, &visTemp, &num_visuals); - /* create XImage */ - pdp->ximage = XCreateImage(dpy, - pdp->visinfo->visual, - pdp->visinfo->depth, - ZPixmap, 0, /* format, offset */ - NULL, /* data */ - 0, 0, /* width, height */ - 32, /* bitmap_pad */ - 0); /* bytes_per_line */ + if (!pdp->visinfo || num_visuals == 0) + return False; + + return True; +} + +static int xshm_error = 0; +static int xshm_opcode = -1; + +/** + * Catches potential Xlib errors. + */ +static int +handle_xerror(Display *dpy, XErrorEvent *event) +{ + (void) dpy; + + assert(xshm_opcode != -1); + if (event->request_code != xshm_opcode || + event->minor_code != X_ShmAttach) + return 0; + + xshm_error = 1; + return 0; +} + +static Bool +XCreateDrawable(struct drisw_drawable * pdp, int shmid, Display * dpy) +{ + if (pdp->ximage) { + XDestroyImage(pdp->ximage); + pdp->ximage = NULL; + } + + if (!xshm_error && shmid >= 0) { + pdp->shminfo.shmid = shmid; + pdp->ximage = XShmCreateImage(dpy, + pdp->visinfo->visual, + pdp->visinfo->depth, + ZPixmap, /* format */ + NULL, /* data */ + &pdp->shminfo, /* shminfo */ + 0, 0); /* width, height */ + if (pdp->ximage != NULL) { + int (*old_handler)(Display *, XErrorEvent *); + + /* dispatch pending errors */ + XSync(dpy, False); + + old_handler = XSetErrorHandler(handle_xerror); + /* This may trigger the X protocol error we're ready to catch: */ + XShmAttach(dpy, &pdp->shminfo); + XSync(dpy, False); + + if (xshm_error) { + /* we are on a remote display, this error is normal, don't print it */ + XDestroyImage(pdp->ximage); + pdp->ximage = NULL; + } + + (void) XSetErrorHandler(old_handler); + } + } + + if (pdp->ximage == NULL) { + pdp->shminfo.shmid = -1; + pdp->ximage = XCreateImage(dpy, + pdp->visinfo->visual, + pdp->visinfo->depth, + ZPixmap, 0, /* format, offset */ + NULL, /* data */ + 0, 0, /* width, height */ + 32, /* bitmap_pad */ + 0); /* bytes_per_line */ + } /** * swrast does not handle 24-bit depth with 24 bpp, so let X do the @@ -115,8 +144,10 @@ XCreateDrawable(struct drisw_drawable * pdp, static void XDestroyDrawable(struct drisw_drawable * pdp, Display * dpy, XID drawable) { - XDestroyImage(pdp->ximage); - XFree(pdp->visinfo); + if (pdp->ximage) + XDestroyImage(pdp->ximage); + + free(pdp->visinfo); XFreeGC(dpy, pdp->gc); XFreeGC(dpy, pdp->swapgc); @@ -169,9 +200,9 @@ bytes_per_line(unsigned pitch_bits, unsigned mul) } static void -swrastPutImage(__DRIdrawable * draw, int op, - int x, int y, int w, int h, - char *data, void *loaderPrivate) +swrastXPutImage(__DRIdrawable * draw, int op, + int x, int y, int w, int h, int stride, + int shmid, char *data, void *loaderPrivate) { struct drisw_drawable *pdp = loaderPrivate; __GLXDRIdrawable *pdraw = &(pdp->base); @@ -180,6 +211,11 @@ swrastPutImage(__DRIdrawable * draw, int op, XImage *ximage; GC gc; + if (!pdp->ximage || shmid != pdp->shminfo.shmid) { + if (!XCreateDrawable(pdp, shmid, dpy)) + return; + } + switch (op) { case __DRI_SWRAST_IMAGE_OP_DRAW: gc = pdp->gc; @@ -192,22 +228,58 @@ swrastPutImage(__DRIdrawable * draw, int op, } drawable = pdraw->xDrawable; - ximage = pdp->ximage; + ximage->bytes_per_line = stride ? stride : bytes_per_line(w * ximage->bits_per_pixel, 32); ximage->data = data; - ximage->width = w; - ximage->height = h; - ximage->bytes_per_line = bytes_per_line(w * ximage->bits_per_pixel, 32); - - XPutImage(dpy, drawable, gc, ximage, 0, 0, x, y, w, h); + if (pdp->shminfo.shmid >= 0) { + ximage->width = ximage->bytes_per_line / ((ximage->bits_per_pixel + 7)/ 8); + ximage->height = h; + XShmPutImage(dpy, drawable, gc, ximage, 0, 0, x, y, w, h, False); + XSync(dpy, False); + } else { + ximage->width = w; + ximage->height = h; + XPutImage(dpy, drawable, gc, ximage, 0, 0, x, y, w, h); + } ximage->data = NULL; } static void -swrastGetImage(__DRIdrawable * read, +swrastPutImageShm(__DRIdrawable * draw, int op, + int x, int y, int w, int h, int stride, + int shmid, char *shmaddr, unsigned offset, + void *loaderPrivate) +{ + struct drisw_drawable *pdp = loaderPrivate; + + pdp->shminfo.shmaddr = shmaddr; + swrastXPutImage(draw, op, x, y, w, h, stride, shmid, + shmaddr + offset, loaderPrivate); +} + +static void +swrastPutImage2(__DRIdrawable * draw, int op, + int x, int y, int w, int h, int stride, + char *data, void *loaderPrivate) +{ + swrastXPutImage(draw, op, x, y, w, h, stride, -1, + data, loaderPrivate); +} + +static void +swrastPutImage(__DRIdrawable * draw, int op, int x, int y, int w, int h, char *data, void *loaderPrivate) +{ + swrastXPutImage(draw, op, x, y, w, h, 0, -1, + data, loaderPrivate); +} + +static void +swrastGetImage2(__DRIdrawable * read, + int x, int y, int w, int h, int stride, + char *data, void *loaderPrivate) { struct drisw_drawable *prp = loaderPrivate; __GLXDRIdrawable *pread = &(prp->base); @@ -215,28 +287,44 @@ swrastGetImage(__DRIdrawable * read, Drawable readable; XImage *ximage; + if (!prp->ximage || prp->shminfo.shmid >= 0) { + if (!XCreateDrawable(prp, -1, dpy)) + return; + } + readable = pread->xDrawable; ximage = prp->ximage; ximage->data = data; ximage->width = w; ximage->height = h; - ximage->bytes_per_line = bytes_per_line(w * ximage->bits_per_pixel, 32); + ximage->bytes_per_line = stride ? stride : bytes_per_line(w * ximage->bits_per_pixel, 32); XGetSubImage(dpy, readable, x, y, w, h, ~0L, ZPixmap, ximage, 0, 0); ximage->data = NULL; } -static const __DRIswrastLoaderExtension swrastLoaderExtension = { - {__DRI_SWRAST_LOADER, __DRI_SWRAST_LOADER_VERSION}, - swrastGetDrawableInfo, - swrastPutImage, - swrastGetImage +static void +swrastGetImage(__DRIdrawable * read, + int x, int y, int w, int h, + char *data, void *loaderPrivate) +{ + swrastGetImage2(read, x, y, w, h, 0, data, loaderPrivate); +} + +static __DRIswrastLoaderExtension swrastLoaderExtension = { + .base = {__DRI_SWRAST_LOADER, 4 }, + + .getDrawableInfo = swrastGetDrawableInfo, + .putImage = swrastPutImage, + .getImage = swrastGetImage, + .putImage2 = swrastPutImage2, + .getImage2 = swrastGetImage2, + .putImageShm = swrastPutImageShm, }; static const __DRIextension *loader_extensions[] = { - &systemTimeExtension.base, &swrastLoaderExtension.base, NULL }; @@ -253,15 +341,11 @@ drisw_destroy_context(struct glx_context *context) driReleaseDrawables(&pcp->base); - if (context->xid) - glx_send_destroy_context(psc->base.dpy, context->xid); - - if (context->extensions) - XFree((char *) context->extensions); + free((char *) context->extensions); (*psc->core->destroyContext) (pcp->driContext); - Xfree(pcp); + free(pcp); } static int @@ -277,11 +361,9 @@ drisw_bind_context(struct glx_context *context, struct glx_context *old, driReleaseDrawables(&pcp->base); - if (pdraw == NULL || pread == NULL) - return GLXBadDrawable; - if ((*psc->core->bindContext) (pcp->driContext, - pdraw->driDrawable, pread->driDrawable)) + pdraw ? pdraw->driDrawable : NULL, + pread ? pread->driDrawable : NULL)) return Success; return GLXBadContext; @@ -304,10 +386,11 @@ drisw_bind_tex_image(Display * dpy, struct glx_context *gc = __glXGetCurrentContext(); struct drisw_context *pcp = (struct drisw_context *) gc; __GLXDRIdrawable *base = GetGLXDRIDrawable(dpy, drawable); - struct glx_display *dpyPriv = __glXInitialize(dpy); struct drisw_drawable *pdraw = (struct drisw_drawable *) base; struct drisw_screen *psc; + __glXInitialize(dpy); + if (pdraw != NULL) { psc = (struct drisw_screen *) base->psc; @@ -332,16 +415,15 @@ drisw_bind_tex_image(Display * dpy, static void drisw_release_tex_image(Display * dpy, GLXDrawable drawable, int buffer) { -#if __DRI_TEX_BUFFER_VERSION >= 3 struct glx_context *gc = __glXGetCurrentContext(); - struct dri2_context *pcp = (struct dri2_context *) gc; + struct drisw_context *pcp = (struct drisw_context *) gc; __GLXDRIdrawable *base = GetGLXDRIDrawable(dpy, drawable); struct glx_display *dpyPriv = __glXInitialize(dpy); - struct dri2_drawable *pdraw = (struct dri2_drawable *) base; - struct dri2_screen *psc; + struct drisw_drawable *pdraw = (struct drisw_drawable *) base; + struct drisw_screen *psc; - if (pdraw != NULL) { - psc = (struct dri2_screen *) base->psc; + if (dpyPriv != NULL && pdraw != NULL) { + psc = (struct drisw_screen *) base->psc; if (!psc->texBuffer) return; @@ -353,19 +435,18 @@ drisw_release_tex_image(Display * dpy, GLXDrawable drawable, int buffer) pdraw->driDrawable); } } -#endif } static const struct glx_context_vtable drisw_context_vtable = { - drisw_destroy_context, - drisw_bind_context, - drisw_unbind_context, - NULL, - NULL, - DRI_glXUseXFont, - drisw_bind_tex_image, - drisw_release_tex_image, - NULL, /* get_proc_address */ + .destroy = drisw_destroy_context, + .bind = drisw_bind_context, + .unbind = drisw_unbind_context, + .wait_gl = NULL, + .wait_x = NULL, + .use_x_font = DRI_glXUseXFont, + .bind_tex_image = drisw_bind_tex_image, + .release_tex_image = drisw_release_tex_image, + .get_proc_address = NULL, }; static struct glx_context * @@ -381,26 +462,139 @@ drisw_create_context(struct glx_screen *base, if (!psc->base.driScreen) return NULL; + /* Check the renderType value */ + if (!validate_renderType_against_config(config_base, renderType)) + return NULL; + if (shareList) { + /* If the shareList context is not a DRISW context, we cannot possibly + * create a DRISW context that shares it. + */ + if (shareList->vtable->destroy != drisw_destroy_context) { + return NULL; + } + pcp_shared = (struct drisw_context *) shareList; shared = pcp_shared->driContext; } - pcp = Xmalloc(sizeof *pcp); + pcp = calloc(1, sizeof *pcp); if (pcp == NULL) return NULL; - memset(pcp, 0, sizeof *pcp); if (!glx_context_init(&pcp->base, &psc->base, &config->base)) { - Xfree(pcp); + free(pcp); return NULL; } + pcp->base.renderType = renderType; + pcp->driContext = (*psc->core->createNewContext) (psc->driScreen, config->driConfig, shared, pcp); if (pcp->driContext == NULL) { - Xfree(pcp); + free(pcp); + return NULL; + } + + pcp->base.vtable = &drisw_context_vtable; + + return &pcp->base; +} + +static struct glx_context * +drisw_create_context_attribs(struct glx_screen *base, + struct glx_config *config_base, + struct glx_context *shareList, + unsigned num_attribs, + const uint32_t *attribs, + unsigned *error) +{ + struct drisw_context *pcp, *pcp_shared; + __GLXDRIconfigPrivate *config = (__GLXDRIconfigPrivate *) config_base; + struct drisw_screen *psc = (struct drisw_screen *) base; + __DRIcontext *shared = NULL; + + uint32_t minor_ver; + uint32_t major_ver; + uint32_t renderType; + uint32_t flags; + unsigned api; + int reset; + int release; + uint32_t ctx_attribs[2 * 5]; + unsigned num_ctx_attribs = 0; + + if (!psc->base.driScreen) + return NULL; + + if (psc->swrast->base.version < 3) + return NULL; + + /* Remap the GLX tokens to DRI2 tokens. + */ + if (!dri2_convert_glx_attribs(num_attribs, attribs, + &major_ver, &minor_ver, &renderType, &flags, + &api, &reset, &release, error)) + return NULL; + + /* Check the renderType value */ + if (!validate_renderType_against_config(config_base, renderType)) { + return NULL; + } + + if (reset != __DRI_CTX_RESET_NO_NOTIFICATION) + return NULL; + + if (release != __DRI_CTX_RELEASE_BEHAVIOR_FLUSH && + release != __DRI_CTX_RELEASE_BEHAVIOR_NONE) + return NULL; + + if (shareList) { + pcp_shared = (struct drisw_context *) shareList; + shared = pcp_shared->driContext; + } + + pcp = calloc(1, sizeof *pcp); + if (pcp == NULL) + return NULL; + + if (!glx_context_init(&pcp->base, &psc->base, config_base)) { + free(pcp); + return NULL; + } + + ctx_attribs[num_ctx_attribs++] = __DRI_CTX_ATTRIB_MAJOR_VERSION; + ctx_attribs[num_ctx_attribs++] = major_ver; + ctx_attribs[num_ctx_attribs++] = __DRI_CTX_ATTRIB_MINOR_VERSION; + ctx_attribs[num_ctx_attribs++] = minor_ver; + if (release != __DRI_CTX_RELEASE_BEHAVIOR_FLUSH) { + ctx_attribs[num_ctx_attribs++] = __DRI_CTX_ATTRIB_RELEASE_BEHAVIOR; + ctx_attribs[num_ctx_attribs++] = release; + } + + if (flags != 0) { + ctx_attribs[num_ctx_attribs++] = __DRI_CTX_ATTRIB_FLAGS; + + /* The current __DRI_CTX_FLAG_* values are identical to the + * GLX_CONTEXT_*_BIT values. + */ + ctx_attribs[num_ctx_attribs++] = flags; + } + + pcp->base.renderType = renderType; + + pcp->driContext = + (*psc->swrast->createContextAttribs) (psc->driScreen, + api, + config ? config->driConfig : 0, + shared, + num_ctx_attribs / 2, + ctx_attribs, + error, + pcp); + if (pcp->driContext == NULL) { + free(pcp); return NULL; } @@ -418,7 +612,7 @@ driswDestroyDrawable(__GLXDRIdrawable * pdraw) (*psc->core->destroyDrawable) (pdp->driDrawable); XDestroyDrawable(pdp, pdraw->psc->dpy, pdraw->drawable); - Xfree(pdp); + free(pdp); } static __GLXDRIdrawable * @@ -428,19 +622,22 @@ driswCreateDrawable(struct glx_screen *base, XID xDrawable, struct drisw_drawable *pdp; __GLXDRIconfigPrivate *config = (__GLXDRIconfigPrivate *) modes; struct drisw_screen *psc = (struct drisw_screen *) base; - + Bool ret; const __DRIswrastExtension *swrast = psc->swrast; - pdp = Xmalloc(sizeof(*pdp)); + pdp = calloc(1, sizeof(*pdp)); if (!pdp) return NULL; - memset(pdp, 0, sizeof *pdp); pdp->base.xDrawable = xDrawable; pdp->base.drawable = drawable; pdp->base.psc = &psc->base; - XCreateDrawable(pdp, psc->base.dpy, xDrawable, modes->visualID); + ret = XCreateGCs(pdp, psc->base.dpy, xDrawable, modes->visualID); + if (!ret) { + free(pdp); + return NULL; + } /* Create a new drawable */ pdp->driDrawable = @@ -448,7 +645,7 @@ driswCreateDrawable(struct glx_screen *base, XID xDrawable, if (!pdp->driDrawable) { XDestroyDrawable(pdp, psc->base.dpy, xDrawable); - Xfree(pdp); + free(pdp); return NULL; } @@ -459,7 +656,8 @@ driswCreateDrawable(struct glx_screen *base, XID xDrawable, static int64_t driswSwapBuffers(__GLXDRIdrawable * pdraw, - int64_t target_msc, int64_t divisor, int64_t remainder) + int64_t target_msc, int64_t divisor, int64_t remainder, + Bool flush) { struct drisw_drawable *pdp = (struct drisw_drawable *) pdraw; struct drisw_screen *psc = (struct drisw_screen *) pdp->base.psc; @@ -468,11 +666,30 @@ driswSwapBuffers(__GLXDRIdrawable * pdraw, (void) divisor; (void) remainder; + if (flush) { + glFlush(); + } + (*psc->core->swapBuffers) (pdp->driDrawable); return 0; } +static void +driswCopySubBuffer(__GLXDRIdrawable * pdraw, + int x, int y, int width, int height, Bool flush) +{ + struct drisw_drawable *pdp = (struct drisw_drawable *) pdraw; + struct drisw_screen *psc = (struct drisw_screen *) pdp->base.psc; + + if (flush) { + glFlush(); + } + + (*psc->copySubBuffer->copySubBuffer) (pdp->driDrawable, + x, y, width, height); +} + static void driswDestroyScreen(struct glx_screen *base) { @@ -484,21 +701,27 @@ driswDestroyScreen(struct glx_screen *base) psc->driScreen = NULL; if (psc->driver) dlclose(psc->driver); + free(psc); } +#define SWRAST_DRIVER_NAME "swrast" + static void * driOpenSwrast(void) { void *driver = NULL; if (driver == NULL) - driver = driOpenDriver("swrast"); + driver = driOpenDriver(SWRAST_DRIVER_NAME); return driver; } static const struct glx_screen_vtable drisw_screen_vtable = { - drisw_create_context + .create_context = drisw_create_context, + .create_context_attribs = drisw_create_context_attribs, + .query_renderer_integer = drisw_query_renderer_integer, + .query_renderer_string = drisw_query_renderer_string, }; static void @@ -506,15 +729,52 @@ driswBindExtensions(struct drisw_screen *psc, const __DRIextension **extensions) { int i; + __glXEnableDirectExtension(&psc->base, "GLX_SGI_make_current_read"); + + if (psc->swrast->base.version >= 3) { + __glXEnableDirectExtension(&psc->base, "GLX_ARB_create_context"); + __glXEnableDirectExtension(&psc->base, "GLX_ARB_create_context_profile"); + + /* DRISW version >= 2 implies support for OpenGL ES. + */ + __glXEnableDirectExtension(&psc->base, + "GLX_EXT_create_context_es_profile"); + __glXEnableDirectExtension(&psc->base, + "GLX_EXT_create_context_es2_profile"); + } + + if (psc->copySubBuffer) + __glXEnableDirectExtension(&psc->base, "GLX_MESA_copy_sub_buffer"); + /* FIXME: Figure out what other extensions can be ported here from dri2. */ for (i = 0; extensions[i]; i++) { if ((strcmp(extensions[i]->name, __DRI_TEX_BUFFER) == 0)) { psc->texBuffer = (__DRItexBufferExtension *) extensions[i]; __glXEnableDirectExtension(&psc->base, "GLX_EXT_texture_from_pixmap"); } + /* DRISW version 3 is also required because GLX_MESA_query_renderer + * requires GLX_ARB_create_context_profile. + */ + if (psc->swrast->base.version >= 3 + && strcmp(extensions[i]->name, __DRI2_RENDERER_QUERY) == 0) { + psc->rendererQuery = (__DRI2rendererQueryExtension *) extensions[i]; + __glXEnableDirectExtension(&psc->base, "GLX_MESA_query_renderer"); + } + if (strcmp(extensions[i]->name, __DRI2_FLUSH_CONTROL) == 0) { + __glXEnableDirectExtension(&psc->base, + "GLX_ARB_context_flush_control"); + } } } +static int +check_xshm(Display *dpy) +{ + int ignore; + + return XQueryExtension(dpy, "MIT-SHM", &xshm_opcode, &ignore, &ignore); +} + static struct glx_screen * driswCreateScreen(int screen, struct glx_display *priv) { @@ -522,15 +782,15 @@ driswCreateScreen(int screen, struct glx_display *priv) const __DRIconfig **driver_configs; const __DRIextension **extensions; struct drisw_screen *psc; + struct glx_config *configs = NULL, *visuals = NULL; int i; - psc = Xcalloc(1, sizeof *psc); + psc = calloc(1, sizeof *psc); if (psc == NULL) return NULL; - memset(psc, 0, sizeof *psc); if (!glx_screen_init(&psc->base, screen, priv)) { - Xfree(psc); + free(psc); return NULL; } @@ -538,17 +798,20 @@ driswCreateScreen(int screen, struct glx_display *priv) if (psc->driver == NULL) goto handle_error; - extensions = dlsym(psc->driver, __DRI_DRIVER_EXTENSIONS); - if (extensions == NULL) { - ErrorMessageF("driver exports no extensions (%s)\n", dlerror()); + extensions = driGetDriverExtensions(psc->driver, SWRAST_DRIVER_NAME); + if (extensions == NULL) goto handle_error; - } + + if (!check_xshm(psc->base.dpy)) + swrastLoaderExtension.putImageShm = NULL; for (i = 0; extensions[i]; i++) { if (strcmp(extensions[i]->name, __DRI_CORE) == 0) psc->core = (__DRIcoreExtension *) extensions[i]; if (strcmp(extensions[i]->name, __DRI_SWRAST) == 0) psc->swrast = (__DRIswrastExtension *) extensions[i]; + if (strcmp(extensions[i]->name, __DRI_COPY_SUB_BUFFER) == 0) + psc->copySubBuffer = (__DRIcopySubBufferExtension *) extensions[i]; } if (psc->core == NULL || psc->swrast == NULL) { @@ -556,9 +819,16 @@ driswCreateScreen(int screen, struct glx_display *priv) goto handle_error; } - psc->driScreen = - psc->swrast->createNewScreen(screen, loader_extensions, - &driver_configs, psc); + if (psc->swrast->base.version >= 4) { + psc->driScreen = + psc->swrast->createNewScreen2(screen, loader_extensions, + extensions, + &driver_configs, psc); + } else { + psc->driScreen = + psc->swrast->createNewScreen(screen, loader_extensions, + &driver_configs, psc); + } if (psc->driScreen == NULL) { ErrorMessageF("failed to create dri screen\n"); goto handle_error; @@ -567,10 +837,18 @@ driswCreateScreen(int screen, struct glx_display *priv) extensions = psc->core->getExtensions(psc->driScreen); driswBindExtensions(psc, extensions); - psc->base.configs = - driConvertConfigs(psc->core, psc->base.configs, driver_configs); - psc->base.visuals = - driConvertConfigs(psc->core, psc->base.visuals, driver_configs); + configs = driConvertConfigs(psc->core, psc->base.configs, driver_configs); + visuals = driConvertConfigs(psc->core, psc->base.visuals, driver_configs); + + if (!configs || !visuals) { + ErrorMessageF("No matching fbConfigs or visuals found\n"); + goto handle_error; + } + + glx_config_destroy_list(psc->base.configs); + psc->base.configs = configs; + glx_config_destroy_list(psc->base.visuals); + psc->base.visuals = visuals; psc->driver_configs = driver_configs; @@ -581,15 +859,26 @@ driswCreateScreen(int screen, struct glx_display *priv) psp->createDrawable = driswCreateDrawable; psp->swapBuffers = driswSwapBuffers; + if (psc->copySubBuffer) + psp->copySubBuffer = driswCopySubBuffer; + return &psc->base; handle_error: + if (configs) + glx_config_destroy_list(configs); + if (visuals) + glx_config_destroy_list(visuals); + if (psc->driScreen) + psc->core->destroyScreen(psc->driScreen); + psc->driScreen = NULL; + if (psc->driver) dlclose(psc->driver); glx_screen_cleanup(&psc->base); - Xfree(psc); + free(psc); - ErrorMessageF("reverting to indirect rendering\n"); + CriticalErrorMessageF("failed to load driver: %s\n", SWRAST_DRIVER_NAME); return NULL; } @@ -599,7 +888,7 @@ driswCreateScreen(int screen, struct glx_display *priv) static void driswDestroyDisplay(__GLXDRIdisplay * dpy) { - Xfree(dpy); + free(dpy); } /* @@ -612,7 +901,7 @@ driswCreateDisplay(Display * dpy) { struct drisw_display *pdpyp; - pdpyp = Xmalloc(sizeof *pdpyp); + pdpyp = malloc(sizeof *pdpyp); if (pdpyp == NULL) return NULL;