X-Git-Url: https://git.libre-soc.org/?a=blobdiff_plain;f=src%2Futil%2Fu_dynarray.h;h=000feaa834939e9baa958dc4240d2d67c28f4fcd;hb=7fbadfc385c359fd291d58a75fbe6ce3fdc91747;hp=6bea481d44bfe591a9902b7a8b2fd93c93ca2616;hpb=7f8ecedced0e65b40850c5c450fd8c3a1f2f90d1;p=mesa.git diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h index 6bea481d44b..000feaa8349 100644 --- a/src/util/u_dynarray.h +++ b/src/util/u_dynarray.h @@ -29,6 +29,7 @@ #include #include +#include #include "ralloc.h" #ifdef __cplusplus @@ -77,26 +78,40 @@ util_dynarray_clear(struct util_dynarray *buf) #define DYN_ARRAY_INITIAL_SIZE 64 -/* use util_dynarray_trim to reduce the allocated storage */ -static inline void * -util_dynarray_resize(struct util_dynarray *buf, unsigned newsize) +MUST_CHECK static inline void * +util_dynarray_ensure_cap(struct util_dynarray *buf, unsigned newcap) { - void *p; - if (newsize > buf->capacity) { - if (buf->capacity == 0) - buf->capacity = DYN_ARRAY_INITIAL_SIZE; - - while (newsize > buf->capacity) - buf->capacity *= 2; + if (newcap > buf->capacity) { + unsigned capacity = MAX3(DYN_ARRAY_INITIAL_SIZE, buf->capacity * 2, newcap); + void *data; if (buf->mem_ctx) { - buf->data = reralloc_size(buf->mem_ctx, buf->data, buf->capacity); + data = reralloc_size(buf->mem_ctx, buf->data, capacity); } else { - buf->data = realloc(buf->data, buf->capacity); + data = realloc(buf->data, capacity); } + if (!data) + return 0; + + buf->data = data; + buf->capacity = capacity; } - p = (void *)((char *)buf->data + buf->size); + return (void *)((char *)buf->data + buf->size); +} + +/* use util_dynarray_trim to reduce the allocated storage */ +MUST_CHECK static inline void * +util_dynarray_resize_bytes(struct util_dynarray *buf, unsigned nelts, size_t eltsize) +{ + if (unlikely(nelts > UINT_MAX / eltsize)) + return 0; + + unsigned newsize = nelts * eltsize; + void *p = util_dynarray_ensure_cap(buf, newsize); + if (!p) + return 0; + buf->size = newsize; return p; @@ -107,14 +122,27 @@ util_dynarray_clone(struct util_dynarray *buf, void *mem_ctx, struct util_dynarray *from_buf) { util_dynarray_init(buf, mem_ctx); - util_dynarray_resize(buf, from_buf->size); - memcpy(buf->data, from_buf->data, from_buf->size); + if (util_dynarray_resize_bytes(buf, from_buf->size, 1)) + memcpy(buf->data, from_buf->data, from_buf->size); } -static inline void * -util_dynarray_grow(struct util_dynarray *buf, int diff) +MUST_CHECK static inline void * +util_dynarray_grow_bytes(struct util_dynarray *buf, unsigned ngrow, size_t eltsize) { - return util_dynarray_resize(buf, buf->size + diff); + unsigned growbytes = ngrow * eltsize; + + if (unlikely(ngrow > (UINT_MAX / eltsize) || + growbytes > UINT_MAX - buf->size)) + return 0; + + unsigned newsize = buf->size + growbytes; + void *p = util_dynarray_ensure_cap(buf, newsize); + if (!p) + return 0; + + buf->size = newsize; + + return p; } static inline void @@ -134,13 +162,16 @@ util_dynarray_trim(struct util_dynarray *buf) } else { free(buf->data); } - buf->data = 0; + buf->data = NULL; buf->capacity = 0; } } } -#define util_dynarray_append(buf, type, v) do {type __v = (v); memcpy(util_dynarray_grow((buf), sizeof(type)), &__v, sizeof(type));} while(0) +#define util_dynarray_append(buf, type, v) do {type __v = (v); memcpy(util_dynarray_grow_bytes((buf), 1, sizeof(type)), &__v, sizeof(type));} while(0) +/* Returns a pointer to the space of the first new element (in case of growth) or NULL on failure. */ +#define util_dynarray_resize(buf, type, nelts) util_dynarray_resize_bytes(buf, (nelts), sizeof(type)) +#define util_dynarray_grow(buf, type, ngrow) util_dynarray_grow_bytes(buf, (ngrow), sizeof(type)) #define util_dynarray_top_ptr(buf, type) (type*)((char*)(buf)->data + (buf)->size - sizeof(type)) #define util_dynarray_top(buf, type) *util_dynarray_top_ptr(buf, type) #define util_dynarray_pop_ptr(buf, type) (type*)((char*)(buf)->data + ((buf)->size -= sizeof(type))) @@ -149,11 +180,18 @@ util_dynarray_trim(struct util_dynarray *buf) #define util_dynarray_element(buf, type, idx) ((type*)(buf)->data + (idx)) #define util_dynarray_begin(buf) ((buf)->data) #define util_dynarray_end(buf) ((void*)util_dynarray_element((buf), char, (buf)->size)) +#define util_dynarray_num_elements(buf, type) ((buf)->size / sizeof(type)) #define util_dynarray_foreach(buf, type, elem) \ for (type *elem = (type *)(buf)->data; \ elem < (type *)((char *)(buf)->data + (buf)->size); elem++) +#define util_dynarray_foreach_reverse(buf, type, elem) \ + if ((buf)->size > 0) \ + for (type *elem = util_dynarray_top_ptr(buf, type); \ + elem; \ + elem = elem > (type *)(buf)->data ? elem - 1 : NULL) + #define util_dynarray_delete_unordered(buf, type, v) \ do { \ unsigned num_elements = (buf)->size / sizeof(type); \