meta: Disable dithering during glBlitFramebuffer
authorNeil Roberts <neil@linux.intel.com>
Mon, 4 Aug 2014 19:54:03 +0000 (20:54 +0100)
committerNeil Roberts <neil@linux.intel.com>
Tue, 5 Aug 2014 13:48:15 +0000 (14:48 +0100)
commit816dbdb106dd1955d7db90084790af21fc496d83
tree59fd5b23f1bf3ab9026fc20268e526230d452e5f
parentafcf5d33cfd01a85dbd0adc930a1f4b137beaf95
meta: Disable dithering during glBlitFramebuffer

According to the GL spec the only fragment operations that should affect
glBlitFramebuffer are “the pixel ownership test, the scissor test, and sRGB
conversion”. That implies that dithering should not be performed so we need to
disable it when implementing the blit with a render.

Before commit 05b52efbc97731 the dithering state would be left as whatever the
application picks (the default being GL_TRUE) and after that commit it was
explicitly enabled. Neither of these were correct.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81828
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Topi Pohjolainen <topi.pohjolainen@intel.com>
src/mesa/drivers/common/meta_blit.c