Enable hardware breakpoints for gdbserver on Windows
authorHannes Domani <ssbssa@yahoo.de>
Mon, 11 May 2020 17:18:31 +0000 (19:18 +0200)
committerHannes Domani <ssbssa@yahoo.de>
Fri, 15 May 2020 08:55:21 +0000 (10:55 +0200)
commit013707794a67269dd34fd8ae6e354e982c547dc0
tree2893fa4b9a9a8dbbe628167ddebe6736c8b63184
parent2a50b401465f74d7f3ee1654915b9070b4dc0fee
Enable hardware breakpoints for gdbserver on Windows

When trying to use hardware breakpoints with gdbserver you get this error:

(gdb) hbreak main
Hardware assisted breakpoint 2 at 0x40162d: file gdb-9493.c, line 5.
(gdb) c
Continuing.
Warning:
Cannot insert hardware breakpoint 2.
Could not insert hardware breakpoints:
You may have requested too many hardware breakpoints/watchpoints.

It turns out the respective types just needed to be added to the
appropriate callback functions, because x86_dr_(insert|remove)_watchpoint
already handles them.

gdbserver/ChangeLog:

2020-05-15  Hannes Domani  <ssbssa@yahoo.de>

* win32-i386-low.cc (i386_supports_z_point_type): Handle
Z_PACKET_HW_BP z_type.
(i386_insert_point): Handle raw_bkpt_type type.
(i386_remove_point): Likewise.
gdbserver/ChangeLog
gdbserver/win32-i386-low.cc