st: Don't try to finalize the texture in st_render_texture().
authorEric Anholt <eric@anholt.net>
Tue, 27 Mar 2018 22:39:49 +0000 (15:39 -0700)
committerEric Anholt <eric@anholt.net>
Thu, 29 Mar 2018 00:48:41 +0000 (17:48 -0700)
commit0349c79bdc2c04b3d64d144159f3268ad74e2b7c
treeb415216c8d8ed928a822fa0383f8be11dc7b5a3e
parente159d46fc7c579b40f76ffb400ef1aebd3a59560
st: Don't try to finalize the texture in st_render_texture().

We can't necessarily finalize the texture at this point if we're rendering
to a texture image whose format is different from the baselevel's format.
This was introduced as a fix for fbo-incomplete-texture-03 in
de414f491526610bb260c73805c81ba413388e20, but the later fix for vmware on
that testcase in 95d5c48f68b598cfa6db25f44aac52b3e11403cc made it
unnecessary.

Fixes assertion failures in util_resource_copy_region() in
KHR-GLES3.copy_tex_image_conversions.forbidden.* when trying to finalize
an R8 texture image to the RG8 texture object's pt.

Reviewed-by: Brian Paul <brianp@vmware.com>
src/mesa/state_tracker/st_cb_fbo.c