Fix gdb.base/remote.exp with native-extended-gdbserver board
authorPedro Alves <palves@redhat.com>
Tue, 22 May 2018 22:26:46 +0000 (23:26 +0100)
committerPedro Alves <palves@redhat.com>
Tue, 22 May 2018 22:26:46 +0000 (23:26 +0100)
commit035522c0228be33b2124ada2f178187e7e53aa6c
treec75752ebe7d59df26694784cbe1de5981a2daf77
parent35f1fea3fcd44546a6cf074029c284c64ad25b3c
Fix gdb.base/remote.exp with native-extended-gdbserver board

This fixes gdb.base/remote.exp regressions caused by the previous
commit to the testcase, when tested with
--target_board=native-extended-gdbserver.  For example:

  ...
  show remote memory-write-packet-size
  The memory-write-packet-size is 0 (default). Packets are limited to 16383 bytes.
  (gdb) FAIL: gdb.base/remote.exp: write-packet default
  ...

With that board, GDB connects to GDBserver at gdb_start time, so GDB
is showing the actual remote/gdbserver packet size limits.

Fix it using the usual "disconnect" pattern.  While at it, there's no
need to start GDB before compiling the testcase.

gdb/testsuite/ChangeLog:
2018-05-22  Pedro Alves  <palves@redhat.com>

* gdb.base/remote.exp: Only gdb_start after compiling the
testcase.  Issue "disconnect" before testing "set remote" command
defaults.  Issue clean_restart before running to main.
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/remote.exp