i965/vs: Preserve the type when copy propagating into an instruction.
authorKenneth Graunke <kenneth@whitecape.org>
Thu, 25 Oct 2012 09:29:15 +0000 (02:29 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Thu, 25 Oct 2012 21:52:54 +0000 (14:52 -0700)
commit03ea156f1b3e57ef223c0340afb49e513fa0b407
tree274fed64b3880fc6eadfa567391e29f26094d507
parent10ff6772c8054aea12ac0f08e2e3898fd4a7f76b
i965/vs: Preserve the type when copy propagating into an instruction.

Consider the following code, which reinterprets a register as a
different type:

mov(8)          g6<1>F          g1.4<0,4,1>.xF
and(8)          g5<1>.xUD       g6<4,4,1>.xUD   0x7fffffffUD

Copy propagation would notice that we can replace the use of g6 with
g1.4 and eliminate the MOV.  Unfortunately, it failed to preserve the UD
type, incorrectly generating:

and(8)          g5<1>.xUD       g6<4,4,1>.xF    0x7fffffffUD

Found while debugging Ian's uncommitted ARB_vertex_program LOG opcode
test with my new Mesa IR -> Vec4 IR translator.

NOTE: This is a candidate for stable release branches.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp