Replace calls to NodeManager::mkSkolem with SkolemManager::mkDummySkolem (#6291)
authorAndrew Reynolds <andrew.j.reynolds@gmail.com>
Wed, 7 Apr 2021 18:36:15 +0000 (13:36 -0500)
committerGitHub <noreply@github.com>
Wed, 7 Apr 2021 18:36:15 +0000 (18:36 +0000)
commit04a494e251a8cc2c90bb429e2858f1c4eb8f88ff
tree03b1a5792f2f6ca5537353b86682f427090668da
parent5059658ee0d6fc65e4cb1652c605895d016cd274
Replace calls to NodeManager::mkSkolem with SkolemManager::mkDummySkolem (#6291)

This is in preparation for refactoring skolem creation throughout the code base to improve proofs and migrate Theory::expandDefinitions to Rewriter::expandDefinitions.

This PR also eliminates some unused code in TheoryArithPrivate.

Followup PRs will start formalizing/eliminating calls to mkDummySkolem.
92 files changed:
src/expr/dtype.cpp
src/expr/dtype_cons.cpp
src/expr/node_manager.h
src/expr/skolem_manager.cpp
src/expr/skolem_manager.h
src/expr/subs.cpp
src/expr/sygus_datatype.cpp
src/preprocessing/passes/ackermann.cpp
src/preprocessing/passes/bv_to_int.cpp
src/preprocessing/passes/fun_def_fmf.cpp
src/preprocessing/passes/ho_elim.cpp
src/preprocessing/passes/int_to_bv.cpp
src/preprocessing/passes/miplib_trick.cpp
src/preprocessing/passes/nl_ext_purify.cpp
src/preprocessing/passes/quantifier_macros.cpp
src/preprocessing/passes/real_to_int.cpp
src/preprocessing/passes/sep_skolem_emp.cpp
src/preprocessing/passes/unconstrained_simplifier.cpp
src/preprocessing/util/ite_utilities.cpp
src/smt/quant_elim_solver.cpp
src/smt/sygus_solver.cpp
src/theory/arith/arith_ite_utils.cpp
src/theory/arith/arith_utilities.h
src/theory/arith/callbacks.cpp
src/theory/arith/dio_solver.cpp
src/theory/arith/nl/cad_solver.cpp
src/theory/arith/nl/transcendental/sine_solver.cpp
src/theory/arith/nl/transcendental/transcendental_solver.cpp
src/theory/arith/theory_arith_private.cpp
src/theory/arith/theory_arith_private.h
src/theory/builtin/theory_builtin_type_rules.cpp
src/theory/bv/abstraction.cpp
src/theory/bv/bv_subtheory_core.cpp
src/theory/bv/theory_bv_utils.cpp
src/theory/datatypes/sygus_extension.cpp
src/theory/datatypes/theory_datatypes.cpp
src/theory/engine_output_channel.cpp
src/theory/fp/theory_fp.cpp
src/theory/quantifiers/bv_inverter.cpp
src/theory/quantifiers/cegqi/ceg_bv_instantiator.cpp
src/theory/quantifiers/cegqi/inst_strategy_cegqi.cpp
src/theory/quantifiers/cegqi/vts_term_cache.cpp
src/theory/quantifiers/conjecture_generator.cpp
src/theory/quantifiers/dynamic_rewrite.cpp
src/theory/quantifiers/expr_miner.cpp
src/theory/quantifiers/fmf/bounded_integers.cpp
src/theory/quantifiers/fmf/first_order_model_fmc.cpp
src/theory/quantifiers/fmf/full_model_check.cpp
src/theory/quantifiers/quantifiers_rewriter.cpp
src/theory/quantifiers/single_inv_partition.cpp
src/theory/quantifiers/skolemize.cpp
src/theory/quantifiers/sygus/ce_guided_single_inv.cpp
src/theory/quantifiers/sygus/cegis_unif.cpp
src/theory/quantifiers/sygus/rcons_type_info.cpp
src/theory/quantifiers/sygus/sygus_abduct.cpp
src/theory/quantifiers/sygus/sygus_qe_preproc.cpp
src/theory/quantifiers/sygus/sygus_reconstruct.cpp
src/theory/quantifiers/sygus/sygus_repair_const.cpp
src/theory/quantifiers/sygus/sygus_unif_rl.cpp
src/theory/quantifiers/sygus/sygus_unif_strat.cpp
src/theory/quantifiers/sygus/sygus_utils.cpp
src/theory/quantifiers/sygus/synth_conjecture.cpp
src/theory/quantifiers/sygus/template_infer.cpp
src/theory/quantifiers/sygus/term_database_sygus.cpp
src/theory/quantifiers/sygus/transition_inference.cpp
src/theory/quantifiers/sygus_inst.cpp
src/theory/quantifiers/term_database.cpp
src/theory/sep/theory_sep.cpp
src/theory/sets/cardinality_extension.cpp
src/theory/sets/skolem_cache.cpp
src/theory/sets/term_registry.cpp
src/theory/sets/theory_sets_private.cpp
src/theory/sets/theory_sets_rels.cpp
src/theory/sort_inference.cpp
src/theory/strings/regexp_operation.cpp
src/theory/strings/skolem_cache.cpp
src/theory/strings/theory_strings_preprocess.cpp
src/theory/uf/cardinality_extension.cpp
src/theory/uf/ho_extension.cpp
test/unit/node/attribute_black.cpp
test/unit/node/node_algorithm_black.cpp
test/unit/node/node_black.cpp
test/unit/node/node_builder_black.cpp
test/unit/node/node_manager_black.cpp
test/unit/node/node_manager_white.cpp
test/unit/node/node_self_iterator_black.cpp
test/unit/test_node.h
test/unit/test_smt.h
test/unit/theory/theory_bags_rewriter_white.cpp
test/unit/theory/theory_quantifiers_bv_inverter_white.cpp
test/unit/theory/theory_strings_skolem_cache_black.cpp
test/unit/util/boolean_simplification_black.cpp