runtime: use the call instruction's PC for panic-in-runtime detection
authorIan Lance Taylor <ian@gcc.gnu.org>
Tue, 29 Jan 2019 00:49:23 +0000 (00:49 +0000)
committerIan Lance Taylor <ian@gcc.gnu.org>
Tue, 29 Jan 2019 00:49:23 +0000 (00:49 +0000)
commit053a1f232023b15c21bdd8e89f67de21d8aea285
tree30cc483c1055da9667de55c49b7ef3673f6266b4
parent45e7df858b408b0277ee3580f6a67696d5cfd8b4
runtime: use the call instruction's PC for panic-in-runtime detection

    If a panic happens in the runtime we turn that into a fatal error.
    We use the caller's PC to determine if the panic call is inside
    the runtime. getcallerpc returns the PC immediately after the
    call instruction. If the call is the very last instruction of a
    function, it may not find this PC belong to a runtime function,
    giving false result. We need to back off the PC by 1 to the call
    instruction.

    The gc runtime doesn't do this because the gc compiler always
    emit an instruction following a panic call, presumably an UNDEF
    instruction which turns into an architecture-specific illegal
    instruction. Our compiler doesn't do this.

    Reviewed-on: https://go-review.googlesource.com/c/159437

From-SVN: r268358
gcc/go/gofrontend/MERGE
libgo/go/runtime/panic.go
libgo/runtime/go-runtime-error.c