gdb/guile: don't try to print location for watchpoints
authorAndrew Burgess <andrew.burgess@embecosm.com>
Wed, 5 May 2021 15:52:29 +0000 (16:52 +0100)
committerAndrew Burgess <andrew.burgess@embecosm.com>
Thu, 6 May 2021 09:44:29 +0000 (10:44 +0100)
commit0618ecf6eb99dce0278102a88f622f28e3ecd837
tree50fd21fbd4a963082ad8c833f4fb1978ff37f650
parenta7ed4ea6af8a333fccf1760cf38bf7d3634afd59
gdb/guile: don't try to print location for watchpoints

Currently, using the guile API, if a user tries to print a breakpoint
object that represents a watchpoint, then GDB will crash.  For
example:

  (gdb) guile (use-modules (gdb))
  (gdb) guile (define wp1 (make-breakpoint "some_variable" #:type BP_WATCHPOINT #:wp-class WP_WRITE))
  (gdb) guile (register-breakpoint! wp1)
  (gdb) guile (display wp1) (newline)
  Aborted (core dumped)

This turns out to be because GDB calls event_location_to_string on the
breakpoints location, and watchpoint breakpoints don't have a
location.

This commit resolves the crash by just skipping the printing of the
location if the breakpoint doesn't have one.

Potentially, we could improve on this by printing details about what
the watchpoint is watching, however, I'm considering this a possible
future enhancement, this commit focuses just on having GDB not crash.

gdb/ChangeLog:

* guile/scm-breakpoint.c (bpscm_print_breakpoint_smob): Only print
breakpoint locations when the breakpoint actually has a location.

gdb/testsuite/ChangeLog:

* gdb.guile/scm-breakpoint.exp (test_watchpoints): Print the
watchpoint object before and after registering it with GDB.
gdb/ChangeLog
gdb/guile/scm-breakpoint.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.guile/scm-breakpoint.exp