linux_spu_make_corefile_notes: return note_data instead of nullptr
authorSimon Marchi <simon.marchi@ericsson.com>
Mon, 16 Apr 2018 20:47:06 +0000 (16:47 -0400)
committerSimon Marchi <simon.marchi@ericsson.com>
Mon, 16 Apr 2018 20:47:06 +0000 (16:47 -0400)
commit07d28c777757148d13e429c4463da52cbb50d297
tree760314f777b27ecaf7a08c419bfd98a5ed43012a
parente3a91079b5e5669567424d3b2f31b48b7b89ef72
linux_spu_make_corefile_notes: return note_data instead of nullptr

Since commit

  9018be2 ("Make target_read_alloc & al return vectors")

the test gdb.threads/gcore-stale-thread.exp test results in UNSUPPORTED:

  UNSUPPORTED: gdb.threads/gcore-stale-thread.exp: save a corefile

The problem is that the linux_spu_make_corefile_notes started returning
nullptr when reading TARGET_OBJECT_SPU fails.  The previous (and proper)
behaviour is to return the note_data received as a parameter, so that
other functions may continue to append to this buffer.

With this patch, the test goes back to PASS.

gdb/ChangeLog:

* linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
instead of nullptr.
gdb/ChangeLog
gdb/linux-tdep.c