radv: do not use CP predication for DCC decompressions
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Thu, 16 Aug 2018 16:56:22 +0000 (18:56 +0200)
committerSamuel Pitoiset <samuel.pitoiset@gmail.com>
Mon, 20 Aug 2018 09:54:37 +0000 (11:54 +0200)
commit0aacb5eab6120aa1410966d23101e16eea3fbcd7
tree056997d5b1cefab60df8819a812979f8118d35d0
parent799b3d16d4bb0caa16dc35de66e11eca8517cd02
radv: do not use CP predication for DCC decompressions

This fixes a regression with some Unity demos. Not sure
what the root cause of the problem is, especially because
the driver doesn't perform any fast color clears. So, it
shouldn't be needed to decompress DCC. RadeonSI says that
the decompression is relatively cheap if the surface has
been decompressed already.

One possible improvement is to two use predicates, one for
DCC and one for FCE that could be cleared when DCC, FMASK
or CMASK are performed by the driver. That might skip some
unnecessary decompression passes (not DCC though).

Fixes: ff7daadca1 ("radv: enable/disable predication for the DCC decompression pass")
CC: 18.2 <mesa-stable@lists.freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107563
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
src/amd/vulkan/radv_meta_fast_clear.c