projects / mesa.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e051880) | patch
aco: fix printing ASM on GFX6-7 again
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Mon, 22 Jun 2020 11:33:21 +0000 (13:33 +0200)
committerMarge Bot <eric+marge@anholt.net>
Tue, 23 Jun 2020 07:45:03 +0000 (07:45 +0000)
commit0aca04afa585e87bc900fb3b9c19c92d78b3e8f7
tree1e24711d9775f8ac8b3dd02a7f7dc5d8628bedb5tree
parente0518800a1256a98588f1cb9dcc89e7346756b1acommit | diff
aco: fix printing ASM on GFX6-7 again

Checking errno is actually wrong because it's only updated if
popen() fails (ie. NULL). One solution is to check if the first
line is empty.

Fixes: c95d258d1bc ("aco: fix printing ASM on GFX6-7 if clrxdisasm is not found")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5591>
src/amd/compiler/aco_print_asm.cpp diff | blob | history