bfd/elf64-ppc.c: fix clang -Wbitwise-instead-of-logical warning in ppc64_elf_check_in...
authorSimon Marchi <simon.marchi@efficios.com>
Sun, 16 Jan 2022 03:13:07 +0000 (22:13 -0500)
committerSimon Marchi <simon.marchi@polymtl.ca>
Tue, 18 Jan 2022 04:14:57 +0000 (23:14 -0500)
commit0c80c644641f67b18661a63b19c47074b308bc18
treec4600f8d51caaf6385272c67bc14ce6add4a24db
parente2c0149e8b0ce12accb8f4b02cbbeff3e91e4737
bfd/elf64-ppc.c: fix clang -Wbitwise-instead-of-logical warning in ppc64_elf_check_init_fini

I see this error with clang-14:

      CC       elf64-ppc.lo
    /home/smarchi/src/binutils-gdb/bfd/elf64-ppc.c:13131:11: error: use of bitwise '&' with boolean operands [-Werror,-Wbitwise-instead-of-logical]
      return (check_pasted_section (info, ".init")
             ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fix by replacing & with &&.  But given that the check_pasted_section
function has side-effects and we want to make sure both calls are made,
assign to temporary variables before evaluating the `&&`.

Change-Id: I849e1b2401bea5f4d8ef3ab9af99ba9e3ef42490
bfd/elf64-ppc.c