gdb: use gdb::byte_vector instead of std::vector<char> in core_target::get_core_regis...
authorSimon Marchi <simon.marchi@efficios.com>
Mon, 13 Jan 2020 23:12:08 +0000 (18:12 -0500)
committerSimon Marchi <simon.marchi@efficios.com>
Mon, 13 Jan 2020 23:12:08 +0000 (18:12 -0500)
commit0cac9354bfb07a5cf53d70dbefaa35c6afa7da0a
tree92db38d9e027bd2eea944586d3f1aed2aa10472d
parent9a6d629ccf328e3f041c3fcb7e91f49a5d72d0fb
gdb: use gdb::byte_vector instead of std::vector<char> in core_target::get_core_register_section

Since the data held by the `contents` variable is arbitrary binary data,
it should have gdb_byte elements, not char elements.  Also, using
gdb::byte_vector is preferable, since it doesn't unnecessarily
zero-initialize the values.

Instead of adding a cast in the call to m_core_vec->core_read_registers,
I have changed core_read_registers' argument to be a gdb_byte* instead
of a char*.

gdb/ChangeLog:

* gdbcore.h (struct core_fns) <core_read_registers>: Change
core_reg_sect type to gdb_byte *.
* arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
* cris-tdep.c (fetch_core_registers): Likewise.
* corelow.c (core_target::get_core_register_section): Change
type of `contents` to gdb::byte_vector.
gdb/ChangeLog
gdb/arm-nbsd-nat.c
gdb/corelow.c
gdb/cris-tdep.c
gdb/gdbcore.h