core/download: fix when the BR2_DL_DIR does not accept hardlinks
authorYann E. MORIN <yann.morin.1998@free.fr>
Tue, 3 Apr 2018 18:54:56 +0000 (20:54 +0200)
committerPeter Korsgaard <peter@korsgaard.com>
Tue, 3 Apr 2018 20:45:00 +0000 (22:45 +0200)
commit0d19fcf6c24f7dcf585ad3423518068b5789f3b0
tree03fef48d908d0de21366538a884c18c234c544d5
parent7f4deda135c23e83f255340fd3620b83eea81b8c
core/download: fix when the BR2_DL_DIR does not accept hardlinks

When the BR2_DL_DIR is a mountpoint (presumably shared between various
machine, or mounted from the local host when running in a VM), it is
possible that it does not support hardlinks (e.g. samba, or the VMWare
VMFS, etc...).

If the hardlink fails, fallback to copying the file. As a last resort,
if that also fails, eventually fallback to doing the download.

Note: this means that the dl-wrapper is no longer atomic-safe: the code
suffers of a TOCTTOU condition: the file may be created in-between the
check and the moment we try to ln/cp it. Fortunately, the dl-wrapper is
now run under an flock, so we're still safe. If we eventually go for a
more fine-grained implementation, we'll have to be careful then.

Reported-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Peter Korsgaard <peter@korsgaard.com>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
support/download/dl-wrapper