package/pkgconf: fix behavior of pkg-config --version
authorThomas Petazzoni <thomas.petazzoni@bootlin.com>
Wed, 2 Jan 2019 17:36:38 +0000 (18:36 +0100)
committerThomas Petazzoni <thomas.petazzoni@bootlin.com>
Thu, 3 Jan 2019 20:55:15 +0000 (21:55 +0100)
commit0d244183bfce0c5cf74f4897e57bb4b00b00bfa8
tree71bb38cc45f2b79b024b214c689955d12e6e8670
parentbbf32a77ec5883aef5e954379591504ae20e946b
package/pkgconf: fix behavior of pkg-config --version

For some odd reason, the new pkg-config 1.5.3 changed the behavior of
"pkg-config --version": as soon as another argument than "--version"
is passed, the code assumes the user wanted to run "--modversion"
instead.

Sadly, this breaks badly with our pkg-config wrapper that
unconditionally passes --static to pkg-config when
BR2_STATIC_LIBS=y. When ffmpeg calls "pkg-config --version" to test if
pkg-config is available and functional, it's actually "pkg-config
--static --version" that gets executed. pkg-config assumes that the
user wanted to use --modversion and bails out with an error.

This causes a build failure of ffmpeg in BR2_STATIC_LIBS=y
configuration.

This misbehavior of pkg-config has been reported upstream at
https://git.dereferenced.org/pkgconf/pkgconf/issues/19, but until it
gets fixed, we work around the issue by reverting the commit that does
the "hey let's assume you're using --modversion if --version is passed
with more than one argument".

Fixes:

  http://autobuild.buildroot.net/results/ed82a95e1866ea2caadbb3433b2a255b2cf621d2/
  (and plenty of other ffmpeg + BR2_STATIC_LIBS=y build failures)

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
package/pkgconf/0002-Revert-main-assume-modversion-insted-of-version-if-o.patch [new file with mode: 0644]