arch, base, cpu, gpu, mem: Replace assert(0 or false with panic.
authorGabe Black <gabeblack@google.com>
Tue, 27 Nov 2018 01:51:16 +0000 (17:51 -0800)
committerGabe Black <gabeblack@google.com>
Tue, 27 Nov 2018 21:58:24 +0000 (21:58 +0000)
commit12311c5540e69750b39f1f2e476546cdf05d1f3e
tree56478af783014362be805d560a19d41faed49b65
parenta66d12c23517a010f5a05efbc2e47d61fba705c9
arch, base, cpu, gpu, mem: Replace assert(0 or false with panic.

Neither assert(0) nor assert(false) give any hint as to why control
getting to them is bad, and their more descriptive versions,
assert(0 && "description") and assert(false && "description"), jury
rig assert to add an error message when the utility function panic()
already does that directly with better formatting options.

This change replaces that flavor of call to assert with panic, except
in the actual code which processes the formatting that panic uses (to
avoid infinitely recurring error handling), and in some *.sm files
since I don't know what rules those have to follow and don't want to
accidentaly break them.

Change-Id: I8addfbfaf77eaed94ec8191f2ae4efb477cefdd0
Reviewed-on: https://gem5-review.googlesource.com/c/14636
Reviewed-by: Brandon Potter <Brandon.Potter@amd.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
20 files changed:
src/arch/arm/insts/fplib.cc
src/arch/arm/insts/pred_inst.hh
src/arch/mips/isa/formats/mem.isa
src/base/inet.cc
src/cpu/minor/buffers.hh
src/cpu/minor/lsq.cc
src/cpu/o3/commit_impl.hh
src/cpu/o3/inst_queue_impl.hh
src/cpu/o3/lsq_impl.hh
src/cpu/o3/rob_impl.hh
src/gpu-compute/gpu_dyn_inst.hh
src/gpu-compute/gpu_tlb.cc
src/gpu-compute/gpu_tlb.hh
src/gpu-compute/tlb_coalescer.cc
src/mem/cache/queue.hh
src/mem/mem_checker_monitor.cc
src/mem/ruby/filters/H3BloomFilter.cc
src/mem/ruby/filters/MultiBitSelBloomFilter.cc
src/mem/ruby/network/garnet2.0/RoutingUnit.cc
src/mem/ruby/structures/CacheMemory.cc