gdb/build: Fix Wpessimizing-move in clang build
authorEnze Li <lienze2010@hotmail.com>
Fri, 28 Jan 2022 13:26:40 +0000 (21:26 +0800)
committerEnze Li <lienze2010@hotmail.com>
Fri, 28 Jan 2022 15:02:36 +0000 (23:02 +0800)
commit12735d34728d540ca39b8158da0ed1e257fa8f50
treec0dbe8f1af31af4f83daa1e46800db7cc3914f49
parent459140adc0cbcf7ff5d389a195a3c9e34dd8282f
gdb/build: Fix Wpessimizing-move in clang build

When building with clang, I run into an error:

...
tui/tui-disasm.c:138:25: error: moving a temporary object prevents copy
elision [-Werror,-Wpessimizing-move]
      tal.addr_string = std::move (gdb_dis_out.release ());
                        ^
tui/tui-disasm.c:138:25: note: remove std::move call here
      tal.addr_string = std::move (gdb_dis_out.release ());
                        ^~~~~~~~~~~                      ~
...

The error above is caused by the recent commit 5d10a2041eb8 ("gdb: add
string_file::release method").

Fix this by removing std::move.

Build on x86_64-linux with clang 13.0.0.
gdb/tui/tui-disasm.c