Improvements for evaluation in model (#8738)
authorAndrew Reynolds <andrew.j.reynolds@gmail.com>
Mon, 9 May 2022 19:28:52 +0000 (14:28 -0500)
committerGitHub <noreply@github.com>
Mon, 9 May 2022 19:28:52 +0000 (19:28 +0000)
commit18be156d626248e8c0b125e98f4aac059fa085c9
tree66adec0c1bd13f1e7ab69faf18ea93bb622e5501
parente7fd317234408618bb0c5fb3c4511bdd47f200e7
Improvements for evaluation in model (#8738)

This marks APPLY_SELECTOR and SEQ_NTH as unevaluatable kinds.

This means that get-value applied to applications of them e.g. (seq.nth t) will evaluate to c if (seq.nth t) is in the same equivalence class as constant c. (Note that this could be further improved to reason by congruence for (seq.nth s) where s = t, which I'm considering to do on a followup PR).

This removes many of the required -q from the command line arguments of our regressions. This also does some minor cleanup to our regressions to remove -q from further regressions.
70 files changed:
src/theory/datatypes/theory_datatypes.cpp
src/theory/strings/theory_strings.cpp
src/theory/theory_model.cpp
test/regress/cli/regress0/arith/div.05.smt2
test/regress/cli/regress0/arith/issue7984-quant-trans.smt2
test/regress/cli/regress0/arith/projissue469-int-equality.smt2
test/regress/cli/regress0/cores/issue3455.smt2
test/regress/cli/regress0/cores/issue3651.smt2
test/regress/cli/regress0/cores/issue4971-0.smt2
test/regress/cli/regress0/cores/issue4971-1.smt2
test/regress/cli/regress0/cores/issue4971-3.smt2
test/regress/cli/regress0/cores/issue5902.smt2
test/regress/cli/regress0/cores/issue5908.smt2
test/regress/cli/regress0/datatypes/data-nested-codata.smt2
test/regress/cli/regress0/datatypes/datatype1.cvc.smt2
test/regress/cli/regress0/datatypes/datatype3.cvc.smt2
test/regress/cli/regress0/datatypes/issue1433.smt2
test/regress/cli/regress0/datatypes/issue2838.cvc.smt2
test/regress/cli/regress0/datatypes/parametric-alt-list.cvc.smt2
test/regress/cli/regress0/datatypes/v3l60006.cvc.smt2
test/regress/cli/regress0/datatypes/wrong-sel-simp.cvc.smt2
test/regress/cli/regress0/fp/issue3536.smt2
test/regress/cli/regress0/fp/issue3619.smt2
test/regress/cli/regress0/fp/issue4277-assign-func.smt2
test/regress/cli/regress0/issue5099-model-2.smt2
test/regress/cli/regress0/issue5473.smt2
test/regress/cli/regress0/issue5736.smt2
test/regress/cli/regress0/issue5743.smt2
test/regress/cli/regress0/issue5947.smt2
test/regress/cli/regress0/nl/nta/issue4693-4-inc-purify-sat.smt2
test/regress/cli/regress0/nl/nta/issue4693-5-inc-purify.smt2
test/regress/cli/regress0/nl/nta/issue4693-inc-purify.smt2
test/regress/cli/regress0/nl/nta/issue8182-2-exact-mv-keep.smt2
test/regress/cli/regress0/parser/issue7894-parse-error-assoc.smt2
test/regress/cli/regress0/parser/to_fp.smt2
test/regress/cli/regress0/quantifiers/issue8001-mem-leak.smt2
test/regress/cli/regress0/quantifiers/pure_dt_cbqi.smt2
test/regress/cli/regress0/seq/mixed-types-seq-nth.smt2
test/regress/cli/regress0/seq/nth-update.smt2
test/regress/cli/regress0/seq/seq-expand-defs.smt2
test/regress/cli/regress0/seq/seq-nth.smt2
test/regress/cli/regress0/seq/update-concat-non-atomic.smt2
test/regress/cli/regress0/seq/update-concat-non-atomic2.smt2
test/regress/cli/regress0/seq/wrong-model-020322.smt2
test/regress/cli/regress1/bug507.smt2
test/regress/cli/regress1/bug516.smt2
test/regress/cli/regress1/cee-bug0909-dd-scope.smt2
test/regress/cli/regress1/cores/issue5604.smt2
test/regress/cli/regress1/datatypes/non-simple-rec-param.smt2
test/regress/cli/regress1/fmf/bug651.smt2
test/regress/cli/regress1/fmf/cons-sets-bounds.smt2
test/regress/cli/regress1/fmf/jasmin-cdt-crash.smt2
test/regress/cli/regress1/fmf/loopy_coda.smt2
test/regress/cli/regress1/fmf/lst-no-self-rev-exp.smt2
test/regress/cli/regress1/fmf/nun-0208-to.smt2
test/regress/cli/regress1/fmf/pow2-bool.smt2
test/regress/cli/regress1/nl/transcedental_model_simple.smt2
test/regress/cli/regress1/quantifiers/issue5484-qe.smt2
test/regress/cli/regress1/quantifiers/issue5484b-qe.smt2
test/regress/cli/regress1/quantifiers/qbv-simple-2vars-vo.smt2
test/regress/cli/regress1/quantifiers/qbv-subcall.smt2
test/regress/cli/regress1/quantifiers/smtcomp-qbv-053118.smt2
test/regress/cli/regress1/seq/issue8148-2-const-mv.smt2
test/regress/cli/regress1/seq/issue8148-const-mv.smt2
test/regress/cli/regress1/strings/issue1105.smt2
test/regress/cli/regress1/strings/issue6913.smt2
test/regress/cli/regress1/wrong-qfabvfp-smtcomp2018.smt2
test/regress/cli/regress2/bug765.smt2
test/regress/cli/regress2/quantifiers/net-policy-no-time.smt2
test/regress/cli/regress2/strings/issue6483.smt2