cpu: Stop extracting inst_flags from the machInst.
authorGabe Black <gabeblack@google.com>
Tue, 27 Mar 2018 07:26:58 +0000 (00:26 -0700)
committerGabe Black <gabeblack@google.com>
Tue, 27 Mar 2018 10:57:36 +0000 (10:57 +0000)
commit197ae7aca7a911fb06c8e96beddfb6c5712b5561
tree44f3890c10787feda841f062a1c5f0abf93148a8
parent979b30ec8b5d589eee4c17209733daaad75962dd
cpu: Stop extracting inst_flags from the machInst.

The instruction representation is already encoded in the trace
protobuf, so there's no reason to encode a part of it again. This is
especially true since this supposedly generic code is extracting the
first 8 bits of the machInst, a totally arbitrary set of bits for most
ISAs. If certain bits within a machine instruction are actually
relevant, the consumer of the trace should be able to interpret the
instruction bytes which are already there and extract the same bits
within the context of whatever ISA they're appropriate for.

Change-Id: Idaebe6a110d7d4812c3d7c434582d5a9470bcec1
Reviewed-on: https://gem5-review.googlesource.com/9401
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Maintainer: Gabe Black <gabeblack@google.com>
src/cpu/inst_pb_trace.cc
src/proto/inst.proto