misc: Clean up usage of arch/isa_traits.hh.
authorGabe Black <gabeblack@google.com>
Sat, 22 Aug 2020 04:58:03 +0000 (21:58 -0700)
committerGabe Black <gabeblack@google.com>
Fri, 28 Aug 2020 07:20:58 +0000 (07:20 +0000)
commit1d755b4ba154a240c591032028e90ca91628dbbf
tree8bac320132ab54945fafa0f10cb96c222ca52447
parent1e18de8270dc26394022fcc76b8959ebead66d1a
misc: Clean up usage of arch/isa_traits.hh.

isa_traits.hh used to have much more in it, but now it only has
PageShift, PageBytes, and (for now) the guest endianness. These values
should only be retrieved from the System class generally speaking, so
only the system class should include arch/isa_traits.hh.

Some gpu compute related files need PageBytes or PageShift. Even though
those files don't advertise their ISA dependence, they are tied to x86.
In those files, they can include arch/x86/isa_traits.hh.

The only other file which legitimately needs arch/isa_traits.hh is the
decoder cache since it uses PageBytes to size an array.

Change-Id: I12686368715623e3140a68a7027c136bd52567b1
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33203
Reviewed-by: Gabe Black <gabeblack@google.com>
Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br>
Maintainer: Gabe Black <gabeblack@google.com>
Tested-by: kokoro <noreply+kokoro@google.com>
28 files changed:
src/arch/generic/memhelpers.hh
src/arch/riscv/registers.hh
src/cpu/base.hh
src/cpu/checker/cpu_impl.hh
src/cpu/exetrace.cc
src/cpu/o3/dyn_inst.hh
src/cpu/o3/fetch_impl.hh
src/cpu/o3/impl.hh
src/cpu/o3/lsq_unit.hh
src/cpu/o3/regfile.hh
src/cpu/o3/rename_impl.hh
src/cpu/pred/bpred_unit.cc
src/cpu/pred/simple_indirect.hh
src/cpu/simple_thread.cc
src/cpu/simple_thread.hh
src/dev/storage/ide_disk.cc
src/dev/virtio/base.hh
src/gpu-compute/compute_unit.cc
src/gpu-compute/gpu_tlb.cc
src/gpu-compute/shader.cc
src/gpu-compute/shader.hh
src/gpu-compute/tlb_coalescer.cc
src/gpu-compute/tlb_coalescer.hh
src/kern/linux/helpers.cc
src/mem/cache/prefetch/base.hh
src/sim/faults.cc
src/sim/process.cc
src/sim/syscall_emul.cc