glsl: Consistently use length-based ralloc string functions for info_log.
authorCarl Worth <cworth@cworth.org>
Sat, 9 Jun 2012 16:45:56 +0000 (09:45 -0700)
committerCarl Worth <cworth@cworth.org>
Tue, 26 Jun 2012 22:20:53 +0000 (15:20 -0700)
commit1db463ce2e2812c4e41ab4096ff16a148d4bcc90
tree60826af5a3d9a2323e3d068f7e891616c8343348
parentc96b8302a398a6db27f1bb6070cdc088c7ee0fba
glsl: Consistently use length-based ralloc string functions for info_log.

Commit b823b99ec0f13af257dcd885f436a4d294c6222a switched from using
functions such as ralloc_asprintf and ralloc_strcat to
ralloc_asprintf_rewrite_tail. This change maintains the string's
length as a aparamter that is updated by the ralloc functions (rather
than recomputing it with strlen over and over).

However, the change failed to updated two locations (glcpp_error and
glcpp_warning), with the result that the string's length wasn't
updated by these calls. Then, subsequent calls to other
ralloc_asprintf_rewrite_tail would overwrite the text appended by
glcpp_error.

This commit fixes the two missing updates, and restores line numbers
to the output of glcpp error messages, (as noticed by a glcpp unit
test case that has been failing since the above-mentioned commit).

Signed-off-by: Carl Worth <cworth@cworth.org>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/glsl/glcpp/pp.c