[gdb/build] Return gdb::array_view in thread_info_to_thread_handle
authorTom de Vries <tdevries@suse.de>
Thu, 24 Aug 2023 11:40:38 +0000 (13:40 +0200)
committerTom de Vries <tdevries@suse.de>
Thu, 24 Aug 2023 11:40:38 +0000 (13:40 +0200)
commit1f08d324601ef7fd4cce3cff8f8db4a774791828
treef5dc02b94c0fe17232557d8bf24b9f705a7ba337
parentf1917fc63166d73a9d0930d96468e486a49c666d
[gdb/build] Return gdb::array_view in thread_info_to_thread_handle

In remote_target::thread_info_to_thread_handle we return a copy:
...
gdb::byte_vector
remote_target::thread_info_to_thread_handle (struct thread_info *tp)
{
  remote_thread_info *priv = get_remote_thread_info (tp);
  return priv->thread_handle;
}
...

Fix this by returning a gdb::array_view instead:
...
gdb::array_view<const gdb_byte>
remote_target::thread_info_to_thread_handle (struct thread_info *tp)
...

Tested on x86_64-linux.

This fixes the build when building with -std=c++20.

Approved-By: Pedro Alves <pedro@palves.net>
gdb/linux-thread-db.c
gdb/python/py-infthread.c
gdb/remote.c
gdb/target-debug.h
gdb/target-delegates.c
gdb/target.c
gdb/target.h