radeonsi: don't lower constant arrays to uniforms in GLSL IR
authorTimothy Arceri <tarceri@itsqueeze.com>
Tue, 7 Apr 2020 01:28:32 +0000 (11:28 +1000)
committerMarge Bot <eric+marge@anholt.net>
Wed, 8 Apr 2020 01:23:40 +0000 (01:23 +0000)
commit1f649ff10764b2f47fd69013f390e9286547cc3b
tree49458427d8cd4f5e7c6d6a9554276c3d38267a5c
parentc682ea598f72ded39903015ec3188969fe468ff7
radeonsi: don't lower constant arrays to uniforms in GLSL IR

This re-enables the change made in 2f5783bc2b82 which was
incorrectly disabled by 3e1dd99adca5.

For radeonsi, we will prefer the NIR pass as it'll generate better code
(some index calculation and a single load vs. a load, then index
calculation, then another load) and oftentimes NIR optimization can kick
in and make all the access indices constant.

Fixes: 3e1dd99adca5 ("radeonsi: Remove a bunch of default handling of pipe caps.")
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4474>
src/gallium/drivers/radeonsi/si_get.c