Handle bit offset and bit size in base types
authorTom Tromey <tom@tromey.com>
Wed, 23 Sep 2020 15:39:24 +0000 (09:39 -0600)
committerTom Tromey <tom@tromey.com>
Wed, 23 Sep 2020 15:39:24 +0000 (09:39 -0600)
commit20a5fcbd5b28cca88511ac5a9ad5e54251e8fa6d
tree5443c2824f7d53f50d8d280f64d19f398f523f65
parentbac51ab78d4bee5273c7d6306ff6d41545fd5628
Handle bit offset and bit size in base types

PR symtab/25470 points out that the Zig programming language allows
integers of various bit sizes (including zero), not just sizes that
are a multiple of 8.

This is supported in DWARF by applying both a byte size and a
DW_AT_bit_size.

This patch adds support for this feature to integer and boolean types.
Other base types are not handled -- for floating-point types, this
didn't seem to make sense, and for character types I didn't see much
need.  (These can be added later if desired.)

I've also added support for DW_AT_data_bit_offset at the same time.  I
don't know whether the Zig compiler requires this, but it was
described in the same section in the DWARF standard and was easy to
add.

A new test case is supplied, using the DWARF assembler.

gdb/ChangeLog
2020-09-23  Tom Tromey  <tom@tromey.com>

PR symtab/25470:
* value.c (unpack_long, pack_long, pack_unsigned_long): Handle bit
offset and bit size.
* printcmd.c (print_scalar_formatted): Handle zero-length
integer.
(print_scalar_formatted): Use bit_size_differs_p.
* gdbtypes.h (enum type_specific_kind) <TYPE_SPECIFIC_INT>: New
constant.
(union type_specific): <int_stuff>: New member.
(struct type) <bit_size_differs_p, bit_size, bit_offset>: New
methods.
* gdbtypes.c (init_integer_type, init_boolean_type): Initialize
TYPE_SPECIFIC_FIELD.
(recursive_dump_type, copy_type_recursive): Update.
* dwarf2/read.c (read_base_type): Handle DW_AT_bit_size and
DW_AT_data_bit_offset.

gdb/testsuite/ChangeLog
2020-09-23  Tom Tromey  <tom@tromey.com>

* gdb.dwarf2/intbits.exp: New file.
* gdb.dwarf2/intbits.c: New file.
gdb/ChangeLog
gdb/dwarf2/read.c
gdb/gdbtypes.c
gdb/gdbtypes.h
gdb/printcmd.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.dwarf2/intbits.c [new file with mode: 0644]
gdb/testsuite/gdb.dwarf2/intbits.exp [new file with mode: 0644]
gdb/value.c