Make handling of illegal internal representatives in quantifiers engine more robust...
authorAndrew Reynolds <andrew.j.reynolds@gmail.com>
Fri, 20 Mar 2020 15:16:21 +0000 (10:16 -0500)
committerGitHub <noreply@github.com>
Fri, 20 Mar 2020 15:16:21 +0000 (10:16 -0500)
commit210e66251b40c74243cf13a967464add2abb7a52
treec6e6f9fb16c2d93453762686f0b25a6e90af3347
parent74a31b92b0d7bd83777fa1650b5c21ed968fb887
Make handling of illegal internal representatives in quantifiers engine more robust (#4034)

Fixes #4002 (that benchmark is now unknown).

The experimental option --cbqi-all previously had some issues when combined with finite model finding. When these two options are used simultaneously, it may be the case that certain equivalence classes are "illegal" since they contain only terms that are ineligible for instantiation.

The previous code threw a warning when this occurred which in extreme cases allowed for potentially ineligible terms for instantiation. The new code is more conservative: we never choose illegal internal representatives and instead set the incomplete flag in finite model finding when this occurs.

A block of code changed indentation in this PR, which was updated to the new standards.
src/theory/quantifiers/ematching/candidate_generator.cpp
src/theory/quantifiers/equality_query.cpp
src/theory/quantifiers/fmf/model_engine.cpp
src/theory/quantifiers_engine.h